-
Notifications
You must be signed in to change notification settings - Fork 317
Update Extended appsec request/response headers and request body collection #9428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: a09de0f | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~a09de0fb31, baseline=1.54.0-SNAPSHOT~088156e595
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.024 s) : 0, 1023800
Total [baseline] (10.629 s) : 0, 10629168
Agent [candidate] (1.014 s) : 0, 1014401
Total [candidate] (10.663 s) : 0, 10662511
section appsec
Agent [baseline] (1.195 s) : 0, 1194806
Total [baseline] (11.096 s) : 0, 11095927
Agent [candidate] (1.192 s) : 0, 1191604
Total [candidate] (11.095 s) : 0, 11094895
section iast
Agent [baseline] (1.15 s) : 0, 1149971
Total [baseline] (10.935 s) : 0, 10935278
Agent [candidate] (1.149 s) : 0, 1149482
Total [candidate] (10.89 s) : 0, 10890163
section profiling
Agent [baseline] (1.161 s) : 0, 1160792
Total [baseline] (11.067 s) : 0, 11066790
Agent [candidate] (1.16 s) : 0, 1160423
Total [candidate] (11.01 s) : 0, 11009736
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~a09de0fb31, baseline=1.54.0-SNAPSHOT~088156e595
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (697.077 ms) : 0, 697077
BytebuddyAgent [candidate] (690.092 ms) : 0, 690092
GlobalTracer [baseline] (243.866 ms) : 0, 243866
GlobalTracer [candidate] (242.731 ms) : 0, 242731
AppSec [baseline] (33.029 ms) : 0, 33029
AppSec [candidate] (32.665 ms) : 0, 32665
Debugger [baseline] (6.452 ms) : 0, 6452
Debugger [candidate] (6.346 ms) : 0, 6346
Remote Config [baseline] (715.279 µs) : 0, 715
Remote Config [candidate] (674.602 µs) : 0, 675
Telemetry [baseline] (9.059 ms) : 0, 9059
Telemetry [candidate] (9.06 ms) : 0, 9060
Flare Poller [baseline] (10.875 ms) : 0, 10875
Flare Poller [candidate] (10.219 ms) : 0, 10219
section appsec
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (717.547 ms) : 0, 717547
BytebuddyAgent [candidate] (715.528 ms) : 0, 715528
GlobalTracer [baseline] (235.478 ms) : 0, 235478
GlobalTracer [candidate] (235.125 ms) : 0, 235125
AppSec [baseline] (175.27 ms) : 0, 175270
AppSec [candidate] (173.657 ms) : 0, 173657
Debugger [baseline] (6.108 ms) : 0, 6108
Debugger [candidate] (6.032 ms) : 0, 6032
Remote Config [baseline] (668.94 µs) : 0, 669
Remote Config [candidate] (658.538 µs) : 0, 659
Telemetry [baseline] (8.274 ms) : 0, 8274
Telemetry [candidate] (9.116 ms) : 0, 9116
Flare Poller [baseline] (3.968 ms) : 0, 3968
Flare Poller [candidate] (3.983 ms) : 0, 3983
IAST [baseline] (24.924 ms) : 0, 24924
IAST [candidate] (24.908 ms) : 0, 24908
section iast
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (813.529 ms) : 0, 813529
BytebuddyAgent [candidate] (812.708 ms) : 0, 812708
GlobalTracer [baseline] (233.11 ms) : 0, 233110
GlobalTracer [candidate] (233.231 ms) : 0, 233231
AppSec [baseline] (35.152 ms) : 0, 35152
AppSec [candidate] (35.075 ms) : 0, 35075
Debugger [baseline] (6.042 ms) : 0, 6042
Debugger [candidate] (6.085 ms) : 0, 6085
Remote Config [baseline] (592.539 µs) : 0, 593
Remote Config [candidate] (588.951 µs) : 0, 589
Telemetry [baseline] (8.195 ms) : 0, 8195
Telemetry [candidate] (8.215 ms) : 0, 8215
Flare Poller [baseline] (4.176 ms) : 0, 4176
Flare Poller [candidate] (4.272 ms) : 0, 4272
IAST [baseline] (26.356 ms) : 0, 26356
IAST [candidate] (26.429 ms) : 0, 26429
section profiling
ProfilingAgent [baseline] (105.194 ms) : 0, 105194
ProfilingAgent [candidate] (105.489 ms) : 0, 105489
crashtracking [baseline] (1.422 ms) : 0, 1422
crashtracking [candidate] (1.421 ms) : 0, 1421
BytebuddyAgent [baseline] (719.61 ms) : 0, 719610
BytebuddyAgent [candidate] (719.717 ms) : 0, 719717
GlobalTracer [baseline] (218.644 ms) : 0, 218644
GlobalTracer [candidate] (218.178 ms) : 0, 218178
AppSec [baseline] (32.698 ms) : 0, 32698
AppSec [candidate] (32.831 ms) : 0, 32831
Debugger [baseline] (6.546 ms) : 0, 6546
Debugger [candidate] (6.513 ms) : 0, 6513
Remote Config [baseline] (810.726 µs) : 0, 811
Remote Config [candidate] (788.569 µs) : 0, 789
Telemetry [baseline] (16.481 ms) : 0, 16481
Telemetry [candidate] (16.624 ms) : 0, 16624
Flare Poller [baseline] (4.153 ms) : 0, 4153
Flare Poller [candidate] (4.191 ms) : 0, 4191
Profiling [baseline] (108.53 ms) : 0, 108530
Profiling [candidate] (108.386 ms) : 0, 108386
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~a09de0fb31, baseline=1.54.0-SNAPSHOT~088156e595
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1022168
Total [baseline] (8.664 s) : 0, 8663971
Agent [candidate] (1.016 s) : 0, 1016472
Total [candidate] (8.649 s) : 0, 8649481
section iast
Agent [baseline] (1.151 s) : 0, 1150670
Total [baseline] (9.265 s) : 0, 9264675
Agent [candidate] (1.146 s) : 0, 1146426
Total [candidate] (9.241 s) : 0, 9241296
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~a09de0fb31, baseline=1.54.0-SNAPSHOT~088156e595
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (695.156 ms) : 0, 695156
BytebuddyAgent [candidate] (692.216 ms) : 0, 692216
GlobalTracer [baseline] (243.466 ms) : 0, 243466
GlobalTracer [candidate] (243.368 ms) : 0, 243368
AppSec [baseline] (32.745 ms) : 0, 32745
AppSec [candidate] (32.722 ms) : 0, 32722
Debugger [baseline] (6.451 ms) : 0, 6451
Debugger [candidate] (6.411 ms) : 0, 6411
Remote Config [baseline] (724.293 µs) : 0, 724
Remote Config [candidate] (676.232 µs) : 0, 676
Telemetry [baseline] (9.12 ms) : 0, 9120
Telemetry [candidate] (9.034 ms) : 0, 9034
Flare Poller [baseline] (11.794 ms) : 0, 11794
Flare Poller [candidate] (9.482 ms) : 0, 9482
section iast
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (813.864 ms) : 0, 813864
BytebuddyAgent [candidate] (811.156 ms) : 0, 811156
GlobalTracer [baseline] (233.151 ms) : 0, 233151
GlobalTracer [candidate] (232.417 ms) : 0, 232417
IAST [baseline] (26.439 ms) : 0, 26439
IAST [candidate] (26.302 ms) : 0, 26302
AppSec [baseline] (35.606 ms) : 0, 35606
AppSec [candidate] (34.902 ms) : 0, 34902
Debugger [baseline] (6.001 ms) : 0, 6001
Debugger [candidate] (6.023 ms) : 0, 6023
Remote Config [baseline] (586.348 µs) : 0, 586
Remote Config [candidate] (586.459 µs) : 0, 586
Telemetry [baseline] (8.037 ms) : 0, 8037
Telemetry [candidate] (8.113 ms) : 0, 8113
Flare Poller [baseline] (4.209 ms) : 0, 4209
Flare Poller [candidate] (4.198 ms) : 0, 4198
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~a09de0fb31, baseline=1.54.0-SNAPSHOT~088156e595
dateFormat X
axisFormat %s
section baseline
no_agent (37.202 ms) : 36905, 37500
. : milestone, 37202,
appsec (48.229 ms) : 47808, 48649
. : milestone, 48229,
code_origins (44.141 ms) : 43760, 44523
. : milestone, 44141,
iast (45.214 ms) : 44829, 45599
. : milestone, 45214,
profiling (47.217 ms) : 46767, 47668
. : milestone, 47217,
tracing (45.176 ms) : 44787, 45565
. : milestone, 45176,
section candidate
no_agent (37.643 ms) : 37340, 37945
. : milestone, 37643,
appsec (47.181 ms) : 46772, 47589
. : milestone, 47181,
code_origins (44.612 ms) : 44236, 44989
. : milestone, 44612,
iast (43.975 ms) : 43604, 44346
. : milestone, 43975,
profiling (47.223 ms) : 46796, 47650
. : milestone, 47223,
tracing (45.7 ms) : 45308, 46092
. : milestone, 45700,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~a09de0fb31, baseline=1.54.0-SNAPSHOT~088156e595
dateFormat X
axisFormat %s
section baseline
no_agent (4.213 ms) : 4167, 4260
. : milestone, 4213,
iast (9.917 ms) : 9746, 10087
. : milestone, 9917,
iast_FULL (14.367 ms) : 14079, 14655
. : milestone, 14367,
iast_GLOBAL (10.972 ms) : 10765, 11179
. : milestone, 10972,
profiling (9.304 ms) : 9156, 9452
. : milestone, 9304,
tracing (7.553 ms) : 7438, 7668
. : milestone, 7553,
section candidate
no_agent (4.415 ms) : 4361, 4468
. : milestone, 4415,
iast (10.252 ms) : 10076, 10428
. : milestone, 10252,
iast_FULL (14.197 ms) : 13915, 14479
. : milestone, 14197,
iast_GLOBAL (10.387 ms) : 10201, 10573
. : milestone, 10387,
profiling (9.424 ms) : 9266, 9582
. : milestone, 9424,
tracing (7.597 ms) : 7483, 7712
. : milestone, 7597,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~a09de0fb31, baseline=1.54.0-SNAPSHOT~088156e595
dateFormat X
axisFormat %s
section baseline
no_agent (1.467 ms) : 1455, 1478
. : milestone, 1467,
appsec (2.508 ms) : 2454, 2561
. : milestone, 2508,
iast (2.191 ms) : 2128, 2254
. : milestone, 2191,
iast_GLOBAL (2.24 ms) : 2176, 2303
. : milestone, 2240,
profiling (2.491 ms) : 2321, 2661
. : milestone, 2491,
tracing (2.007 ms) : 1958, 2056
. : milestone, 2007,
section candidate
no_agent (1.476 ms) : 1464, 1488
. : milestone, 1476,
appsec (3.718 ms) : 3499, 3936
. : milestone, 3718,
iast (2.2 ms) : 2137, 2263
. : milestone, 2200,
iast_GLOBAL (2.241 ms) : 2178, 2305
. : milestone, 2241,
profiling (2.033 ms) : 1983, 2084
. : milestone, 2033,
tracing (2.024 ms) : 1975, 2074
. : milestone, 2024,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~a09de0fb31, baseline=1.54.0-SNAPSHOT~088156e595
dateFormat X
axisFormat %s
section baseline
no_agent (15.532 s) : 15532000, 15532000
. : milestone, 15532000,
appsec (15.053 s) : 15053000, 15053000
. : milestone, 15053000,
iast (18.598 s) : 18598000, 18598000
. : milestone, 18598000,
iast_GLOBAL (17.759 s) : 17759000, 17759000
. : milestone, 17759000,
profiling (15.699 s) : 15699000, 15699000
. : milestone, 15699000,
tracing (15.22 s) : 15220000, 15220000
. : milestone, 15220000,
section candidate
no_agent (15.229 s) : 15229000, 15229000
. : milestone, 15229000,
appsec (15.143 s) : 15143000, 15143000
. : milestone, 15143000,
iast (18.884 s) : 18884000, 18884000
. : milestone, 18884000,
iast_GLOBAL (17.874 s) : 17874000, 17874000
. : milestone, 17874000,
profiling (15.306 s) : 15306000, 15306000
. : milestone, 15306000,
tracing (15.1 s) : 15100000, 15100000
. : milestone, 15100000,
|
597e4c5 to
479b7a8
Compare
d1301dc to
974ea01
Compare
dd-java-agent/appsec/src/main/java/com/datadog/appsec/ddwaf/WAFModule.java
Outdated
Show resolved
Hide resolved
dd-java-agent/appsec/src/main/java/com/datadog/appsec/ddwaf/WAFModule.java
Outdated
Show resolved
Hide resolved
5886943 to
2f45476
Compare
dd-java-agent/appsec/src/main/java/com/datadog/appsec/gateway/AppSecRequestContext.java
Show resolved
Hide resolved
manuel-alvarez-alvarez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What Does This Do
_dd.appsec.rasp.request_body_size.exceededrenamed to_dd.appsec.request_body_size.exceededMotivation
Update implementation to meet the new RFC requirements
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APPSEC-58757