-
Notifications
You must be signed in to change notification settings - Fork 318
Lazy config of the CallSiteInstrumentationPlugin
#9316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| project.tasks.named("jar", Jar::class.java).configure { | ||
| project.tasks.named("jar", Jar::class.java) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: named already applies the configuration lazily.
| project.tasks.withType(AbstractCompile::class.java).matching { | ||
| task -> task.name.startsWith("compileTest") | ||
| }.configureEach { | ||
| inputs.dir(extension.targetFolder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: This should help with the configuration cache.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~03a5fa1930, baseline=1.53.0-SNAPSHOT~8504f5ad51
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046695
Total [baseline] (8.626 s) : 0, 8626051
Agent [candidate] (1.048 s) : 0, 1047944
Total [candidate] (8.654 s) : 0, 8653681
section iast
Agent [baseline] (1.174 s) : 0, 1173899
Total [baseline] (9.282 s) : 0, 9282033
Agent [candidate] (1.175 s) : 0, 1175101
Total [candidate] (9.322 s) : 0, 9321733
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~03a5fa1930, baseline=1.53.0-SNAPSHOT~8504f5ad51
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.441 ms) : 0, 1441
crashtracking [candidate] (1.429 ms) : 0, 1429
BytebuddyAgent [baseline] (735.092 ms) : 0, 735092
BytebuddyAgent [candidate] (733.442 ms) : 0, 733442
GlobalTracer [baseline] (241.888 ms) : 0, 241888
GlobalTracer [candidate] (243.469 ms) : 0, 243469
AppSec [baseline] (30.026 ms) : 0, 30026
AppSec [candidate] (30.4 ms) : 0, 30400
Debugger [baseline] (6.022 ms) : 0, 6022
Debugger [candidate] (6.104 ms) : 0, 6104
Remote Config [baseline] (655.552 µs) : 0, 656
Remote Config [candidate] (666.204 µs) : 0, 666
Telemetry [baseline] (10.526 ms) : 0, 10526
Telemetry [candidate] (11.428 ms) : 0, 11428
section iast
crashtracking [baseline] (1.427 ms) : 0, 1427
crashtracking [candidate] (1.433 ms) : 0, 1433
BytebuddyAgent [baseline] (846.262 ms) : 0, 846262
BytebuddyAgent [candidate] (848.449 ms) : 0, 848449
GlobalTracer [baseline] (232.81 ms) : 0, 232810
GlobalTracer [candidate] (234.197 ms) : 0, 234197
IAST [baseline] (28.325 ms) : 0, 28325
IAST [candidate] (28.111 ms) : 0, 28111
AppSec [baseline] (28.603 ms) : 0, 28603
AppSec [candidate] (26.708 ms) : 0, 26708
Debugger [baseline] (6.68 ms) : 0, 6680
Debugger [candidate] (6.528 ms) : 0, 6528
Remote Config [baseline] (601.692 µs) : 0, 602
Remote Config [candidate] (580.583 µs) : 0, 581
Telemetry [baseline] (8.258 ms) : 0, 8258
Telemetry [candidate] (8.115 ms) : 0, 8115
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~03a5fa1930, baseline=1.53.0-SNAPSHOT~8504f5ad51
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050769
Total [baseline] (10.726 s) : 0, 10726157
Agent [candidate] (1.05 s) : 0, 1049854
Total [candidate] (10.89 s) : 0, 10890428
section appsec
Agent [baseline] (1.22 s) : 0, 1220250
Total [baseline] (10.754 s) : 0, 10754238
Agent [candidate] (1.225 s) : 0, 1225285
Total [candidate] (10.842 s) : 0, 10841688
section iast
Agent [baseline] (1.172 s) : 0, 1171603
Total [baseline] (10.955 s) : 0, 10955088
Agent [candidate] (1.175 s) : 0, 1174725
Total [candidate] (10.901 s) : 0, 10900905
section profiling
Agent [baseline] (1.195 s) : 0, 1194872
Total [baseline] (10.875 s) : 0, 10874751
Agent [candidate] (1.195 s) : 0, 1194764
Total [candidate] (10.927 s) : 0, 10927388
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~03a5fa1930, baseline=1.53.0-SNAPSHOT~8504f5ad51
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.444 ms) : 0, 1444
crashtracking [candidate] (1.433 ms) : 0, 1433
BytebuddyAgent [baseline] (736.335 ms) : 0, 736335
BytebuddyAgent [candidate] (733.134 ms) : 0, 733134
GlobalTracer [baseline] (243.367 ms) : 0, 243367
GlobalTracer [candidate] (243.855 ms) : 0, 243855
AppSec [baseline] (30.404 ms) : 0, 30404
AppSec [candidate] (30.367 ms) : 0, 30367
Debugger [baseline] (6.082 ms) : 0, 6082
Debugger [candidate] (6.066 ms) : 0, 6066
Remote Config [baseline] (663.452 µs) : 0, 663
Remote Config [candidate] (652.633 µs) : 0, 653
Telemetry [baseline] (11.318 ms) : 0, 11318
Telemetry [candidate] (13.278 ms) : 0, 13278
section appsec
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (752.914 ms) : 0, 752914
BytebuddyAgent [candidate] (755.86 ms) : 0, 755860
GlobalTracer [baseline] (235.379 ms) : 0, 235379
GlobalTracer [candidate] (236.243 ms) : 0, 236243
IAST [baseline] (23.669 ms) : 0, 23669
IAST [candidate] (23.839 ms) : 0, 23839
AppSec [baseline] (168.18 ms) : 0, 168180
AppSec [candidate] (169.048 ms) : 0, 169048
Debugger [baseline] (8.737 ms) : 0, 8737
Debugger [candidate] (7.986 ms) : 0, 7986
Remote Config [baseline] (620.404 µs) : 0, 620
Remote Config [candidate] (663.195 µs) : 0, 663
Telemetry [baseline] (8.213 ms) : 0, 8213
Telemetry [candidate] (9.034 ms) : 0, 9034
section iast
crashtracking [baseline] (1.429 ms) : 0, 1429
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (845.98 ms) : 0, 845980
BytebuddyAgent [candidate] (848.011 ms) : 0, 848011
GlobalTracer [baseline] (231.425 ms) : 0, 231425
GlobalTracer [candidate] (232.345 ms) : 0, 232345
IAST [baseline] (29.783 ms) : 0, 29783
IAST [candidate] (29.169 ms) : 0, 29169
AppSec [baseline] (27.587 ms) : 0, 27587
AppSec [candidate] (26.511 ms) : 0, 26511
Debugger [baseline] (5.732 ms) : 0, 5732
Debugger [candidate] (7.454 ms) : 0, 7454
Remote Config [baseline] (581.752 µs) : 0, 582
Remote Config [candidate] (584.091 µs) : 0, 584
Telemetry [baseline] (8.103 ms) : 0, 8103
Telemetry [candidate] (8.095 ms) : 0, 8095
section profiling
crashtracking [baseline] (1.414 ms) : 0, 1414
crashtracking [candidate] (1.409 ms) : 0, 1409
BytebuddyAgent [baseline] (760.818 ms) : 0, 760818
BytebuddyAgent [candidate] (761.495 ms) : 0, 761495
GlobalTracer [baseline] (222.315 ms) : 0, 222315
GlobalTracer [candidate] (221.65 ms) : 0, 221650
AppSec [baseline] (30.037 ms) : 0, 30037
AppSec [candidate] (29.856 ms) : 0, 29856
Debugger [baseline] (6.251 ms) : 0, 6251
Debugger [candidate] (6.275 ms) : 0, 6275
Remote Config [baseline] (689.559 µs) : 0, 690
Remote Config [candidate] (705.688 µs) : 0, 706
Telemetry [baseline] (15.981 ms) : 0, 15981
Telemetry [candidate] (15.854 ms) : 0, 15854
ProfilingAgent [baseline] (107.948 ms) : 0, 107948
ProfilingAgent [candidate] (108.008 ms) : 0, 108008
Profiling [baseline] (108.598 ms) : 0, 108598
Profiling [candidate] (108.659 ms) : 0, 108659
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~03a5fa1930, baseline=1.53.0-SNAPSHOT~8504f5ad51
dateFormat X
axisFormat %s
section baseline
no_agent (4.324 ms) : 4274, 4373
. : milestone, 4324,
iast (9.208 ms) : 9058, 9358
. : milestone, 9208,
iast_FULL (14.103 ms) : 13816, 14389
. : milestone, 14103,
iast_GLOBAL (10.456 ms) : 10271, 10641
. : milestone, 10456,
profiling (8.702 ms) : 8563, 8840
. : milestone, 8702,
tracing (7.306 ms) : 7205, 7408
. : milestone, 7306,
section candidate
no_agent (4.324 ms) : 4271, 4376
. : milestone, 4324,
iast (9.187 ms) : 9032, 9342
. : milestone, 9187,
iast_FULL (14.11 ms) : 13826, 14393
. : milestone, 14110,
iast_GLOBAL (10.381 ms) : 10199, 10564
. : milestone, 10381,
profiling (8.604 ms) : 8472, 8736
. : milestone, 8604,
tracing (7.368 ms) : 7265, 7472
. : milestone, 7368,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~03a5fa1930, baseline=1.53.0-SNAPSHOT~8504f5ad51
dateFormat X
axisFormat %s
section baseline
no_agent (37.103 ms) : 36799, 37406
. : milestone, 37103,
appsec (47.619 ms) : 47201, 48036
. : milestone, 47619,
code_origins (45.286 ms) : 44896, 45676
. : milestone, 45286,
iast (45.908 ms) : 45507, 46308
. : milestone, 45908,
profiling (47.591 ms) : 47111, 48070
. : milestone, 47591,
tracing (43.911 ms) : 43538, 44284
. : milestone, 43911,
section candidate
no_agent (37.007 ms) : 36706, 37309
. : milestone, 37007,
appsec (46.438 ms) : 46024, 46852
. : milestone, 46438,
code_origins (44.376 ms) : 43985, 44767
. : milestone, 44376,
iast (43.393 ms) : 43020, 43765
. : milestone, 43393,
profiling (46.756 ms) : 46329, 47182
. : milestone, 46756,
tracing (44.422 ms) : 44036, 44808
. : milestone, 44422,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~03a5fa1930, baseline=1.53.0-SNAPSHOT~8504f5ad51
dateFormat X
axisFormat %s
section baseline
no_agent (15.681 s) : 15681000, 15681000
. : milestone, 15681000,
appsec (14.605 s) : 14605000, 14605000
. : milestone, 14605000,
iast (18.587 s) : 18587000, 18587000
. : milestone, 18587000,
iast_GLOBAL (17.829 s) : 17829000, 17829000
. : milestone, 17829000,
profiling (15.339 s) : 15339000, 15339000
. : milestone, 15339000,
tracing (14.789 s) : 14789000, 14789000
. : milestone, 14789000,
section candidate
no_agent (15.51 s) : 15510000, 15510000
. : milestone, 15510000,
appsec (15.007 s) : 15007000, 15007000
. : milestone, 15007000,
iast (18.375 s) : 18375000, 18375000
. : milestone, 18375000,
iast_GLOBAL (18.067 s) : 18067000, 18067000
. : milestone, 18067000,
profiling (15.542 s) : 15542000, 15542000
. : milestone, 15542000,
tracing (15.03 s) : 15030000, 15030000
. : milestone, 15030000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~03a5fa1930, baseline=1.53.0-SNAPSHOT~8504f5ad51
dateFormat X
axisFormat %s
section baseline
no_agent (1.466 ms) : 1455, 1478
. : milestone, 1466,
appsec (3.642 ms) : 3425, 3859
. : milestone, 3642,
iast (2.184 ms) : 2121, 2246
. : milestone, 2184,
iast_GLOBAL (2.234 ms) : 2171, 2298
. : milestone, 2234,
profiling (2.45 ms) : 2281, 2619
. : milestone, 2450,
tracing (2.008 ms) : 1959, 2057
. : milestone, 2008,
section candidate
no_agent (1.466 ms) : 1454, 1477
. : milestone, 1466,
appsec (3.638 ms) : 3423, 3854
. : milestone, 3638,
iast (2.195 ms) : 2133, 2258
. : milestone, 2195,
iast_GLOBAL (2.219 ms) : 2156, 2282
. : milestone, 2219,
profiling (2.038 ms) : 1987, 2089
. : milestone, 2038,
tracing (1.991 ms) : 1942, 2039
. : milestone, 1991,
|
* chore: Configure lazily :buildSrc:call-site-instrumentation-plugin tasks * chore: Configure lazily CallSiteInstrumentationPlugin
What Does This Do
Use lazy configuration API, in particular
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]