-
Notifications
You must be signed in to change notification settings - Fork 318
Configure lazily MuzzlePlugin
#9315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
Code coverage: total 57.12%, patch 100.00% (view details) This comment will be updated automatically if new data arrives.🔗 Commit SHA: 9b4075e | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~9b4075eb26, baseline=1.53.0-SNAPSHOT~e8faa9419c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1045472
Total [baseline] (8.64 s) : 0, 8639630
Agent [candidate] (1.045 s) : 0, 1044940
Total [candidate] (8.576 s) : 0, 8575676
section iast
Agent [baseline] (1.177 s) : 0, 1176601
Total [baseline] (9.33 s) : 0, 9329821
Agent [candidate] (1.182 s) : 0, 1182410
Total [candidate] (9.312 s) : 0, 9311595
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~9b4075eb26, baseline=1.53.0-SNAPSHOT~e8faa9419c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.423 ms) : 0, 1423
crashtracking [candidate] (1.428 ms) : 0, 1428
BytebuddyAgent [baseline] (730.942 ms) : 0, 730942
BytebuddyAgent [candidate] (730.832 ms) : 0, 730832
GlobalTracer [baseline] (242.816 ms) : 0, 242816
GlobalTracer [candidate] (241.586 ms) : 0, 241586
AppSec [baseline] (30.302 ms) : 0, 30302
AppSec [candidate] (30.075 ms) : 0, 30075
Debugger [baseline] (6.069 ms) : 0, 6069
Debugger [candidate] (6.037 ms) : 0, 6037
Remote Config [baseline] (657.507 µs) : 0, 658
Remote Config [candidate] (658.081 µs) : 0, 658
Telemetry [baseline] (12.25 ms) : 0, 12250
Telemetry [candidate] (13.411 ms) : 0, 13411
section iast
crashtracking [baseline] (1.425 ms) : 0, 1425
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (849.267 ms) : 0, 849267
BytebuddyAgent [candidate] (853.989 ms) : 0, 853989
GlobalTracer [baseline] (232.597 ms) : 0, 232597
GlobalTracer [candidate] (233.102 ms) : 0, 233102
IAST [baseline] (29.248 ms) : 0, 29248
IAST [candidate] (30.147 ms) : 0, 30147
AppSec [baseline] (26.747 ms) : 0, 26747
AppSec [candidate] (27.106 ms) : 0, 27106
Debugger [baseline] (7.423 ms) : 0, 7423
Debugger [candidate] (6.733 ms) : 0, 6733
Remote Config [baseline] (579.965 µs) : 0, 580
Remote Config [candidate] (598.755 µs) : 0, 599
Telemetry [baseline] (8.309 ms) : 0, 8309
Telemetry [candidate] (8.242 ms) : 0, 8242
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~9b4075eb26, baseline=1.53.0-SNAPSHOT~e8faa9419c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050913
Total [baseline] (10.776 s) : 0, 10775857
Agent [candidate] (1.044 s) : 0, 1043781
Total [candidate] (10.766 s) : 0, 10765617
section appsec
Agent [baseline] (1.219 s) : 0, 1219214
Total [baseline] (10.801 s) : 0, 10800805
Agent [candidate] (1.219 s) : 0, 1218710
Total [candidate] (10.872 s) : 0, 10871718
section iast
Agent [baseline] (1.185 s) : 0, 1185494
Total [baseline] (11.144 s) : 0, 11144087
Agent [candidate] (1.177 s) : 0, 1176696
Total [candidate] (10.889 s) : 0, 10889189
section profiling
Agent [baseline] (1.197 s) : 0, 1196957
Total [baseline] (10.891 s) : 0, 10890858
Agent [candidate] (1.212 s) : 0, 1211691
Total [candidate] (11.001 s) : 0, 11001432
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~9b4075eb26, baseline=1.53.0-SNAPSHOT~e8faa9419c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.439 ms) : 0, 1439
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (736.017 ms) : 0, 736017
BytebuddyAgent [candidate] (730.685 ms) : 0, 730685
GlobalTracer [baseline] (243.651 ms) : 0, 243651
GlobalTracer [candidate] (241.898 ms) : 0, 241898
AppSec [baseline] (30.33 ms) : 0, 30330
AppSec [candidate] (30.031 ms) : 0, 30031
Debugger [baseline] (6.071 ms) : 0, 6071
Debugger [candidate] (6.04 ms) : 0, 6040
Remote Config [baseline] (655.823 µs) : 0, 656
Remote Config [candidate] (646.735 µs) : 0, 647
Telemetry [baseline] (11.587 ms) : 0, 11587
Telemetry [candidate] (10.604 ms) : 0, 10604
section appsec
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.429 ms) : 0, 1429
BytebuddyAgent [baseline] (752.479 ms) : 0, 752479
BytebuddyAgent [candidate] (751.816 ms) : 0, 751816
GlobalTracer [baseline] (234.722 ms) : 0, 234722
GlobalTracer [candidate] (234.795 ms) : 0, 234795
IAST [baseline] (23.469 ms) : 0, 23469
IAST [candidate] (23.691 ms) : 0, 23691
AppSec [baseline] (166.929 ms) : 0, 166929
AppSec [candidate] (169.136 ms) : 0, 169136
Debugger [baseline] (9.34 ms) : 0, 9340
Debugger [candidate] (6.431 ms) : 0, 6431
Remote Config [baseline] (629.532 µs) : 0, 630
Remote Config [candidate] (618.25 µs) : 0, 618
Telemetry [baseline] (9.129 ms) : 0, 9129
Telemetry [candidate] (9.756 ms) : 0, 9756
section iast
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.438 ms) : 0, 1438
BytebuddyAgent [baseline] (856.351 ms) : 0, 856351
BytebuddyAgent [candidate] (849.868 ms) : 0, 849868
GlobalTracer [baseline] (233.802 ms) : 0, 233802
GlobalTracer [candidate] (232.277 ms) : 0, 232277
IAST [baseline] (28.574 ms) : 0, 28574
IAST [candidate] (32.168 ms) : 0, 32168
AppSec [baseline] (28.55 ms) : 0, 28550
AppSec [candidate] (25.32 ms) : 0, 25320
Debugger [baseline] (6.628 ms) : 0, 6628
Debugger [candidate] (5.828 ms) : 0, 5828
Remote Config [baseline] (587.991 µs) : 0, 588
Remote Config [candidate] (606.146 µs) : 0, 606
Telemetry [baseline] (8.354 ms) : 0, 8354
Telemetry [candidate] (8.178 ms) : 0, 8178
section profiling
crashtracking [baseline] (1.417 ms) : 0, 1417
crashtracking [candidate] (1.422 ms) : 0, 1422
BytebuddyAgent [baseline] (762.07 ms) : 0, 762070
BytebuddyAgent [candidate] (770.907 ms) : 0, 770907
GlobalTracer [baseline] (223.001 ms) : 0, 223001
GlobalTracer [candidate] (225.089 ms) : 0, 225089
AppSec [baseline] (30.217 ms) : 0, 30217
AppSec [candidate] (30.853 ms) : 0, 30853
Debugger [baseline] (6.295 ms) : 0, 6295
Debugger [candidate] (6.47 ms) : 0, 6470
Remote Config [baseline] (671.116 µs) : 0, 671
Remote Config [candidate] (710.449 µs) : 0, 710
Telemetry [baseline] (16.086 ms) : 0, 16086
Telemetry [candidate] (16.104 ms) : 0, 16104
ProfilingAgent [baseline] (107.822 ms) : 0, 107822
ProfilingAgent [candidate] (109.997 ms) : 0, 109997
Profiling [baseline] (108.459 ms) : 0, 108459
Profiling [candidate] (110.637 ms) : 0, 110637
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 2 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~9b4075eb26, baseline=1.53.0-SNAPSHOT~e8faa9419c
dateFormat X
axisFormat %s
section baseline
no_agent (37.429 ms) : 37128, 37729
. : milestone, 37429,
appsec (46.958 ms) : 46533, 47383
. : milestone, 46958,
code_origins (45.061 ms) : 44688, 45434
. : milestone, 45061,
iast (44.401 ms) : 44019, 44783
. : milestone, 44401,
profiling (50.436 ms) : 49984, 50889
. : milestone, 50436,
tracing (42.377 ms) : 42024, 42730
. : milestone, 42377,
section candidate
no_agent (36.608 ms) : 36315, 36901
. : milestone, 36608,
appsec (46.829 ms) : 46408, 47249
. : milestone, 46829,
code_origins (44.157 ms) : 43784, 44530
. : milestone, 44157,
iast (43.747 ms) : 43380, 44113
. : milestone, 43747,
profiling (45.512 ms) : 45074, 45951
. : milestone, 45512,
tracing (44.434 ms) : 44058, 44811
. : milestone, 44434,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~9b4075eb26, baseline=1.53.0-SNAPSHOT~e8faa9419c
dateFormat X
axisFormat %s
section baseline
no_agent (4.462 ms) : 4411, 4513
. : milestone, 4462,
iast (9.232 ms) : 9079, 9385
. : milestone, 9232,
iast_FULL (13.512 ms) : 13243, 13780
. : milestone, 13512,
iast_GLOBAL (10.323 ms) : 10141, 10504
. : milestone, 10323,
profiling (9.026 ms) : 8885, 9168
. : milestone, 9026,
tracing (7.995 ms) : 7877, 8112
. : milestone, 7995,
section candidate
no_agent (4.283 ms) : 4230, 4335
. : milestone, 4283,
iast (9.735 ms) : 9571, 9899
. : milestone, 9735,
iast_FULL (13.76 ms) : 13484, 14035
. : milestone, 13760,
iast_GLOBAL (10.594 ms) : 10408, 10779
. : milestone, 10594,
profiling (8.562 ms) : 8432, 8692
. : milestone, 8562,
tracing (7.478 ms) : 7371, 7584
. : milestone, 7478,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~9b4075eb26, baseline=1.53.0-SNAPSHOT~e8faa9419c
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.643 ms) : 3425, 3861
. : milestone, 3643,
iast (2.185 ms) : 2123, 2247
. : milestone, 2185,
iast_GLOBAL (2.236 ms) : 2173, 2299
. : milestone, 2236,
profiling (2.051 ms) : 2000, 2101
. : milestone, 2051,
tracing (2.022 ms) : 1973, 2071
. : milestone, 2022,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.645 ms) : 3428, 3862
. : milestone, 3645,
iast (2.199 ms) : 2136, 2261
. : milestone, 2199,
iast_GLOBAL (2.243 ms) : 2181, 2306
. : milestone, 2243,
profiling (2.063 ms) : 2012, 2115
. : milestone, 2063,
tracing (2.008 ms) : 1960, 2056
. : milestone, 2008,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~9b4075eb26, baseline=1.53.0-SNAPSHOT~e8faa9419c
dateFormat X
axisFormat %s
section baseline
no_agent (15.042 s) : 15042000, 15042000
. : milestone, 15042000,
appsec (14.865 s) : 14865000, 14865000
. : milestone, 14865000,
iast (18.253 s) : 18253000, 18253000
. : milestone, 18253000,
iast_GLOBAL (18.19 s) : 18190000, 18190000
. : milestone, 18190000,
profiling (15.946 s) : 15946000, 15946000
. : milestone, 15946000,
tracing (15.126 s) : 15126000, 15126000
. : milestone, 15126000,
section candidate
no_agent (15.697 s) : 15697000, 15697000
. : milestone, 15697000,
appsec (14.935 s) : 14935000, 14935000
. : milestone, 14935000,
iast (18.45 s) : 18450000, 18450000
. : milestone, 18450000,
iast_GLOBAL (18.272 s) : 18272000, 18272000
. : milestone, 18272000,
profiling (15.039 s) : 15039000, 15039000
. : milestone, 15039000,
tracing (15.116 s) : 15116000, 15116000
. : milestone, 15116000,
|
PerfectSlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good 👍 Thanks for the improvement.
Left a minor comment about coding style.
* chore: Configure lazily MuzzlePlugin * chore: Groovy style
What Does This Do
Use lazy configuration API, in particular
Also, simplified a bit the task registration with regular for-loop, instead of Groovy's
.inject.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]