-
Notifications
You must be signed in to change notification settings - Fork 311
Added retrieval and embedding span methods #9269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@@ -35,4 +35,14 @@ public LLMObsSpan startWorkflowSpan( | |||
String spanName, @Nullable String mlApp, @Nullable String sessionId) { | |||
return NoOpLLMObsSpan.INSTANCE; | |||
} | |||
|
|||
public LLMObsSpan startEmbeddingSpan( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there should be modelName
and modelProvider
param for this one, where modelProvider defaults to custom if a value is not provided
|
||
public LLMObsSpan startRetrievalSpan( | ||
String spanName, | ||
@javax.annotation.Nullable String mlApp, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this javax's Nullable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe the original jetbrain's import of nullable is wrong :/
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~6bc111f6b8e, baseline=1.51.1-SNAPSHOT~b35e1215b0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1040613
Total [baseline] (10.794 s) : 0, 10794195
Agent [candidate] (1.051 s) : 0, 1051258
Total [candidate] (10.788 s) : 0, 10787513
section appsec
Agent [baseline] (1.224 s) : 0, 1224391
Total [baseline] (10.906 s) : 0, 10906452
Agent [candidate] (1.227 s) : 0, 1226699
Total [candidate] (10.832 s) : 0, 10832422
section iast
Agent [baseline] (1.177 s) : 0, 1177221
Total [baseline] (11.025 s) : 0, 11024962
Agent [candidate] (1.179 s) : 0, 1178800
Total [candidate] (10.953 s) : 0, 10953006
section profiling
Agent [baseline] (1.188 s) : 0, 1187679
Total [baseline] (9.899 s) : 0, 9898556
Agent [candidate] (1.198 s) : 0, 1197500
Total [candidate] (10.953 s) : 0, 10952671
gantt
title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~6bc111f6b8e, baseline=1.51.1-SNAPSHOT~b35e1215b0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.423 ms) : 0, 1423
crashtracking [candidate] (1.438 ms) : 0, 1438
BytebuddyAgent [baseline] (729.466 ms) : 0, 729466
BytebuddyAgent [candidate] (735.992 ms) : 0, 735992
GlobalTracer [baseline] (241.178 ms) : 0, 241178
GlobalTracer [candidate] (243.782 ms) : 0, 243782
AppSec [baseline] (30.364 ms) : 0, 30364
AppSec [candidate] (30.774 ms) : 0, 30774
Debugger [baseline] (6.027 ms) : 0, 6027
Debugger [candidate] (6.119 ms) : 0, 6119
Remote Config [baseline] (639.384 µs) : 0, 639
Remote Config [candidate] (660.104 µs) : 0, 660
Telemetry [baseline] (9.855 ms) : 0, 9855
Telemetry [candidate] (11.422 ms) : 0, 11422
section appsec
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (756.053 ms) : 0, 756053
BytebuddyAgent [candidate] (757.086 ms) : 0, 757086
GlobalTracer [baseline] (236.138 ms) : 0, 236138
GlobalTracer [candidate] (237.118 ms) : 0, 237118
IAST [baseline] (23.797 ms) : 0, 23797
IAST [candidate] (23.704 ms) : 0, 23704
AppSec [baseline] (170.456 ms) : 0, 170456
AppSec [candidate] (168.916 ms) : 0, 168916
Debugger [baseline] (5.693 ms) : 0, 5693
Debugger [candidate] (8.032 ms) : 0, 8032
Remote Config [baseline] (628.652 µs) : 0, 629
Remote Config [candidate] (615.397 µs) : 0, 615
Telemetry [baseline] (9.043 ms) : 0, 9043
Telemetry [candidate] (8.366 ms) : 0, 8366
section iast
crashtracking [baseline] (1.447 ms) : 0, 1447
crashtracking [candidate] (1.432 ms) : 0, 1432
BytebuddyAgent [baseline] (848.987 ms) : 0, 848987
BytebuddyAgent [candidate] (850.648 ms) : 0, 850648
GlobalTracer [baseline] (232.237 ms) : 0, 232237
GlobalTracer [candidate] (232.893 ms) : 0, 232893
IAST [baseline] (29.337 ms) : 0, 29337
IAST [candidate] (29.903 ms) : 0, 29903
AppSec [baseline] (25.996 ms) : 0, 25996
AppSec [candidate] (26.542 ms) : 0, 26542
Debugger [baseline] (9.139 ms) : 0, 9139
Debugger [candidate] (7.596 ms) : 0, 7596
Remote Config [baseline] (589.906 µs) : 0, 590
Remote Config [candidate] (595.467 µs) : 0, 595
Telemetry [baseline] (8.282 ms) : 0, 8282
Telemetry [candidate] (8.12 ms) : 0, 8120
section profiling
crashtracking [baseline] (1.402 ms) : 0, 1402
crashtracking [candidate] (1.396 ms) : 0, 1396
BytebuddyAgent [baseline] (756.521 ms) : 0, 756521
BytebuddyAgent [candidate] (762.291 ms) : 0, 762291
GlobalTracer [baseline] (220.477 ms) : 0, 220477
GlobalTracer [candidate] (222.642 ms) : 0, 222642
AppSec [baseline] (30.112 ms) : 0, 30112
AppSec [candidate] (30.79 ms) : 0, 30790
Debugger [baseline] (6.262 ms) : 0, 6262
Debugger [candidate] (6.362 ms) : 0, 6362
Remote Config [baseline] (665.476 µs) : 0, 665
Remote Config [candidate] (698.89 µs) : 0, 699
Telemetry [baseline] (14.562 ms) : 0, 14562
Telemetry [candidate] (16.136 ms) : 0, 16136
ProfilingAgent [baseline] (108.586 ms) : 0, 108586
ProfilingAgent [candidate] (107.958 ms) : 0, 107958
Profiling [baseline] (109.239 ms) : 0, 109239
Profiling [candidate] (108.622 ms) : 0, 108622
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~6bc111f6b8e, baseline=1.51.1-SNAPSHOT~b35e1215b0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1051269
Total [baseline] (8.594 s) : 0, 8593945
Agent [candidate] (1.048 s) : 0, 1048080
Total [candidate] (8.645 s) : 0, 8644680
section iast
Agent [baseline] (1.176 s) : 0, 1175562
Total [baseline] (9.28 s) : 0, 9280369
Agent [candidate] (1.174 s) : 0, 1174472
Total [candidate] (9.339 s) : 0, 9338837
gantt
title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~6bc111f6b8e, baseline=1.51.1-SNAPSHOT~b35e1215b0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.426 ms) : 0, 1426
crashtracking [candidate] (1.437 ms) : 0, 1437
BytebuddyAgent [baseline] (735.199 ms) : 0, 735199
BytebuddyAgent [candidate] (734.62 ms) : 0, 734620
GlobalTracer [baseline] (242.876 ms) : 0, 242876
GlobalTracer [candidate] (243.465 ms) : 0, 243465
AppSec [baseline] (30.343 ms) : 0, 30343
AppSec [candidate] (30.868 ms) : 0, 30868
Debugger [baseline] (6.022 ms) : 0, 6022
Debugger [candidate] (6.105 ms) : 0, 6105
Remote Config [baseline] (648.782 µs) : 0, 649
Remote Config [candidate] (653.136 µs) : 0, 653
Telemetry [baseline] (13.867 ms) : 0, 13867
Telemetry [candidate] (9.864 ms) : 0, 9864
section iast
crashtracking [baseline] (1.431 ms) : 0, 1431
crashtracking [candidate] (1.43 ms) : 0, 1430
BytebuddyAgent [baseline] (849.653 ms) : 0, 849653
BytebuddyAgent [candidate] (847.88 ms) : 0, 847880
GlobalTracer [baseline] (231.175 ms) : 0, 231175
GlobalTracer [candidate] (231.657 ms) : 0, 231657
IAST [baseline] (30.571 ms) : 0, 30571
IAST [candidate] (30.662 ms) : 0, 30662
AppSec [baseline] (26.465 ms) : 0, 26465
AppSec [candidate] (26.609 ms) : 0, 26609
Debugger [baseline] (6.604 ms) : 0, 6604
Debugger [candidate] (5.863 ms) : 0, 5863
Remote Config [baseline] (584.785 µs) : 0, 585
Remote Config [candidate] (595.965 µs) : 0, 596
Telemetry [baseline] (8.132 ms) : 0, 8132
Telemetry [candidate] (8.875 ms) : 0, 8875
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~6bc111f6b8e, baseline=1.51.1-SNAPSHOT~b35e1215b0
dateFormat X
axisFormat %s
section baseline
no_agent (4.233 ms) : 4185, 4282
. : milestone, 4233,
iast (9.493 ms) : 9337, 9650
. : milestone, 9493,
iast_FULL (14.111 ms) : 13828, 14394
. : milestone, 14111,
iast_GLOBAL (10.573 ms) : 10389, 10758
. : milestone, 10573,
profiling (8.978 ms) : 8838, 9118
. : milestone, 8978,
tracing (7.553 ms) : 7447, 7660
. : milestone, 7553,
section candidate
no_agent (4.422 ms) : 4370, 4473
. : milestone, 4422,
iast (9.335 ms) : 9184, 9485
. : milestone, 9335,
iast_FULL (14.348 ms) : 14060, 14636
. : milestone, 14348,
iast_GLOBAL (10.471 ms) : 10286, 10656
. : milestone, 10471,
profiling (9.228 ms) : 9078, 9379
. : milestone, 9228,
tracing (7.403 ms) : 7300, 7506
. : milestone, 7403,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~6bc111f6b8e, baseline=1.51.1-SNAPSHOT~b35e1215b0
dateFormat X
axisFormat %s
section baseline
no_agent (36.391 ms) : 36092, 36689
. : milestone, 36391,
appsec (45.851 ms) : 45446, 46256
. : milestone, 45851,
code_origins (46.758 ms) : 46349, 47167
. : milestone, 46758,
iast (44.356 ms) : 43958, 44754
. : milestone, 44356,
profiling (48.52 ms) : 48054, 48986
. : milestone, 48520,
tracing (44.026 ms) : 43640, 44412
. : milestone, 44026,
section candidate
no_agent (36.273 ms) : 35981, 36565
. : milestone, 36273,
appsec (46.584 ms) : 46168, 47001
. : milestone, 46584,
code_origins (44.216 ms) : 43828, 44604
. : milestone, 44216,
iast (45.092 ms) : 44701, 45484
. : milestone, 45092,
profiling (49.423 ms) : 48985, 49861
. : milestone, 49423,
tracing (43.789 ms) : 43416, 44162
. : milestone, 43789,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~6bc111f6b8e, baseline=1.51.1-SNAPSHOT~b35e1215b0
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (3.65 ms) : 3433, 3867
. : milestone, 3650,
iast (2.191 ms) : 2128, 2253
. : milestone, 2191,
iast_GLOBAL (2.24 ms) : 2176, 2303
. : milestone, 2240,
profiling (2.04 ms) : 1988, 2092
. : milestone, 2040,
tracing (2.012 ms) : 1963, 2060
. : milestone, 2012,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.59 ms) : 3380, 3801
. : milestone, 3590,
iast (2.187 ms) : 2124, 2250
. : milestone, 2187,
iast_GLOBAL (2.224 ms) : 2161, 2288
. : milestone, 2224,
profiling (2.044 ms) : 1993, 2094
. : milestone, 2044,
tracing (2.025 ms) : 1976, 2074
. : milestone, 2025,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~6bc111f6b8e, baseline=1.51.1-SNAPSHOT~b35e1215b0
dateFormat X
axisFormat %s
section baseline
no_agent (14.973 s) : 14973000, 14973000
. : milestone, 14973000,
appsec (14.903 s) : 14903000, 14903000
. : milestone, 14903000,
iast (18.642 s) : 18642000, 18642000
. : milestone, 18642000,
iast_GLOBAL (17.904 s) : 17904000, 17904000
. : milestone, 17904000,
profiling (15.589 s) : 15589000, 15589000
. : milestone, 15589000,
tracing (14.895 s) : 14895000, 14895000
. : milestone, 14895000,
section candidate
no_agent (15.673 s) : 15673000, 15673000
. : milestone, 15673000,
appsec (14.718 s) : 14718000, 14718000
. : milestone, 14718000,
iast (18.085 s) : 18085000, 18085000
. : milestone, 18085000,
iast_GLOBAL (18.051 s) : 18051000, 18051000
. : milestone, 18051000,
profiling (15.219 s) : 15219000, 15219000
. : milestone, 15219000,
tracing (15.065 s) : 15065000, 15065000
. : milestone, 15065000,
|
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]