Cleanup of zstd dependency and jps functionality #9010

jbachorik · 2025-06-19T10:13:35Z

What Does This Do

This cleans up the aircompressor dependency not to pull in all possible compressor implementations when we are interested only in zstd.
It also does minor cleanup in the jps-like helper where it does not make sense to use internal JVM classes via reflection when we already have a file based approach working.

Motivation

Reduce the agent size, cleanup the jps utility implementation.

Additional Notes

pr-commenter · 2025-06-19T10:47:44Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jb/zstd_improvement
git_commit_date	1750342534	1750344440
git_commit_sha	`e0a1fc0`	`48ab511`
release_version	1.50.0-SNAPSHOT~e0a1fc0e75	1.50.0-SNAPSHOT~48ab511815

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1750346193	1750346193
ci_job_id	990269045	990269045
ci_pipeline_id	68249359	68249359
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-z-gvyqhn-project-304-concurrent-0-2cev4gul 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-z-gvyqhn-project-304-concurrent-0-2cev4gul 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 2 performance improvements and 1 performance regressions! Performance is the same for 39 metrics, 11 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:insecure-bank:tracing:Remote Config	better [-89.238µs; -39.120µs] or [-12.077%; -5.294%]	674.706µs	738.885µs
scenario:startup:petclinic:profiling:Remote Config	worse [+52.111µs; +87.929µs] or [+8.124%; +13.708%]	711.441µs	641.421µs
scenario:startup:petclinic:tracing:Remote Config	better [-81.874µs; -32.086µs] or [-11.300%; -4.428%]	667.593µs	724.573µs

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~48ab511815, baseline=1.50.0-SNAPSHOT~e0a1fc0e75

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.031 s) : 0, 1031186
Total [baseline] (8.574 s) : 0, 8573630
Agent [candidate] (1.026 s) : 0, 1026108
Total [candidate] (8.541 s) : 0, 8540785
section iast
Agent [baseline] (1.15 s) : 0, 1149746
Total [baseline] (9.244 s) : 0, 9243877
Agent [candidate] (1.16 s) : 0, 1159588
Total [candidate] (9.209 s) : 0, 9208687

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.031 s	-
Agent	iast	1.15 s	118.56 ms (11.5%)
Total	tracing	8.574 s	-
Total	iast	9.244 s	670.247 ms (7.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.026 s	-
Agent	iast	1.16 s	133.48 ms (13.0%)
Total	tracing	8.541 s	-
Total	iast	9.209 s	667.902 ms (7.8%)

gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~48ab511815, baseline=1.50.0-SNAPSHOT~e0a1fc0e75

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.937 ms) : 0, 688937
BytebuddyAgent [candidate] (686.885 ms) : 0, 686885
GlobalTracer [baseline] (242.169 ms) : 0, 242169
GlobalTracer [candidate] (242.593 ms) : 0, 242593
AppSec [baseline] (58.383 ms) : 0, 58383
AppSec [candidate] (56.76 ms) : 0, 56760
Debugger [baseline] (6.938 ms) : 0, 6938
Debugger [candidate] (8.616 ms) : 0, 8616
Remote Config [baseline] (738.885 µs) : 0, 739
Remote Config [candidate] (674.706 µs) : 0, 675
Telemetry [baseline] (10.463 ms) : 0, 10463
Telemetry [candidate] (9.644 ms) : 0, 9644
section iast
BytebuddyAgent [baseline] (802.369 ms) : 0, 802369
BytebuddyAgent [candidate] (812.235 ms) : 0, 812235
GlobalTracer [baseline] (230.667 ms) : 0, 230667
GlobalTracer [candidate] (232.831 ms) : 0, 232831
IAST [baseline] (27.656 ms) : 0, 27656
IAST [candidate] (26.187 ms) : 0, 26187
AppSec [baseline] (51.183 ms) : 0, 51183
AppSec [candidate] (52.807 ms) : 0, 52807
Debugger [baseline] (5.947 ms) : 0, 5947
Debugger [candidate] (5.944 ms) : 0, 5944
Remote Config [baseline] (590.755 µs) : 0, 591
Remote Config [candidate] (616.732 µs) : 0, 617
Telemetry [baseline] (7.954 ms) : 0, 7954
Telemetry [candidate] (8.093 ms) : 0, 8093

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~48ab511815, baseline=1.50.0-SNAPSHOT~e0a1fc0e75

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.028 s) : 0, 1027802
Total [baseline] (10.57 s) : 0, 10570131
Agent [candidate] (1.026 s) : 0, 1026243
Total [candidate] (10.551 s) : 0, 10551349
section appsec
Agent [baseline] (1.185 s) : 0, 1184941
Total [baseline] (10.74 s) : 0, 10739839
Agent [candidate] (1.176 s) : 0, 1176076
Total [candidate] (10.724 s) : 0, 10724304
section iast
Agent [baseline] (1.159 s) : 0, 1159327
Total [baseline] (10.934 s) : 0, 10934160
Agent [candidate] (1.16 s) : 0, 1160373
Total [candidate] (10.909 s) : 0, 10909063
section profiling
Agent [baseline] (1.264 s) : 0, 1264283
Total [baseline] (10.947 s) : 0, 10946649
Agent [candidate] (1.264 s) : 0, 1263839
Total [candidate] (10.949 s) : 0, 10949105

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.028 s	-
Agent	appsec	1.185 s	157.14 ms (15.3%)
Agent	iast	1.159 s	131.526 ms (12.8%)
Agent	profiling	1.264 s	236.481 ms (23.0%)
Total	tracing	10.57 s	-
Total	appsec	10.74 s	169.707 ms (1.6%)
Total	iast	10.934 s	364.028 ms (3.4%)
Total	profiling	10.947 s	376.517 ms (3.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.026 s	-
Agent	appsec	1.176 s	149.833 ms (14.6%)
Agent	iast	1.16 s	134.129 ms (13.1%)
Agent	profiling	1.264 s	237.596 ms (23.2%)
Total	tracing	10.551 s	-
Total	appsec	10.724 s	172.955 ms (1.6%)
Total	iast	10.909 s	357.714 ms (3.4%)
Total	profiling	10.949 s	397.756 ms (3.8%)

gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~48ab511815, baseline=1.50.0-SNAPSHOT~e0a1fc0e75

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.625 ms) : 0, 687625
BytebuddyAgent [candidate] (687.34 ms) : 0, 687340
GlobalTracer [baseline] (241.157 ms) : 0, 241157
GlobalTracer [candidate] (243.129 ms) : 0, 243129
AppSec [baseline] (57.595 ms) : 0, 57595
AppSec [candidate] (58.982 ms) : 0, 58982
Debugger [baseline] (6.824 ms) : 0, 6824
Debugger [candidate] (6.284 ms) : 0, 6284
Remote Config [baseline] (724.573 µs) : 0, 725
Remote Config [candidate] (667.593 µs) : 0, 668
Telemetry [baseline] (10.399 ms) : 0, 10399
Telemetry [candidate] (8.968 ms) : 0, 8968
section appsec
BytebuddyAgent [baseline] (712.09 ms) : 0, 712090
BytebuddyAgent [candidate] (708.979 ms) : 0, 708979
GlobalTracer [baseline] (236.644 ms) : 0, 236644
GlobalTracer [candidate] (234.943 ms) : 0, 234943
IAST [baseline] (22.007 ms) : 0, 22007
IAST [candidate] (21.863 ms) : 0, 21863
AppSec [baseline] (176.691 ms) : 0, 176691
AppSec [candidate] (175.795 ms) : 0, 175795
Debugger [baseline] (5.911 ms) : 0, 5911
Debugger [candidate] (5.907 ms) : 0, 5907
Remote Config [baseline] (624.45 µs) : 0, 624
Remote Config [candidate] (616.471 µs) : 0, 616
Telemetry [baseline] (7.383 ms) : 0, 7383
Telemetry [candidate] (7.24 ms) : 0, 7240
section iast
BytebuddyAgent [baseline] (808.813 ms) : 0, 808813
BytebuddyAgent [candidate] (810.858 ms) : 0, 810858
GlobalTracer [baseline] (232.428 ms) : 0, 232428
GlobalTracer [candidate] (233.838 ms) : 0, 233838
IAST [baseline] (28.764 ms) : 0, 28764
IAST [candidate] (25.594 ms) : 0, 25594
AppSec [baseline] (51.029 ms) : 0, 51029
AppSec [candidate] (54.393 ms) : 0, 54393
Debugger [baseline] (6.042 ms) : 0, 6042
Debugger [candidate] (5.993 ms) : 0, 5993
Remote Config [baseline] (612.128 µs) : 0, 612
Remote Config [candidate] (643.209 µs) : 0, 643
Telemetry [baseline] (8.023 ms) : 0, 8023
Telemetry [candidate] (8.078 ms) : 0, 8078
section profiling
BytebuddyAgent [baseline] (673.943 ms) : 0, 673943
BytebuddyAgent [candidate] (674.601 ms) : 0, 674601
GlobalTracer [baseline] (360.233 ms) : 0, 360233
GlobalTracer [candidate] (359.355 ms) : 0, 359355
AppSec [baseline] (61.778 ms) : 0, 61778
AppSec [candidate] (62.169 ms) : 0, 62169
Debugger [baseline] (6.152 ms) : 0, 6152
Debugger [candidate] (6.112 ms) : 0, 6112
Remote Config [baseline] (641.421 µs) : 0, 641
Remote Config [candidate] (711.441 µs) : 0, 711
Telemetry [baseline] (8.161 ms) : 0, 8161
Telemetry [candidate] (8.099 ms) : 0, 8099
ProfilingAgent [baseline] (102.69 ms) : 0, 102690
ProfilingAgent [candidate] (104.37 ms) : 0, 104370
Profiling [baseline] (102.715 ms) : 0, 102715
Profiling [candidate] (104.395 ms) : 0, 104395

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jb/zstd_improvement
git_commit_date	1750342534	1750344440
git_commit_sha	`e0a1fc0`	`48ab511`
release_version	1.50.0-SNAPSHOT~e0a1fc0e75	1.50.0-SNAPSHOT~48ab511815

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1750345873	1750345873
ci_job_id	990269046	990269046
ci_pipeline_id	68249359	68249359
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-z-gvyqhn-project-304-concurrent-1-byyeshjd 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-z-gvyqhn-project-304-concurrent-1-byyeshjd 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:no_agent:high_load	better [-219.976µs; -112.914µs] or [-4.856%; -2.492%]	unstable [-84.582op/s; +160.707op/s] or [-8.344%; +15.853%]	4.364ms	1051.781op/s	4.530ms	1013.719op/s
scenario:load:petclinic:appsec:high_load	better [-2.511ms; -1.669ms] or [-5.442%; -3.617%]	unstable [-2.887op/s; +12.512op/s] or [-2.846%; +12.337%]	44.050ms	106.225op/s	46.140ms	101.412op/s
scenario:load:petclinic:tracing:high_load	better [-2.232ms; -1.406ms] or [-4.864%; -3.064%]	unstable [-3.197op/s; +11.622op/s] or [-3.136%; +11.401%]	44.070ms	106.150op/s	45.889ms	101.938op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~48ab511815, baseline=1.50.0-SNAPSHOT~e0a1fc0e75
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.53 ms) : 4480, 4581
.   : milestone, 4530,
iast (9.571 ms) : 9412, 9730
.   : milestone, 9571,
iast_FULL (13.757 ms) : 13486, 14029
.   : milestone, 13757,
iast_GLOBAL (10.423 ms) : 10239, 10607
.   : milestone, 10423,
profiling (8.78 ms) : 8625, 8936
.   : milestone, 8780,
tracing (7.37 ms) : 7261, 7478
.   : milestone, 7370,
section candidate
no_agent (4.364 ms) : 4315, 4413
.   : milestone, 4364,
iast (9.247 ms) : 9093, 9402
.   : milestone, 9247,
iast_FULL (13.958 ms) : 13676, 14240
.   : milestone, 13958,
iast_GLOBAL (10.418 ms) : 10236, 10601
.   : milestone, 10418,
profiling (9.019 ms) : 8879, 9160
.   : milestone, 9019,
tracing (7.586 ms) : 7481, 7691
.   : milestone, 7586,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.53 ms [4.48 ms, 4.581 ms]	-
iast	9.571 ms [9.412 ms, 9.73 ms]	5.041 ms (111.3%)
iast_FULL	13.757 ms [13.486 ms, 14.029 ms]	9.227 ms (203.7%)
iast_GLOBAL	10.423 ms [10.239 ms, 10.607 ms]	5.893 ms (130.1%)
profiling	8.78 ms [8.625 ms, 8.936 ms]	4.25 ms (93.8%)
tracing	7.37 ms [7.261 ms, 7.478 ms]	2.84 ms (62.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.364 ms [4.315 ms, 4.413 ms]	-
iast	9.247 ms [9.093 ms, 9.402 ms]	4.883 ms (111.9%)
iast_FULL	13.958 ms [13.676 ms, 14.24 ms]	9.594 ms (219.9%)
iast_GLOBAL	10.418 ms [10.236 ms, 10.601 ms]	6.055 ms (138.7%)
profiling	9.019 ms [8.879 ms, 9.16 ms]	4.655 ms (106.7%)
tracing	7.586 ms [7.481 ms, 7.691 ms]	3.222 ms (73.8%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~48ab511815, baseline=1.50.0-SNAPSHOT~e0a1fc0e75
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.776 ms) : 36472, 37081
.   : milestone, 36776,
appsec (46.14 ms) : 45734, 46545
.   : milestone, 46140,
code_origins (44.332 ms) : 43980, 44685
.   : milestone, 44332,
iast (43.288 ms) : 42923, 43653
.   : milestone, 43288,
profiling (49.097 ms) : 48641, 49552
.   : milestone, 49097,
tracing (45.889 ms) : 45495, 46282
.   : milestone, 45889,
section candidate
no_agent (36.786 ms) : 36487, 37085
.   : milestone, 36786,
appsec (44.05 ms) : 43673, 44426
.   : milestone, 44050,
code_origins (44.223 ms) : 43878, 44569
.   : milestone, 44223,
iast (43.944 ms) : 43573, 44314
.   : milestone, 43944,
profiling (49.172 ms) : 48727, 49617
.   : milestone, 49172,
tracing (44.07 ms) : 43696, 44443
.   : milestone, 44070,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.776 ms [36.472 ms, 37.081 ms]	-
appsec	46.14 ms [45.734 ms, 46.545 ms]	9.364 ms (25.5%)
code_origins	44.332 ms [43.98 ms, 44.685 ms]	7.556 ms (20.5%)
iast	43.288 ms [42.923 ms, 43.653 ms]	6.512 ms (17.7%)
profiling	49.097 ms [48.641 ms, 49.552 ms]	12.32 ms (33.5%)
tracing	45.889 ms [45.495 ms, 46.282 ms]	9.112 ms (24.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.786 ms [36.487 ms, 37.085 ms]	-
appsec	44.05 ms [43.673 ms, 44.426 ms]	7.264 ms (19.7%)
code_origins	44.223 ms [43.878 ms, 44.569 ms]	7.437 ms (20.2%)
iast	43.944 ms [43.573 ms, 44.314 ms]	7.158 ms (19.5%)
profiling	49.172 ms [48.727 ms, 49.617 ms]	12.386 ms (33.7%)
tracing	44.07 ms [43.696 ms, 44.443 ms]	7.284 ms (19.8%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jb/zstd_improvement
git_commit_date	1750342534	1750344440
git_commit_sha	`e0a1fc0`	`48ab511`
release_version	1.50.0-SNAPSHOT~e0a1fc0e75	1.50.0-SNAPSHOT~48ab511815

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1750346438	1750346438
ci_job_id	990269047	990269047
ci_pipeline_id	68249359	68249359
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-z-gvyqhn-project-304-concurrent-2-gz1iyqpn 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-z-gvyqhn-project-304-concurrent-2-gz1iyqpn 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~48ab511815, baseline=1.50.0-SNAPSHOT~e0a1fc0e75
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (2.394 ms) : 2346, 2443
.   : milestone, 2394,
iast (2.18 ms) : 2118, 2241
.   : milestone, 2180,
iast_GLOBAL (2.233 ms) : 2171, 2294
.   : milestone, 2233,
profiling (2.021 ms) : 1972, 2070
.   : milestone, 2021,
tracing (2.004 ms) : 1956, 2051
.   : milestone, 2004,
section candidate
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (2.399 ms) : 2350, 2447
.   : milestone, 2399,
iast (2.185 ms) : 2124, 2246
.   : milestone, 2185,
iast_GLOBAL (2.226 ms) : 2165, 2288
.   : milestone, 2226,
profiling (2.039 ms) : 1989, 2089
.   : milestone, 2039,
tracing (2.006 ms) : 1958, 2054
.   : milestone, 2006,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.475 ms [1.463 ms, 1.486 ms]	-
appsec	2.394 ms [2.346 ms, 2.443 ms]	919.383 µs (62.3%)
iast	2.18 ms [2.118 ms, 2.241 ms]	704.64 µs (47.8%)
iast_GLOBAL	2.233 ms [2.171 ms, 2.294 ms]	757.597 µs (51.4%)
profiling	2.021 ms [1.972 ms, 2.07 ms]	545.908 µs (37.0%)
tracing	2.004 ms [1.956 ms, 2.051 ms]	528.987 µs (35.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.462 ms, 1.485 ms]	-
appsec	2.399 ms [2.35 ms, 2.447 ms]	925.354 µs (62.8%)
iast	2.185 ms [2.124 ms, 2.246 ms]	711.823 µs (48.3%)
iast_GLOBAL	2.226 ms [2.165 ms, 2.288 ms]	752.845 µs (51.1%)
profiling	2.039 ms [1.989 ms, 2.089 ms]	565.413 µs (38.4%)
tracing	2.006 ms [1.958 ms, 2.054 ms]	532.504 µs (36.1%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~48ab511815, baseline=1.50.0-SNAPSHOT~e0a1fc0e75
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.547 s) : 15547000, 15547000
.   : milestone, 15547000,
appsec (15.149 s) : 15149000, 15149000
.   : milestone, 15149000,
iast (18.581 s) : 18581000, 18581000
.   : milestone, 18581000,
iast_GLOBAL (17.947 s) : 17947000, 17947000
.   : milestone, 17947000,
profiling (15.126 s) : 15126000, 15126000
.   : milestone, 15126000,
tracing (14.839 s) : 14839000, 14839000
.   : milestone, 14839000,
section candidate
no_agent (15.589 s) : 15589000, 15589000
.   : milestone, 15589000,
appsec (14.732 s) : 14732000, 14732000
.   : milestone, 14732000,
iast (18.594 s) : 18594000, 18594000
.   : milestone, 18594000,
iast_GLOBAL (18.046 s) : 18046000, 18046000
.   : milestone, 18046000,
profiling (15.121 s) : 15121000, 15121000
.   : milestone, 15121000,
tracing (14.981 s) : 14981000, 14981000
.   : milestone, 14981000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.547 s [15.547 s, 15.547 s]	-
appsec	15.149 s [15.149 s, 15.149 s]	-398.0 ms (-2.6%)
iast	18.581 s [18.581 s, 18.581 s]	3.034 s (19.5%)
iast_GLOBAL	17.947 s [17.947 s, 17.947 s]	2.4 s (15.4%)
profiling	15.126 s [15.126 s, 15.126 s]	-421.0 ms (-2.7%)
tracing	14.839 s [14.839 s, 14.839 s]	-708.0 ms (-4.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.589 s [15.589 s, 15.589 s]	-
appsec	14.732 s [14.732 s, 14.732 s]	-857.0 ms (-5.5%)
iast	18.594 s [18.594 s, 18.594 s]	3.005 s (19.3%)
iast_GLOBAL	18.046 s [18.046 s, 18.046 s]	2.457 s (15.8%)
profiling	15.121 s [15.121 s, 15.121 s]	-468.0 ms (-3.0%)
tracing	14.981 s [14.981 s, 14.981 s]	-608.0 ms (-3.9%)

bric3

LGTM

bric3 · 2025-06-19T16:07:46Z

dd-java-agent/build.gradle

+  exclude '**/io/airlift/compress/deflate/**'
+  exclude '**/io/airlift/compress/gzip/**'
+  exclude '**/io/airlift/compress/hadoop/**'
+  exclude '**/io/airlift/compress/lz4/**'


question: Out of curiosity is there a reason to prefer lz4-java over aircompressor lz4 ?

Not really, it's just that we know lz4-java works and it didn't feel good to do the change as a part of last minute cleanup PR :)
But definitely we should followup on this - it does not make sense pulling in two different libraries when we can handle the supported compression formats by a single one.

bric3 · 2025-06-19T16:24:30Z

internal-api/src/main/java/datadog/trace/util/PidHelper.java

-      }
-    } catch (Exception e) {
-      log.debug("Unable to list java processes via 'jps'", e);
+      log.debug("Unable to obtain Java PIDs", e);


suggestion: Might be worth to keep mentioning the source of the pid i.e. hsperfdata, so support can look why this didn't work.

jbachorik · 2025-06-19T16:40:28Z

Thanks!

jbachorik added comp: profiling Profiling type: task labels Jun 19, 2025

jbachorik changed the title ~~WIP~~ Reduce the shadowed aircompressor classes Jun 19, 2025

jbachorik added 2 commits June 19, 2025 16:43

Make the zstd dependency more lightweight

86ff6ed

Simplify the JVMs pids collection

2587735

jbachorik force-pushed the jb/zstd_improvement branch from 2868fa3 to 2587735 Compare June 19, 2025 14:43

jbachorik changed the title ~~Reduce the shadowed aircompressor classes~~ Cleanup of zstd dependency and jps functionality Jun 19, 2025

jbachorik marked this pull request as ready for review June 19, 2025 14:47

jbachorik requested review from a team as code owners June 19, 2025 14:47

jbachorik requested a review from amarziali June 19, 2025 14:47

Merge branch 'master' into jb/zstd_improvement

48ab511

amarziali approved these changes Jun 19, 2025

View reviewed changes

bric3 approved these changes Jun 19, 2025

View reviewed changes

jbachorik merged commit 21afb48 into master Jun 19, 2025
484 checks passed

jbachorik deleted the jb/zstd_improvement branch June 19, 2025 16:40

github-actions bot added this to the 1.50.0 milestone Jun 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Cleanup of zstd dependency and jps functionality #9010

Cleanup of zstd dependency and jps functionality #9010

Uh oh!

jbachorik commented Jun 19, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Jun 19, 2025 •

edited

Loading

Uh oh!

bric3 left a comment

Uh oh!

bric3 Jun 19, 2025

Uh oh!

jbachorik Jun 19, 2025

Uh oh!

bric3 Jun 19, 2025

Uh oh!

jbachorik commented Jun 19, 2025

Uh oh!

Uh oh!

Uh oh!

Cleanup of zstd dependency and jps functionality #9010

Cleanup of zstd dependency and jps functionality #9010

Uh oh!

Conversation

jbachorik commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Uh oh!

pr-commenter bot commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

bric3 left a comment

Choose a reason for hiding this comment

Uh oh!

bric3 Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

jbachorik Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

bric3 Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

jbachorik commented Jun 19, 2025

Uh oh!

Uh oh!

Uh oh!

jbachorik commented Jun 19, 2025 •

edited

Loading

pr-commenter bot commented Jun 19, 2025 •

edited

Loading