-
Notifications
You must be signed in to change notification settings - Fork 305
Mute tracing for subprocesses executed by bootstrap telemetry logic. #9005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
AlexeyKuznetsov-DD
wants to merge
3
commits into
master
Choose a base branch
from
alexeyk/mute-forwarder-trace
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~199b508fc5, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1025981
Total [baseline] (8.536 s) : 0, 8535721
Agent [candidate] (1.029 s) : 0, 1028591
Total [candidate] (8.537 s) : 0, 8536827
section iast
Agent [baseline] (1.159 s) : 0, 1159213
Total [baseline] (9.233 s) : 0, 9232501
Agent [candidate] (1.156 s) : 0, 1156112
Total [candidate] (9.268 s) : 0, 9267580
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~199b508fc5, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.924 ms) : 0, 685924
BytebuddyAgent [candidate] (687.435 ms) : 0, 687435
GlobalTracer [baseline] (241.445 ms) : 0, 241445
GlobalTracer [candidate] (242.956 ms) : 0, 242956
AppSec [baseline] (57.834 ms) : 0, 57834
AppSec [candidate] (60.71 ms) : 0, 60710
Debugger [baseline] (8.871 ms) : 0, 8871
Debugger [candidate] (6.22 ms) : 0, 6220
Remote Config [baseline] (672.51 µs) : 0, 673
Remote Config [candidate] (658.141 µs) : 0, 658
Telemetry [baseline] (10.411 ms) : 0, 10411
Telemetry [candidate] (9.673 ms) : 0, 9673
section iast
BytebuddyAgent [baseline] (811.375 ms) : 0, 811375
BytebuddyAgent [candidate] (809.071 ms) : 0, 809071
GlobalTracer [baseline] (233.013 ms) : 0, 233013
GlobalTracer [candidate] (232.613 ms) : 0, 232613
IAST [baseline] (27.873 ms) : 0, 27873
IAST [candidate] (25.238 ms) : 0, 25238
AppSec [baseline] (51.581 ms) : 0, 51581
AppSec [candidate] (53.694 ms) : 0, 53694
Debugger [baseline] (5.939 ms) : 0, 5939
Debugger [candidate] (5.972 ms) : 0, 5972
Remote Config [baseline] (606.179 µs) : 0, 606
Remote Config [candidate] (599.29 µs) : 0, 599
Telemetry [baseline] (8.026 ms) : 0, 8026
Telemetry [candidate] (8.038 ms) : 0, 8038
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~199b508fc5, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.034 s) : 0, 1033633
Total [baseline] (10.637 s) : 0, 10637484
Agent [candidate] (1.032 s) : 0, 1032347
Total [candidate] (10.769 s) : 0, 10769402
section appsec
Agent [baseline] (1.177 s) : 0, 1177426
Total [baseline] (10.759 s) : 0, 10759225
Agent [candidate] (1.179 s) : 0, 1178677
Total [candidate] (10.794 s) : 0, 10794071
section iast
Agent [baseline] (1.159 s) : 0, 1158952
Total [baseline] (10.907 s) : 0, 10907254
Agent [candidate] (1.152 s) : 0, 1152350
Total [candidate] (10.902 s) : 0, 10901776
section profiling
Agent [baseline] (1.27 s) : 0, 1269812
Total [baseline] (11.039 s) : 0, 11038782
Agent [candidate] (1.279 s) : 0, 1278993
Total [candidate] (11.142 s) : 0, 11142158
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~199b508fc5, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.494 ms) : 0, 691494
BytebuddyAgent [candidate] (690.608 ms) : 0, 690608
GlobalTracer [baseline] (244.085 ms) : 0, 244085
GlobalTracer [candidate] (244.088 ms) : 0, 244088
AppSec [baseline] (57.241 ms) : 0, 57241
AppSec [candidate] (57.055 ms) : 0, 57055
Debugger [baseline] (7.108 ms) : 0, 7108
Debugger [candidate] (6.327 ms) : 0, 6327
Remote Config [baseline] (696.121 µs) : 0, 696
Remote Config [candidate] (674.665 µs) : 0, 675
Telemetry [baseline] (11.999 ms) : 0, 11999
Telemetry [candidate] (12.579 ms) : 0, 12579
section appsec
BytebuddyAgent [baseline] (709.044 ms) : 0, 709044
BytebuddyAgent [candidate] (710.664 ms) : 0, 710664
GlobalTracer [baseline] (235.583 ms) : 0, 235583
GlobalTracer [candidate] (235.677 ms) : 0, 235677
IAST [baseline] (21.946 ms) : 0, 21946
IAST [candidate] (21.987 ms) : 0, 21987
AppSec [baseline] (176.283 ms) : 0, 176283
AppSec [candidate] (175.795 ms) : 0, 175795
Debugger [baseline] (5.919 ms) : 0, 5919
Debugger [candidate] (5.917 ms) : 0, 5917
Remote Config [baseline] (612.67 µs) : 0, 613
Remote Config [candidate] (603.788 µs) : 0, 604
Telemetry [baseline] (7.245 ms) : 0, 7245
Telemetry [candidate] (7.223 ms) : 0, 7223
section iast
BytebuddyAgent [baseline] (811.372 ms) : 0, 811372
BytebuddyAgent [candidate] (806.102 ms) : 0, 806102
GlobalTracer [baseline] (233.45 ms) : 0, 233450
GlobalTracer [candidate] (232.096 ms) : 0, 232096
IAST [baseline] (27.824 ms) : 0, 27824
IAST [candidate] (25.889 ms) : 0, 25889
AppSec [baseline] (50.866 ms) : 0, 50866
AppSec [candidate] (52.939 ms) : 0, 52939
Debugger [baseline] (5.884 ms) : 0, 5884
Debugger [candidate] (5.899 ms) : 0, 5899
Remote Config [baseline] (596.588 µs) : 0, 597
Remote Config [candidate] (599.705 µs) : 0, 600
Telemetry [baseline] (8.054 ms) : 0, 8054
Telemetry [candidate] (7.961 ms) : 0, 7961
section profiling
BytebuddyAgent [baseline] (677.62 ms) : 0, 677620
BytebuddyAgent [candidate] (682.558 ms) : 0, 682558
GlobalTracer [baseline] (361.11 ms) : 0, 361110
GlobalTracer [candidate] (362.986 ms) : 0, 362986
AppSec [baseline] (62.016 ms) : 0, 62016
AppSec [candidate] (62.175 ms) : 0, 62175
Debugger [baseline] (6.125 ms) : 0, 6125
Debugger [candidate] (6.246 ms) : 0, 6246
Remote Config [baseline] (717.463 µs) : 0, 717
Remote Config [candidate] (714.133 µs) : 0, 714
Telemetry [baseline] (8.141 ms) : 0, 8141
Telemetry [candidate] (8.406 ms) : 0, 8406
ProfilingAgent [baseline] (105.621 ms) : 0, 105621
ProfilingAgent [candidate] (106.912 ms) : 0, 106912
Profiling [baseline] (105.645 ms) : 0, 105645
Profiling [candidate] (106.938 ms) : 0, 106938
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~199b508fc5, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section baseline
no_agent (35.194 ms) : 34920, 35469
. : milestone, 35194,
appsec (45.761 ms) : 45356, 46165
. : milestone, 45761,
code_origins (44.757 ms) : 44390, 45123
. : milestone, 44757,
iast (44.686 ms) : 44299, 45073
. : milestone, 44686,
profiling (49.438 ms) : 48989, 49887
. : milestone, 49438,
tracing (44.84 ms) : 44469, 45212
. : milestone, 44840,
section candidate
no_agent (36.447 ms) : 36151, 36743
. : milestone, 36447,
appsec (47.52 ms) : 47101, 47938
. : milestone, 47520,
code_origins (45.324 ms) : 44946, 45701
. : milestone, 45324,
iast (44.301 ms) : 43918, 44683
. : milestone, 44301,
profiling (49.109 ms) : 48634, 49585
. : milestone, 49109,
tracing (43.67 ms) : 43315, 44024
. : milestone, 43670,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~199b508fc5, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section baseline
no_agent (4.491 ms) : 4439, 4544
. : milestone, 4491,
iast (8.882 ms) : 8742, 9023
. : milestone, 8882,
iast_FULL (13.78 ms) : 13507, 14054
. : milestone, 13780,
iast_GLOBAL (9.769 ms) : 9603, 9936
. : milestone, 9769,
profiling (8.586 ms) : 8445, 8727
. : milestone, 8586,
tracing (7.376 ms) : 7267, 7485
. : milestone, 7376,
section candidate
no_agent (4.284 ms) : 4229, 4339
. : milestone, 4284,
iast (9.175 ms) : 9029, 9322
. : milestone, 9175,
iast_FULL (13.474 ms) : 13206, 13742
. : milestone, 13474,
iast_GLOBAL (10.234 ms) : 10049, 10419
. : milestone, 10234,
profiling (8.566 ms) : 8437, 8696
. : milestone, 8566,
tracing (7.49 ms) : 7386, 7595
. : milestone, 7490,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~199b508fc5, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section baseline
no_agent (14.995 s) : 14995000, 14995000
. : milestone, 14995000,
appsec (14.897 s) : 14897000, 14897000
. : milestone, 14897000,
iast (18.847 s) : 18847000, 18847000
. : milestone, 18847000,
iast_GLOBAL (17.905 s) : 17905000, 17905000
. : milestone, 17905000,
profiling (15.189 s) : 15189000, 15189000
. : milestone, 15189000,
tracing (15.119 s) : 15119000, 15119000
. : milestone, 15119000,
section candidate
no_agent (15.363 s) : 15363000, 15363000
. : milestone, 15363000,
appsec (14.54 s) : 14540000, 14540000
. : milestone, 14540000,
iast (18.446 s) : 18446000, 18446000
. : milestone, 18446000,
iast_GLOBAL (18.253 s) : 18253000, 18253000
. : milestone, 18253000,
profiling (15.835 s) : 15835000, 15835000
. : milestone, 15835000,
tracing (14.76 s) : 14760000, 14760000
. : milestone, 14760000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~199b508fc5, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1493
. : milestone, 1481,
appsec (2.4 ms) : 2352, 2449
. : milestone, 2400,
iast (2.189 ms) : 2127, 2250
. : milestone, 2189,
iast_GLOBAL (2.234 ms) : 2172, 2296
. : milestone, 2234,
profiling (2.469 ms) : 2298, 2641
. : milestone, 2469,
tracing (1.997 ms) : 1950, 2044
. : milestone, 1997,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.401 ms) : 2352, 2450
. : milestone, 2401,
iast (2.186 ms) : 2125, 2247
. : milestone, 2186,
iast_GLOBAL (2.221 ms) : 2160, 2283
. : milestone, 2221,
profiling (2.031 ms) : 1982, 2080
. : milestone, 2031,
tracing (1.999 ms) : 1952, 2046
. : milestone, 1999,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: core
Tracer core
tag: no release notes
Changes to exclude from release notes
type: enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
The bootstrap logic runs external process to forward some initial telemetry. The subprocess instrumentation creates span for this which may be confusing to users.
Motivation
Reduce noise for the end user.
Additional Notes
We have similar logic in couple of other places, see #6584 as example.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]