Skip to content

Enable test retry in CI #9000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

Enable test retry in CI #9000

merged 1 commit into from
Jun 18, 2025

Conversation

bric3
Copy link
Contributor

@bric3 bric3 commented Jun 17, 2025

What Does This Do

Retry tests in CI, I wonder however if these should be tracked ? Maybe Test Optim has that?

Note:
When a test fails it is captured by Test Optimization.

@git.branch:test-retry-in-ci @test.status:(fail OR pass) @test.suite:PekkoHttpServerInstrumentationAsyncHttp2Test @ci.job.name:"test_inst: [17, 5/6]"

image

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@bric3 bric3 added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jun 17, 2025
@bric3 bric3 changed the title chore(ci): Enable test retry in CI Enable test retry in CI Jun 17, 2025
@bric3 bric3 requested a review from PerfectSlayer June 17, 2025 12:08
@bric3 bric3 marked this pull request as ready for review June 17, 2025 13:48
@bric3 bric3 requested review from a team as code owners June 17, 2025 13:48
@bric3 bric3 requested a review from daniel-mohedano June 17, 2025 13:48
@bric3 bric3 requested a review from smola June 17, 2025 14:16
Copy link
Member

@smola smola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to this. Big advantage of the test-retry plugin as opposed to JUnit/Spock-level retry mechanisms is that intermediate test runs are not lost. So we can keep observability of intermediate failures in Test Optimization (I checked this in Circle CI back in the day, I haven't verified with Test Optimization though).

I think eventually we'd need a more nuanced approach here the way I outlined at #8113, and also stop skipping @Flaky tests and rely on this mechanism. But there's more work involved there. I think it is a good idea to start with this PR if it works well.

Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we can keep observability of intermediate failures in Test Optimization

It was my main concern about the feature. I'm glad @bric3 came with a new pair of eyes and gave it another try with the new CI 👍

@bric3 bric3 merged commit 712d5c3 into master Jun 18, 2025
490 of 491 checks passed
@bric3 bric3 deleted the test-retry-in-ci branch June 18, 2025 15:04
@github-actions github-actions bot added this to the 1.50.0 milestone Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants