-
Notifications
You must be signed in to change notification settings - Fork 305
Simplified ListWriter await logic. #8992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AlexeyKuznetsov-DD
merged 2 commits into
master
from
alexeyk/fixed-flaky-pekko-test-signed
Jun 16, 2025
Merged
Simplified ListWriter await logic. #8992
AlexeyKuznetsov-DD
merged 2 commits into
master
from
alexeyk/fixed-flaky-pekko-test-signed
Jun 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bric3
reviewed
Jun 16, 2025
dd-trace-core/src/main/java/datadog/trace/common/writer/ListWriter.java
Outdated
Show resolved
Hide resolved
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~b461bc2366, baseline=1.50.0-SNAPSHOT~9db71d4352
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.029 s) : 0, 1028916
Total [baseline] (10.608 s) : 0, 10608144
Agent [candidate] (1.027 s) : 0, 1027431
Total [candidate] (10.618 s) : 0, 10618400
section appsec
Agent [baseline] (1.179 s) : 0, 1179035
Total [baseline] (10.724 s) : 0, 10723907
Agent [candidate] (1.191 s) : 0, 1190594
Total [candidate] (10.873 s) : 0, 10873324
section iast
Agent [baseline] (1.153 s) : 0, 1153120
Total [baseline] (10.838 s) : 0, 10838458
Agent [candidate] (1.156 s) : 0, 1156156
Total [candidate] (10.852 s) : 0, 10851583
section profiling
Agent [baseline] (1.274 s) : 0, 1273781
Total [baseline] (10.922 s) : 0, 10922410
Agent [candidate] (1.27 s) : 0, 1270489
Total [candidate] (10.941 s) : 0, 10941420
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~b461bc2366, baseline=1.50.0-SNAPSHOT~9db71d4352
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.521 ms) : 0, 684521
BytebuddyAgent [candidate] (684.388 ms) : 0, 684388
GlobalTracer [baseline] (241.886 ms) : 0, 241886
GlobalTracer [candidate] (241.434 ms) : 0, 241434
AppSec [baseline] (60.706 ms) : 0, 60706
AppSec [candidate] (61.031 ms) : 0, 61031
Debugger [baseline] (6.17 ms) : 0, 6170
Debugger [candidate] (6.078 ms) : 0, 6078
Remote Config [baseline] (739.65 µs) : 0, 740
Remote Config [candidate] (735.568 µs) : 0, 736
Telemetry [baseline] (11.288 ms) : 0, 11288
Telemetry [candidate] (10.305 ms) : 0, 10305
section appsec
BytebuddyAgent [baseline] (705.972 ms) : 0, 705972
BytebuddyAgent [candidate] (712.474 ms) : 0, 712474
GlobalTracer [baseline] (234.433 ms) : 0, 234433
GlobalTracer [candidate] (238.134 ms) : 0, 238134
AppSec [baseline] (179.648 ms) : 0, 179648
AppSec [candidate] (180.083 ms) : 0, 180083
Debugger [baseline] (5.849 ms) : 0, 5849
Debugger [candidate] (5.938 ms) : 0, 5938
Remote Config [baseline] (612.121 µs) : 0, 612
Remote Config [candidate] (624.321 µs) : 0, 624
Telemetry [baseline] (7.231 ms) : 0, 7231
Telemetry [candidate] (7.406 ms) : 0, 7406
IAST [baseline] (21.843 ms) : 0, 21843
IAST [candidate] (22.319 ms) : 0, 22319
section iast
BytebuddyAgent [baseline] (802.95 ms) : 0, 802950
BytebuddyAgent [candidate] (805.295 ms) : 0, 805295
GlobalTracer [baseline] (230.776 ms) : 0, 230776
GlobalTracer [candidate] (231.626 ms) : 0, 231626
AppSec [baseline] (52.178 ms) : 0, 52178
AppSec [candidate] (53.036 ms) : 0, 53036
Debugger [baseline] (6.02 ms) : 0, 6020
Debugger [candidate] (5.979 ms) : 0, 5979
Remote Config [baseline] (587.289 µs) : 0, 587
Remote Config [candidate] (590.831 µs) : 0, 591
Telemetry [baseline] (7.871 ms) : 0, 7871
Telemetry [candidate] (7.885 ms) : 0, 7885
IAST [baseline] (29.34 ms) : 0, 29340
IAST [candidate] (28.249 ms) : 0, 28249
section profiling
BytebuddyAgent [baseline] (676.778 ms) : 0, 676778
BytebuddyAgent [candidate] (674.571 ms) : 0, 674571
GlobalTracer [baseline] (361.325 ms) : 0, 361325
GlobalTracer [candidate] (359.884 ms) : 0, 359884
AppSec [baseline] (64.663 ms) : 0, 64663
AppSec [candidate] (64.741 ms) : 0, 64741
Debugger [baseline] (6.172 ms) : 0, 6172
Debugger [candidate] (6.133 ms) : 0, 6133
Remote Config [baseline] (654.732 µs) : 0, 655
Remote Config [candidate] (639.73 µs) : 0, 640
Telemetry [baseline] (8.173 ms) : 0, 8173
Telemetry [candidate] (8.112 ms) : 0, 8112
ProfilingAgent [baseline] (105.216 ms) : 0, 105216
ProfilingAgent [candidate] (105.765 ms) : 0, 105765
Profiling [baseline] (105.24 ms) : 0, 105240
Profiling [candidate] (105.79 ms) : 0, 105790
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~b461bc2366, baseline=1.50.0-SNAPSHOT~9db71d4352
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.027 s) : 0, 1027431
Total [baseline] (8.527 s) : 0, 8527441
Agent [candidate] (1.028 s) : 0, 1027826
Total [candidate] (8.533 s) : 0, 8532649
section iast
Agent [baseline] (1.171 s) : 0, 1170523
Total [baseline] (9.234 s) : 0, 9233766
Agent [candidate] (1.163 s) : 0, 1162632
Total [candidate] (9.224 s) : 0, 9224158
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.159 s) : 0, 1159307
Total [baseline] (9.203 s) : 0, 9202839
Agent [candidate] (1.155 s) : 0, 1155228
Total [candidate] (9.173 s) : 0, 9173210
section iast_TELEMETRY_OFF
Agent [baseline] (1.159 s) : 0, 1159297
Total [baseline] (9.233 s) : 0, 9233209
Agent [candidate] (1.163 s) : 0, 1162750
Total [candidate] (9.268 s) : 0, 9268046
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~b461bc2366, baseline=1.50.0-SNAPSHOT~9db71d4352
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.166 ms) : 0, 685166
BytebuddyAgent [candidate] (684.423 ms) : 0, 684423
GlobalTracer [baseline] (240.925 ms) : 0, 240925
GlobalTracer [candidate] (241.487 ms) : 0, 241487
AppSec [baseline] (59.834 ms) : 0, 59834
AppSec [candidate] (59.401 ms) : 0, 59401
Debugger [baseline] (6.194 ms) : 0, 6194
Debugger [candidate] (6.267 ms) : 0, 6267
Remote Config [baseline] (744.112 µs) : 0, 744
Remote Config [candidate] (748.344 µs) : 0, 748
Telemetry [baseline] (11.144 ms) : 0, 11144
Telemetry [candidate] (12.056 ms) : 0, 12056
section iast
BytebuddyAgent [baseline] (815.805 ms) : 0, 815805
BytebuddyAgent [candidate] (809.827 ms) : 0, 809827
GlobalTracer [baseline] (233.555 ms) : 0, 233555
GlobalTracer [candidate] (232.744 ms) : 0, 232744
AppSec [baseline] (57.793 ms) : 0, 57793
AppSec [candidate] (55.684 ms) : 0, 55684
Debugger [baseline] (6.049 ms) : 0, 6049
Debugger [candidate] (5.981 ms) : 0, 5981
Remote Config [baseline] (600.068 µs) : 0, 600
Remote Config [candidate] (596.212 µs) : 0, 596
Telemetry [baseline] (7.978 ms) : 0, 7978
Telemetry [candidate] (7.922 ms) : 0, 7922
IAST [baseline] (25.066 ms) : 0, 25066
IAST [candidate] (25.523 ms) : 0, 25523
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (807.62 ms) : 0, 807620
BytebuddyAgent [candidate] (803.745 ms) : 0, 803745
GlobalTracer [baseline] (232.012 ms) : 0, 232012
GlobalTracer [candidate] (231.487 ms) : 0, 231487
AppSec [baseline] (55.719 ms) : 0, 55719
AppSec [candidate] (53.349 ms) : 0, 53349
Debugger [baseline] (5.96 ms) : 0, 5960
Debugger [candidate] (5.97 ms) : 0, 5970
Remote Config [baseline] (598.313 µs) : 0, 598
Remote Config [candidate] (584.433 µs) : 0, 584
Telemetry [baseline] (7.864 ms) : 0, 7864
Telemetry [candidate] (7.971 ms) : 0, 7971
IAST [baseline] (26.118 ms) : 0, 26118
IAST [candidate] (28.681 ms) : 0, 28681
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (807.539 ms) : 0, 807539
BytebuddyAgent [candidate] (809.019 ms) : 0, 809019
GlobalTracer [baseline] (232.41 ms) : 0, 232410
GlobalTracer [candidate] (233.417 ms) : 0, 233417
AppSec [baseline] (52.321 ms) : 0, 52321
AppSec [candidate] (52.918 ms) : 0, 52918
Debugger [baseline] (5.997 ms) : 0, 5997
Debugger [candidate] (6.123 ms) : 0, 6123
Remote Config [baseline] (603.913 µs) : 0, 604
Remote Config [candidate] (606.017 µs) : 0, 606
Telemetry [baseline] (7.859 ms) : 0, 7859
Telemetry [candidate] (7.946 ms) : 0, 7946
IAST [baseline] (28.175 ms) : 0, 28175
IAST [candidate] (28.268 ms) : 0, 28268
LoadParameters
See matching parameters
SummaryFound 6 performance improvements and 1 performance regressions! Performance is the same for 1 metrics, 10 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~b461bc2366, baseline=1.50.0-SNAPSHOT~9db71d4352
dateFormat X
axisFormat %s
section baseline
no_agent (12.359 ms) : 12246, 12471
. : milestone, 12359,
appsec (71.478 ms) : 70457, 72499
. : milestone, 71478,
code_origins (86.775 ms) : 84952, 88598
. : milestone, 86775,
iast (79.361 ms) : 78059, 80664
. : milestone, 79361,
profiling (62.743 ms) : 61893, 63594
. : milestone, 62743,
tracing (52.493 ms) : 51714, 53271
. : milestone, 52493,
section candidate
no_agent (7.668 ms) : 7645, 7691
. : milestone, 7668,
appsec (10.618 ms) : 10560, 10675
. : milestone, 10618,
code_origins (42.705 ms) : 42396, 43014
. : milestone, 42705,
iast (34.788 ms) : 34451, 35126
. : milestone, 34788,
profiling (292.932 µs) : 266, 320
. : milestone, 293,
tracing (8.921 ms) : 8888, 8954
. : milestone, 8921,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~b461bc2366, baseline=1.50.0-SNAPSHOT~9db71d4352
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.409 ms) : 2360, 2457
. : milestone, 2409,
iast (2.187 ms) : 2126, 2248
. : milestone, 2187,
iast_GLOBAL (2.235 ms) : 2173, 2296
. : milestone, 2235,
profiling (2.049 ms) : 1999, 2099
. : milestone, 2049,
tracing (1.998 ms) : 1951, 2046
. : milestone, 1998,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (2.401 ms) : 2353, 2450
. : milestone, 2401,
iast (2.184 ms) : 2123, 2245
. : milestone, 2184,
iast_GLOBAL (2.228 ms) : 2167, 2289
. : milestone, 2228,
profiling (2.021 ms) : 1972, 2069
. : milestone, 2021,
tracing (1.994 ms) : 1947, 2040
. : milestone, 1994,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~b461bc2366, baseline=1.50.0-SNAPSHOT~9db71d4352
dateFormat X
axisFormat %s
section baseline
no_agent (14.766 s) : 14766000, 14766000
. : milestone, 14766000,
appsec (14.803 s) : 14803000, 14803000
. : milestone, 14803000,
iast (18.545 s) : 18545000, 18545000
. : milestone, 18545000,
iast_GLOBAL (17.79 s) : 17790000, 17790000
. : milestone, 17790000,
profiling (15.872 s) : 15872000, 15872000
. : milestone, 15872000,
tracing (15.123 s) : 15123000, 15123000
. : milestone, 15123000,
section candidate
no_agent (15.587 s) : 15587000, 15587000
. : milestone, 15587000,
appsec (14.969 s) : 14969000, 14969000
. : milestone, 14969000,
iast (18.513 s) : 18513000, 18513000
. : milestone, 18513000,
iast_GLOBAL (17.814 s) : 17814000, 17814000
. : milestone, 17814000,
profiling (15.04 s) : 15040000, 15040000
. : milestone, 15040000,
tracing (14.875 s) : 14875000, 14875000
. : milestone, 14875000,
|
bric3
approved these changes
Jun 16, 2025
dougqh
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Refactored await logic from quite complex manipulations with list of latches with simple
wait/notifyAll
approach.Motivation
Green CI.
PekkoHttpServerInstrumentationAsyncTest failed from time to time with
TimeoutException
:Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]