-
Notifications
You must be signed in to change notification settings - Fork 311
Ignore all gitlab jobs in Check CI pipeline
#8972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to rework the whole integration of this workflow.
It's not working as is and @cbeauchesne recommended to use it differently from the workflow repository documentation.
Would you like to have a look at it?
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 13 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~b2e247fee1, baseline=1.50.0-SNAPSHOT~d56d38c890
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.034 s) : 0, 1033715
Total [baseline] (10.683 s) : 0, 10683281
Agent [candidate] (1.03 s) : 0, 1030465
Total [candidate] (10.636 s) : 0, 10635637
section appsec
Agent [baseline] (1.18 s) : 0, 1179574
Total [baseline] (10.7 s) : 0, 10700018
Agent [candidate] (1.18 s) : 0, 1179727
Total [candidate] (10.675 s) : 0, 10675106
section iast
Agent [baseline] (1.155 s) : 0, 1154797
Total [baseline] (10.925 s) : 0, 10925117
Agent [candidate] (1.157 s) : 0, 1156648
Total [candidate] (10.908 s) : 0, 10908060
section profiling
Agent [baseline] (1.273 s) : 0, 1273249
Total [baseline] (10.901 s) : 0, 10901093
Agent [candidate] (1.272 s) : 0, 1271872
Total [candidate] (10.9 s) : 0, 10899826
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~b2e247fee1, baseline=1.50.0-SNAPSHOT~d56d38c890
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.024 ms) : 0, 688024
BytebuddyAgent [candidate] (684.644 ms) : 0, 684644
GlobalTracer [baseline] (241.9 ms) : 0, 241900
GlobalTracer [candidate] (242.84 ms) : 0, 242840
AppSec [baseline] (59.898 ms) : 0, 59898
AppSec [candidate] (60.24 ms) : 0, 60240
Debugger [baseline] (6.84 ms) : 0, 6840
Debugger [candidate] (6.156 ms) : 0, 6156
Remote Config [baseline] (746.065 µs) : 0, 746
Remote Config [candidate] (742.417 µs) : 0, 742
Telemetry [baseline] (12.741 ms) : 0, 12741
Telemetry [candidate] (12.281 ms) : 0, 12281
section appsec
BytebuddyAgent [baseline] (706.152 ms) : 0, 706152
BytebuddyAgent [candidate] (706.653 ms) : 0, 706653
GlobalTracer [baseline] (235.477 ms) : 0, 235477
GlobalTracer [candidate] (235.357 ms) : 0, 235357
IAST [baseline] (21.836 ms) : 0, 21836
IAST [candidate] (21.746 ms) : 0, 21746
AppSec [baseline] (178.852 ms) : 0, 178852
AppSec [candidate] (178.709 ms) : 0, 178709
Debugger [baseline] (5.893 ms) : 0, 5893
Debugger [candidate] (5.871 ms) : 0, 5871
Remote Config [baseline] (599.894 µs) : 0, 600
Remote Config [candidate] (607.116 µs) : 0, 607
Telemetry [baseline] (7.307 ms) : 0, 7307
Telemetry [candidate] (7.314 ms) : 0, 7314
section iast
BytebuddyAgent [baseline] (804.278 ms) : 0, 804278
BytebuddyAgent [candidate] (806.967 ms) : 0, 806967
GlobalTracer [baseline] (230.955 ms) : 0, 230955
GlobalTracer [candidate] (230.33 ms) : 0, 230330
IAST [baseline] (27.672 ms) : 0, 27672
IAST [candidate] (30.033 ms) : 0, 30033
AppSec [baseline] (53.995 ms) : 0, 53995
AppSec [candidate] (51.366 ms) : 0, 51366
Debugger [baseline] (5.938 ms) : 0, 5938
Debugger [candidate] (5.919 ms) : 0, 5919
Remote Config [baseline] (584.038 µs) : 0, 584
Remote Config [candidate] (582.697 µs) : 0, 583
Telemetry [baseline] (7.86 ms) : 0, 7860
Telemetry [candidate] (7.889 ms) : 0, 7889
section profiling
BytebuddyAgent [baseline] (676.272 ms) : 0, 676272
BytebuddyAgent [candidate] (675.014 ms) : 0, 675014
GlobalTracer [baseline] (361.097 ms) : 0, 361097
GlobalTracer [candidate] (359.997 ms) : 0, 359997
AppSec [baseline] (64.492 ms) : 0, 64492
AppSec [candidate] (64.513 ms) : 0, 64513
Debugger [baseline] (6.17 ms) : 0, 6170
Debugger [candidate] (6.17 ms) : 0, 6170
Remote Config [baseline] (671.922 µs) : 0, 672
Remote Config [candidate] (648.266 µs) : 0, 648
Telemetry [baseline] (8.116 ms) : 0, 8116
Telemetry [candidate] (8.168 ms) : 0, 8168
ProfilingAgent [baseline] (105.401 ms) : 0, 105401
ProfilingAgent [candidate] (106.499 ms) : 0, 106499
Profiling [baseline] (105.426 ms) : 0, 105426
Profiling [candidate] (106.524 ms) : 0, 106524
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~b2e247fee1, baseline=1.50.0-SNAPSHOT~d56d38c890
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.027 s) : 0, 1026889
Total [baseline] (8.503 s) : 0, 8503028
Agent [candidate] (1.028 s) : 0, 1027528
Total [candidate] (8.554 s) : 0, 8554238
section iast
Agent [baseline] (1.164 s) : 0, 1163860
Total [baseline] (9.192 s) : 0, 9192101
Agent [candidate] (1.155 s) : 0, 1155407
Total [candidate] (9.188 s) : 0, 9188465
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.159 s) : 0, 1159375
Total [baseline] (9.193 s) : 0, 9193495
Agent [candidate] (1.163 s) : 0, 1163467
Total [candidate] (9.157 s) : 0, 9156863
section iast_TELEMETRY_OFF
Agent [baseline] (1.152 s) : 0, 1152046
Total [baseline] (9.188 s) : 0, 9187881
Agent [candidate] (1.152 s) : 0, 1152056
Total [candidate] (9.184 s) : 0, 9183903
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~b2e247fee1, baseline=1.50.0-SNAPSHOT~d56d38c890
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.494 ms) : 0, 683494
BytebuddyAgent [candidate] (684.723 ms) : 0, 684723
GlobalTracer [baseline] (240.712 ms) : 0, 240712
GlobalTracer [candidate] (241.186 ms) : 0, 241186
AppSec [baseline] (60.485 ms) : 0, 60485
AppSec [candidate] (59.154 ms) : 0, 59154
Debugger [baseline] (6.057 ms) : 0, 6057
Debugger [candidate] (7.648 ms) : 0, 7648
Remote Config [baseline] (735.375 µs) : 0, 735
Remote Config [candidate] (739.832 µs) : 0, 740
Telemetry [baseline] (12.007 ms) : 0, 12007
Telemetry [candidate] (10.546 ms) : 0, 10546
section iast
BytebuddyAgent [baseline] (810.847 ms) : 0, 810847
BytebuddyAgent [candidate] (804.517 ms) : 0, 804517
GlobalTracer [baseline] (232.733 ms) : 0, 232733
GlobalTracer [candidate] (231.335 ms) : 0, 231335
IAST [baseline] (27.108 ms) : 0, 27108
IAST [candidate] (28.634 ms) : 0, 28634
AppSec [baseline] (55.077 ms) : 0, 55077
AppSec [candidate] (52.962 ms) : 0, 52962
Debugger [baseline] (5.987 ms) : 0, 5987
Debugger [candidate] (5.968 ms) : 0, 5968
Remote Config [baseline] (591.509 µs) : 0, 592
Remote Config [candidate] (592.318 µs) : 0, 592
Telemetry [baseline] (7.97 ms) : 0, 7970
Telemetry [candidate] (7.884 ms) : 0, 7884
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (806.471 ms) : 0, 806471
BytebuddyAgent [candidate] (810.06 ms) : 0, 810060
GlobalTracer [baseline] (232.53 ms) : 0, 232530
GlobalTracer [candidate] (232.71 ms) : 0, 232710
IAST [baseline] (26.409 ms) : 0, 26409
IAST [candidate] (28.007 ms) : 0, 28007
AppSec [baseline] (55.878 ms) : 0, 55878
AppSec [candidate] (54.38 ms) : 0, 54380
Debugger [baseline] (6.026 ms) : 0, 6026
Debugger [candidate] (6.056 ms) : 0, 6056
Remote Config [baseline] (597.807 µs) : 0, 598
Remote Config [candidate] (591.226 µs) : 0, 591
Telemetry [baseline] (7.972 ms) : 0, 7972
Telemetry [candidate] (7.982 ms) : 0, 7982
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (801.949 ms) : 0, 801949
BytebuddyAgent [candidate] (801.57 ms) : 0, 801570
GlobalTracer [baseline] (231.446 ms) : 0, 231446
GlobalTracer [candidate] (231.678 ms) : 0, 231678
IAST [baseline] (28.482 ms) : 0, 28482
IAST [candidate] (28.586 ms) : 0, 28586
AppSec [baseline] (52.243 ms) : 0, 52243
AppSec [candidate] (52.26 ms) : 0, 52260
Debugger [baseline] (6.024 ms) : 0, 6024
Debugger [candidate] (6.033 ms) : 0, 6033
Remote Config [baseline] (590.491 µs) : 0, 590
Remote Config [candidate] (590.777 µs) : 0, 591
Telemetry [baseline] (7.824 ms) : 0, 7824
Telemetry [candidate] (7.868 ms) : 0, 7868
LoadDacapo |
Check CI pipeline
156ed57
to
15c9dc5
Compare
Check CI pipeline
Check CI pipeline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick feedback about your PRs: can you make sure to follow the PR title conventions from the first bullet of contribution checklist? Thanks!
I added dd-gitlab/default-pipeline
as PR check where it’s needed so let’s merge it now.
15c9dc5
to
26c3bcb
Compare
Checks on gitlab are enabled via dd-gitlab/default-pipeline status on the branch protection rules.
26c3bcb
to
b2e247f
Compare
What Does This Do
gitlab/default-pipeline regroups all gitlab jobs and has been added as a required check for
master
,project/*
andrelease/
in rulesets. (See LANGPLAT-589)Also these job names don't exist anymore since #8945 (i.e. there are split by 4), as such they are not used
dd-gitlab/test_smoke: \[11, 2/2\]
dd-gitlab/test_smoke: \[8, 2/2\]
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]