-
Notifications
You must be signed in to change notification settings - Fork 305
Update test source file reporting to match codeowners file #8936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupLoadParameters
See matching parameters
SummaryFound 6 performance improvements and 0 performance regressions! Performance is the same for 0 metrics, 6 unstable metrics.
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~a40f665903, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (2.387 ms) : 2339, 2435
. : milestone, 2387,
iast (2.174 ms) : 2113, 2235
. : milestone, 2174,
iast_GLOBAL (2.215 ms) : 2153, 2276
. : milestone, 2215,
profiling (2.05 ms) : 2000, 2101
. : milestone, 2050,
tracing (1.995 ms) : 1947, 2042
. : milestone, 1995,
section candidate
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.392 ms) : 2344, 2441
. : milestone, 2392,
iast (2.176 ms) : 2115, 2237
. : milestone, 2176,
iast_GLOBAL (2.213 ms) : 2151, 2274
. : milestone, 2213,
profiling (2.04 ms) : 1989, 2090
. : milestone, 2040,
tracing (2.001 ms) : 1954, 2049
. : milestone, 2001,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~a40f665903, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section baseline
no_agent (14.967 s) : 14967000, 14967000
. : milestone, 14967000,
appsec (14.752 s) : 14752000, 14752000
. : milestone, 14752000,
iast (18.995 s) : 18995000, 18995000
. : milestone, 18995000,
iast_GLOBAL (17.866 s) : 17866000, 17866000
. : milestone, 17866000,
profiling (15.296 s) : 15296000, 15296000
. : milestone, 15296000,
tracing (14.787 s) : 14787000, 14787000
. : milestone, 14787000,
section candidate
no_agent (15.46 s) : 15460000, 15460000
. : milestone, 15460000,
appsec (14.791 s) : 14791000, 14791000
. : milestone, 14791000,
iast (18.861 s) : 18861000, 18861000
. : milestone, 18861000,
iast_GLOBAL (18.029 s) : 18029000, 18029000
. : milestone, 18029000,
profiling (15.699 s) : 15699000, 15699000
. : milestone, 15699000,
tracing (14.957 s) : 14957000, 14957000
. : milestone, 14957000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, why we need this change if CircleCI was decommissioned?
Or am I missing something?
@AlexeyKuznetsov-DD Right now, the Gitlab CI is still using CircleCI scripts (collect_results.sh is being used here). I think the plan is to eventually update the scripts to be Gitlab-specific, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What Does This Do
Add initial
\
to test source file paths in order to match changes made to the CODEOWNERS file in #8830Motivation
After updating the CODEOWNERS file in #8830, our reported test case source file paths no longer matched. This resulted in a loss of codeowner data (see the past week's reports vs a month ago's reports).
Additional Notes
We can check this change by looking at the test source files here.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]