Skip to content

Update test source file reporting to match codeowners file #8936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

sarahchen6
Copy link
Contributor

@sarahchen6 sarahchen6 commented Jun 5, 2025

What Does This Do

Add initial \ to test source file paths in order to match changes made to the CODEOWNERS file in #8830

Motivation

After updating the CODEOWNERS file in #8830, our reported test case source file paths no longer matched. This resulted in a loss of codeowner data (see the past week's reports vs a month ago's reports).

Additional Notes

We can check this change by looking at the test source files here.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@sarahchen6 sarahchen6 added type: enhancement tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jun 5, 2025
@sarahchen6 sarahchen6 marked this pull request as ready for review June 5, 2025 21:21
@sarahchen6 sarahchen6 requested a review from a team as a code owner June 5, 2025 21:21
@sarahchen6 sarahchen6 requested review from AlexeyKuznetsov-DD and removed request for a team June 5, 2025 21:21
@pr-commenter
Copy link

pr-commenter bot commented Jun 5, 2025

Benchmarks

Startup

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-06-05T21:14:33 2025-06-05T21:19:17
git_branch master sarahchen6/fix-codeowner-retrieval
git_commit_date 1749044153 1749156703
git_commit_sha 7787af7 a40f665
release_version 1.50.0-SNAPSHOT~7787af738f 1.50.0-SNAPSHOT~a40f665903
start_time 2025-06-05T21:13:46 2025-06-05T21:16:22
See matching parameters
Baseline Candidate
application petclinic petclinic
ci_job_date 1749158357 1749158357
ci_job_id 970992373 970992373
ci_pipeline_id 67125160 67125160
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-63wmvl1-project-304-concurrent-0-be4cuyxf 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-63wmvl1-project-304-concurrent-0-be4cuyxf 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
thresholds_or_results results results
variant appsec appsec

Summary

Found 6 performance improvements and 0 performance regressions! Performance is the same for 0 metrics, 6 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:appsec better
[-46.293ms; -45.060ms] or [-78.636%; -76.542%]
unstable
[+267.841op/s; +312.973op/s] or [+326.221%; +381.191%]
13.194ms 372.511op/s 58.870ms 82.104op/s
scenario:load:petclinic:appsec_no_iast better
[-30.167ms; -28.452ms] or [-44.683%; -42.143%]
unstable
[+38.999op/s; +68.528op/s] or [+54.928%; +96.518%]
38.204ms 124.763op/s 67.513ms 71.000op/s
scenario:load:petclinic:code_origins better
[-30.083ms; -26.492ms] or [-36.653%; -32.277%]
unstable
[+14.314op/s; +44.148op/s] or [+25.560%; +78.835%]
53.789ms 85.231op/s 82.077ms 56.000op/s
scenario:load:petclinic:iast better
[-30.827ms; -28.507ms] or [-40.796%; -37.726%]
unstable
[+23.430op/s; +50.900op/s] or [+36.769%; +79.880%]
45.897ms 100.885op/s 75.564ms 63.720op/s
scenario:load:petclinic:no_agent better
[-7.696ms; -7.533ms] or [-87.909%; -86.050%]
unstable
[+784.787op/s; +4014.379op/s] or [+139.300%; +712.552%]
1.140ms 2962.963op/s 8.754ms 563.380op/s
scenario:load:petclinic:tracing better
[-12.401ms; -12.176ms] or [-95.311%; -93.581%]
unstable
[+1269.205op/s; +5280.012op/s] or [+333.935%; +1389.200%]
0.723ms 3654.684op/s 13.011ms 380.076op/s

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master sarahchen6/fix-codeowner-retrieval
git_commit_date 1749044153 1749156703
git_commit_sha 7787af7 a40f665
release_version 1.50.0-SNAPSHOT~7787af738f 1.50.0-SNAPSHOT~a40f665903
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1749158924 1749158924
ci_job_id 970992374 970992374
ci_pipeline_id 67125160 67125160
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-grlozykg-project-304-concurrent-1-bure6ww2 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-grlozykg-project-304-concurrent-1-bure6ww2 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~a40f665903, baseline=1.50.0-SNAPSHOT~7787af738f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.468 ms) : 1457, 1480
.   : milestone, 1468,
appsec (2.387 ms) : 2339, 2435
.   : milestone, 2387,
iast (2.174 ms) : 2113, 2235
.   : milestone, 2174,
iast_GLOBAL (2.215 ms) : 2153, 2276
.   : milestone, 2215,
profiling (2.05 ms) : 2000, 2101
.   : milestone, 2050,
tracing (1.995 ms) : 1947, 2042
.   : milestone, 1995,
section candidate
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (2.392 ms) : 2344, 2441
.   : milestone, 2392,
iast (2.176 ms) : 2115, 2237
.   : milestone, 2176,
iast_GLOBAL (2.213 ms) : 2151, 2274
.   : milestone, 2213,
profiling (2.04 ms) : 1989, 2090
.   : milestone, 2040,
tracing (2.001 ms) : 1954, 2049
.   : milestone, 2001,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.457 ms, 1.48 ms] -
appsec 2.387 ms [2.339 ms, 2.435 ms] 918.527 µs (62.6%)
iast 2.174 ms [2.113 ms, 2.235 ms] 705.952 µs (48.1%)
iast_GLOBAL 2.215 ms [2.153 ms, 2.276 ms] 746.409 µs (50.8%)
profiling 2.05 ms [2.0 ms, 2.101 ms] 582.068 µs (39.6%)
tracing 1.995 ms [1.947 ms, 2.042 ms] 526.149 µs (35.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.458 ms, 1.481 ms] -
appsec 2.392 ms [2.344 ms, 2.441 ms] 923.288 µs (62.8%)
iast 2.176 ms [2.115 ms, 2.237 ms] 707.202 µs (48.1%)
iast_GLOBAL 2.213 ms [2.151 ms, 2.274 ms] 743.774 µs (50.6%)
profiling 2.04 ms [1.989 ms, 2.09 ms] 570.499 µs (38.8%)
tracing 2.001 ms [1.954 ms, 2.049 ms] 532.064 µs (36.2%)
Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~a40f665903, baseline=1.50.0-SNAPSHOT~7787af738f
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.967 s) : 14967000, 14967000
.   : milestone, 14967000,
appsec (14.752 s) : 14752000, 14752000
.   : milestone, 14752000,
iast (18.995 s) : 18995000, 18995000
.   : milestone, 18995000,
iast_GLOBAL (17.866 s) : 17866000, 17866000
.   : milestone, 17866000,
profiling (15.296 s) : 15296000, 15296000
.   : milestone, 15296000,
tracing (14.787 s) : 14787000, 14787000
.   : milestone, 14787000,
section candidate
no_agent (15.46 s) : 15460000, 15460000
.   : milestone, 15460000,
appsec (14.791 s) : 14791000, 14791000
.   : milestone, 14791000,
iast (18.861 s) : 18861000, 18861000
.   : milestone, 18861000,
iast_GLOBAL (18.029 s) : 18029000, 18029000
.   : milestone, 18029000,
profiling (15.699 s) : 15699000, 15699000
.   : milestone, 15699000,
tracing (14.957 s) : 14957000, 14957000
.   : milestone, 14957000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.967 s [14.967 s, 14.967 s] -
appsec 14.752 s [14.752 s, 14.752 s] -215.0 ms (-1.4%)
iast 18.995 s [18.995 s, 18.995 s] 4.028 s (26.9%)
iast_GLOBAL 17.866 s [17.866 s, 17.866 s] 2.899 s (19.4%)
profiling 15.296 s [15.296 s, 15.296 s] 329.0 ms (2.2%)
tracing 14.787 s [14.787 s, 14.787 s] -180.0 ms (-1.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.46 s [15.46 s, 15.46 s] -
appsec 14.791 s [14.791 s, 14.791 s] -669.0 ms (-4.3%)
iast 18.861 s [18.861 s, 18.861 s] 3.401 s (22.0%)
iast_GLOBAL 18.029 s [18.029 s, 18.029 s] 2.569 s (16.6%)
profiling 15.699 s [15.699 s, 15.699 s] 239.0 ms (1.5%)
tracing 14.957 s [14.957 s, 14.957 s] -503.0 ms (-3.3%)

Copy link
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why we need this change if CircleCI was decommissioned?
Or am I missing something?

@sarahchen6
Copy link
Contributor Author

@AlexeyKuznetsov-DD Right now, the Gitlab CI is still using CircleCI scripts (collect_results.sh is being used here). I think the plan is to eventually update the scripts to be Gitlab-specific, though.

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-requested a review June 6, 2025 00:02
Copy link
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PerfectSlayer PerfectSlayer merged commit c4c5d62 into master Jun 6, 2025
510 of 512 checks passed
@PerfectSlayer PerfectSlayer deleted the sarahchen6/fix-codeowner-retrieval branch June 6, 2025 07:47
@github-actions github-actions bot added this to the 1.50.0 milestone Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants