-
Notifications
You must be signed in to change notification settings - Fork 303
HTTP response schema collection and data classification #8840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sezen-datadog
wants to merge
3
commits into
master
Choose a base branch
from
sezen.leblay/APPSEC-57259
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
891c835
to
a2809f5
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 54 metrics, 12 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~de47e36971, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.016 s) : 0, 1016334
Total [baseline] (10.426 s) : 0, 10426445
Agent [candidate] (1.025 s) : 0, 1024830
Total [candidate] (10.472 s) : 0, 10471510
section appsec
Agent [baseline] (1.159 s) : 0, 1159349
Total [baseline] (10.738 s) : 0, 10738279
Agent [candidate] (1.16 s) : 0, 1160143
Total [candidate] (10.628 s) : 0, 10627796
section iast
Agent [baseline] (1.148 s) : 0, 1147543
Total [baseline] (10.848 s) : 0, 10847606
Agent [candidate] (1.147 s) : 0, 1146625
Total [candidate] (10.846 s) : 0, 10845732
section profiling
Agent [baseline] (1.286 s) : 0, 1285618
Total [baseline] (10.882 s) : 0, 10881709
Agent [candidate] (1.263 s) : 0, 1263082
Total [candidate] (10.792 s) : 0, 10791755
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~de47e36971, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.799 ms) : 0, 681799
BytebuddyAgent [candidate] (685.14 ms) : 0, 685140
GlobalTracer [baseline] (239.393 ms) : 0, 239393
GlobalTracer [candidate] (240.795 ms) : 0, 240795
AppSec [baseline] (55.004 ms) : 0, 55004
AppSec [candidate] (56.528 ms) : 0, 56528
Debugger [baseline] (7.617 ms) : 0, 7617
Debugger [candidate] (9.137 ms) : 0, 9137
Remote Config [baseline] (700.289 µs) : 0, 700
Remote Config [candidate] (668.339 µs) : 0, 668
Telemetry [baseline] (8.33 ms) : 0, 8330
Telemetry [candidate] (8.18 ms) : 0, 8180
section appsec
BytebuddyAgent [baseline] (698.971 ms) : 0, 698971
BytebuddyAgent [candidate] (698.531 ms) : 0, 698531
GlobalTracer [baseline] (236.287 ms) : 0, 236287
GlobalTracer [candidate] (236.538 ms) : 0, 236538
IAST [baseline] (21.65 ms) : 0, 21650
IAST [candidate] (21.687 ms) : 0, 21687
AppSec [baseline] (175.805 ms) : 0, 175805
AppSec [candidate] (176.498 ms) : 0, 176498
Debugger [baseline] (5.945 ms) : 0, 5945
Debugger [candidate] (5.925 ms) : 0, 5925
Remote Config [baseline] (622.069 µs) : 0, 622
Remote Config [candidate] (637.76 µs) : 0, 638
Telemetry [baseline] (7.403 ms) : 0, 7403
Telemetry [candidate] (7.692 ms) : 0, 7692
section iast
BytebuddyAgent [baseline] (801.122 ms) : 0, 801122
BytebuddyAgent [candidate] (799.654 ms) : 0, 799654
GlobalTracer [baseline] (230.61 ms) : 0, 230610
GlobalTracer [candidate] (230.078 ms) : 0, 230078
IAST [baseline] (29.013 ms) : 0, 29013
IAST [candidate] (29.104 ms) : 0, 29104
AppSec [baseline] (47.542 ms) : 0, 47542
AppSec [candidate] (49.974 ms) : 0, 49974
Debugger [baseline] (5.853 ms) : 0, 5853
Debugger [candidate] (5.925 ms) : 0, 5925
Remote Config [baseline] (585.179 µs) : 0, 585
Remote Config [candidate] (585.785 µs) : 0, 586
Telemetry [baseline] (7.866 ms) : 0, 7866
Telemetry [candidate] (7.874 ms) : 0, 7874
section profiling
BytebuddyAgent [baseline] (676.529 ms) : 0, 676529
BytebuddyAgent [candidate] (672.663 ms) : 0, 672663
GlobalTracer [baseline] (378.904 ms) : 0, 378904
GlobalTracer [candidate] (359.044 ms) : 0, 359044
AppSec [baseline] (54.586 ms) : 0, 54586
AppSec [candidate] (62.682 ms) : 0, 62682
Debugger [baseline] (6.177 ms) : 0, 6177
Debugger [candidate] (6.236 ms) : 0, 6236
Remote Config [baseline] (669.11 µs) : 0, 669
Remote Config [candidate] (645.257 µs) : 0, 645
Telemetry [baseline] (8.118 ms) : 0, 8118
Telemetry [candidate] (8.321 ms) : 0, 8321
ProfilingAgent [baseline] (109.759 ms) : 0, 109759
ProfilingAgent [candidate] (102.779 ms) : 0, 102779
Profiling [baseline] (109.785 ms) : 0, 109785
Profiling [candidate] (102.803 ms) : 0, 102803
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~de47e36971, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1021280
Total [baseline] (8.65 s) : 0, 8650318
Agent [candidate] (1.021 s) : 0, 1020530
Total [candidate] (8.622 s) : 0, 8622188
section iast
Agent [baseline] (1.153 s) : 0, 1152848
Total [baseline] (9.2 s) : 0, 9200276
Agent [candidate] (1.146 s) : 0, 1145646
Total [candidate] (9.239 s) : 0, 9238654
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.145 s) : 0, 1145009
Total [baseline] (9.221 s) : 0, 9220796
Agent [candidate] (1.162 s) : 0, 1162423
Total [candidate] (9.183 s) : 0, 9182583
section iast_TELEMETRY_OFF
Agent [baseline] (1.144 s) : 0, 1144019
Total [baseline] (9.207 s) : 0, 9207139
Agent [candidate] (1.153 s) : 0, 1152913
Total [candidate] (9.191 s) : 0, 9191100
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~de47e36971, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.625 ms) : 0, 685625
BytebuddyAgent [candidate] (681.758 ms) : 0, 681758
GlobalTracer [baseline] (240.544 ms) : 0, 240544
GlobalTracer [candidate] (239.471 ms) : 0, 239471
AppSec [baseline] (54.833 ms) : 0, 54833
AppSec [candidate] (58.502 ms) : 0, 58502
Debugger [baseline] (6.912 ms) : 0, 6912
Debugger [candidate] (6.305 ms) : 0, 6305
Remote Config [baseline] (707.799 µs) : 0, 708
Remote Config [candidate] (683.176 µs) : 0, 683
Telemetry [baseline] (9.146 ms) : 0, 9146
Telemetry [candidate] (10.381 ms) : 0, 10381
section iast
BytebuddyAgent [baseline] (804.91 ms) : 0, 804910
BytebuddyAgent [candidate] (799.044 ms) : 0, 799044
GlobalTracer [baseline] (231.005 ms) : 0, 231005
GlobalTracer [candidate] (230.05 ms) : 0, 230050
IAST [baseline] (28.382 ms) : 0, 28382
IAST [candidate] (28.346 ms) : 0, 28346
AppSec [baseline] (50.55 ms) : 0, 50550
AppSec [candidate] (48.327 ms) : 0, 48327
Debugger [baseline] (5.96 ms) : 0, 5960
Debugger [candidate] (5.812 ms) : 0, 5812
Remote Config [baseline] (611.92 µs) : 0, 612
Remote Config [candidate] (592.473 µs) : 0, 592
Telemetry [baseline] (7.881 ms) : 0, 7881
Telemetry [candidate] (7.845 ms) : 0, 7845
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (799.14 ms) : 0, 799140
BytebuddyAgent [candidate] (813.289 ms) : 0, 813289
GlobalTracer [baseline] (229.944 ms) : 0, 229944
GlobalTracer [candidate] (231.341 ms) : 0, 231341
IAST [baseline] (30.737 ms) : 0, 30737
IAST [candidate] (30.256 ms) : 0, 30256
AppSec [baseline] (47.526 ms) : 0, 47526
AppSec [candidate] (49.484 ms) : 0, 49484
Debugger [baseline] (5.86 ms) : 0, 5860
Debugger [candidate] (5.851 ms) : 0, 5851
Remote Config [baseline] (588.052 µs) : 0, 588
Remote Config [candidate] (607.393 µs) : 0, 607
Telemetry [baseline] (7.838 ms) : 0, 7838
Telemetry [candidate] (7.954 ms) : 0, 7954
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (797.776 ms) : 0, 797776
BytebuddyAgent [candidate] (803.467 ms) : 0, 803467
GlobalTracer [baseline] (230.192 ms) : 0, 230192
GlobalTracer [candidate] (231.823 ms) : 0, 231823
IAST [baseline] (23.086 ms) : 0, 23086
IAST [candidate] (22.724 ms) : 0, 22724
AppSec [baseline] (55.192 ms) : 0, 55192
AppSec [candidate] (56.996 ms) : 0, 56996
Debugger [baseline] (5.874 ms) : 0, 5874
Debugger [candidate] (5.939 ms) : 0, 5939
Remote Config [baseline] (606.764 µs) : 0, 607
Remote Config [candidate] (602.045 µs) : 0, 602
Telemetry [baseline] (7.73 ms) : 0, 7730
Telemetry [candidate] (7.754 ms) : 0, 7754
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 18 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~de47e36971, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (390.965 µs) : 371, 411
. : milestone, 391,
iast (527.719 µs) : 506, 549
. : milestone, 528,
iast_FULL (743.588 µs) : 722, 766
. : milestone, 744,
iast_GLOBAL (572.454 µs) : 551, 594
. : milestone, 572,
iast_HARDCODED_SECRET_DISABLED (526.005 µs) : 504, 548
. : milestone, 526,
iast_INACTIVE (477.717 µs) : 455, 500
. : milestone, 478,
iast_TELEMETRY_OFF (512.734 µs) : 489, 536
. : milestone, 513,
tracing (469.501 µs) : 447, 492
. : milestone, 470,
section candidate
no_agent (393.557 µs) : 374, 413
. : milestone, 394,
iast (504.336 µs) : 482, 526
. : milestone, 504,
iast_FULL (820.69 µs) : 798, 844
. : milestone, 821,
iast_GLOBAL (542.294 µs) : 517, 568
. : milestone, 542,
iast_HARDCODED_SECRET_DISABLED (502.56 µs) : 479, 526
. : milestone, 503,
iast_INACTIVE (482.252 µs) : 459, 505
. : milestone, 482,
iast_TELEMETRY_OFF (499.022 µs) : 476, 522
. : milestone, 499,
tracing (469.267 µs) : 447, 492
. : milestone, 469,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~de47e36971, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (1.36 ms) : 1340, 1379
. : milestone, 1360,
appsec (1.735 ms) : 1711, 1758
. : milestone, 1735,
appsec_no_iast (1.724 ms) : 1701, 1748
. : milestone, 1724,
code_origins (1.681 ms) : 1654, 1707
. : milestone, 1681,
iast (1.524 ms) : 1501, 1548
. : milestone, 1524,
profiling (1.536 ms) : 1513, 1560
. : milestone, 1536,
tracing (1.513 ms) : 1488, 1537
. : milestone, 1513,
section candidate
no_agent (1.375 ms) : 1356, 1394
. : milestone, 1375,
appsec (1.491 ms) : 1468, 1514
. : milestone, 1491,
appsec_no_iast (1.483 ms) : 1460, 1506
. : milestone, 1483,
code_origins (1.661 ms) : 1635, 1688
. : milestone, 1661,
iast (1.483 ms) : 1459, 1507
. : milestone, 1483,
profiling (1.483 ms) : 1459, 1507
. : milestone, 1483,
tracing (1.466 ms) : 1440, 1492
. : milestone, 1466,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 1 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~de47e36971, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.406 ms) : 2357, 2455
. : milestone, 2406,
iast (2.18 ms) : 2119, 2241
. : milestone, 2180,
iast_GLOBAL (2.227 ms) : 2165, 2288
. : milestone, 2227,
profiling (2.045 ms) : 1995, 2095
. : milestone, 2045,
tracing (2.012 ms) : 1965, 2060
. : milestone, 2012,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (1.959 ms) : 1911, 2007
. : milestone, 1959,
iast (2.105 ms) : 2045, 2165
. : milestone, 2105,
iast_GLOBAL (2.125 ms) : 2064, 2187
. : milestone, 2125,
profiling (2.442 ms) : 2261, 2623
. : milestone, 2442,
tracing (1.957 ms) : 1909, 2006
. : milestone, 1957,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~de47e36971, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (14.761 s) : 14761000, 14761000
. : milestone, 14761000,
appsec (15.242 s) : 15242000, 15242000
. : milestone, 15242000,
iast (18.995 s) : 18995000, 18995000
. : milestone, 18995000,
iast_GLOBAL (18.1 s) : 18100000, 18100000
. : milestone, 18100000,
profiling (14.991 s) : 14991000, 14991000
. : milestone, 14991000,
tracing (14.915 s) : 14915000, 14915000
. : milestone, 14915000,
section candidate
no_agent (14.828 s) : 14828000, 14828000
. : milestone, 14828000,
appsec (15.088 s) : 15088000, 15088000
. : milestone, 15088000,
iast (18.954 s) : 18954000, 18954000
. : milestone, 18954000,
iast_GLOBAL (18.178 s) : 18178000, 18178000
. : milestone, 18178000,
profiling (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
tracing (14.847 s) : 14847000, 14847000
. : milestone, 14847000,
|
ff2d34f
to
4d7fed2
Compare
a29290a
to
314cb27
Compare
314cb27
to
ba4b25c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-57259