-
Notifications
You must be signed in to change notification settings - Fork 303
Send initial telemetry in separate thread to reduce start-up latency. #8818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Send initial telemetry in separate thread to reduce start-up latency. #8818
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 54 metrics, 13 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~6ceb1cba00, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1021095
Total [baseline] (8.681 s) : 0, 8681144
Agent [candidate] (1.018 s) : 0, 1017836
Total [candidate] (8.642 s) : 0, 8642166
section iast
Agent [baseline] (1.147 s) : 0, 1146685
Total [baseline] (9.209 s) : 0, 9209367
Agent [candidate] (1.15 s) : 0, 1149594
Total [candidate] (9.235 s) : 0, 9235313
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.146 s) : 0, 1146495
Total [baseline] (9.183 s) : 0, 9182805
Agent [candidate] (1.15 s) : 0, 1149850
Total [candidate] (9.167 s) : 0, 9166668
section iast_TELEMETRY_OFF
Agent [baseline] (1.147 s) : 0, 1146616
Total [baseline] (9.227 s) : 0, 9227080
Agent [candidate] (1.152 s) : 0, 1152165
Total [candidate] (9.246 s) : 0, 9246373
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~6ceb1cba00, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.746 ms) : 0, 682746
BytebuddyAgent [candidate] (681.467 ms) : 0, 681467
GlobalTracer [baseline] (240.864 ms) : 0, 240864
GlobalTracer [candidate] (239.801 ms) : 0, 239801
AppSec [baseline] (54.968 ms) : 0, 54968
AppSec [candidate] (55.721 ms) : 0, 55721
Debugger [baseline] (7.713 ms) : 0, 7713
Debugger [candidate] (6.855 ms) : 0, 6855
Remote Config [baseline] (696.508 µs) : 0, 697
Remote Config [candidate] (703.275 µs) : 0, 703
Telemetry [baseline] (10.686 ms) : 0, 10686
Telemetry [candidate] (9.754 ms) : 0, 9754
section iast
BytebuddyAgent [baseline] (800.147 ms) : 0, 800147
BytebuddyAgent [candidate] (802.148 ms) : 0, 802148
GlobalTracer [baseline] (229.98 ms) : 0, 229980
GlobalTracer [candidate] (230.732 ms) : 0, 230732
IAST [baseline] (25.808 ms) : 0, 25808
IAST [candidate] (27.657 ms) : 0, 27657
AppSec [baseline] (52.868 ms) : 0, 52868
AppSec [candidate] (51.231 ms) : 0, 51231
Debugger [baseline] (5.921 ms) : 0, 5921
Debugger [candidate] (5.917 ms) : 0, 5917
Remote Config [baseline] (611.716 µs) : 0, 612
Remote Config [candidate] (599.285 µs) : 0, 599
Telemetry [baseline] (7.876 ms) : 0, 7876
Telemetry [candidate] (7.854 ms) : 0, 7854
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.119 ms) : 0, 800119
BytebuddyAgent [candidate] (802.489 ms) : 0, 802489
GlobalTracer [baseline] (229.937 ms) : 0, 229937
GlobalTracer [candidate] (230.727 ms) : 0, 230727
IAST [baseline] (26.072 ms) : 0, 26072
IAST [candidate] (29.143 ms) : 0, 29143
AppSec [baseline] (52.527 ms) : 0, 52527
AppSec [candidate] (49.522 ms) : 0, 49522
Debugger [baseline] (5.914 ms) : 0, 5914
Debugger [candidate] (5.911 ms) : 0, 5911
Remote Config [baseline] (578.977 µs) : 0, 579
Remote Config [candidate] (592.799 µs) : 0, 593
Telemetry [baseline] (7.837 ms) : 0, 7837
Telemetry [candidate] (7.917 ms) : 0, 7917
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (799.329 ms) : 0, 799329
BytebuddyAgent [candidate] (803.811 ms) : 0, 803811
GlobalTracer [baseline] (230.623 ms) : 0, 230623
GlobalTracer [candidate] (231.627 ms) : 0, 231627
IAST [baseline] (22.451 ms) : 0, 22451
IAST [candidate] (24.008 ms) : 0, 24008
AppSec [baseline] (56.153 ms) : 0, 56153
AppSec [candidate] (53.837 ms) : 0, 53837
Debugger [baseline] (5.963 ms) : 0, 5963
Debugger [candidate] (6.018 ms) : 0, 6018
Remote Config [baseline] (616.097 µs) : 0, 616
Remote Config [candidate] (609.821 µs) : 0, 610
Telemetry [baseline] (7.802 ms) : 0, 7802
Telemetry [candidate] (7.91 ms) : 0, 7910
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~6ceb1cba00, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1020504
Total [baseline] (10.44 s) : 0, 10440347
Agent [candidate] (1.019 s) : 0, 1018663
Total [candidate] (10.429 s) : 0, 10429188
section appsec
Agent [baseline] (1.166 s) : 0, 1166042
Total [baseline] (10.702 s) : 0, 10701850
Agent [candidate] (1.172 s) : 0, 1172219
Total [candidate] (10.697 s) : 0, 10696949
section iast
Agent [baseline] (1.151 s) : 0, 1151409
Total [baseline] (10.944 s) : 0, 10944218
Agent [candidate] (1.15 s) : 0, 1150469
Total [candidate] (10.804 s) : 0, 10803966
section profiling
Agent [baseline] (1.28 s) : 0, 1279815
Total [baseline] (10.884 s) : 0, 10883560
Agent [candidate] (1.268 s) : 0, 1268333
Total [candidate] (10.8 s) : 0, 10800250
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~6ceb1cba00, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.209 ms) : 0, 682209
BytebuddyAgent [candidate] (681.94 ms) : 0, 681940
GlobalTracer [baseline] (239.632 ms) : 0, 239632
GlobalTracer [candidate] (240.096 ms) : 0, 240096
AppSec [baseline] (55.163 ms) : 0, 55163
AppSec [candidate] (55.251 ms) : 0, 55251
Debugger [baseline] (10.483 ms) : 0, 10483
Debugger [candidate] (8.939 ms) : 0, 8939
Remote Config [baseline] (666.169 µs) : 0, 666
Remote Config [candidate] (692.561 µs) : 0, 693
Telemetry [baseline] (8.926 ms) : 0, 8926
Telemetry [candidate] (8.293 ms) : 0, 8293
section appsec
BytebuddyAgent [baseline] (704.443 ms) : 0, 704443
BytebuddyAgent [candidate] (707.73 ms) : 0, 707730
GlobalTracer [baseline] (237.039 ms) : 0, 237039
GlobalTracer [candidate] (238.637 ms) : 0, 238637
IAST [baseline] (21.702 ms) : 0, 21702
IAST [candidate] (22.234 ms) : 0, 22234
AppSec [baseline] (176.075 ms) : 0, 176075
AppSec [candidate] (176.194 ms) : 0, 176194
Debugger [baseline] (5.92 ms) : 0, 5920
Debugger [candidate] (6.023 ms) : 0, 6023
Remote Config [baseline] (632.44 µs) : 0, 632
Remote Config [candidate] (629.165 µs) : 0, 629
Telemetry [baseline] (7.426 ms) : 0, 7426
Telemetry [candidate] (8.192 ms) : 0, 8192
section iast
BytebuddyAgent [baseline] (803.65 ms) : 0, 803650
BytebuddyAgent [candidate] (802.965 ms) : 0, 802965
GlobalTracer [baseline] (230.871 ms) : 0, 230871
GlobalTracer [candidate] (230.8 ms) : 0, 230800
IAST [baseline] (25.452 ms) : 0, 25452
IAST [candidate] (27.662 ms) : 0, 27662
AppSec [baseline] (51.079 ms) : 0, 51079
AppSec [candidate] (51.117 ms) : 0, 51117
Debugger [baseline] (5.882 ms) : 0, 5882
Debugger [candidate] (5.92 ms) : 0, 5920
Remote Config [baseline] (596.993 µs) : 0, 597
Remote Config [candidate] (591.802 µs) : 0, 592
Telemetry [baseline] (7.897 ms) : 0, 7897
Telemetry [candidate] (7.972 ms) : 0, 7972
section profiling
BytebuddyAgent [baseline] (672.399 ms) : 0, 672399
BytebuddyAgent [candidate] (674.375 ms) : 0, 674375
GlobalTracer [baseline] (378.113 ms) : 0, 378113
GlobalTracer [candidate] (361.713 ms) : 0, 361713
AppSec [baseline] (54.347 ms) : 0, 54347
AppSec [candidate] (62.012 ms) : 0, 62012
Debugger [baseline] (6.114 ms) : 0, 6114
Debugger [candidate] (6.348 ms) : 0, 6348
Remote Config [baseline] (649.117 µs) : 0, 649
Remote Config [candidate] (656.583 µs) : 0, 657
Telemetry [baseline] (8.071 ms) : 0, 8071
Telemetry [candidate] (8.292 ms) : 0, 8292
ProfilingAgent [baseline] (109.545 ms) : 0, 109545
ProfilingAgent [candidate] (103.995 ms) : 0, 103995
Profiling [baseline] (109.57 ms) : 0, 109570
Profiling [candidate] (104.018 ms) : 0, 104018
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~6ceb1cba00, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (390.938 µs) : 370, 412
. : milestone, 391,
iast (523.256 µs) : 501, 545
. : milestone, 523,
iast_FULL (746.465 µs) : 724, 768
. : milestone, 746,
iast_GLOBAL (584.438 µs) : 561, 608
. : milestone, 584,
iast_HARDCODED_SECRET_DISABLED (533.002 µs) : 510, 556
. : milestone, 533,
iast_INACTIVE (475.94 µs) : 454, 498
. : milestone, 476,
iast_TELEMETRY_OFF (525.028 µs) : 502, 548
. : milestone, 525,
tracing (459.766 µs) : 438, 481
. : milestone, 460,
section candidate
no_agent (389.765 µs) : 370, 409
. : milestone, 390,
iast (527.554 µs) : 506, 549
. : milestone, 528,
iast_FULL (743.637 µs) : 722, 766
. : milestone, 744,
iast_GLOBAL (567.592 µs) : 546, 589
. : milestone, 568,
iast_HARDCODED_SECRET_DISABLED (527.035 µs) : 505, 549
. : milestone, 527,
iast_INACTIVE (471.089 µs) : 449, 493
. : milestone, 471,
iast_TELEMETRY_OFF (512.668 µs) : 489, 536
. : milestone, 513,
tracing (466.969 µs) : 445, 489
. : milestone, 467,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~6ceb1cba00, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (1.365 ms) : 1345, 1385
. : milestone, 1365,
appsec (1.732 ms) : 1709, 1756
. : milestone, 1732,
appsec_no_iast (1.737 ms) : 1714, 1761
. : milestone, 1737,
code_origins (1.695 ms) : 1665, 1724
. : milestone, 1695,
iast (1.523 ms) : 1499, 1547
. : milestone, 1523,
profiling (1.558 ms) : 1532, 1583
. : milestone, 1558,
tracing (1.502 ms) : 1477, 1526
. : milestone, 1502,
section candidate
no_agent (1.378 ms) : 1358, 1397
. : milestone, 1378,
appsec (1.76 ms) : 1736, 1784
. : milestone, 1760,
appsec_no_iast (1.739 ms) : 1716, 1763
. : milestone, 1739,
code_origins (1.703 ms) : 1675, 1730
. : milestone, 1703,
iast (1.512 ms) : 1487, 1536
. : milestone, 1512,
profiling (1.513 ms) : 1489, 1537
. : milestone, 1513,
tracing (1.515 ms) : 1490, 1540
. : milestone, 1515,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~6ceb1cba00, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1471, 1495
. : milestone, 1483,
appsec (2.403 ms) : 2355, 2451
. : milestone, 2403,
iast (2.179 ms) : 2119, 2240
. : milestone, 2179,
iast_GLOBAL (2.215 ms) : 2154, 2276
. : milestone, 2215,
profiling (2.024 ms) : 1975, 2072
. : milestone, 2024,
tracing (2.009 ms) : 1962, 2057
. : milestone, 2009,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (2.413 ms) : 2364, 2461
. : milestone, 2413,
iast (2.189 ms) : 2128, 2249
. : milestone, 2189,
iast_GLOBAL (2.234 ms) : 2172, 2295
. : milestone, 2234,
profiling (2.038 ms) : 1989, 2086
. : milestone, 2038,
tracing (2.015 ms) : 1967, 2062
. : milestone, 2015,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~6ceb1cba00, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (15.531 s) : 15531000, 15531000
. : milestone, 15531000,
appsec (14.804 s) : 14804000, 14804000
. : milestone, 14804000,
iast (18.708 s) : 18708000, 18708000
. : milestone, 18708000,
iast_GLOBAL (18.253 s) : 18253000, 18253000
. : milestone, 18253000,
profiling (15.023 s) : 15023000, 15023000
. : milestone, 15023000,
tracing (15.176 s) : 15176000, 15176000
. : milestone, 15176000,
section candidate
no_agent (15.584 s) : 15584000, 15584000
. : milestone, 15584000,
appsec (14.888 s) : 14888000, 14888000
. : milestone, 14888000,
iast (19.037 s) : 19037000, 19037000
. : milestone, 19037000,
iast_GLOBAL (18.266 s) : 18266000, 18266000
. : milestone, 18266000,
profiling (15.093 s) : 15093000, 15093000
. : milestone, 15093000,
tracing (14.862 s) : 14862000, 14862000
. : milestone, 14862000,
|
What Does This Do
Send bootstrap telemetry from separate thread.
Motivation
Reduce start-up latency
Additional Notes
Change already covered by existing tests.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]