-
Notifications
You must be signed in to change notification settings - Fork 305
Send initial telemetry in separate thread to reduce start-up latency. #8818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send initial telemetry in separate thread to reduce start-up latency. #8818
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 51 metrics, 16 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~3dc654bbfc, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1021533
Total [baseline] (8.657 s) : 0, 8657436
Agent [candidate] (1.028 s) : 0, 1028196
Total [candidate] (8.696 s) : 0, 8696481
section iast
Agent [baseline] (1.15 s) : 0, 1149648
Total [baseline] (9.273 s) : 0, 9272748
Agent [candidate] (1.146 s) : 0, 1146121
Total [candidate] (9.219 s) : 0, 9219481
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.158 s) : 0, 1157764
Total [baseline] (9.21 s) : 0, 9209589
Agent [candidate] (1.151 s) : 0, 1151220
Total [candidate] (9.227 s) : 0, 9227444
section iast_TELEMETRY_OFF
Agent [baseline] (1.152 s) : 0, 1152406
Total [baseline] (9.24 s) : 0, 9240119
Agent [candidate] (1.16 s) : 0, 1159933
Total [candidate] (9.286 s) : 0, 9285964
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~3dc654bbfc, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.242 ms) : 0, 683242
BytebuddyAgent [candidate] (688.419 ms) : 0, 688419
GlobalTracer [baseline] (240.237 ms) : 0, 240237
GlobalTracer [candidate] (242.123 ms) : 0, 242123
AppSec [baseline] (55.626 ms) : 0, 55626
AppSec [candidate] (57.247 ms) : 0, 57247
Debugger [baseline] (9.181 ms) : 0, 9181
Debugger [candidate] (6.904 ms) : 0, 6904
Remote Config [baseline] (714.179 µs) : 0, 714
Remote Config [candidate] (721.291 µs) : 0, 721
Telemetry [baseline] (9.036 ms) : 0, 9036
Telemetry [candidate] (9.158 ms) : 0, 9158
section iast
BytebuddyAgent [baseline] (802.449 ms) : 0, 802449
BytebuddyAgent [candidate] (800.013 ms) : 0, 800013
GlobalTracer [baseline] (230.583 ms) : 0, 230583
GlobalTracer [candidate] (230.425 ms) : 0, 230425
IAST [baseline] (26.786 ms) : 0, 26786
IAST [candidate] (27.263 ms) : 0, 27263
AppSec [baseline] (52.096 ms) : 0, 52096
AppSec [candidate] (50.766 ms) : 0, 50766
Debugger [baseline] (5.874 ms) : 0, 5874
Debugger [candidate] (5.834 ms) : 0, 5834
Remote Config [baseline] (591.062 µs) : 0, 591
Remote Config [candidate] (585.53 µs) : 0, 586
Telemetry [baseline] (7.776 ms) : 0, 7776
Telemetry [candidate] (7.823 ms) : 0, 7823
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (808.087 ms) : 0, 808087
BytebuddyAgent [candidate] (802.927 ms) : 0, 802927
GlobalTracer [baseline] (232.118 ms) : 0, 232118
GlobalTracer [candidate] (231.631 ms) : 0, 231631
IAST [baseline] (27.793 ms) : 0, 27793
IAST [candidate] (27.471 ms) : 0, 27471
AppSec [baseline] (51.56 ms) : 0, 51560
AppSec [candidate] (51.326 ms) : 0, 51326
Debugger [baseline] (5.998 ms) : 0, 5998
Debugger [candidate] (5.921 ms) : 0, 5921
Remote Config [baseline] (599.58 µs) : 0, 600
Remote Config [candidate] (593.694 µs) : 0, 594
Telemetry [baseline] (7.985 ms) : 0, 7985
Telemetry [candidate] (7.884 ms) : 0, 7884
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (804.383 ms) : 0, 804383
BytebuddyAgent [candidate] (810.364 ms) : 0, 810364
GlobalTracer [baseline] (231.712 ms) : 0, 231712
GlobalTracer [candidate] (232.243 ms) : 0, 232243
IAST [baseline] (23.379 ms) : 0, 23379
IAST [candidate] (22.672 ms) : 0, 22672
AppSec [baseline] (55.019 ms) : 0, 55019
AppSec [candidate] (55.462 ms) : 0, 55462
Debugger [baseline] (5.946 ms) : 0, 5946
Debugger [candidate] (6.03 ms) : 0, 6030
Remote Config [baseline] (598.26 µs) : 0, 598
Remote Config [candidate] (675.324 µs) : 0, 675
Telemetry [baseline] (7.69 ms) : 0, 7690
Telemetry [candidate] (7.868 ms) : 0, 7868
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~3dc654bbfc, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.028 s) : 0, 1028457
Total [baseline] (10.467 s) : 0, 10467261
Agent [candidate] (1.038 s) : 0, 1037629
Total [candidate] (10.475 s) : 0, 10475067
section appsec
Agent [baseline] (1.167 s) : 0, 1166876
Total [baseline] (10.701 s) : 0, 10701333
Agent [candidate] (1.17 s) : 0, 1169536
Total [candidate] (10.699 s) : 0, 10699253
section iast
Agent [baseline] (1.152 s) : 0, 1151513
Total [baseline] (10.916 s) : 0, 10915665
Agent [candidate] (1.153 s) : 0, 1153371
Total [candidate] (10.897 s) : 0, 10897449
section profiling
Agent [baseline] (1.291 s) : 0, 1290566
Total [baseline] (10.883 s) : 0, 10883049
Agent [candidate] (1.267 s) : 0, 1266716
Total [candidate] (10.833 s) : 0, 10833331
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~3dc654bbfc, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.32 ms) : 0, 688320
BytebuddyAgent [candidate] (694.574 ms) : 0, 694574
GlobalTracer [baseline] (241.972 ms) : 0, 241972
GlobalTracer [candidate] (244.098 ms) : 0, 244098
AppSec [baseline] (54.592 ms) : 0, 54592
AppSec [candidate] (55.404 ms) : 0, 55404
Debugger [baseline] (9.321 ms) : 0, 9321
Debugger [candidate] (9.853 ms) : 0, 9853
Remote Config [baseline] (697.395 µs) : 0, 697
Remote Config [candidate] (712.359 µs) : 0, 712
Telemetry [baseline] (9.891 ms) : 0, 9891
Telemetry [candidate] (9.129 ms) : 0, 9129
section appsec
BytebuddyAgent [baseline] (703.444 ms) : 0, 703444
BytebuddyAgent [candidate] (704.974 ms) : 0, 704974
GlobalTracer [baseline] (237.745 ms) : 0, 237745
GlobalTracer [candidate] (238.461 ms) : 0, 238461
IAST [baseline] (22.027 ms) : 0, 22027
IAST [candidate] (21.731 ms) : 0, 21731
AppSec [baseline] (176.617 ms) : 0, 176617
AppSec [candidate] (176.348 ms) : 0, 176348
Debugger [baseline] (5.974 ms) : 0, 5974
Debugger [candidate] (6.374 ms) : 0, 6374
Remote Config [baseline] (634.971 µs) : 0, 635
Remote Config [candidate] (633.823 µs) : 0, 634
Telemetry [baseline] (7.781 ms) : 0, 7781
Telemetry [candidate] (7.842 ms) : 0, 7842
section iast
BytebuddyAgent [baseline] (803.843 ms) : 0, 803843
BytebuddyAgent [candidate] (805.039 ms) : 0, 805039
GlobalTracer [baseline] (231.143 ms) : 0, 231143
GlobalTracer [candidate] (231.682 ms) : 0, 231682
IAST [baseline] (27.328 ms) : 0, 27328
IAST [candidate] (28.236 ms) : 0, 28236
AppSec [baseline] (51.217 ms) : 0, 51217
AppSec [candidate] (50.429 ms) : 0, 50429
Debugger [baseline] (5.929 ms) : 0, 5929
Debugger [candidate] (5.939 ms) : 0, 5939
Remote Config [baseline] (592.654 µs) : 0, 593
Remote Config [candidate] (593.286 µs) : 0, 593
Telemetry [baseline] (7.873 ms) : 0, 7873
Telemetry [candidate] (7.897 ms) : 0, 7897
section profiling
BytebuddyAgent [baseline] (678.756 ms) : 0, 678756
BytebuddyAgent [candidate] (674.285 ms) : 0, 674285
GlobalTracer [baseline] (380.464 ms) : 0, 380464
GlobalTracer [candidate] (360.383 ms) : 0, 360383
AppSec [baseline] (54.827 ms) : 0, 54827
AppSec [candidate] (61.859 ms) : 0, 61859
Debugger [baseline] (6.208 ms) : 0, 6208
Debugger [candidate] (6.298 ms) : 0, 6298
Remote Config [baseline] (666.005 µs) : 0, 666
Remote Config [candidate] (664.738 µs) : 0, 665
Telemetry [baseline] (8.22 ms) : 0, 8220
Telemetry [candidate] (8.203 ms) : 0, 8203
ProfilingAgent [baseline] (110.478 ms) : 0, 110478
ProfilingAgent [candidate] (104.145 ms) : 0, 104145
Profiling [baseline] (110.506 ms) : 0, 110506
Profiling [candidate] (104.169 ms) : 0, 104169
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~3dc654bbfc, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (1.368 ms) : 1348, 1388
. : milestone, 1368,
appsec (1.737 ms) : 1714, 1761
. : milestone, 1737,
appsec_no_iast (1.737 ms) : 1713, 1761
. : milestone, 1737,
code_origins (1.693 ms) : 1666, 1721
. : milestone, 1693,
iast (1.514 ms) : 1489, 1539
. : milestone, 1514,
profiling (1.516 ms) : 1493, 1540
. : milestone, 1516,
tracing (1.508 ms) : 1484, 1532
. : milestone, 1508,
section candidate
no_agent (1.368 ms) : 1348, 1388
. : milestone, 1368,
appsec (1.751 ms) : 1728, 1774
. : milestone, 1751,
appsec_no_iast (1.753 ms) : 1730, 1776
. : milestone, 1753,
code_origins (1.681 ms) : 1654, 1708
. : milestone, 1681,
iast (1.528 ms) : 1504, 1552
. : milestone, 1528,
profiling (1.521 ms) : 1498, 1543
. : milestone, 1521,
tracing (1.499 ms) : 1474, 1524
. : milestone, 1499,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~3dc654bbfc, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (385.003 µs) : 365, 405
. : milestone, 385,
iast (539.967 µs) : 517, 563
. : milestone, 540,
iast_FULL (737.91 µs) : 716, 760
. : milestone, 738,
iast_GLOBAL (561.112 µs) : 539, 583
. : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (523.395 µs) : 502, 545
. : milestone, 523,
iast_INACTIVE (470.193 µs) : 448, 493
. : milestone, 470,
iast_TELEMETRY_OFF (510.947 µs) : 487, 534
. : milestone, 511,
tracing (457.956 µs) : 436, 480
. : milestone, 458,
section candidate
no_agent (387.522 µs) : 368, 407
. : milestone, 388,
iast (518.735 µs) : 497, 540
. : milestone, 519,
iast_FULL (743.546 µs) : 721, 766
. : milestone, 744,
iast_GLOBAL (562.316 µs) : 540, 584
. : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (520.831 µs) : 498, 544
. : milestone, 521,
iast_INACTIVE (468.302 µs) : 446, 490
. : milestone, 468,
iast_TELEMETRY_OFF (508.479 µs) : 485, 532
. : milestone, 508,
tracing (464.119 µs) : 442, 486
. : milestone, 464,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~3dc654bbfc, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (2.42 ms) : 2371, 2469
. : milestone, 2420,
iast (2.19 ms) : 2128, 2251
. : milestone, 2190,
iast_GLOBAL (2.234 ms) : 2171, 2296
. : milestone, 2234,
profiling (2.057 ms) : 2006, 2107
. : milestone, 2057,
tracing (2.015 ms) : 1967, 2063
. : milestone, 2015,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (2.41 ms) : 2361, 2459
. : milestone, 2410,
iast (2.202 ms) : 2140, 2263
. : milestone, 2202,
iast_GLOBAL (2.239 ms) : 2177, 2301
. : milestone, 2239,
profiling (2.045 ms) : 1994, 2095
. : milestone, 2045,
tracing (2.012 ms) : 1965, 2059
. : milestone, 2012,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~3dc654bbfc, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (15.453 s) : 15453000, 15453000
. : milestone, 15453000,
appsec (15.1 s) : 15100000, 15100000
. : milestone, 15100000,
iast (18.193 s) : 18193000, 18193000
. : milestone, 18193000,
iast_GLOBAL (18.079 s) : 18079000, 18079000
. : milestone, 18079000,
profiling (15.266 s) : 15266000, 15266000
. : milestone, 15266000,
tracing (14.977 s) : 14977000, 14977000
. : milestone, 14977000,
section candidate
no_agent (15.248 s) : 15248000, 15248000
. : milestone, 15248000,
appsec (15.078 s) : 15078000, 15078000
. : milestone, 15078000,
iast (18.796 s) : 18796000, 18796000
. : milestone, 18796000,
iast_GLOBAL (18.354 s) : 18354000, 18354000
. : milestone, 18354000,
profiling (15.098 s) : 15098000, 15098000
. : milestone, 15098000,
tracing (15.022 s) : 15022000, 15022000
. : milestone, 15022000,
|
What Does This Do
Send bootstrap telemetry from separate thread.
Motivation
Reduce start-up latency
Additional Notes
Change already covered by existing tests.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]