Disable some static analysis rules #8593

smola · 2025-03-20T09:15:19Z

What Does This Do

Disable missing-switch-statement-default and call-super-in-constructor. Both conflict with common practices in this project.

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-03-20T09:54:09Z

Benchmarks

Startup

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-03-20T09:27:49	2025-03-20T09:35:31
git_branch	master	smola/static-analysis-rule-updates
git_commit_date	1742419098	1742462078
git_commit_sha	`727c7c7`	`d0400b9`
release_version	1.48.0-SNAPSHOT~727c7c738f	1.48.0-SNAPSHOT~d0400b9b7f
start_time	2025-03-20T09:27:35	2025-03-20T09:35:17

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1742463726	1742463726
ci_job_id	856452262	856452262
ci_pipeline_id	59421560	59421560
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-yaepk1w-project-304-concurrent-1-dqd59w6o 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-yaepk1w-project-304-concurrent-1-dqd59w6o 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~d0400b9b7f, baseline=1.48.0-SNAPSHOT~727c7c738f
    dateFormat X
    axisFormat %s
section baseline
no_agent (388.885 µs) : 369, 409
.   : milestone, 389,
iast (508.896 µs) : 487, 531
.   : milestone, 509,
iast_FULL (725.81 µs) : 704, 748
.   : milestone, 726,
iast_GLOBAL (552.3 µs) : 531, 574
.   : milestone, 552,
iast_HARDCODED_SECRET_DISABLED (508.992 µs) : 487, 531
.   : milestone, 509,
iast_INACTIVE (460.054 µs) : 439, 481
.   : milestone, 460,
iast_TELEMETRY_OFF (495.596 µs) : 474, 517
.   : milestone, 496,
tracing (463.097 µs) : 442, 485
.   : milestone, 463,
section candidate
no_agent (372.299 µs) : 353, 392
.   : milestone, 372,
iast (506.626 µs) : 485, 529
.   : milestone, 507,
iast_FULL (728.725 µs) : 707, 751
.   : milestone, 729,
iast_GLOBAL (549.232 µs) : 528, 571
.   : milestone, 549,
iast_HARDCODED_SECRET_DISABLED (511.154 µs) : 489, 533
.   : milestone, 511,
iast_INACTIVE (455.245 µs) : 434, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (504.969 µs) : 483, 527
.   : milestone, 505,
tracing (459.763 µs) : 438, 481
.   : milestone, 460,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	388.885 µs [369.023 µs, 408.748 µs]	-
iast	508.896 µs [486.868 µs, 530.925 µs]	120.011 µs (30.9%)
iast_FULL	725.81 µs [703.839 µs, 747.78 µs]	336.924 µs (86.6%)
iast_GLOBAL	552.3 µs [530.619 µs, 573.982 µs]	163.415 µs (42.0%)
iast_HARDCODED_SECRET_DISABLED	508.992 µs [487.407 µs, 530.576 µs]	120.106 µs (30.9%)
iast_INACTIVE	460.054 µs [438.704 µs, 481.404 µs]	71.169 µs (18.3%)
iast_TELEMETRY_OFF	495.596 µs [473.754 µs, 517.438 µs]	106.711 µs (27.4%)
tracing	463.097 µs [441.632 µs, 484.562 µs]	74.211 µs (19.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	372.299 µs [352.532 µs, 392.066 µs]	-
iast	506.626 µs [484.668 µs, 528.583 µs]	134.326 µs (36.1%)
iast_FULL	728.725 µs [706.805 µs, 750.645 µs]	356.426 µs (95.7%)
iast_GLOBAL	549.232 µs [527.688 µs, 570.776 µs]	176.933 µs (47.5%)
iast_HARDCODED_SECRET_DISABLED	511.154 µs [489.141 µs, 533.166 µs]	138.855 µs (37.3%)
iast_INACTIVE	455.245 µs [434.268 µs, 476.223 µs]	82.946 µs (22.3%)
iast_TELEMETRY_OFF	504.969 µs [482.905 µs, 527.033 µs]	132.67 µs (35.6%)
tracing	459.763 µs [438.134 µs, 481.392 µs]	87.464 µs (23.5%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~d0400b9b7f, baseline=1.48.0-SNAPSHOT~727c7c738f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.334 ms) : 1314, 1354
.   : milestone, 1334,
appsec (1.729 ms) : 1707, 1752
.   : milestone, 1729,
appsec_no_iast (1.738 ms) : 1714, 1762
.   : milestone, 1738,
code_origins (1.676 ms) : 1649, 1703
.   : milestone, 1676,
iast (1.512 ms) : 1488, 1536
.   : milestone, 1512,
profiling (1.516 ms) : 1493, 1540
.   : milestone, 1516,
tracing (1.481 ms) : 1456, 1506
.   : milestone, 1481,
section candidate
no_agent (1.367 ms) : 1348, 1387
.   : milestone, 1367,
appsec (1.73 ms) : 1706, 1754
.   : milestone, 1730,
appsec_no_iast (1.746 ms) : 1722, 1770
.   : milestone, 1746,
code_origins (1.67 ms) : 1644, 1696
.   : milestone, 1670,
iast (1.51 ms) : 1486, 1534
.   : milestone, 1510,
profiling (1.5 ms) : 1476, 1523
.   : milestone, 1500,
tracing (1.475 ms) : 1450, 1500
.   : milestone, 1475,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.334 ms [1.314 ms, 1.354 ms]	-
appsec	1.729 ms [1.707 ms, 1.752 ms]	394.966 µs (29.6%)
appsec_no_iast	1.738 ms [1.714 ms, 1.762 ms]	403.793 µs (30.3%)
code_origins	1.676 ms [1.649 ms, 1.703 ms]	341.253 µs (25.6%)
iast	1.512 ms [1.488 ms, 1.536 ms]	177.72 µs (13.3%)
profiling	1.516 ms [1.493 ms, 1.54 ms]	182.011 µs (13.6%)
tracing	1.481 ms [1.456 ms, 1.506 ms]	146.824 µs (11.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.367 ms [1.348 ms, 1.387 ms]	-
appsec	1.73 ms [1.706 ms, 1.754 ms]	362.885 µs (26.5%)
appsec_no_iast	1.746 ms [1.722 ms, 1.77 ms]	378.997 µs (27.7%)
code_origins	1.67 ms [1.644 ms, 1.696 ms]	302.715 µs (22.1%)
iast	1.51 ms [1.486 ms, 1.534 ms]	142.967 µs (10.5%)
profiling	1.5 ms [1.476 ms, 1.523 ms]	132.474 µs (9.7%)
tracing	1.475 ms [1.45 ms, 1.5 ms]	107.539 µs (7.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	smola/static-analysis-rule-updates
git_commit_date	1742419098	1742462078
git_commit_sha	`727c7c7`	`d0400b9`
release_version	1.48.0-SNAPSHOT~727c7c738f	1.48.0-SNAPSHOT~d0400b9b7f

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1742464265	1742464265
ci_job_id	856452263	856452263
ci_pipeline_id	59421560	59421560
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-yaepk1w-project-304-concurrent-2-utl9kcvz 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-yaepk1w-project-304-concurrent-2-utl9kcvz 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~d0400b9b7f, baseline=1.48.0-SNAPSHOT~727c7c738f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
.   : milestone, 1476,
appsec (2.354 ms) : 2310, 2398
.   : milestone, 2354,
iast (2.137 ms) : 2081, 2193
.   : milestone, 2137,
iast_GLOBAL (2.179 ms) : 2123, 2236
.   : milestone, 2179,
profiling (1.998 ms) : 1953, 2042
.   : milestone, 1998,
tracing (1.95 ms) : 1908, 1993
.   : milestone, 1950,
section candidate
no_agent (1.478 ms) : 1466, 1490
.   : milestone, 1478,
appsec (2.356 ms) : 2312, 2400
.   : milestone, 2356,
iast (2.144 ms) : 2088, 2200
.   : milestone, 2144,
iast_GLOBAL (2.175 ms) : 2118, 2232
.   : milestone, 2175,
profiling (1.998 ms) : 1953, 2043
.   : milestone, 1998,
tracing (1.971 ms) : 1928, 2013
.   : milestone, 1971,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.465 ms, 1.488 ms]	-
appsec	2.354 ms [2.31 ms, 2.398 ms]	877.979 µs (59.5%)
iast	2.137 ms [2.081 ms, 2.193 ms]	660.454 µs (44.7%)
iast_GLOBAL	2.179 ms [2.123 ms, 2.236 ms]	702.927 µs (47.6%)
profiling	1.998 ms [1.953 ms, 2.042 ms]	521.037 µs (35.3%)
tracing	1.95 ms [1.908 ms, 1.993 ms]	473.719 µs (32.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.478 ms [1.466 ms, 1.49 ms]	-
appsec	2.356 ms [2.312 ms, 2.4 ms]	878.03 µs (59.4%)
iast	2.144 ms [2.088 ms, 2.2 ms]	665.748 µs (45.0%)
iast_GLOBAL	2.175 ms [2.118 ms, 2.232 ms]	696.866 µs (47.1%)
profiling	1.998 ms [1.953 ms, 2.043 ms]	519.687 µs (35.2%)
tracing	1.971 ms [1.928 ms, 2.013 ms]	492.485 µs (33.3%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~d0400b9b7f, baseline=1.48.0-SNAPSHOT~727c7c738f
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.971 s) : 14971000, 14971000
.   : milestone, 14971000,
appsec (14.802 s) : 14802000, 14802000
.   : milestone, 14802000,
iast (19.032 s) : 19032000, 19032000
.   : milestone, 19032000,
iast_GLOBAL (18.137 s) : 18137000, 18137000
.   : milestone, 18137000,
profiling (15.397 s) : 15397000, 15397000
.   : milestone, 15397000,
tracing (14.765 s) : 14765000, 14765000
.   : milestone, 14765000,
section candidate
no_agent (14.718 s) : 14718000, 14718000
.   : milestone, 14718000,
appsec (14.996 s) : 14996000, 14996000
.   : milestone, 14996000,
iast (19.109 s) : 19109000, 19109000
.   : milestone, 19109000,
iast_GLOBAL (17.985 s) : 17985000, 17985000
.   : milestone, 17985000,
profiling (15.733 s) : 15733000, 15733000
.   : milestone, 15733000,
tracing (15.055 s) : 15055000, 15055000
.   : milestone, 15055000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.971 s [14.971 s, 14.971 s]	-
appsec	14.802 s [14.802 s, 14.802 s]	-169.0 ms (-1.1%)
iast	19.032 s [19.032 s, 19.032 s]	4.061 s (27.1%)
iast_GLOBAL	18.137 s [18.137 s, 18.137 s]	3.166 s (21.1%)
profiling	15.397 s [15.397 s, 15.397 s]	426.0 ms (2.8%)
tracing	14.765 s [14.765 s, 14.765 s]	-206.0 ms (-1.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.718 s [14.718 s, 14.718 s]	-
appsec	14.996 s [14.996 s, 14.996 s]	278.0 ms (1.9%)
iast	19.109 s [19.109 s, 19.109 s]	4.391 s (29.8%)
iast_GLOBAL	17.985 s [17.985 s, 17.985 s]	3.267 s (22.2%)
profiling	15.733 s [15.733 s, 15.733 s]	1.015 s (6.9%)
tracing	15.055 s [15.055 s, 15.055 s]	337.0 ms (2.3%)

mcculls

thanks!

Disable some static analysis rules

d0400b9

smola added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Mar 20, 2025

smola requested a review from a team as a code owner March 20, 2025 09:15

smola requested a review from mcculls March 20, 2025 09:15

mcculls approved these changes Mar 20, 2025

View reviewed changes

smola merged commit 9c4ccdf into master Mar 20, 2025
273 of 274 checks passed

smola deleted the smola/static-analysis-rule-updates branch March 20, 2025 11:10

github-actions bot added this to the 1.48.0 milestone Mar 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Disable some static analysis rules #8593

Disable some static analysis rules #8593

Uh oh!

smola commented Mar 20, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Mar 20, 2025

Uh oh!

mcculls left a comment

Uh oh!

Uh oh!

Uh oh!

Disable some static analysis rules #8593

Disable some static analysis rules #8593

Uh oh!

Conversation

smola commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented Mar 20, 2025

Benchmarks

Startup

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

mcculls left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

smola commented Mar 20, 2025 •

edited

Loading