-
Notifications
You must be signed in to change notification settings - Fork 318
Add vertx postgresql client instrumentation #8457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vertx postgresql client instrumentation #8457
Conversation
|
@PerfectSlayer @gary-huang can you please help me identify why the checks are failing?? |
|
Hello @onkar-dream11 👋 First, thanks for you contribution. |
vandonr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok, but most of the code has been duplicated compared to the existing mysql integration. I think it'd be better to have only the Pg* classes in this package, do the same for mysql, and put the common code in a vertex-sql-common to avoid that.
I can let you do it, or I can take your commits in a branch I own and do it if you prefer.
dd-java-agent/instrumentation/vertx-pg-client-4.2.0/build.gradle
Outdated
Show resolved
Hide resolved
dd-java-agent/instrumentation/vertx-pg-client-4.2.0/build.gradle
Outdated
Show resolved
Hide resolved
|
@vandonr I have resolved the given comments, and regarding common code I thought of it having in |
|
TIL I can push to a branch on a fork |
|
OK I think I may need to push on my own branch anyway for the CI to run properly |
|
closing in favor of #8471 |
What Does This Do
This PR adds support for automatic tracing of PostgreSQL queries when using the Vert.x PostgreSQL Client in a Vert.x 4 application, enabling Datadog APM to capture query execution times and database interactions.
Motivation
Datadog APM currently doesn't automatically trace PostgreSQL queries executed via the Vert.x PostgreSQL Client, leading to a lack of visibility into database operations. This fix addresses that gap.
Additional Notes
The PR ensures that PostgreSQL queries are automatically instrumented and visible in Datadog APM.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]