Skip to content

Add stacktraces on httpurlconnection requests #8325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add stacktraces on httpurlconnection requests #8325

wants to merge 3 commits into from

Conversation

nayeem-kamal
Copy link
Contributor

@nayeem-kamal nayeem-kamal commented Feb 3, 2025 •
edited by jira bot
Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Jira ticket: APMS-14172

@pr-commenter
Copy link

pr-commenter bot commented Feb 3, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nayeem-kamal/boomi-fix
git_commit_date 1749044153 1749138981
git_commit_sha 7787af7 b79e9dd
release_version 1.50.0-SNAPSHOT~7787af738f 1.50.0-SNAPSHOT~b79e9dd64b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1749141941 1749141941
ci_job_id 970352967 970352967
ci_pipeline_id 67086073 67086073
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-ul4n-y4k-project-304-concurrent-2-k3s57c9q 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-ul4n-y4k-project-304-concurrent-2-k3s57c9q 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~b79e9dd64b, baseline=1.50.0-SNAPSHOT~7787af738f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.028 s) : 0, 1028165
Total [baseline] (11.117 s) : 0, 11117182
Agent [candidate] (1.023 s) : 0, 1023158
Total [candidate] (11.151 s) : 0, 11150613
section appsec
Agent [baseline] (1.166 s) : 0, 1166158
Total [baseline] (11.231 s) : 0, 11230643
Agent [candidate] (1.161 s) : 0, 1160993
Total [candidate] (11.197 s) : 0, 11196631
section iast
Agent [baseline] (1.151 s) : 0, 1150554
Total [baseline] (11.389 s) : 0, 11388750
Agent [candidate] (1.149 s) : 0, 1149116
Total [candidate] (11.328 s) : 0, 11328355
section profiling
Agent [baseline] (1.269 s) : 0, 1268501
Total [baseline] (11.506 s) : 0, 11505652
Agent [candidate] (1.277 s) : 0, 1277267
Total [candidate] (11.594 s) : 0, 11594099
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.028 s -
Agent appsec 1.166 s 137.993 ms (13.4%)
Agent iast 1.151 s 122.389 ms (11.9%)
Agent profiling 1.269 s 240.336 ms (23.4%)
Total tracing 11.117 s -
Total appsec 11.231 s 113.461 ms (1.0%)
Total iast 11.389 s 271.568 ms (2.4%)
Total profiling 11.506 s 388.47 ms (3.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.023 s -
Agent appsec 1.161 s 137.835 ms (13.5%)
Agent iast 1.149 s 125.958 ms (12.3%)
Agent profiling 1.277 s 254.109 ms (24.8%)
Total tracing 11.151 s -
Total appsec 11.197 s 46.018 ms (0.4%)
Total iast 11.328 s 177.742 ms (1.6%)
Total profiling 11.594 s 443.486 ms (4.0%) 
gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~b79e9dd64b, baseline=1.50.0-SNAPSHOT~7787af738f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.853 ms) : 0, 686853
BytebuddyAgent [candidate] (683.326 ms) : 0, 683326
GlobalTracer [baseline] (241.043 ms) : 0, 241043
GlobalTracer [candidate] (240.492 ms) : 0, 240492
AppSec [baseline] (55.127 ms) : 0, 55127
AppSec [candidate] (58.316 ms) : 0, 58316
Debugger [baseline] (6.296 ms) : 0, 6296
Debugger [candidate] (6.112 ms) : 0, 6112
Remote Config [baseline] (741.11 µs) : 0, 741
Remote Config [candidate] (723.195 µs) : 0, 723
Telemetry [baseline] (14.309 ms) : 0, 14309
Telemetry [candidate] (10.524 ms) : 0, 10524
section appsec
BytebuddyAgent [baseline] (702.722 ms) : 0, 702722
BytebuddyAgent [candidate] (699.086 ms) : 0, 699086
GlobalTracer [baseline] (238.28 ms) : 0, 238280
GlobalTracer [candidate] (236.918 ms) : 0, 236918
AppSec [baseline] (176.682 ms) : 0, 176682
AppSec [candidate] (176.557 ms) : 0, 176557
Debugger [baseline] (5.969 ms) : 0, 5969
Debugger [candidate] (6.002 ms) : 0, 6002
Remote Config [baseline] (620.61 µs) : 0, 621
Remote Config [candidate] (632.591 µs) : 0, 633
Telemetry [baseline] (7.312 ms) : 0, 7312
Telemetry [candidate] (7.381 ms) : 0, 7381
IAST [baseline] (21.945 ms) : 0, 21945
IAST [candidate] (21.752 ms) : 0, 21752
section iast
BytebuddyAgent [baseline] (801.917 ms) : 0, 801917
BytebuddyAgent [candidate] (801.178 ms) : 0, 801178
GlobalTracer [baseline] (231.095 ms) : 0, 231095
GlobalTracer [candidate] (230.366 ms) : 0, 230366
AppSec [baseline] (52.012 ms) : 0, 52012
AppSec [candidate] (52.044 ms) : 0, 52044
Debugger [baseline] (5.944 ms) : 0, 5944
Debugger [candidate] (5.902 ms) : 0, 5902
Remote Config [baseline] (608.327 µs) : 0, 608
Remote Config [candidate] (593.275 µs) : 0, 593
Telemetry [baseline] (7.973 ms) : 0, 7973
Telemetry [candidate] (7.927 ms) : 0, 7927
IAST [baseline] (27.483 ms) : 0, 27483
IAST [candidate] (27.556 ms) : 0, 27556
section profiling
BytebuddyAgent [baseline] (675.321 ms) : 0, 675321
BytebuddyAgent [candidate] (678.779 ms) : 0, 678779
GlobalTracer [baseline] (361.287 ms) : 0, 361287
GlobalTracer [candidate] (364.116 ms) : 0, 364116
AppSec [baseline] (61.789 ms) : 0, 61789
AppSec [candidate] (62.598 ms) : 0, 62598
Debugger [baseline] (6.112 ms) : 0, 6112
Debugger [candidate] (6.2 ms) : 0, 6200
Remote Config [baseline] (664.519 µs) : 0, 665
Remote Config [candidate] (652.107 µs) : 0, 652
Telemetry [baseline] (8.147 ms) : 0, 8147
Telemetry [candidate] (8.316 ms) : 0, 8316
ProfilingAgent [baseline] (104.378 ms) : 0, 104378
ProfilingAgent [candidate] (105.731 ms) : 0, 105731
Profiling [baseline] (104.402 ms) : 0, 104402
Profiling [candidate] (105.755 ms) : 0, 105755
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~b79e9dd64b, baseline=1.50.0-SNAPSHOT~7787af738f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1020890
Total [baseline] (8.493 s) : 0, 8493470
Agent [candidate] (1.024 s) : 0, 1024091
Total [candidate] (8.5 s) : 0, 8500460
section iast
Agent [baseline] (1.152 s) : 0, 1151711
Total [baseline] (9.218 s) : 0, 9217547
Agent [candidate] (1.15 s) : 0, 1149958
Total [candidate] (9.171 s) : 0, 9170556
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.148 s) : 0, 1148437
Total [baseline] (9.151 s) : 0, 9150817
Agent [candidate] (1.152 s) : 0, 1152362
Total [candidate] (9.163 s) : 0, 9162759
section iast_TELEMETRY_OFF
Agent [baseline] (1.154 s) : 0, 1153984
Total [baseline] (9.242 s) : 0, 9241980
Agent [candidate] (1.157 s) : 0, 1157365
Total [candidate] (9.267 s) : 0, 9266848
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.021 s -
Agent iast 1.152 s 130.821 ms (12.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.148 s 127.547 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.154 s 133.094 ms (13.0%)
Total tracing 8.493 s -
Total iast 9.218 s 724.077 ms (8.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.151 s 657.347 ms (7.7%)
Total iast_TELEMETRY_OFF 9.242 s 748.509 ms (8.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.024 s -
Agent iast 1.15 s 125.868 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.152 s 128.271 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.157 s 133.274 ms (13.0%)
Total tracing 8.5 s -
Total iast 9.171 s 670.097 ms (7.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.163 s 662.299 ms (7.8%)
Total iast_TELEMETRY_OFF 9.267 s 766.389 ms (9.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~b79e9dd64b, baseline=1.50.0-SNAPSHOT~7787af738f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.116 ms) : 0, 683116
BytebuddyAgent [candidate] (682.665 ms) : 0, 682665
GlobalTracer [baseline] (239.776 ms) : 0, 239776
GlobalTracer [candidate] (240.344 ms) : 0, 240344
AppSec [baseline] (56.995 ms) : 0, 56995
AppSec [candidate] (57.836 ms) : 0, 57836
Debugger [baseline] (6.178 ms) : 0, 6178
Debugger [candidate] (6.164 ms) : 0, 6164
Remote Config [baseline] (730.349 µs) : 0, 730
Remote Config [candidate] (731.629 µs) : 0, 732
Telemetry [baseline] (10.565 ms) : 0, 10565
Telemetry [candidate] (12.848 ms) : 0, 12848
section iast
BytebuddyAgent [baseline] (803.066 ms) : 0, 803066
BytebuddyAgent [candidate] (802.018 ms) : 0, 802018
GlobalTracer [baseline] (231.071 ms) : 0, 231071
GlobalTracer [candidate] (230.718 ms) : 0, 230718
IAST [baseline] (25.533 ms) : 0, 25533
IAST [candidate] (26.882 ms) : 0, 26882
AppSec [baseline] (54.17 ms) : 0, 54170
AppSec [candidate] (52.402 ms) : 0, 52402
Debugger [baseline] (5.911 ms) : 0, 5911
Debugger [candidate] (5.973 ms) : 0, 5973
Remote Config [baseline] (587.103 µs) : 0, 587
Remote Config [candidate] (595.681 µs) : 0, 596
Telemetry [baseline] (7.852 ms) : 0, 7852
Telemetry [candidate] (7.843 ms) : 0, 7843
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.66 ms) : 0, 800660
BytebuddyAgent [candidate] (802.797 ms) : 0, 802797
GlobalTracer [baseline] (230.169 ms) : 0, 230169
GlobalTracer [candidate] (231.781 ms) : 0, 231781
IAST [baseline] (25.539 ms) : 0, 25539
IAST [candidate] (26.457 ms) : 0, 26457
AppSec [baseline] (54.052 ms) : 0, 54052
AppSec [candidate] (53.113 ms) : 0, 53113
Debugger [baseline] (5.959 ms) : 0, 5959
Debugger [candidate] (6.029 ms) : 0, 6029
Remote Config [baseline] (598.004 µs) : 0, 598
Remote Config [candidate] (593.955 µs) : 0, 594
Telemetry [baseline] (7.95 ms) : 0, 7950
Telemetry [candidate] (7.98 ms) : 0, 7980
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (803.922 ms) : 0, 803922
BytebuddyAgent [candidate] (804.953 ms) : 0, 804953
GlobalTracer [baseline] (232.274 ms) : 0, 232274
GlobalTracer [candidate] (233.553 ms) : 0, 233553
IAST [baseline] (27.394 ms) : 0, 27394
IAST [candidate] (28.719 ms) : 0, 28719
AppSec [baseline] (52.291 ms) : 0, 52291
AppSec [candidate] (51.804 ms) : 0, 51804
Debugger [baseline] (5.969 ms) : 0, 5969
Debugger [candidate] (6.113 ms) : 0, 6113
Remote Config [baseline] (606.481 µs) : 0, 606
Remote Config [candidate] (604.181 µs) : 0, 604
Telemetry [baseline] (7.912 ms) : 0, 7912
Telemetry [candidate] (7.954 ms) : 0, 7954
Loading

Load

Dacapo

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 1, 2025

This pull request has been marked as stale because it has not had activity over the past quarter. It will be closed in 7 days if no further activity occurs. Feel free to reopen the PR if you are still working on it.

@github-actions github-actions bot added the tag: stale Stale pull requests label Jun 1, 2025
@jordan-wong jordan-wong added inst: java Core Java language instrumentation and removed tag: stale Stale pull requests labels Jun 5, 2025
@jordan-wong jordan-wong marked this pull request as ready for review June 5, 2025 17:37
@jordan-wong jordan-wong requested review from a team as code owners June 5, 2025 17:37
@jordan-wong jordan-wong requested a review from dougqh June 5, 2025 17:37
nayeem-kamal
nayeem-kamal commented Jun 5, 2025
View reviewed changes
dd-java-agent/testing/src/main/groovy/datadog/trace/agent/test/base/HttpClientTest.groovy
@@ -314,6 +315,7 @@ abstract class HttpClientTest extends VersionedNamingTestBase {
}

@Flaky(suites = ["ApacheHttpAsyncClient5Test"])
@IgnoreIf({true})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These ignores need to be resolved before this is ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
inst: java Core Java language instrumentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nayeem-kamal @jordan-wong