-
Notifications
You must be signed in to change notification settings - Fork 311
Clean up internal API excluded classes from coverage #8305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort by name Remove deleted / moved classes
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~12679c7a4e, baseline=1.46.0-SNAPSHOT~81a92e778d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.039 s) : 0, 1039479
Total [baseline] (10.436 s) : 0, 10436288
Agent [candidate] (1.047 s) : 0, 1047380
Total [candidate] (10.5 s) : 0, 10500468
section appsec
Agent [baseline] (1.186 s) : 0, 1186249
Total [baseline] (10.782 s) : 0, 10781971
Agent [candidate] (1.181 s) : 0, 1181438
Total [candidate] (10.75 s) : 0, 10750054
section iast
Agent [baseline] (1.178 s) : 0, 1177757
Total [baseline] (10.995 s) : 0, 10995479
Agent [candidate] (1.169 s) : 0, 1169478
Total [candidate] (11.021 s) : 0, 11020559
section profiling
Agent [baseline] (1.256 s) : 0, 1256279
Total [baseline] (10.83 s) : 0, 10830161
Agent [candidate] (1.265 s) : 0, 1265330
Total [candidate] (10.849 s) : 0, 10849359
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~12679c7a4e, baseline=1.46.0-SNAPSHOT~81a92e778d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.55 ms) : 0, 716550
BytebuddyAgent [candidate] (721.294 ms) : 0, 721294
GlobalTracer [baseline] (239.183 ms) : 0, 239183
GlobalTracer [candidate] (242.045 ms) : 0, 242045
AppSec [baseline] (56.392 ms) : 0, 56392
AppSec [candidate] (55.739 ms) : 0, 55739
Remote Config [baseline] (720.322 µs) : 0, 720
Remote Config [candidate] (716.744 µs) : 0, 717
Telemetry [baseline] (11.355 ms) : 0, 11355
Telemetry [candidate] (12.219 ms) : 0, 12219
section appsec
BytebuddyAgent [baseline] (735.172 ms) : 0, 735172
BytebuddyAgent [candidate] (732.252 ms) : 0, 732252
GlobalTracer [baseline] (239.152 ms) : 0, 239152
GlobalTracer [candidate] (237.736 ms) : 0, 237736
AppSec [baseline] (176.735 ms) : 0, 176735
AppSec [candidate] (176.067 ms) : 0, 176067
Remote Config [baseline] (658.242 µs) : 0, 658
Remote Config [candidate] (645.559 µs) : 0, 646
Telemetry [baseline] (8.344 ms) : 0, 8344
Telemetry [candidate] (8.649 ms) : 0, 8649
IAST [baseline] (21.734 ms) : 0, 21734
IAST [candidate] (21.549 ms) : 0, 21549
section iast
BytebuddyAgent [baseline] (840.57 ms) : 0, 840570
BytebuddyAgent [candidate] (833.576 ms) : 0, 833576
GlobalTracer [baseline] (231.96 ms) : 0, 231960
GlobalTracer [candidate] (231.282 ms) : 0, 231282
AppSec [baseline] (55.9 ms) : 0, 55900
AppSec [candidate] (55.525 ms) : 0, 55525
Remote Config [baseline] (636.465 µs) : 0, 636
Remote Config [candidate] (614.003 µs) : 0, 614
Telemetry [baseline] (8.783 ms) : 0, 8783
Telemetry [candidate] (8.879 ms) : 0, 8879
IAST [baseline] (24.478 ms) : 0, 24478
IAST [candidate] (24.312 ms) : 0, 24312
section profiling
BytebuddyAgent [baseline] (704.481 ms) : 0, 704481
BytebuddyAgent [candidate] (709.204 ms) : 0, 709204
GlobalTracer [baseline] (350.174 ms) : 0, 350174
GlobalTracer [candidate] (353.002 ms) : 0, 353002
AppSec [baseline] (54.912 ms) : 0, 54912
AppSec [candidate] (54.635 ms) : 0, 54635
Remote Config [baseline] (702.15 µs) : 0, 702
Remote Config [candidate] (714.225 µs) : 0, 714
Telemetry [baseline] (8.791 ms) : 0, 8791
Telemetry [candidate] (8.905 ms) : 0, 8905
ProfilingAgent [baseline] (95.059 ms) : 0, 95059
ProfilingAgent [candidate] (96.268 ms) : 0, 96268
Profiling [baseline] (95.083 ms) : 0, 95083
Profiling [candidate] (96.292 ms) : 0, 96292
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~12679c7a4e, baseline=1.46.0-SNAPSHOT~81a92e778d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1041965
Total [baseline] (8.628 s) : 0, 8627850
Agent [candidate] (1.043 s) : 0, 1043470
Total [candidate] (8.619 s) : 0, 8618682
section iast
Agent [baseline] (1.175 s) : 0, 1174546
Total [baseline] (9.228 s) : 0, 9227578
Agent [candidate] (1.181 s) : 0, 1180905
Total [candidate] (9.251 s) : 0, 9251267
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.169 s) : 0, 1168966
Total [baseline] (9.204 s) : 0, 9203819
Agent [candidate] (1.172 s) : 0, 1171590
Total [candidate] (9.228 s) : 0, 9227538
section iast_TELEMETRY_OFF
Agent [baseline] (1.163 s) : 0, 1163437
Total [baseline] (9.222 s) : 0, 9222122
Agent [candidate] (1.166 s) : 0, 1165868
Total [candidate] (9.268 s) : 0, 9267851
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~12679c7a4e, baseline=1.46.0-SNAPSHOT~81a92e778d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.469 ms) : 0, 717469
BytebuddyAgent [candidate] (717.266 ms) : 0, 717266
GlobalTracer [baseline] (240.129 ms) : 0, 240129
GlobalTracer [candidate] (240.816 ms) : 0, 240816
AppSec [baseline] (55.549 ms) : 0, 55549
AppSec [candidate] (56.531 ms) : 0, 56531
Remote Config [baseline] (715.052 µs) : 0, 715
Remote Config [candidate] (717.929 µs) : 0, 718
Telemetry [baseline] (12.902 ms) : 0, 12902
Telemetry [candidate] (12.897 ms) : 0, 12897
section iast
BytebuddyAgent [baseline] (838.607 ms) : 0, 838607
BytebuddyAgent [candidate] (842.428 ms) : 0, 842428
GlobalTracer [baseline] (231.505 ms) : 0, 231505
GlobalTracer [candidate] (233.368 ms) : 0, 233368
IAST [baseline] (25.705 ms) : 0, 25705
IAST [candidate] (25.831 ms) : 0, 25831
AppSec [baseline] (54.148 ms) : 0, 54148
AppSec [candidate] (54.335 ms) : 0, 54335
Remote Config [baseline] (624.109 µs) : 0, 624
Remote Config [candidate] (623.839 µs) : 0, 624
Telemetry [baseline] (8.692 ms) : 0, 8692
Telemetry [candidate] (8.867 ms) : 0, 8867
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (834.266 ms) : 0, 834266
BytebuddyAgent [candidate] (837.088 ms) : 0, 837088
GlobalTracer [baseline] (230.357 ms) : 0, 230357
GlobalTracer [candidate] (230.504 ms) : 0, 230504
IAST [baseline] (25.729 ms) : 0, 25729
IAST [candidate] (28.969 ms) : 0, 28969
AppSec [baseline] (53.983 ms) : 0, 53983
AppSec [candidate] (50.408 ms) : 0, 50408
Remote Config [baseline] (623.817 µs) : 0, 624
Remote Config [candidate] (599.797 µs) : 0, 600
Telemetry [baseline] (8.771 ms) : 0, 8771
Telemetry [candidate] (8.619 ms) : 0, 8619
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (829.953 ms) : 0, 829953
BytebuddyAgent [candidate] (832.01 ms) : 0, 832010
GlobalTracer [baseline] (230.523 ms) : 0, 230523
GlobalTracer [candidate] (231.033 ms) : 0, 231033
IAST [baseline] (26.578 ms) : 0, 26578
IAST [candidate] (27.392 ms) : 0, 27392
AppSec [baseline] (52.058 ms) : 0, 52058
AppSec [candidate] (50.988 ms) : 0, 50988
Remote Config [baseline] (602.285 µs) : 0, 602
Remote Config [candidate] (615.809 µs) : 0, 616
Telemetry [baseline] (8.533 ms) : 0, 8533
Telemetry [candidate] (8.539 ms) : 0, 8539
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~12679c7a4e, baseline=1.46.0-SNAPSHOT~81a92e778d
dateFormat X
axisFormat %s
section baseline
no_agent (1.361 ms) : 1342, 1381
. : milestone, 1361,
appsec (1.757 ms) : 1733, 1781
. : milestone, 1757,
appsec_no_iast (1.768 ms) : 1745, 1790
. : milestone, 1768,
iast (1.505 ms) : 1480, 1529
. : milestone, 1505,
profiling (1.533 ms) : 1508, 1559
. : milestone, 1533,
tracing (1.488 ms) : 1463, 1513
. : milestone, 1488,
section candidate
no_agent (1.363 ms) : 1344, 1383
. : milestone, 1363,
appsec (1.736 ms) : 1712, 1760
. : milestone, 1736,
appsec_no_iast (1.764 ms) : 1740, 1789
. : milestone, 1764,
iast (1.507 ms) : 1483, 1532
. : milestone, 1507,
profiling (1.516 ms) : 1494, 1539
. : milestone, 1516,
tracing (1.505 ms) : 1481, 1530
. : milestone, 1505,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~12679c7a4e, baseline=1.46.0-SNAPSHOT~81a92e778d
dateFormat X
axisFormat %s
section baseline
no_agent (378.346 µs) : 358, 398
. : milestone, 378,
iast (511.718 µs) : 489, 535
. : milestone, 512,
iast_FULL (748.74 µs) : 725, 772
. : milestone, 749,
iast_GLOBAL (571.805 µs) : 547, 596
. : milestone, 572,
iast_HARDCODED_SECRET_DISABLED (520.392 µs) : 497, 544
. : milestone, 520,
iast_INACTIVE (465.774 µs) : 444, 487
. : milestone, 466,
iast_TELEMETRY_OFF (500.134 µs) : 477, 523
. : milestone, 500,
tracing (454.162 µs) : 433, 475
. : milestone, 454,
section candidate
no_agent (379.815 µs) : 360, 400
. : milestone, 380,
iast (510.789 µs) : 486, 535
. : milestone, 511,
iast_FULL (745.716 µs) : 722, 769
. : milestone, 746,
iast_GLOBAL (565.245 µs) : 544, 587
. : milestone, 565,
iast_HARDCODED_SECRET_DISABLED (512.661 µs) : 490, 536
. : milestone, 513,
iast_INACTIVE (465.332 µs) : 444, 487
. : milestone, 465,
iast_TELEMETRY_OFF (499.212 µs) : 476, 523
. : milestone, 499,
tracing (451.951 µs) : 431, 473
. : milestone, 452,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~12679c7a4e, baseline=1.46.0-SNAPSHOT~81a92e778d
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.359 ms) : 2316, 2403
. : milestone, 2359,
iast (2.105 ms) : 2050, 2160
. : milestone, 2105,
iast_GLOBAL (2.149 ms) : 2093, 2204
. : milestone, 2149,
profiling (1.956 ms) : 1912, 1999
. : milestone, 1956,
tracing (1.943 ms) : 1901, 1985
. : milestone, 1943,
section candidate
no_agent (1.462 ms) : 1451, 1473
. : milestone, 1462,
appsec (2.346 ms) : 2303, 2389
. : milestone, 2346,
iast (2.108 ms) : 2053, 2163
. : milestone, 2108,
iast_GLOBAL (2.144 ms) : 2089, 2199
. : milestone, 2144,
profiling (1.946 ms) : 1902, 1989
. : milestone, 1946,
tracing (1.944 ms) : 1901, 1986
. : milestone, 1944,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~12679c7a4e, baseline=1.46.0-SNAPSHOT~81a92e778d
dateFormat X
axisFormat %s
section baseline
no_agent (15.569 s) : 15569000, 15569000
. : milestone, 15569000,
appsec (15.105 s) : 15105000, 15105000
. : milestone, 15105000,
iast (18.733 s) : 18733000, 18733000
. : milestone, 18733000,
iast_GLOBAL (18.149 s) : 18149000, 18149000
. : milestone, 18149000,
profiling (15.044 s) : 15044000, 15044000
. : milestone, 15044000,
tracing (14.823 s) : 14823000, 14823000
. : milestone, 14823000,
section candidate
no_agent (15.476 s) : 15476000, 15476000
. : milestone, 15476000,
appsec (14.886 s) : 14886000, 14886000
. : milestone, 14886000,
iast (18.36 s) : 18360000, 18360000
. : milestone, 18360000,
iast_GLOBAL (17.585 s) : 17585000, 17585000
. : milestone, 17585000,
profiling (15.476 s) : 15476000, 15476000
. : milestone, 15476000,
tracing (14.916 s) : 14916000, 14916000
. : milestone, 14916000,
|
jpbempel
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: core
Tracer core
tag: no release notes
Changes to exclude from release notes
type: refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR cleans up excluded classes from coverage by removing moved / deleted classes and sorting by naming inside of each section.
Motivation
A bit of clean-up
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]