Skip to content

Do not set test framework version tag if the value is null #8295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 29, 2025
Merged

Do not set test framework version tag if the value is null #8295

merged 3 commits into from
Jan 29, 2025

Conversation

@nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Jan 28, 2025

What Does This Do

Fixes an issue introduced in #8252
test.framework_version tag should not be set on test spans if its value is null.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@nikita-tkachenko-datadog nikita-tkachenko-datadog added type: bug Bug report and fix tag: no release notes Changes to exclude from release notes comp: ci visibility Continuous Integration Visibility labels Jan 28, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jan 28, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/test-framework-version-null
git_commit_date 1738161747 1738163629
git_commit_sha a41d151 7c78663
release_version 1.46.0-SNAPSHOT~a41d1512de 1.46.0-SNAPSHOT~7c78663215
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1738166014 1738166014
ci_job_id 785638645 785638645
ci_pipeline_id 54329275 54329275
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-xcwqdre5-project-304-concurrent-1-5zega9zh 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-xcwqdre5-project-304-concurrent-1-5zega9zh 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~7c78663215, baseline=1.46.0-SNAPSHOT~a41d1512de

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.035 s) : 0, 1035472
Total [baseline] (10.38 s) : 0, 10379644
Agent [candidate] (1.044 s) : 0, 1043580
Total [candidate] (10.44 s) : 0, 10440012
section appsec
Agent [baseline] (1.177 s) : 0, 1177058
Total [baseline] (10.731 s) : 0, 10730972
Agent [candidate] (1.181 s) : 0, 1180769
Total [candidate] (10.716 s) : 0, 10715549
section iast
Agent [baseline] (1.164 s) : 0, 1163682
Total [baseline] (10.914 s) : 0, 10913739
Agent [candidate] (1.169 s) : 0, 1168929
Total [candidate] (10.956 s) : 0, 10956196
section profiling
Agent [baseline] (1.264 s) : 0, 1264229
Total [baseline] (10.86 s) : 0, 10860415
Agent [candidate] (1.255 s) : 0, 1255009
Total [candidate] (10.819 s) : 0, 10818979
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.035 s -
Agent appsec 1.177 s 141.585 ms (13.7%)
Agent iast 1.164 s 128.21 ms (12.4%)
Agent profiling 1.264 s 228.757 ms (22.1%)
Total tracing 10.38 s -
Total appsec 10.731 s 351.328 ms (3.4%)
Total iast 10.914 s 534.095 ms (5.1%)
Total profiling 10.86 s 480.771 ms (4.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.044 s -
Agent appsec 1.181 s 137.19 ms (13.1%)
Agent iast 1.169 s 125.349 ms (12.0%)
Agent profiling 1.255 s 211.43 ms (20.3%)
Total tracing 10.44 s -
Total appsec 10.716 s 275.538 ms (2.6%)
Total iast 10.956 s 516.184 ms (4.9%)
Total profiling 10.819 s 378.967 ms (3.6%) 
gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~7c78663215, baseline=1.46.0-SNAPSHOT~a41d1512de

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (712.802 ms) : 0, 712802
BytebuddyAgent [candidate] (719.158 ms) : 0, 719158
GlobalTracer [baseline] (239.153 ms) : 0, 239153
GlobalTracer [candidate] (240.751 ms) : 0, 240751
AppSec [baseline] (55.392 ms) : 0, 55392
AppSec [candidate] (56.032 ms) : 0, 56032
Remote Config [baseline] (711.01 µs) : 0, 711
Remote Config [candidate] (718.328 µs) : 0, 718
Telemetry [baseline] (12.304 ms) : 0, 12304
Telemetry [candidate] (11.628 ms) : 0, 11628
section appsec
BytebuddyAgent [baseline] (730.192 ms) : 0, 730192
BytebuddyAgent [candidate] (732.305 ms) : 0, 732305
GlobalTracer [baseline] (236.372 ms) : 0, 236372
GlobalTracer [candidate] (237.303 ms) : 0, 237303
IAST [baseline] (21.637 ms) : 0, 21637
IAST [candidate] (21.395 ms) : 0, 21395
AppSec [baseline] (175.579 ms) : 0, 175579
AppSec [candidate] (176.259 ms) : 0, 176259
Remote Config [baseline] (660.199 µs) : 0, 660
Remote Config [candidate] (648.908 µs) : 0, 649
Telemetry [baseline] (8.257 ms) : 0, 8257
Telemetry [candidate] (8.297 ms) : 0, 8297
section iast
BytebuddyAgent [baseline] (830.46 ms) : 0, 830460
BytebuddyAgent [candidate] (833.471 ms) : 0, 833471
GlobalTracer [baseline] (229.694 ms) : 0, 229694
GlobalTracer [candidate] (230.986 ms) : 0, 230986
IAST [baseline] (26.195 ms) : 0, 26195
IAST [candidate] (25.65 ms) : 0, 25650
AppSec [baseline] (52.805 ms) : 0, 52805
AppSec [candidate] (54.2 ms) : 0, 54200
Remote Config [baseline] (608.03 µs) : 0, 608
Remote Config [candidate] (620.198 µs) : 0, 620
Telemetry [baseline] (8.684 ms) : 0, 8684
Telemetry [candidate] (8.779 ms) : 0, 8779
section profiling
BytebuddyAgent [baseline] (709.106 ms) : 0, 709106
BytebuddyAgent [candidate] (704.176 ms) : 0, 704176
GlobalTracer [baseline] (351.619 ms) : 0, 351619
GlobalTracer [candidate] (349.536 ms) : 0, 349536
AppSec [baseline] (55.237 ms) : 0, 55237
AppSec [candidate] (54.012 ms) : 0, 54012
Remote Config [baseline] (696.237 µs) : 0, 696
Remote Config [candidate] (693.177 µs) : 0, 693
Telemetry [baseline] (8.944 ms) : 0, 8944
Telemetry [candidate] (8.882 ms) : 0, 8882
ProfilingAgent [baseline] (96.149 ms) : 0, 96149
ProfilingAgent [candidate] (95.41 ms) : 0, 95410
Profiling [baseline] (96.173 ms) : 0, 96173
Profiling [candidate] (95.434 ms) : 0, 95434
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~7c78663215, baseline=1.46.0-SNAPSHOT~a41d1512de

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.038 s) : 0, 1037621
Total [baseline] (8.603 s) : 0, 8602858
Agent [candidate] (1.037 s) : 0, 1037394
Total [candidate] (8.593 s) : 0, 8593148
section iast
Agent [baseline] (1.173 s) : 0, 1173010
Total [baseline] (9.234 s) : 0, 9233772
Agent [candidate] (1.173 s) : 0, 1172526
Total [candidate] (9.219 s) : 0, 9218962
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.183 s) : 0, 1183487
Total [baseline] (9.222 s) : 0, 9221771
Agent [candidate] (1.166 s) : 0, 1166351
Total [candidate] (9.164 s) : 0, 9163654
section iast_TELEMETRY_OFF
Agent [baseline] (1.162 s) : 0, 1162290
Total [baseline] (9.171 s) : 0, 9171344
Agent [candidate] (1.163 s) : 0, 1162955
Total [candidate] (9.202 s) : 0, 9202189
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.038 s -
Agent iast 1.173 s 135.389 ms (13.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.183 s 145.865 ms (14.1%)
Agent iast_TELEMETRY_OFF 1.162 s 124.669 ms (12.0%)
Total tracing 8.603 s -
Total iast 9.234 s 630.914 ms (7.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.222 s 618.914 ms (7.2%)
Total iast_TELEMETRY_OFF 9.171 s 568.486 ms (6.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.037 s -
Agent iast 1.173 s 135.132 ms (13.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.166 s 128.958 ms (12.4%)
Agent iast_TELEMETRY_OFF 1.163 s 125.562 ms (12.1%)
Total tracing 8.593 s -
Total iast 9.219 s 625.814 ms (7.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.164 s 570.506 ms (6.6%)
Total iast_TELEMETRY_OFF 9.202 s 609.041 ms (7.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~7c78663215, baseline=1.46.0-SNAPSHOT~a41d1512de

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (712.91 ms) : 0, 712910
BytebuddyAgent [candidate] (714.591 ms) : 0, 714591
GlobalTracer [baseline] (239.268 ms) : 0, 239268
GlobalTracer [candidate] (239.546 ms) : 0, 239546
AppSec [baseline] (55.205 ms) : 0, 55205
AppSec [candidate] (55.719 ms) : 0, 55719
Remote Config [baseline] (706.527 µs) : 0, 707
Remote Config [candidate] (725.938 µs) : 0, 726
Telemetry [baseline] (14.34 ms) : 0, 14340
Telemetry [candidate] (11.639 ms) : 0, 11639
section iast
BytebuddyAgent [baseline] (837.095 ms) : 0, 837095
BytebuddyAgent [candidate] (837.097 ms) : 0, 837097
GlobalTracer [baseline] (231.204 ms) : 0, 231204
GlobalTracer [candidate] (231.161 ms) : 0, 231161
IAST [baseline] (24.924 ms) : 0, 24924
IAST [candidate] (25.708 ms) : 0, 25708
AppSec [baseline] (54.937 ms) : 0, 54937
AppSec [candidate] (53.963 ms) : 0, 53963
Remote Config [baseline] (622.488 µs) : 0, 622
Remote Config [candidate] (613.166 µs) : 0, 613
Telemetry [baseline] (8.887 ms) : 0, 8887
Telemetry [candidate] (8.687 ms) : 0, 8687
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (845.866 ms) : 0, 845866
BytebuddyAgent [candidate] (831.9 ms) : 0, 831900
GlobalTracer [baseline] (231.878 ms) : 0, 231878
GlobalTracer [candidate] (230.174 ms) : 0, 230174
IAST [baseline] (24.555 ms) : 0, 24555
IAST [candidate] (22.506 ms) : 0, 22506
AppSec [baseline] (56.145 ms) : 0, 56145
AppSec [candidate] (57.176 ms) : 0, 57176
Remote Config [baseline] (634.243 µs) : 0, 634
Remote Config [candidate] (616.231 µs) : 0, 616
Telemetry [baseline] (8.931 ms) : 0, 8931
Telemetry [candidate] (8.715 ms) : 0, 8715
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (828.841 ms) : 0, 828841
BytebuddyAgent [candidate] (830.025 ms) : 0, 830025
GlobalTracer [baseline] (229.665 ms) : 0, 229665
GlobalTracer [candidate] (229.93 ms) : 0, 229930
IAST [baseline] (23.825 ms) : 0, 23825
IAST [candidate] (27.487 ms) : 0, 27487
AppSec [baseline] (55.472 ms) : 0, 55472
AppSec [candidate] (51.106 ms) : 0, 51106
Remote Config [baseline] (618.326 µs) : 0, 618
Remote Config [candidate] (613.632 µs) : 0, 614
Telemetry [baseline] (8.626 ms) : 0, 8626
Telemetry [candidate] (8.553 ms) : 0, 8553
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-01-29T15:21:26 2025-01-29T15:28:31
git_branch master nikita-tkachenko/test-framework-version-null
git_commit_date 1738161747 1738163629
git_commit_sha a41d151 7c78663
release_version 1.46.0-SNAPSHOT~a41d1512de 1.46.0-SNAPSHOT~7c78663215
start_time 2025-01-29T15:21:12 2025-01-29T15:28:17
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1738164869 1738164869
ci_job_id 785638646 785638646
ci_pipeline_id 54329275 54329275
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zsvuzntn-project-304-concurrent-0-7z6unw3i 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zsvuzntn-project-304-concurrent-0-7z6unw3i 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~7c78663215, baseline=1.46.0-SNAPSHOT~a41d1512de
    dateFormat X
    axisFormat %s
section baseline
no_agent (385.63 µs) : 366, 405
.   : milestone, 386,
iast (509.119 µs) : 486, 533
.   : milestone, 509,
iast_FULL (747.139 µs) : 724, 770
.   : milestone, 747,
iast_GLOBAL (556.067 µs) : 533, 579
.   : milestone, 556,
iast_HARDCODED_SECRET_DISABLED (505.123 µs) : 482, 528
.   : milestone, 505,
iast_INACTIVE (457.609 µs) : 436, 479
.   : milestone, 458,
iast_TELEMETRY_OFF (495.944 µs) : 473, 519
.   : milestone, 496,
tracing (453.566 µs) : 431, 476
.   : milestone, 454,
section candidate
no_agent (385.724 µs) : 365, 407
.   : milestone, 386,
iast (511.533 µs) : 488, 535
.   : milestone, 512,
iast_FULL (747.695 µs) : 725, 770
.   : milestone, 748,
iast_GLOBAL (559.166 µs) : 537, 582
.   : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (510.38 µs) : 488, 533
.   : milestone, 510,
iast_INACTIVE (461.372 µs) : 440, 483
.   : milestone, 461,
iast_TELEMETRY_OFF (498.792 µs) : 476, 522
.   : milestone, 499,
tracing (452.125 µs) : 431, 473
.   : milestone, 452,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 385.63 µs [365.934 µs, 405.326 µs] -
iast 509.119 µs [485.584 µs, 532.655 µs] 123.489 µs (32.0%)
iast_FULL 747.139 µs [724.151 µs, 770.127 µs] 361.509 µs (93.7%)
iast_GLOBAL 556.067 µs [533.177 µs, 578.957 µs] 170.437 µs (44.2%)
iast_HARDCODED_SECRET_DISABLED 505.123 µs [482.136 µs, 528.11 µs] 119.493 µs (31.0%)
iast_INACTIVE 457.609 µs [436.175 µs, 479.042 µs] 71.979 µs (18.7%)
iast_TELEMETRY_OFF 495.944 µs [472.828 µs, 519.06 µs] 110.314 µs (28.6%)
tracing 453.566 µs [431.062 µs, 476.07 µs] 67.936 µs (17.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 385.724 µs [364.865 µs, 406.584 µs] -
iast 511.533 µs [488.308 µs, 534.758 µs] 125.809 µs (32.6%)
iast_FULL 747.695 µs [725.441 µs, 769.949 µs] 361.971 µs (93.8%)
iast_GLOBAL 559.166 µs [536.786 µs, 581.545 µs] 173.441 µs (45.0%)
iast_HARDCODED_SECRET_DISABLED 510.38 µs [487.681 µs, 533.079 µs] 124.656 µs (32.3%)
iast_INACTIVE 461.372 µs [439.768 µs, 482.975 µs] 75.648 µs (19.6%)
iast_TELEMETRY_OFF 498.792 µs [475.605 µs, 521.98 µs] 113.068 µs (29.3%)
tracing 452.125 µs [431.293 µs, 472.957 µs] 66.401 µs (17.2%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~7c78663215, baseline=1.46.0-SNAPSHOT~a41d1512de
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.364 ms) : 1344, 1384
.   : milestone, 1364,
appsec (1.74 ms) : 1716, 1764
.   : milestone, 1740,
appsec_no_iast (1.763 ms) : 1738, 1788
.   : milestone, 1763,
iast (1.493 ms) : 1469, 1517
.   : milestone, 1493,
profiling (1.539 ms) : 1514, 1563
.   : milestone, 1539,
tracing (1.511 ms) : 1486, 1535
.   : milestone, 1511,
section candidate
no_agent (1.362 ms) : 1343, 1382
.   : milestone, 1362,
appsec (1.749 ms) : 1725, 1773
.   : milestone, 1749,
appsec_no_iast (1.767 ms) : 1744, 1790
.   : milestone, 1767,
iast (1.514 ms) : 1490, 1538
.   : milestone, 1514,
profiling (1.51 ms) : 1486, 1534
.   : milestone, 1510,
tracing (1.507 ms) : 1482, 1531
.   : milestone, 1507,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.364 ms [1.344 ms, 1.384 ms] -
appsec 1.74 ms [1.716 ms, 1.764 ms] 376.184 µs (27.6%)
appsec_no_iast 1.763 ms [1.738 ms, 1.788 ms] 398.954 µs (29.2%)
iast 1.493 ms [1.469 ms, 1.517 ms] 128.952 µs (9.5%)
profiling 1.539 ms [1.514 ms, 1.563 ms] 174.448 µs (12.8%)
tracing 1.511 ms [1.486 ms, 1.535 ms] 146.672 µs (10.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.362 ms [1.343 ms, 1.382 ms] -
appsec 1.749 ms [1.725 ms, 1.773 ms] 386.999 µs (28.4%)
appsec_no_iast 1.767 ms [1.744 ms, 1.79 ms] 404.885 µs (29.7%)
iast 1.514 ms [1.49 ms, 1.538 ms] 151.854 µs (11.1%)
profiling 1.51 ms [1.486 ms, 1.534 ms] 147.868 µs (10.9%)
tracing 1.507 ms [1.482 ms, 1.531 ms] 144.475 µs (10.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/test-framework-version-null
git_commit_date 1738161747 1738163629
git_commit_sha a41d151 7c78663
release_version 1.46.0-SNAPSHOT~a41d1512de 1.46.0-SNAPSHOT~7c78663215
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1738165421 1738165421
ci_job_id 785638647 785638647
ci_pipeline_id 54329275 54329275
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-xcwqdre5-project-304-concurrent-4-gkrcn6br 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-xcwqdre5-project-304-concurrent-4-gkrcn6br 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~7c78663215, baseline=1.46.0-SNAPSHOT~a41d1512de
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (2.365 ms) : 2322, 2408
.   : milestone, 2365,
iast (2.12 ms) : 2065, 2175
.   : milestone, 2120,
iast_GLOBAL (2.152 ms) : 2097, 2207
.   : milestone, 2152,
profiling (1.963 ms) : 1920, 2007
.   : milestone, 1963,
tracing (1.95 ms) : 1908, 1993
.   : milestone, 1950,
section candidate
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.357 ms) : 2313, 2400
.   : milestone, 2357,
iast (2.106 ms) : 2052, 2161
.   : milestone, 2106,
iast_GLOBAL (2.157 ms) : 2102, 2213
.   : milestone, 2157,
profiling (1.975 ms) : 1931, 2019
.   : milestone, 1975,
tracing (1.942 ms) : 1900, 1984
.   : milestone, 1942,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.462 ms, 1.485 ms] -
appsec 2.365 ms [2.322 ms, 2.408 ms] 891.236 µs (60.5%)
iast 2.12 ms [2.065 ms, 2.175 ms] 646.2 µs (43.8%)
iast_GLOBAL 2.152 ms [2.097 ms, 2.207 ms] 678.154 µs (46.0%)
profiling 1.963 ms [1.92 ms, 2.007 ms] 489.601 µs (33.2%)
tracing 1.95 ms [1.908 ms, 1.993 ms] 476.285 µs (32.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.483 ms] -
appsec 2.357 ms [2.313 ms, 2.4 ms] 885.141 µs (60.1%)
iast 2.106 ms [2.052 ms, 2.161 ms] 634.756 µs (43.1%)
iast_GLOBAL 2.157 ms [2.102 ms, 2.213 ms] 685.862 µs (46.6%)
profiling 1.975 ms [1.931 ms, 2.019 ms] 503.325 µs (34.2%)
tracing 1.942 ms [1.9 ms, 1.984 ms] 470.243 µs (32.0%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~7c78663215, baseline=1.46.0-SNAPSHOT~a41d1512de
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.296 s) : 15296000, 15296000
.   : milestone, 15296000,
appsec (15.181 s) : 15181000, 15181000
.   : milestone, 15181000,
iast (18.651 s) : 18651000, 18651000
.   : milestone, 18651000,
iast_GLOBAL (18.029 s) : 18029000, 18029000
.   : milestone, 18029000,
profiling (15.713 s) : 15713000, 15713000
.   : milestone, 15713000,
tracing (14.76 s) : 14760000, 14760000
.   : milestone, 14760000,
section candidate
no_agent (14.985 s) : 14985000, 14985000
.   : milestone, 14985000,
appsec (15.119 s) : 15119000, 15119000
.   : milestone, 15119000,
iast (18.447 s) : 18447000, 18447000
.   : milestone, 18447000,
iast_GLOBAL (18.234 s) : 18234000, 18234000
.   : milestone, 18234000,
profiling (15.674 s) : 15674000, 15674000
.   : milestone, 15674000,
tracing (15.194 s) : 15194000, 15194000
.   : milestone, 15194000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.296 s [15.296 s, 15.296 s] -
appsec 15.181 s [15.181 s, 15.181 s] -115.0 ms (-0.8%)
iast 18.651 s [18.651 s, 18.651 s] 3.355 s (21.9%)
iast_GLOBAL 18.029 s [18.029 s, 18.029 s] 2.733 s (17.9%)
profiling 15.713 s [15.713 s, 15.713 s] 417.0 ms (2.7%)
tracing 14.76 s [14.76 s, 14.76 s] -536.0 ms (-3.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.985 s [14.985 s, 14.985 s] -
appsec 15.119 s [15.119 s, 15.119 s] 134.0 ms (0.9%)
iast 18.447 s [18.447 s, 18.447 s] 3.462 s (23.1%)
iast_GLOBAL 18.234 s [18.234 s, 18.234 s] 3.249 s (21.7%)
profiling 15.674 s [15.674 s, 15.674 s] 689.0 ms (4.6%)
tracing 15.194 s [15.194 s, 15.194 s] 209.0 ms (1.4%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review January 29, 2025 12:57
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner January 29, 2025 12:57
@nikita-tkachenko-datadog nikita-tkachenko-datadog added tag: no release notes Changes to exclude from release notes and removed tag: no release notes Changes to exclude from release notes labels Jan 29, 2025
@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 81a92e7 into master Jan 29, 2025
196 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/test-framework-version-null branch January 29, 2025 16:11
@github-actions github-actions bot added this to the 1.46.0 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vitor-de-araujo vitor-de-araujo vitor-de-araujo approved these changes

@daniel-mohedano daniel-mohedano daniel-mohedano approved these changes

@tonyredondo tonyredondo Awaiting requested review from tonyredondo tonyredondo is a code owner automatically assigned from DataDog/ci-app-libraries-java

Assignees

No one assigned

Labels

comp: ci visibility Continuous Integration Visibility tag: no release notes Changes to exclude from release notes type: bug Bug report and fix

Projects

None yet

Milestone

1.46.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nikita-tkachenko-datadog @vitor-de-araujo @daniel-mohedano