Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multivalue multiline header extraction #8112

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
+392 −221
Draft

Allow multivalue multiline header extraction #8112

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5facb70
Add HttpClientTest2 file
sarahchen6 Dec 18, 2024
03a5c70
Extend HttpClientTest2 for Apache, Grizzly, and Jetty 9.1
sarahchen6 Dec 18, 2024
51b4adf
Change headers struct to be List<List<String>> instead of a map
sarahchen6 Dec 18, 2024
1c01394
Update HttpServletRequestExtractAdapter
sarahchen6 Dec 18, 2024
c7f8230
Update HostAndRequestAsHttpUriRequest for Apaches
sarahchen6 Dec 18, 2024
dad5213
Update Grizzly and Jetty91 getRequestHeader
sarahchen6 Dec 18, 2024
ccbffdb
Update Apache getRequestHeader and getResponseHeader
sarahchen6 Dec 18, 2024
4cdc4d4
Remove JettyClient91 support
sarahchen6 Dec 18, 2024
ec51de9
Fix missing header maps
sarahchen6 Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update HostAndRequestAsHttpUriRequest for Apaches
  • Loading branch information
@sarahchen6
sarahchen6 committed Dec 18, 2024
commit c7f8230fdba72f4a2146d738a9f97f53ba21e2c8
5 changes: 5 additions & 0 deletions ...a/datadog/trace/instrumentation/apachehttpasyncclient/HostAndRequestAsHttpUriRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,11 @@ public Header getFirstHeader(String name) {
return actualRequest.getFirstHeader(name);
}

@Override
public Header[] getHeaders(String name) {
return actualRequest.getHeaders(name);
}

public HttpRequest getActualRequest() {
return actualRequest;
}
Expand Down
5 changes: 5 additions & 0 deletions ...n/java/datadog/trace/instrumentation/apachehttpclient/HostAndRequestAsHttpUriRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,11 @@ public Header getFirstHeader(String name) {
return actualRequest.getFirstHeader(name);
}

@Override
public Header[] getHeaders(String name) {
return actualRequest.getHeaders(name);
}

public HttpRequest getActualRequest() {
return actualRequest;
}
Expand Down
5 changes: 5 additions & 0 deletions .../java/datadog/trace/instrumentation/apachehttpclient5/HostAndRequestAsHttpUriRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,9 @@ public void setHeader(String name, Object value) {
public Header getFirstHeader(String name) {
return actualRequest.getFirstHeader(name);
}

@Override
public Header[] getHeaders(String name) {
return actualRequest.getHeaders(name);
}
}