-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dangling stderr print #8063
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarziali
added
inst: others
All other instrumentations
tag: no release notes
Changes to exclude from release notes
type: refactoring
labels
Dec 6, 2024
amarziali
force-pushed
the
andrea.marziali/ignite
branch
from
December 6, 2024 13:51
507aa05
to
a4daa6c
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~507aa056e9, baseline=1.44.0-SNAPSHOT~6e8f3a5828
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.094 s) : 0, 1093574
Total [baseline] (8.68 s) : 0, 8680266
Agent [candidate] (1.093 s) : 0, 1092627
Total [candidate] (8.704 s) : 0, 8704223
section iast
Agent [baseline] (1.228 s) : 0, 1228076
Total [baseline] (9.307 s) : 0, 9307134
Agent [candidate] (1.231 s) : 0, 1230861
Total [candidate] (9.245 s) : 0, 9244528
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.222 s) : 0, 1221944
Total [baseline] (9.249 s) : 0, 9248653
Agent [candidate] (1.226 s) : 0, 1226281
Total [candidate] (9.231 s) : 0, 9231332
section iast_TELEMETRY_OFF
Agent [baseline] (1.217 s) : 0, 1216656
Total [baseline] (9.223 s) : 0, 9222871
Agent [candidate] (1.228 s) : 0, 1228014
Total [candidate] (9.248 s) : 0, 9248445
gantt
title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~507aa056e9, baseline=1.44.0-SNAPSHOT~6e8f3a5828
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.591 ms) : 0, 695591
BytebuddyAgent [candidate] (695.716 ms) : 0, 695716
GlobalTracer [baseline] (318.371 ms) : 0, 318371
GlobalTracer [candidate] (318.484 ms) : 0, 318484
AppSec [baseline] (54.617 ms) : 0, 54617
AppSec [candidate] (54.77 ms) : 0, 54770
Remote Config [baseline] (673.995 µs) : 0, 674
Remote Config [candidate] (689.217 µs) : 0, 689
Telemetry [baseline] (10.589 ms) : 0, 10589
Telemetry [candidate] (9.195 ms) : 0, 9195
section iast
BytebuddyAgent [baseline] (817.841 ms) : 0, 817841
BytebuddyAgent [candidate] (820.002 ms) : 0, 820002
GlobalTracer [baseline] (308.063 ms) : 0, 308063
GlobalTracer [candidate] (309.11 ms) : 0, 309110
AppSec [baseline] (57.665 ms) : 0, 57665
AppSec [candidate] (57.708 ms) : 0, 57708
IAST [baseline] (22.264 ms) : 0, 22264
IAST [candidate] (21.888 ms) : 0, 21888
Remote Config [baseline] (682.382 µs) : 0, 682
Remote Config [candidate] (640.634 µs) : 0, 641
Telemetry [baseline] (7.733 ms) : 0, 7733
Telemetry [candidate] (7.611 ms) : 0, 7611
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (813.442 ms) : 0, 813442
BytebuddyAgent [candidate] (815.488 ms) : 0, 815488
GlobalTracer [baseline] (307.188 ms) : 0, 307188
GlobalTracer [candidate] (308.32 ms) : 0, 308320
AppSec [baseline] (57.184 ms) : 0, 57184
AppSec [candidate] (58.769 ms) : 0, 58769
IAST [baseline] (22.047 ms) : 0, 22047
IAST [candidate] (21.455 ms) : 0, 21455
Remote Config [baseline] (645.834 µs) : 0, 646
Remote Config [candidate] (660.16 µs) : 0, 660
Telemetry [baseline] (7.636 ms) : 0, 7636
Telemetry [candidate] (7.733 ms) : 0, 7733
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (810.08 ms) : 0, 810080
BytebuddyAgent [candidate] (817.502 ms) : 0, 817502
GlobalTracer [baseline] (305.897 ms) : 0, 305897
GlobalTracer [candidate] (309.453 ms) : 0, 309453
AppSec [baseline] (57.5 ms) : 0, 57500
AppSec [candidate] (57.491 ms) : 0, 57491
IAST [baseline] (21.308 ms) : 0, 21308
IAST [candidate] (21.447 ms) : 0, 21447
Remote Config [baseline] (644.806 µs) : 0, 645
Remote Config [candidate] (634.281 µs) : 0, 634
Telemetry [baseline] (7.476 ms) : 0, 7476
Telemetry [candidate] (7.443 ms) : 0, 7443
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~507aa056e9, baseline=1.44.0-SNAPSHOT~6e8f3a5828
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1091797
Total [baseline] (10.498 s) : 0, 10498393
Agent [candidate] (1.093 s) : 0, 1093001
Total [candidate] (10.527 s) : 0, 10527028
section appsec
Agent [baseline] (1.232 s) : 0, 1231607
Total [baseline] (10.788 s) : 0, 10787870
Agent [candidate] (1.234 s) : 0, 1233840
Total [candidate] (10.795 s) : 0, 10795252
section iast
Agent [baseline] (1.222 s) : 0, 1222390
Total [baseline] (10.894 s) : 0, 10894326
Agent [candidate] (1.229 s) : 0, 1229453
Total [candidate] (11.013 s) : 0, 11012524
section profiling
Agent [baseline] (1.325 s) : 0, 1325091
Total [baseline] (10.892 s) : 0, 10892068
Agent [candidate] (1.321 s) : 0, 1321197
Total [candidate] (10.907 s) : 0, 10907120
gantt
title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~507aa056e9, baseline=1.44.0-SNAPSHOT~6e8f3a5828
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.917 ms) : 0, 695917
BytebuddyAgent [candidate] (696.18 ms) : 0, 696180
GlobalTracer [baseline] (318.223 ms) : 0, 318223
GlobalTracer [candidate] (317.919 ms) : 0, 317919
AppSec [baseline] (54.678 ms) : 0, 54678
AppSec [candidate] (54.567 ms) : 0, 54567
Remote Config [baseline] (710.597 µs) : 0, 711
Remote Config [candidate] (687.162 µs) : 0, 687
Telemetry [baseline] (8.478 ms) : 0, 8478
Telemetry [candidate] (9.89 ms) : 0, 9890
section appsec
BytebuddyAgent [baseline] (715.557 ms) : 0, 715557
BytebuddyAgent [candidate] (716.533 ms) : 0, 716533
GlobalTracer [baseline] (316.612 ms) : 0, 316612
GlobalTracer [candidate] (316.965 ms) : 0, 316965
AppSec [baseline] (167.196 ms) : 0, 167196
AppSec [candidate] (167.0 ms) : 0, 167000
Remote Config [baseline] (1.019 ms) : 0, 1019
Remote Config [candidate] (1.024 ms) : 0, 1024
Telemetry [baseline] (7.853 ms) : 0, 7853
Telemetry [candidate] (8.965 ms) : 0, 8965
IAST [baseline] (19.101 ms) : 0, 19101
IAST [candidate] (18.955 ms) : 0, 18955
section iast
BytebuddyAgent [baseline] (813.711 ms) : 0, 813711
BytebuddyAgent [candidate] (819.356 ms) : 0, 819356
GlobalTracer [baseline] (307.524 ms) : 0, 307524
GlobalTracer [candidate] (308.803 ms) : 0, 308803
AppSec [baseline] (57.201 ms) : 0, 57201
AppSec [candidate] (57.309 ms) : 0, 57309
Remote Config [baseline] (638.889 µs) : 0, 639
Remote Config [candidate] (625.347 µs) : 0, 625
Telemetry [baseline] (7.632 ms) : 0, 7632
Telemetry [candidate] (7.569 ms) : 0, 7569
IAST [baseline] (21.895 ms) : 0, 21895
IAST [candidate] (21.9 ms) : 0, 21900
section profiling
ProfilingAgent [baseline] (93.173 ms) : 0, 93173
ProfilingAgent [candidate] (94.011 ms) : 0, 94011
BytebuddyAgent [baseline] (693.765 ms) : 0, 693765
BytebuddyAgent [candidate] (690.789 ms) : 0, 690789
GlobalTracer [baseline] (437.004 ms) : 0, 437004
GlobalTracer [candidate] (434.867 ms) : 0, 434867
AppSec [baseline] (53.388 ms) : 0, 53388
AppSec [candidate] (53.803 ms) : 0, 53803
Remote Config [baseline] (660.366 µs) : 0, 660
Remote Config [candidate] (668.419 µs) : 0, 668
Telemetry [baseline] (7.706 ms) : 0, 7706
Telemetry [candidate] (7.77 ms) : 0, 7770
Profiling [baseline] (93.197 ms) : 0, 93197
Profiling [candidate] (94.036 ms) : 0, 94036
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~507aa056e9, baseline=1.44.0-SNAPSHOT~6e8f3a5828
dateFormat X
axisFormat %s
section baseline
no_agent (383.191 µs) : 363, 403
. : milestone, 383,
iast (497.948 µs) : 476, 520
. : milestone, 498,
iast_FULL (660.455 µs) : 639, 682
. : milestone, 660,
iast_GLOBAL (527.927 µs) : 506, 550
. : milestone, 528,
iast_HARDCODED_SECRET_DISABLED (503.734 µs) : 482, 525
. : milestone, 504,
iast_INACTIVE (469.573 µs) : 448, 491
. : milestone, 470,
iast_TELEMETRY_OFF (489.474 µs) : 468, 511
. : milestone, 489,
tracing (458.899 µs) : 438, 479
. : milestone, 459,
section candidate
no_agent (381.965 µs) : 362, 402
. : milestone, 382,
iast (501.091 µs) : 480, 523
. : milestone, 501,
iast_FULL (664.073 µs) : 643, 686
. : milestone, 664,
iast_GLOBAL (528.997 µs) : 507, 551
. : milestone, 529,
iast_HARDCODED_SECRET_DISABLED (501.636 µs) : 480, 523
. : milestone, 502,
iast_INACTIVE (458.269 µs) : 437, 479
. : milestone, 458,
iast_TELEMETRY_OFF (486.273 µs) : 465, 507
. : milestone, 486,
tracing (453.147 µs) : 433, 474
. : milestone, 453,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~507aa056e9, baseline=1.44.0-SNAPSHOT~6e8f3a5828
dateFormat X
axisFormat %s
section baseline
no_agent (1.372 ms) : 1352, 1392
. : milestone, 1372,
appsec (1.737 ms) : 1714, 1761
. : milestone, 1737,
appsec_no_iast (1.765 ms) : 1741, 1789
. : milestone, 1765,
iast (1.524 ms) : 1502, 1547
. : milestone, 1524,
profiling (1.526 ms) : 1503, 1548
. : milestone, 1526,
tracing (1.482 ms) : 1457, 1507
. : milestone, 1482,
section candidate
no_agent (1.364 ms) : 1344, 1385
. : milestone, 1364,
appsec (1.754 ms) : 1729, 1779
. : milestone, 1754,
appsec_no_iast (1.767 ms) : 1743, 1792
. : milestone, 1767,
iast (1.505 ms) : 1481, 1528
. : milestone, 1505,
profiling (1.521 ms) : 1498, 1544
. : milestone, 1521,
tracing (1.49 ms) : 1466, 1515
. : milestone, 1490,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~507aa056e9, baseline=1.44.0-SNAPSHOT~6e8f3a5828
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (2.344 ms) : 2302, 2385
. : milestone, 2344,
iast (2.1 ms) : 2047, 2153
. : milestone, 2100,
iast_GLOBAL (2.141 ms) : 2088, 2193
. : milestone, 2141,
profiling (1.976 ms) : 1933, 2018
. : milestone, 1976,
tracing (1.945 ms) : 1904, 1985
. : milestone, 1945,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.355 ms) : 2313, 2397
. : milestone, 2355,
iast (2.097 ms) : 2044, 2150
. : milestone, 2097,
iast_GLOBAL (2.142 ms) : 2089, 2195
. : milestone, 2142,
profiling (1.965 ms) : 1923, 2007
. : milestone, 1965,
tracing (1.934 ms) : 1894, 1975
. : milestone, 1934,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~507aa056e9, baseline=1.44.0-SNAPSHOT~6e8f3a5828
dateFormat X
axisFormat %s
section baseline
no_agent (14.953 s) : 14953000, 14953000
. : milestone, 14953000,
appsec (14.863 s) : 14863000, 14863000
. : milestone, 14863000,
iast (19.004 s) : 19004000, 19004000
. : milestone, 19004000,
iast_GLOBAL (18.319 s) : 18319000, 18319000
. : milestone, 18319000,
profiling (14.856 s) : 14856000, 14856000
. : milestone, 14856000,
tracing (15.198 s) : 15198000, 15198000
. : milestone, 15198000,
section candidate
no_agent (15.569 s) : 15569000, 15569000
. : milestone, 15569000,
appsec (14.795 s) : 14795000, 14795000
. : milestone, 14795000,
iast (18.711 s) : 18711000, 18711000
. : milestone, 18711000,
iast_GLOBAL (18.216 s) : 18216000, 18216000
. : milestone, 18216000,
profiling (14.681 s) : 14681000, 14681000
. : milestone, 14681000,
tracing (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
|
mcculls
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: others
All other instrumentations
tag: no release notes
Changes to exclude from release notes
type: refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]