-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use stubs instead of mocks #8052
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanchooly
force-pushed
the
evanchooly/grpc
branch
from
December 3, 2024 17:40
927f8c8
to
c1da24e
Compare
jpbempel
approved these changes
Dec 3, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~927f8c86bc, baseline=1.44.0-SNAPSHOT~7698f2f594
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1090091
Total [baseline] (8.672 s) : 0, 8672229
Agent [candidate] (1.093 s) : 0, 1093068
Total [candidate] (8.694 s) : 0, 8693952
section iast
Agent [baseline] (1.229 s) : 0, 1228574
Total [baseline] (9.28 s) : 0, 9280196
Agent [candidate] (1.226 s) : 0, 1225998
Total [candidate] (9.206 s) : 0, 9205894
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.223 s) : 0, 1222976
Total [baseline] (9.198 s) : 0, 9198419
Agent [candidate] (1.222 s) : 0, 1222154
Total [candidate] (9.194 s) : 0, 9194161
section iast_TELEMETRY_OFF
Agent [baseline] (1.215 s) : 0, 1215226
Total [baseline] (9.245 s) : 0, 9245119
Agent [candidate] (1.226 s) : 0, 1226312
Total [candidate] (9.188 s) : 0, 9188371
gantt
title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~927f8c86bc, baseline=1.44.0-SNAPSHOT~7698f2f594
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (694.591 ms) : 0, 694591
BytebuddyAgent [candidate] (695.091 ms) : 0, 695091
GlobalTracer [baseline] (317.645 ms) : 0, 317645
GlobalTracer [candidate] (318.639 ms) : 0, 318639
AppSec [baseline] (54.914 ms) : 0, 54914
AppSec [candidate] (54.925 ms) : 0, 54925
Remote Config [baseline] (689.539 µs) : 0, 690
Remote Config [candidate] (683.934 µs) : 0, 684
Telemetry [baseline] (8.48 ms) : 0, 8480
Telemetry [candidate] (9.955 ms) : 0, 9955
section iast
BytebuddyAgent [baseline] (818.325 ms) : 0, 818325
BytebuddyAgent [candidate] (817.342 ms) : 0, 817342
GlobalTracer [baseline] (308.268 ms) : 0, 308268
GlobalTracer [candidate] (307.851 ms) : 0, 307851
AppSec [baseline] (56.677 ms) : 0, 56677
AppSec [candidate] (57.948 ms) : 0, 57948
IAST [baseline] (23.172 ms) : 0, 23172
IAST [candidate] (20.875 ms) : 0, 20875
Remote Config [baseline] (644.654 µs) : 0, 645
Remote Config [candidate] (627.989 µs) : 0, 628
Telemetry [baseline] (7.632 ms) : 0, 7632
Telemetry [candidate] (7.474 ms) : 0, 7474
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (814.532 ms) : 0, 814532
BytebuddyAgent [candidate] (813.967 ms) : 0, 813967
GlobalTracer [baseline] (307.175 ms) : 0, 307175
GlobalTracer [candidate] (307.41 ms) : 0, 307410
AppSec [baseline] (58.31 ms) : 0, 58310
AppSec [candidate] (57.174 ms) : 0, 57174
IAST [baseline] (21.052 ms) : 0, 21052
IAST [candidate] (21.714 ms) : 0, 21714
Remote Config [baseline] (628.036 µs) : 0, 628
Remote Config [candidate] (631.105 µs) : 0, 631
Telemetry [baseline] (7.486 ms) : 0, 7486
Telemetry [candidate] (7.478 ms) : 0, 7478
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (807.992 ms) : 0, 807992
BytebuddyAgent [candidate] (816.248 ms) : 0, 816248
GlobalTracer [baseline] (306.594 ms) : 0, 306594
GlobalTracer [candidate] (309.089 ms) : 0, 309089
AppSec [baseline] (58.22 ms) : 0, 58220
AppSec [candidate] (58.643 ms) : 0, 58643
IAST [baseline] (20.571 ms) : 0, 20571
IAST [candidate] (20.373 ms) : 0, 20373
Remote Config [baseline] (637.986 µs) : 0, 638
Remote Config [candidate] (635.934 µs) : 0, 636
Telemetry [baseline] (7.484 ms) : 0, 7484
Telemetry [candidate] (7.45 ms) : 0, 7450
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~927f8c86bc, baseline=1.44.0-SNAPSHOT~7698f2f594
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1090723
Total [baseline] (10.452 s) : 0, 10452142
Agent [candidate] (1.089 s) : 0, 1089238
Total [candidate] (10.463 s) : 0, 10463024
section appsec
Agent [baseline] (1.231 s) : 0, 1230711
Total [baseline] (10.814 s) : 0, 10814019
Agent [candidate] (1.23 s) : 0, 1229900
Total [candidate] (10.748 s) : 0, 10748018
section iast
Agent [baseline] (1.234 s) : 0, 1233512
Total [baseline] (11.006 s) : 0, 11005647
Agent [candidate] (1.229 s) : 0, 1229181
Total [candidate] (11.03 s) : 0, 11030027
section profiling
Agent [baseline] (1.318 s) : 0, 1318139
Total [baseline] (10.836 s) : 0, 10835840
Agent [candidate] (1.316 s) : 0, 1316118
Total [candidate] (10.84 s) : 0, 10839991
gantt
title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~927f8c86bc, baseline=1.44.0-SNAPSHOT~7698f2f594
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (694.715 ms) : 0, 694715
BytebuddyAgent [candidate] (694.04 ms) : 0, 694040
GlobalTracer [baseline] (317.693 ms) : 0, 317693
GlobalTracer [candidate] (317.763 ms) : 0, 317763
AppSec [baseline] (54.75 ms) : 0, 54750
AppSec [candidate] (54.595 ms) : 0, 54595
Remote Config [baseline] (677.705 µs) : 0, 678
Remote Config [candidate] (672.661 µs) : 0, 673
Telemetry [baseline] (9.112 ms) : 0, 9112
Telemetry [candidate] (8.43 ms) : 0, 8430
section appsec
BytebuddyAgent [baseline] (713.497 ms) : 0, 713497
BytebuddyAgent [candidate] (714.011 ms) : 0, 714011
GlobalTracer [baseline] (316.688 ms) : 0, 316688
GlobalTracer [candidate] (316.462 ms) : 0, 316462
AppSec [baseline] (167.31 ms) : 0, 167310
AppSec [candidate] (166.477 ms) : 0, 166477
Remote Config [baseline] (651.507 µs) : 0, 652
Remote Config [candidate] (654.242 µs) : 0, 654
Telemetry [baseline] (9.314 ms) : 0, 9314
Telemetry [candidate] (8.534 ms) : 0, 8534
IAST [baseline] (18.977 ms) : 0, 18977
IAST [candidate] (19.932 ms) : 0, 19932
section iast
BytebuddyAgent [baseline] (824.109 ms) : 0, 824109
BytebuddyAgent [candidate] (818.28 ms) : 0, 818280
GlobalTracer [baseline] (308.704 ms) : 0, 308704
GlobalTracer [candidate] (309.391 ms) : 0, 309391
AppSec [baseline] (56.987 ms) : 0, 56987
AppSec [candidate] (58.143 ms) : 0, 58143
Remote Config [baseline] (625.438 µs) : 0, 625
Remote Config [candidate] (652.507 µs) : 0, 653
Telemetry [baseline] (7.442 ms) : 0, 7442
Telemetry [candidate] (7.621 ms) : 0, 7621
IAST [baseline] (21.576 ms) : 0, 21576
IAST [candidate] (21.219 ms) : 0, 21219
section profiling
ProfilingAgent [baseline] (92.929 ms) : 0, 92929
ProfilingAgent [candidate] (93.425 ms) : 0, 93425
BytebuddyAgent [baseline] (689.003 ms) : 0, 689003
BytebuddyAgent [candidate] (687.609 ms) : 0, 687609
GlobalTracer [baseline] (435.241 ms) : 0, 435241
GlobalTracer [candidate] (433.652 ms) : 0, 433652
AppSec [baseline] (53.568 ms) : 0, 53568
AppSec [candidate] (53.97 ms) : 0, 53970
Remote Config [baseline] (662.281 µs) : 0, 662
Remote Config [candidate] (657.472 µs) : 0, 657
Telemetry [baseline] (7.705 ms) : 0, 7705
Telemetry [candidate] (7.724 ms) : 0, 7724
Profiling [baseline] (92.952 ms) : 0, 92952
Profiling [candidate] (93.448 ms) : 0, 93448
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~927f8c86bc, baseline=1.44.0-SNAPSHOT~7698f2f594
dateFormat X
axisFormat %s
section baseline
no_agent (375.53 µs) : 355, 396
. : milestone, 376,
iast (488.756 µs) : 467, 510
. : milestone, 489,
iast_FULL (658.883 µs) : 637, 681
. : milestone, 659,
iast_GLOBAL (515.679 µs) : 494, 537
. : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (500.342 µs) : 479, 522
. : milestone, 500,
iast_INACTIVE (447.182 µs) : 427, 468
. : milestone, 447,
iast_TELEMETRY_OFF (478.605 µs) : 457, 500
. : milestone, 479,
tracing (449.595 µs) : 429, 470
. : milestone, 450,
section candidate
no_agent (373.845 µs) : 354, 393
. : milestone, 374,
iast (492.499 µs) : 471, 514
. : milestone, 492,
iast_FULL (653.261 µs) : 632, 675
. : milestone, 653,
iast_GLOBAL (516.698 µs) : 495, 538
. : milestone, 517,
iast_HARDCODED_SECRET_DISABLED (494.216 µs) : 473, 516
. : milestone, 494,
iast_INACTIVE (452.717 µs) : 432, 474
. : milestone, 453,
iast_TELEMETRY_OFF (482.828 µs) : 461, 504
. : milestone, 483,
tracing (445.815 µs) : 425, 467
. : milestone, 446,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~927f8c86bc, baseline=1.44.0-SNAPSHOT~7698f2f594
dateFormat X
axisFormat %s
section baseline
no_agent (1.353 ms) : 1333, 1372
. : milestone, 1353,
appsec (1.758 ms) : 1733, 1783
. : milestone, 1758,
appsec_no_iast (1.746 ms) : 1721, 1771
. : milestone, 1746,
iast (1.516 ms) : 1493, 1538
. : milestone, 1516,
profiling (1.529 ms) : 1506, 1552
. : milestone, 1529,
tracing (1.493 ms) : 1469, 1518
. : milestone, 1493,
section candidate
no_agent (1.351 ms) : 1331, 1371
. : milestone, 1351,
appsec (1.739 ms) : 1714, 1764
. : milestone, 1739,
appsec_no_iast (1.748 ms) : 1723, 1773
. : milestone, 1748,
iast (1.502 ms) : 1478, 1525
. : milestone, 1502,
profiling (1.532 ms) : 1510, 1555
. : milestone, 1532,
tracing (1.493 ms) : 1468, 1518
. : milestone, 1493,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~927f8c86bc, baseline=1.44.0-SNAPSHOT~7698f2f594
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.359 ms) : 2317, 2400
. : milestone, 2359,
iast (2.098 ms) : 2045, 2150
. : milestone, 2098,
iast_GLOBAL (2.143 ms) : 2090, 2196
. : milestone, 2143,
profiling (1.968 ms) : 1926, 2010
. : milestone, 1968,
tracing (1.937 ms) : 1897, 1977
. : milestone, 1937,
section candidate
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (2.36 ms) : 2319, 2401
. : milestone, 2360,
iast (2.097 ms) : 2044, 2149
. : milestone, 2097,
iast_GLOBAL (2.138 ms) : 2085, 2190
. : milestone, 2138,
profiling (1.983 ms) : 1940, 2027
. : milestone, 1983,
tracing (1.942 ms) : 1902, 1982
. : milestone, 1942,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~927f8c86bc, baseline=1.44.0-SNAPSHOT~7698f2f594
dateFormat X
axisFormat %s
section baseline
no_agent (15.613 s) : 15613000, 15613000
. : milestone, 15613000,
appsec (15.248 s) : 15248000, 15248000
. : milestone, 15248000,
iast (18.855 s) : 18855000, 18855000
. : milestone, 18855000,
iast_GLOBAL (17.589 s) : 17589000, 17589000
. : milestone, 17589000,
profiling (15.057 s) : 15057000, 15057000
. : milestone, 15057000,
tracing (15.08 s) : 15080000, 15080000
. : milestone, 15080000,
section candidate
no_agent (15.121 s) : 15121000, 15121000
. : milestone, 15121000,
appsec (15.016 s) : 15016000, 15016000
. : milestone, 15016000,
iast (19.227 s) : 19227000, 19227000
. : milestone, 19227000,
iast_GLOBAL (18.0 s) : 18000000, 18000000
. : milestone, 18000000,
profiling (15.057 s) : 15057000, 15057000
. : milestone, 15057000,
tracing (15.116 s) : 15116000, 15116000
. : milestone, 15116000,
|
PerfectSlayer
added
tag: no release notes
Changes to exclude from release notes
type: refactoring
inst: grpc
gRPC instrumentation
labels
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: grpc
gRPC instrumentation
tag: no release notes
Changes to exclude from release notes
type: refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Simplifies even further by dropping the use of mocks
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]