Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache entry span code origin information to avoid unnecessary repeated stack walks. #8029

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Cache entry span code origin information to avoid unnecessary repeated stack walks. #8029

merged 2 commits into from
Dec 2, 2024

Conversation

evanchooly
Copy link
Contributor

@evanchooly evanchooly commented Nov 27, 2024 •
edited by jira bot
Loading

What Does This Do

This PR uses the class parsing during instrumentation to extract out more accurate entry span information
caches that information to reuse it on commit()

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-3159

@evanchooly
use the class parsing during instrumentation to extract out more accu…
dce86b3 
…rate entry span information

cache that information and reuse it on commit()
@evanchooly evanchooly requested a review from a team as a code owner November 27, 2024 21:43
@evanchooly evanchooly requested review from jpbempel and removed request for a team November 27, 2024 21:43
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 27, 2024 •
edited
Loading

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@evanchooly evanchooly enabled auto-merge (squash) November 27, 2024 21:43
@evanchooly evanchooly added the comp: debugger Dynamic Instrumentation label Nov 27, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 27, 2024 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1733150929 1733151318
end_time 2024-12-02T14:50:06 2024-12-02T14:56:35
git_branch master evanchooly/DEBUG-3159
git_commit_sha d7a0014 c06ea4f
start_time 2024-12-02T14:48:50 2024-12-02T14:55:19
See matching parameters
Baseline Candidate
ci_job_id 724524820 724524820
ci_pipeline_id 50210817 50210817
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1733150321 1733150321

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop better
[-650.719µs; -589.624µs] or [-6.013%; -5.448%]		 better
[-684.760µs; -594.918µs] or [-6.222%; -5.406%]		 better
[-694.788µs; -566.602µs] or [-6.270%; -5.113%]		 better
[-1009.933µs; -392.087µs] or [-8.740%; -3.393%]		 better
[+4.383op/s; +6.721op/s] or [+4.887%; +7.493%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-29354.677ns; +31176.132ns] or [-10.739%; +11.406%]		 unstable
[-43582.630ns; +42954.526ns] or [-13.889%; +13.689%]		 unstable
[-55838.501ns; +55772.098ns] or [-16.988%; +16.968%]		 unstable
[-104.655µs; +119.482µs] or [-17.754%; +20.270%]		 same
scenario:basic same same same unstable
[-36.118µs; +52.684µs] or [-6.723%; +9.807%]		 unstable
[-139.824op/s; +139.824op/s] or [-5.453%; +5.453%]
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (313.784 µs) : 273, 355
.   : milestone, 314,
basic (306.568 µs) : 298, 315
.   : milestone, 307,
loop (11.006 ms) : 10954, 11057
.   : milestone, 11006,
section candidate
noprobe (313.47 µs) : 272, 355
.   : milestone, 313,
basic (305.332 µs) : 295, 316
.   : milestone, 305,
loop (10.366 ms) : 10337, 10395
.   : milestone, 10366,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 313.784 µs [272.649 µs, 354.92 µs]
basic 306.568 µs [297.76 µs, 315.377 µs]
loop 11.006 ms [10.954 ms, 11.057 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 313.47 µs [272.119 µs, 354.821 µs]
basic 305.332 µs [294.96 µs, 315.705 µs]
loop 10.366 ms [10.337 ms, 10.395 ms]

@pr-commenter
Copy link

pr-commenter bot commented Nov 27, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master evanchooly/DEBUG-3159
git_commit_date 1733143408 1733150321
git_commit_sha d7a0014 c06ea4f
release_version 1.44.0-SNAPSHOT~d7a0014648 1.44.0-SNAPSHOT~c06ea4f2df
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1733152796 1733152796
ci_job_id 724524805 724524805
ci_pipeline_id 50210817 50210817
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~c06ea4f2df, baseline=1.44.0-SNAPSHOT~d7a0014648

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1092134
Total [baseline] (10.425 s) : 0, 10425398
Agent [candidate] (1.092 s) : 0, 1092418
Total [candidate] (10.396 s) : 0, 10395860
section appsec
Agent [baseline] (1.236 s) : 0, 1235788
Total [baseline] (10.777 s) : 0, 10777198
Agent [candidate] (1.225 s) : 0, 1225132
Total [candidate] (10.715 s) : 0, 10715422
section iast
Agent [baseline] (1.219 s) : 0, 1218924
Total [baseline] (10.976 s) : 0, 10976426
Agent [candidate] (1.218 s) : 0, 1218192
Total [candidate] (10.954 s) : 0, 10954031
section profiling
Agent [baseline] (1.317 s) : 0, 1317495
Total [baseline] (10.795 s) : 0, 10794711
Agent [candidate] (1.319 s) : 0, 1319254
Total [candidate] (10.855 s) : 0, 10854777
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent appsec 1.236 s 143.655 ms (13.2%)
Agent iast 1.219 s 126.79 ms (11.6%)
Agent profiling 1.317 s 225.361 ms (20.6%)
Total tracing 10.425 s -
Total appsec 10.777 s 351.801 ms (3.4%)
Total iast 10.976 s 551.029 ms (5.3%)
Total profiling 10.795 s 369.313 ms (3.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent appsec 1.225 s 132.714 ms (12.1%)
Agent iast 1.218 s 125.775 ms (11.5%)
Agent profiling 1.319 s 226.836 ms (20.8%)
Total tracing 10.396 s -
Total appsec 10.715 s 319.562 ms (3.1%)
Total iast 10.954 s 558.17 ms (5.4%)
Total profiling 10.855 s 458.917 ms (4.4%) 
gantt
    title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~c06ea4f2df, baseline=1.44.0-SNAPSHOT~d7a0014648

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (694.246 ms) : 0, 694246
BytebuddyAgent [candidate] (695.434 ms) : 0, 695434
GlobalTracer [baseline] (317.005 ms) : 0, 317005
GlobalTracer [candidate] (317.846 ms) : 0, 317846
AppSec [baseline] (54.624 ms) : 0, 54624
AppSec [candidate] (54.841 ms) : 0, 54841
Remote Config [baseline] (673.499 µs) : 0, 673
Remote Config [candidate] (694.457 µs) : 0, 694
Telemetry [baseline] (11.898 ms) : 0, 11898
Telemetry [candidate] (9.882 ms) : 0, 9882
section appsec
BytebuddyAgent [baseline] (718.506 ms) : 0, 718506
BytebuddyAgent [candidate] (711.033 ms) : 0, 711033
GlobalTracer [baseline] (316.454 ms) : 0, 316454
GlobalTracer [candidate] (314.39 ms) : 0, 314390
AppSec [baseline] (167.457 ms) : 0, 167457
AppSec [candidate] (168.141 ms) : 0, 168141
IAST [baseline] (19.33 ms) : 0, 19330
IAST [candidate] (18.975 ms) : 0, 18975
Remote Config [baseline] (661.466 µs) : 0, 661
Remote Config [candidate] (639.212 µs) : 0, 639
Telemetry [baseline] (9.245 ms) : 0, 9245
Telemetry [candidate] (7.756 ms) : 0, 7756
section iast
BytebuddyAgent [baseline] (812.398 ms) : 0, 812398
BytebuddyAgent [candidate] (811.654 ms) : 0, 811654
GlobalTracer [baseline] (306.075 ms) : 0, 306075
GlobalTracer [candidate] (305.875 ms) : 0, 305875
AppSec [baseline] (57.736 ms) : 0, 57736
AppSec [candidate] (56.335 ms) : 0, 56335
IAST [baseline] (20.907 ms) : 0, 20907
IAST [candidate] (22.494 ms) : 0, 22494
Remote Config [baseline] (616.185 µs) : 0, 616
Remote Config [candidate] (623.16 µs) : 0, 623
Telemetry [baseline] (7.479 ms) : 0, 7479
Telemetry [candidate] (7.499 ms) : 0, 7499
section profiling
BytebuddyAgent [baseline] (689.467 ms) : 0, 689467
BytebuddyAgent [candidate] (689.083 ms) : 0, 689083
GlobalTracer [baseline] (434.095 ms) : 0, 434095
GlobalTracer [candidate] (434.346 ms) : 0, 434346
AppSec [baseline] (53.593 ms) : 0, 53593
AppSec [candidate] (54.152 ms) : 0, 54152
Remote Config [baseline] (658.714 µs) : 0, 659
Remote Config [candidate] (659.855 µs) : 0, 660
Telemetry [baseline] (7.694 ms) : 0, 7694
Telemetry [candidate] (7.683 ms) : 0, 7683
ProfilingAgent [baseline] (92.917 ms) : 0, 92917
ProfilingAgent [candidate] (94.2 ms) : 0, 94200
Profiling [baseline] (92.942 ms) : 0, 92942
Profiling [candidate] (94.224 ms) : 0, 94224
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~c06ea4f2df, baseline=1.44.0-SNAPSHOT~d7a0014648

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1092470
Total [baseline] (8.663 s) : 0, 8662620
Agent [candidate] (1.097 s) : 0, 1097323
Total [candidate] (8.676 s) : 0, 8676047
section iast
Agent [baseline] (1.227 s) : 0, 1227299
Total [baseline] (9.229 s) : 0, 9229350
Agent [candidate] (1.216 s) : 0, 1216088
Total [candidate] (9.215 s) : 0, 9214544
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.218 s) : 0, 1217516
Total [baseline] (9.129 s) : 0, 9129422
Agent [candidate] (1.218 s) : 0, 1218228
Total [candidate] (9.166 s) : 0, 9165834
section iast_TELEMETRY_OFF
Agent [baseline] (1.23 s) : 0, 1230304
Total [baseline] (9.235 s) : 0, 9234607
Agent [candidate] (1.217 s) : 0, 1217021
Total [candidate] (9.194 s) : 0, 9193728
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent iast 1.227 s 134.829 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.218 s 125.046 ms (11.4%)
Agent iast_TELEMETRY_OFF 1.23 s 137.834 ms (12.6%)
Total tracing 8.663 s -
Total iast 9.229 s 566.729 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.129 s 466.801 ms (5.4%)
Total iast_TELEMETRY_OFF 9.235 s 571.987 ms (6.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.097 s -
Agent iast 1.216 s 118.765 ms (10.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.218 s 120.904 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.217 s 119.697 ms (10.9%)
Total tracing 8.676 s -
Total iast 9.215 s 538.496 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.166 s 489.787 ms (5.6%)
Total iast_TELEMETRY_OFF 9.194 s 517.68 ms (6.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~c06ea4f2df, baseline=1.44.0-SNAPSHOT~d7a0014648

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (694.933 ms) : 0, 694933
BytebuddyAgent [candidate] (699.389 ms) : 0, 699389
GlobalTracer [baseline] (317.745 ms) : 0, 317745
GlobalTracer [candidate] (320.065 ms) : 0, 320065
AppSec [baseline] (54.858 ms) : 0, 54858
AppSec [candidate] (54.79 ms) : 0, 54790
Remote Config [baseline] (685.173 µs) : 0, 685
Remote Config [candidate] (689.664 µs) : 0, 690
Telemetry [baseline] (10.544 ms) : 0, 10544
Telemetry [candidate] (8.519 ms) : 0, 8519
section iast
BytebuddyAgent [baseline] (818.215 ms) : 0, 818215
BytebuddyAgent [candidate] (810.145 ms) : 0, 810145
GlobalTracer [baseline] (307.77 ms) : 0, 307770
GlobalTracer [candidate] (305.323 ms) : 0, 305323
AppSec [baseline] (58.277 ms) : 0, 58277
AppSec [candidate] (58.068 ms) : 0, 58068
IAST [baseline] (21.053 ms) : 0, 21053
IAST [candidate] (20.758 ms) : 0, 20758
Remote Config [baseline] (628.756 µs) : 0, 629
Remote Config [candidate] (617.294 µs) : 0, 617
Telemetry [baseline] (7.557 ms) : 0, 7557
Telemetry [candidate] (7.432 ms) : 0, 7432
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (811.725 ms) : 0, 811725
BytebuddyAgent [candidate] (811.193 ms) : 0, 811193
GlobalTracer [baseline] (305.347 ms) : 0, 305347
GlobalTracer [candidate] (306.834 ms) : 0, 306834
AppSec [baseline] (57.919 ms) : 0, 57919
AppSec [candidate] (57.621 ms) : 0, 57621
IAST [baseline] (20.74 ms) : 0, 20740
IAST [candidate] (20.709 ms) : 0, 20709
Remote Config [baseline] (627.608 µs) : 0, 628
Remote Config [candidate] (644.134 µs) : 0, 644
Telemetry [baseline] (7.45 ms) : 0, 7450
Telemetry [candidate] (7.471 ms) : 0, 7471
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (820.892 ms) : 0, 820892
BytebuddyAgent [candidate] (809.758 ms) : 0, 809758
GlobalTracer [baseline] (308.657 ms) : 0, 308657
GlobalTracer [candidate] (306.917 ms) : 0, 306917
AppSec [baseline] (58.328 ms) : 0, 58328
AppSec [candidate] (57.538 ms) : 0, 57538
IAST [baseline] (20.461 ms) : 0, 20461
IAST [candidate] (21.11 ms) : 0, 21110
Remote Config [baseline] (629.391 µs) : 0, 629
Remote Config [candidate] (626.561 µs) : 0, 627
Telemetry [baseline] (7.429 ms) : 0, 7429
Telemetry [candidate] (7.351 ms) : 0, 7351
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-12-02T14:50:02 2024-12-02T14:57:01
git_branch master evanchooly/DEBUG-3159
git_commit_date 1733143408 1733150321
git_commit_sha d7a0014 c06ea4f
release_version 1.44.0-SNAPSHOT~d7a0014648 1.44.0-SNAPSHOT~c06ea4f2df
start_time 2024-12-02T14:49:49 2024-12-02T14:56:47
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1733151775 1733151775
ci_job_id 724524807 724524807
ci_pipeline_id 50210817 50210817
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+45.981µs; +97.760µs] or [+3.088%; +6.565%]		 unstable
[-549.179op/s; +549.179op/s] or [-17.848%; +17.848%]		 1.561ms 3076.923op/s 1.489ms 3076.923op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~c06ea4f2df, baseline=1.44.0-SNAPSHOT~d7a0014648
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.348 ms) : 1328, 1367
.   : milestone, 1348,
appsec (1.782 ms) : 1758, 1807
.   : milestone, 1782,
appsec_no_iast (1.754 ms) : 1729, 1779
.   : milestone, 1754,
iast (1.493 ms) : 1470, 1516
.   : milestone, 1493,
profiling (1.489 ms) : 1466, 1513
.   : milestone, 1489,
tracing (1.5 ms) : 1474, 1525
.   : milestone, 1500,
section candidate
no_agent (1.357 ms) : 1337, 1377
.   : milestone, 1357,
appsec (1.755 ms) : 1730, 1780
.   : milestone, 1755,
appsec_no_iast (1.769 ms) : 1743, 1794
.   : milestone, 1769,
iast (1.518 ms) : 1494, 1541
.   : milestone, 1518,
profiling (1.561 ms) : 1536, 1586
.   : milestone, 1561,
tracing (1.481 ms) : 1456, 1506
.   : milestone, 1481,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.348 ms [1.328 ms, 1.367 ms] -
appsec 1.782 ms [1.758 ms, 1.807 ms] 434.772 µs (32.3%)
appsec_no_iast 1.754 ms [1.729 ms, 1.779 ms] 406.298 µs (30.1%)
iast 1.493 ms [1.47 ms, 1.516 ms] 145.426 µs (10.8%)
profiling 1.489 ms [1.466 ms, 1.513 ms] 141.58 µs (10.5%)
tracing 1.5 ms [1.474 ms, 1.525 ms] 152.139 µs (11.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.357 ms [1.337 ms, 1.377 ms] -
appsec 1.755 ms [1.73 ms, 1.78 ms] 397.972 µs (29.3%)
appsec_no_iast 1.769 ms [1.743 ms, 1.794 ms] 411.329 µs (30.3%)
iast 1.518 ms [1.494 ms, 1.541 ms] 160.445 µs (11.8%)
profiling 1.561 ms [1.536 ms, 1.586 ms] 203.791 µs (15.0%)
tracing 1.481 ms [1.456 ms, 1.506 ms] 123.9 µs (9.1%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~c06ea4f2df, baseline=1.44.0-SNAPSHOT~d7a0014648
    dateFormat X
    axisFormat %s
section baseline
no_agent (375.611 µs) : 355, 396
.   : milestone, 376,
iast (493.46 µs) : 472, 515
.   : milestone, 493,
iast_FULL (656.257 µs) : 635, 678
.   : milestone, 656,
iast_GLOBAL (529.256 µs) : 506, 552
.   : milestone, 529,
iast_HARDCODED_SECRET_DISABLED (492.521 µs) : 471, 514
.   : milestone, 493,
iast_INACTIVE (457.396 µs) : 436, 479
.   : milestone, 457,
iast_TELEMETRY_OFF (489.695 µs) : 467, 512
.   : milestone, 490,
tracing (457.342 µs) : 436, 479
.   : milestone, 457,
section candidate
no_agent (373.673 µs) : 354, 393
.   : milestone, 374,
iast (492.938 µs) : 471, 514
.   : milestone, 493,
iast_FULL (653.571 µs) : 632, 675
.   : milestone, 654,
iast_GLOBAL (514.655 µs) : 493, 536
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (490.335 µs) : 469, 512
.   : milestone, 490,
iast_INACTIVE (454.678 µs) : 433, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (485.777 µs) : 464, 508
.   : milestone, 486,
tracing (445.968 µs) : 426, 466
.   : milestone, 446,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 375.611 µs [355.365 µs, 395.856 µs] -
iast 493.46 µs [472.123 µs, 514.798 µs] 117.85 µs (31.4%)
iast_FULL 656.257 µs [634.745 µs, 677.77 µs] 280.647 µs (74.7%)
iast_GLOBAL 529.256 µs [506.478 µs, 552.034 µs] 153.645 µs (40.9%)
iast_HARDCODED_SECRET_DISABLED 492.521 µs [470.783 µs, 514.259 µs] 116.91 µs (31.1%)
iast_INACTIVE 457.396 µs [435.732 µs, 479.06 µs] 81.785 µs (21.8%)
iast_TELEMETRY_OFF 489.695 µs [467.149 µs, 512.241 µs] 114.085 µs (30.4%)
tracing 457.342 µs [436.175 µs, 478.509 µs] 81.731 µs (21.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.673 µs [354.085 µs, 393.261 µs] -
iast 492.938 µs [471.376 µs, 514.5 µs] 119.265 µs (31.9%)
iast_FULL 653.571 µs [631.882 µs, 675.259 µs] 279.898 µs (74.9%)
iast_GLOBAL 514.655 µs [493.384 µs, 535.926 µs] 140.983 µs (37.7%)
iast_HARDCODED_SECRET_DISABLED 490.335 µs [468.955 µs, 511.716 µs] 116.663 µs (31.2%)
iast_INACTIVE 454.678 µs [433.305 µs, 476.051 µs] 81.005 µs (21.7%)
iast_TELEMETRY_OFF 485.777 µs [463.905 µs, 507.649 µs] 112.104 µs (30.0%)
tracing 445.968 µs [425.508 µs, 466.428 µs] 72.295 µs (19.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master evanchooly/DEBUG-3159
git_commit_date 1733143408 1733150321
git_commit_sha d7a0014 c06ea4f
release_version 1.44.0-SNAPSHOT~d7a0014648 1.44.0-SNAPSHOT~c06ea4f2df
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1733152297 1733152297
ci_job_id 724524810 724524810
ci_pipeline_id 50210817 50210817
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~c06ea4f2df, baseline=1.44.0-SNAPSHOT~d7a0014648
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.205 s) : 15205000, 15205000
.   : milestone, 15205000,
appsec (14.916 s) : 14916000, 14916000
.   : milestone, 14916000,
iast (18.756 s) : 18756000, 18756000
.   : milestone, 18756000,
iast_GLOBAL (17.905 s) : 17905000, 17905000
.   : milestone, 17905000,
profiling (15.108 s) : 15108000, 15108000
.   : milestone, 15108000,
tracing (15.009 s) : 15009000, 15009000
.   : milestone, 15009000,
section candidate
no_agent (14.954 s) : 14954000, 14954000
.   : milestone, 14954000,
appsec (15.265 s) : 15265000, 15265000
.   : milestone, 15265000,
iast (18.881 s) : 18881000, 18881000
.   : milestone, 18881000,
iast_GLOBAL (18.009 s) : 18009000, 18009000
.   : milestone, 18009000,
profiling (14.946 s) : 14946000, 14946000
.   : milestone, 14946000,
tracing (15.097 s) : 15097000, 15097000
.   : milestone, 15097000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.205 s [15.205 s, 15.205 s] -
appsec 14.916 s [14.916 s, 14.916 s] -289.0 ms (-1.9%)
iast 18.756 s [18.756 s, 18.756 s] 3.551 s (23.4%)
iast_GLOBAL 17.905 s [17.905 s, 17.905 s] 2.7 s (17.8%)
profiling 15.108 s [15.108 s, 15.108 s] -97.0 ms (-0.6%)
tracing 15.009 s [15.009 s, 15.009 s] -196.0 ms (-1.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.954 s [14.954 s, 14.954 s] -
appsec 15.265 s [15.265 s, 15.265 s] 311.0 ms (2.1%)
iast 18.881 s [18.881 s, 18.881 s] 3.927 s (26.3%)
iast_GLOBAL 18.009 s [18.009 s, 18.009 s] 3.055 s (20.4%)
profiling 14.946 s [14.946 s, 14.946 s] -8.0 ms (-0.1%)
tracing 15.097 s [15.097 s, 15.097 s] 143.0 ms (1.0%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~c06ea4f2df, baseline=1.44.0-SNAPSHOT~d7a0014648
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
.   : milestone, 1477,
appsec (2.363 ms) : 2322, 2405
.   : milestone, 2363,
iast (2.095 ms) : 2042, 2147
.   : milestone, 2095,
iast_GLOBAL (2.146 ms) : 2093, 2200
.   : milestone, 2146,
profiling (1.985 ms) : 1942, 2028
.   : milestone, 1985,
tracing (1.946 ms) : 1906, 1987
.   : milestone, 1946,
section candidate
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (2.36 ms) : 2318, 2401
.   : milestone, 2360,
iast (2.094 ms) : 2041, 2147
.   : milestone, 2094,
iast_GLOBAL (2.15 ms) : 2096, 2203
.   : milestone, 2150,
profiling (1.968 ms) : 1925, 2010
.   : milestone, 1968,
tracing (1.946 ms) : 1906, 1987
.   : milestone, 1946,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.465 ms, 1.488 ms] -
appsec 2.363 ms [2.322 ms, 2.405 ms] 886.804 µs (60.1%)
iast 2.095 ms [2.042 ms, 2.147 ms] 618.05 µs (41.9%)
iast_GLOBAL 2.146 ms [2.093 ms, 2.2 ms] 669.746 µs (45.4%)
profiling 1.985 ms [1.942 ms, 2.028 ms] 508.271 µs (34.4%)
tracing 1.946 ms [1.906 ms, 1.987 ms] 469.753 µs (31.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.462 ms, 1.485 ms] -
appsec 2.36 ms [2.318 ms, 2.401 ms] 886.262 µs (60.1%)
iast 2.094 ms [2.041 ms, 2.147 ms] 620.385 µs (42.1%)
iast_GLOBAL 2.15 ms [2.096 ms, 2.203 ms] 675.866 µs (45.9%)
profiling 1.968 ms [1.925 ms, 2.01 ms] 493.835 µs (33.5%)
tracing 1.946 ms [1.906 ms, 1.987 ms] 472.41 µs (32.1%)

@evanchooly evanchooly merged commit 0d905c6 into master Dec 2, 2024
103 checks passed
@evanchooly evanchooly deleted the evanchooly/DEBUG-3159 branch December 2, 2024 15:25
@github-actions github-actions bot added this to the 1.44.0 milestone Dec 2, 2024
@PerfectSlayer PerfectSlayer added tag: no release notes Changes to exclude from release notes tag: performance Performance related changes labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbempel jpbempel jpbempel approved these changes

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation tag: no release notes Changes to exclude from release notes tag: performance Performance related changes
Projects
None yet
Milestone
1.44.0
Development

Successfully merging this pull request may close these issues.
3 participants
@evanchooly @jpbempel @PerfectSlayer