-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log msgp errors in debug mode #7845
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~b56769e59d, baseline=1.42.0-SNAPSHOT~b2332408b0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.586 s) : 0, 1585570
Total [baseline] (11.929 s) : 0, 11929120
Agent [candidate] (1.59 s) : 0, 1589978
Total [candidate] (11.919 s) : 0, 11918850
section iast
Agent [baseline] (1.754 s) : 0, 1754327
Total [baseline] (12.752 s) : 0, 12752038
Agent [candidate] (1.764 s) : 0, 1763891
Total [candidate] (12.861 s) : 0, 12861021
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.764 s) : 0, 1763535
Total [baseline] (12.768 s) : 0, 12768262
Agent [candidate] (1.759 s) : 0, 1758728
Total [candidate] (12.735 s) : 0, 12735197
section iast_TELEMETRY_OFF
Agent [baseline] (1.747 s) : 0, 1747465
Total [baseline] (12.746 s) : 0, 12746102
Agent [candidate] (1.747 s) : 0, 1746933
Total [candidate] (12.775 s) : 0, 12774734
gantt
title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~b56769e59d, baseline=1.42.0-SNAPSHOT~b2332408b0
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (1.012 s) : 0, 1011814
BytebuddyAgent [candidate] (1.016 s) : 0, 1016143
GlobalTracer [baseline] (463.993 ms) : 0, 463993
GlobalTracer [candidate] (466.207 ms) : 0, 466207
AppSec [baseline] (76.831 ms) : 0, 76831
AppSec [candidate] (76.728 ms) : 0, 76728
Remote Config [baseline] (804.076 µs) : 0, 804
Remote Config [candidate] (813.43 µs) : 0, 813
Telemetry [baseline] (11.966 ms) : 0, 11966
Telemetry [candidate] (9.761 ms) : 0, 9761
section iast
BytebuddyAgent [baseline] (1.176 s) : 0, 1176125
BytebuddyAgent [candidate] (1.182 s) : 0, 1181769
GlobalTracer [baseline] (442.606 ms) : 0, 442606
GlobalTracer [candidate] (445.304 ms) : 0, 445304
AppSec [baseline] (79.276 ms) : 0, 79276
AppSec [candidate] (77.951 ms) : 0, 77951
IAST [baseline] (25.938 ms) : 0, 25938
IAST [candidate] (28.151 ms) : 0, 28151
Remote Config [baseline] (741.261 µs) : 0, 741
Remote Config [candidate] (767.578 µs) : 0, 768
Telemetry [baseline] (9.454 ms) : 0, 9454
Telemetry [candidate] (9.602 ms) : 0, 9602
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.182 s) : 0, 1181955
BytebuddyAgent [candidate] (1.179 s) : 0, 1178586
GlobalTracer [baseline] (445.213 ms) : 0, 445213
GlobalTracer [candidate] (442.915 ms) : 0, 442915
AppSec [baseline] (78.778 ms) : 0, 78778
AppSec [candidate] (78.096 ms) : 0, 78096
IAST [baseline] (26.91 ms) : 0, 26910
IAST [candidate] (27.884 ms) : 0, 27884
Remote Config [baseline] (765.05 µs) : 0, 765
Remote Config [candidate] (785.67 µs) : 0, 786
Telemetry [baseline] (9.593 ms) : 0, 9593
Telemetry [candidate] (10.113 ms) : 0, 10113
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.17 s) : 0, 1169967
BytebuddyAgent [candidate] (1.169 s) : 0, 1169031
GlobalTracer [baseline] (442.347 ms) : 0, 442347
GlobalTracer [candidate] (442.002 ms) : 0, 442002
AppSec [baseline] (78.542 ms) : 0, 78542
AppSec [candidate] (76.256 ms) : 0, 76256
IAST [baseline] (26.325 ms) : 0, 26325
IAST [candidate] (29.367 ms) : 0, 29367
Remote Config [baseline] (762.442 µs) : 0, 762
Remote Config [candidate] (749.423 µs) : 0, 749
Telemetry [baseline] (9.341 ms) : 0, 9341
Telemetry [candidate] (9.299 ms) : 0, 9299
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~b56769e59d, baseline=1.42.0-SNAPSHOT~b2332408b0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.596 s) : 0, 1596078
Total [baseline] (14.347 s) : 0, 14347427
Agent [candidate] (1.589 s) : 0, 1589272
Total [candidate] (14.439 s) : 0, 14439326
section appsec
Agent [baseline] (1.785 s) : 0, 1784956
Total [baseline] (14.592 s) : 0, 14591819
Agent [candidate] (1.789 s) : 0, 1789214
Total [candidate] (14.612 s) : 0, 14611724
section iast
Agent [baseline] (1.761 s) : 0, 1760692
Total [baseline] (15.016 s) : 0, 15015763
Agent [candidate] (1.756 s) : 0, 1756463
Total [candidate] (14.988 s) : 0, 14988197
section profiling
Agent [baseline] (1.919 s) : 0, 1918516
Total [baseline] (14.678 s) : 0, 14677675
Agent [candidate] (1.912 s) : 0, 1911962
Total [candidate] (14.585 s) : 0, 14585109
gantt
title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~b56769e59d, baseline=1.42.0-SNAPSHOT~b2332408b0
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (1.019 s) : 0, 1019395
BytebuddyAgent [candidate] (1.015 s) : 0, 1014766
GlobalTracer [baseline] (467.171 ms) : 0, 467171
GlobalTracer [candidate] (465.563 ms) : 0, 465563
AppSec [baseline] (77.097 ms) : 0, 77097
AppSec [candidate] (77.319 ms) : 0, 77319
Remote Config [baseline] (815.796 µs) : 0, 816
Remote Config [candidate] (814.051 µs) : 0, 814
Telemetry [baseline] (11.269 ms) : 0, 11269
Telemetry [candidate] (10.518 ms) : 0, 10518
section appsec
BytebuddyAgent [baseline] (1.037 s) : 0, 1037203
BytebuddyAgent [candidate] (1.04 s) : 0, 1039740
GlobalTracer [baseline] (460.306 ms) : 0, 460306
GlobalTracer [candidate] (461.241 ms) : 0, 461241
AppSec [baseline] (243.115 ms) : 0, 243115
AppSec [candidate] (243.473 ms) : 0, 243473
IAST [baseline] (24.675 ms) : 0, 24675
IAST [candidate] (27.446 ms) : 0, 27446
Remote Config [baseline] (780.166 µs) : 0, 780
Remote Config [candidate] (796.896 µs) : 0, 797
Telemetry [baseline] (11.056 ms) : 0, 11056
Telemetry [candidate] (9.959 ms) : 0, 9959
section iast
BytebuddyAgent [baseline] (1.181 s) : 0, 1181401
BytebuddyAgent [candidate] (1.177 s) : 0, 1176769
GlobalTracer [baseline] (443.092 ms) : 0, 443092
GlobalTracer [candidate] (443.043 ms) : 0, 443043
AppSec [baseline] (78.779 ms) : 0, 78779
AppSec [candidate] (78.965 ms) : 0, 78965
IAST [baseline] (26.92 ms) : 0, 26920
IAST [candidate] (26.977 ms) : 0, 26977
Remote Config [baseline] (752.82 µs) : 0, 753
Remote Config [candidate] (753.378 µs) : 0, 753
Telemetry [baseline] (9.462 ms) : 0, 9462
Telemetry [candidate] (9.603 ms) : 0, 9603
section profiling
BytebuddyAgent [baseline] (1.007 s) : 0, 1006813
BytebuddyAgent [candidate] (1.005 s) : 0, 1004820
GlobalTracer [baseline] (595.181 ms) : 0, 595181
GlobalTracer [candidate] (593.447 ms) : 0, 593447
AppSec [baseline] (78.129 ms) : 0, 78129
AppSec [candidate] (77.638 ms) : 0, 77638
Remote Config [baseline] (834.908 µs) : 0, 835
Remote Config [candidate] (835.749 µs) : 0, 836
Telemetry [baseline] (13.797 ms) : 0, 13797
Telemetry [candidate] (13.862 ms) : 0, 13862
ProfilingAgent [baseline] (166.039 ms) : 0, 166039
ProfilingAgent [candidate] (163.614 ms) : 0, 163614
Profiling [baseline] (166.093 ms) : 0, 166093
Profiling [candidate] (163.668 ms) : 0, 163668
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 7 metrics, 21 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~b56769e59d, baseline=1.42.0-SNAPSHOT~b2332408b0
dateFormat X
axisFormat %s
section baseline
no_agent (451.543 µs) : 423, 480
. : milestone, 452,
iast (586.24 µs) : 554, 619
. : milestone, 586,
iast_FULL (829.279 µs) : 796, 862
. : milestone, 829,
iast_GLOBAL (628.275 µs) : 595, 662
. : milestone, 628,
iast_HARDCODED_SECRET_DISABLED (584.346 µs) : 552, 617
. : milestone, 584,
iast_INACTIVE (539.092 µs) : 508, 570
. : milestone, 539,
iast_TELEMETRY_OFF (575.885 µs) : 544, 608
. : milestone, 576,
tracing (534.236 µs) : 504, 564
. : milestone, 534,
section candidate
no_agent (446.703 µs) : 418, 475
. : milestone, 447,
iast (587.052 µs) : 554, 620
. : milestone, 587,
iast_FULL (838.265 µs) : 805, 871
. : milestone, 838,
iast_GLOBAL (630.468 µs) : 597, 664
. : milestone, 630,
iast_HARDCODED_SECRET_DISABLED (585.574 µs) : 553, 618
. : milestone, 586,
iast_INACTIVE (555.86 µs) : 525, 587
. : milestone, 556,
iast_TELEMETRY_OFF (583.334 µs) : 551, 616
. : milestone, 583,
tracing (535.68 µs) : 506, 565
. : milestone, 536,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~b56769e59d, baseline=1.42.0-SNAPSHOT~b2332408b0
dateFormat X
axisFormat %s
section baseline
no_agent (1.724 ms) : 1698, 1750
. : milestone, 1724,
appsec (2.187 ms) : 2157, 2217
. : milestone, 2187,
appsec_no_iast (2.203 ms) : 2172, 2235
. : milestone, 2203,
iast (1.893 ms) : 1864, 1922
. : milestone, 1893,
profiling (1.904 ms) : 1874, 1934
. : milestone, 1904,
tracing (1.882 ms) : 1850, 1913
. : milestone, 1882,
section candidate
no_agent (1.719 ms) : 1694, 1744
. : milestone, 1719,
appsec (2.189 ms) : 2157, 2221
. : milestone, 2189,
appsec_no_iast (2.159 ms) : 2128, 2190
. : milestone, 2159,
iast (1.902 ms) : 1872, 1932
. : milestone, 1902,
profiling (1.927 ms) : 1893, 1960
. : milestone, 1927,
tracing (1.86 ms) : 1829, 1892
. : milestone, 1860,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~b56769e59d, baseline=1.42.0-SNAPSHOT~b2332408b0
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1452, 1475
. : milestone, 1464,
appsec (2.32 ms) : 2278, 2361
. : milestone, 2320,
iast (2.075 ms) : 2023, 2127
. : milestone, 2075,
iast_GLOBAL (2.103 ms) : 2051, 2154
. : milestone, 2103,
profiling (1.926 ms) : 1885, 1967
. : milestone, 1926,
tracing (1.905 ms) : 1865, 1945
. : milestone, 1905,
section candidate
no_agent (1.458 ms) : 1447, 1470
. : milestone, 1458,
appsec (2.32 ms) : 2279, 2361
. : milestone, 2320,
iast (2.085 ms) : 2033, 2138
. : milestone, 2085,
iast_GLOBAL (2.12 ms) : 2067, 2173
. : milestone, 2120,
profiling (1.933 ms) : 1891, 1976
. : milestone, 1933,
tracing (1.905 ms) : 1865, 1944
. : milestone, 1905,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~b56769e59d, baseline=1.42.0-SNAPSHOT~b2332408b0
dateFormat X
axisFormat %s
section baseline
no_agent (15.697 s) : 15697000, 15697000
. : milestone, 15697000,
appsec (15.249 s) : 15249000, 15249000
. : milestone, 15249000,
iast (18.552 s) : 18552000, 18552000
. : milestone, 18552000,
iast_GLOBAL (18.191 s) : 18191000, 18191000
. : milestone, 18191000,
profiling (15.146 s) : 15146000, 15146000
. : milestone, 15146000,
tracing (15.174 s) : 15174000, 15174000
. : milestone, 15174000,
section candidate
no_agent (15.584 s) : 15584000, 15584000
. : milestone, 15584000,
appsec (15.0 s) : 15000000, 15000000
. : milestone, 15000000,
iast (20.128 s) : 20128000, 20128000
. : milestone, 20128000,
iast_GLOBAL (18.072 s) : 18072000, 18072000
. : milestone, 18072000,
profiling (14.924 s) : 14924000, 14924000
. : milestone, 14924000,
tracing (15.38 s) : 15380000, 15380000
. : milestone, 15380000,
|
closing in favor of this proposal: https://docs.google.com/document/d/14k1ek086zE86t18VP64R6Z-A34d07qqXvRECM36scV4 |
What Does This Do
Logs in debug level the raw content of the request we sent when we get a message pack error from the agent
Motivation
msgp errors are pretty hard to decypher on their own, but having the bytes when an error happens might help us see what is happening
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APMS-13424