Improve config mapping for OpenTelemetry extensions #7194

mcculls · 2024-06-14T11:14:23Z

Backport of #7193 for v1.35.1

…nces

…xisting mappings as well as experimental packages

…by existing mappings as well as experimental packages As part of this we redirect CallDepth requests to our own CallDepthThreadLocalMap

…tel-bootstrap

pr-commenter · 2024-06-14T12:06:49Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/map-otel-config-for-dropin-v1.35.1
git_commit_date	1718370692	1718365940
git_commit_sha	`33a2dcd`	`ca480b0`
release_version	1.36.0-SNAPSHOT~33a2dcd37c	1.36.0-SNAPSHOT~ca480b0038

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1718374774	1718374774
ci_job_id	543757130	543757130
ci_pipeline_id	36767092	36767092
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 17 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~ca480b0038, baseline=1.36.0-SNAPSHOT~33a2dcd37c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1059942
Total [baseline] (10.315 s) : 0, 10314673
Agent [candidate] (1.07 s) : 0, 1069987
Total [candidate] (10.311 s) : 0, 10310536
section appsec
Agent [baseline] (1.182 s) : 0, 1181793
Total [baseline] (10.48 s) : 0, 10480418
Agent [candidate] (1.186 s) : 0, 1186452
Total [candidate] (10.457 s) : 0, 10457318
section iast
Agent [baseline] (1.178 s) : 0, 1178201
Total [baseline] (10.766 s) : 0, 10765947
Agent [candidate] (1.169 s) : 0, 1168518
Total [candidate] (10.675 s) : 0, 10675266
section profiling
Agent [baseline] (1.279 s) : 0, 1279439
Total [baseline] (10.672 s) : 0, 10672393
Agent [candidate] (1.258 s) : 0, 1257820
Total [candidate] (10.647 s) : 0, 10647054

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.06 s	-
Agent	appsec	1.182 s	121.851 ms (11.5%)
Agent	iast	1.178 s	118.259 ms (11.2%)
Agent	profiling	1.279 s	219.497 ms (20.7%)
Total	tracing	10.315 s	-
Total	appsec	10.48 s	165.744 ms (1.6%)
Total	iast	10.766 s	451.274 ms (4.4%)
Total	profiling	10.672 s	357.72 ms (3.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.07 s	-
Agent	appsec	1.186 s	116.466 ms (10.9%)
Agent	iast	1.169 s	98.531 ms (9.2%)
Agent	profiling	1.258 s	187.833 ms (17.6%)
Total	tracing	10.311 s	-
Total	appsec	10.457 s	146.782 ms (1.4%)
Total	iast	10.675 s	364.73 ms (3.5%)
Total	profiling	10.647 s	336.519 ms (3.3%)

gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~ca480b0038, baseline=1.36.0-SNAPSHOT~33a2dcd37c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.404 ms) : 0, 664404
BytebuddyAgent [candidate] (670.089 ms) : 0, 670089
GlobalTracer [baseline] (302.737 ms) : 0, 302737
GlobalTracer [candidate] (305.826 ms) : 0, 305826
AppSec [baseline] (50.0 ms) : 0, 50000
AppSec [candidate] (50.601 ms) : 0, 50601
Logs Intake [baseline] (331.846 µs) : 0, 332
Logs Intake [candidate] (406.096 µs) : 0, 406
Remote Config [baseline] (666.486 µs) : 0, 666
Remote Config [candidate] (683.747 µs) : 0, 684
Telemetry [baseline] (7.494 ms) : 0, 7494
Telemetry [candidate] (7.54 ms) : 0, 7540
section appsec
BytebuddyAgent [baseline] (675.752 ms) : 0, 675752
BytebuddyAgent [candidate] (680.048 ms) : 0, 680048
GlobalTracer [baseline] (296.99 ms) : 0, 296990
GlobalTracer [candidate] (297.932 ms) : 0, 297932
AppSec [baseline] (154.037 ms) : 0, 154037
AppSec [candidate] (153.111 ms) : 0, 153111
IAST [baseline] (21.698 ms) : 0, 21698
IAST [candidate] (22.48 ms) : 0, 22480
Logs Intake [baseline] (326.319 µs) : 0, 326
Logs Intake [candidate] (330.343 µs) : 0, 330
Remote Config [baseline] (639.104 µs) : 0, 639
Remote Config [candidate] (648.244 µs) : 0, 648
Telemetry [baseline] (8.823 ms) : 0, 8823
Telemetry [candidate] (8.484 ms) : 0, 8484
section iast
BytebuddyAgent [baseline] (785.672 ms) : 0, 785672
BytebuddyAgent [candidate] (779.087 ms) : 0, 779087
GlobalTracer [baseline] (295.193 ms) : 0, 295193
GlobalTracer [candidate] (293.234 ms) : 0, 293234
AppSec [baseline] (47.606 ms) : 0, 47606
AppSec [candidate] (47.078 ms) : 0, 47078
IAST [baseline] (27.576 ms) : 0, 27576
IAST [candidate] (27.197 ms) : 0, 27197
Logs Intake [baseline] (1.113 ms) : 0, 1113
Logs Intake [candidate] (301.377 µs) : 0, 301
Remote Config [baseline] (704.947 µs) : 0, 705
Remote Config [candidate] (578.896 µs) : 0, 579
Telemetry [baseline] (6.985 ms) : 0, 6985
Telemetry [candidate] (7.711 ms) : 0, 7711
section profiling
BytebuddyAgent [baseline] (673.27 ms) : 0, 673270
BytebuddyAgent [candidate] (661.644 ms) : 0, 661644
GlobalTracer [baseline] (390.342 ms) : 0, 390342
GlobalTracer [candidate] (384.708 ms) : 0, 384708
AppSec [baseline] (52.176 ms) : 0, 52176
AppSec [candidate] (50.433 ms) : 0, 50433
Logs Intake [baseline] (349.372 µs) : 0, 349
Logs Intake [candidate] (330.868 µs) : 0, 331
Remote Config [baseline] (707.406 µs) : 0, 707
Remote Config [candidate] (729.973 µs) : 0, 730
Telemetry [baseline] (7.538 ms) : 0, 7538
Telemetry [candidate] (7.383 ms) : 0, 7383
ProfilingAgent [baseline] (97.239 ms) : 0, 97239
ProfilingAgent [candidate] (95.833 ms) : 0, 95833
Profiling [baseline] (97.264 ms) : 0, 97264
Profiling [candidate] (95.858 ms) : 0, 95858

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~ca480b0038, baseline=1.36.0-SNAPSHOT~33a2dcd37c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069286
Total [baseline] (8.546 s) : 0, 8545592
Agent [candidate] (1.068 s) : 0, 1067583
Total [candidate] (8.584 s) : 0, 8583977
section iast
Agent [baseline] (1.179 s) : 0, 1179147
Total [baseline] (9.038 s) : 0, 9038353
Agent [candidate] (1.169 s) : 0, 1168984
Total [candidate] (9.01 s) : 0, 9009521
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.178 s) : 0, 1177685
Total [baseline] (8.965 s) : 0, 8965151
Agent [candidate] (1.169 s) : 0, 1168763
Total [candidate] (9.022 s) : 0, 9022051
section iast_TELEMETRY_OFF
Agent [baseline] (1.175 s) : 0, 1174734
Total [baseline] (8.986 s) : 0, 8985836
Agent [candidate] (1.166 s) : 0, 1165524
Total [candidate] (8.986 s) : 0, 8986129

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.069 s	-
Agent	iast	1.179 s	109.861 ms (10.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.178 s	108.399 ms (10.1%)
Agent	iast_TELEMETRY_OFF	1.175 s	105.448 ms (9.9%)
Total	tracing	8.546 s	-
Total	iast	9.038 s	492.761 ms (5.8%)
Total	iast_HARDCODED_SECRET_DISABLED	8.965 s	419.559 ms (4.9%)
Total	iast_TELEMETRY_OFF	8.986 s	440.244 ms (5.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.068 s	-
Agent	iast	1.169 s	101.401 ms (9.5%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.169 s	101.181 ms (9.5%)
Agent	iast_TELEMETRY_OFF	1.166 s	97.941 ms (9.2%)
Total	tracing	8.584 s	-
Total	iast	9.01 s	425.544 ms (5.0%)
Total	iast_HARDCODED_SECRET_DISABLED	9.022 s	438.074 ms (5.1%)
Total	iast_TELEMETRY_OFF	8.986 s	402.152 ms (4.7%)

gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~ca480b0038, baseline=1.36.0-SNAPSHOT~33a2dcd37c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.908 ms) : 0, 669908
BytebuddyAgent [candidate] (669.166 ms) : 0, 669166
GlobalTracer [baseline] (305.206 ms) : 0, 305206
GlobalTracer [candidate] (304.915 ms) : 0, 304915
AppSec [baseline] (50.881 ms) : 0, 50881
AppSec [candidate] (50.183 ms) : 0, 50183
Logs Intake [baseline] (333.212 µs) : 0, 333
Logs Intake [candidate] (391.935 µs) : 0, 392
Remote Config [baseline] (679.641 µs) : 0, 680
Remote Config [candidate] (681.585 µs) : 0, 682
Telemetry [baseline] (7.635 ms) : 0, 7635
Telemetry [candidate] (7.634 ms) : 0, 7634
section iast
BytebuddyAgent [baseline] (786.449 ms) : 0, 786449
BytebuddyAgent [candidate] (780.13 ms) : 0, 780130
GlobalTracer [baseline] (295.428 ms) : 0, 295428
GlobalTracer [candidate] (293.685 ms) : 0, 293685
AppSec [baseline] (47.486 ms) : 0, 47486
AppSec [candidate] (47.204 ms) : 0, 47204
IAST [baseline] (26.845 ms) : 0, 26845
IAST [candidate] (25.403 ms) : 0, 25403
Logs Intake [baseline] (325.301 µs) : 0, 325
Logs Intake [candidate] (966.902 µs) : 0, 967
Remote Config [baseline] (652.726 µs) : 0, 653
Remote Config [candidate] (1.388 ms) : 0, 1388
Telemetry [baseline] (8.554 ms) : 0, 8554
Telemetry [candidate] (6.949 ms) : 0, 6949
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (785.35 ms) : 0, 785350
BytebuddyAgent [candidate] (779.466 ms) : 0, 779466
GlobalTracer [baseline] (295.555 ms) : 0, 295555
GlobalTracer [candidate] (293.724 ms) : 0, 293724
AppSec [baseline] (47.694 ms) : 0, 47694
AppSec [candidate] (46.62 ms) : 0, 46620
IAST [baseline] (26.173 ms) : 0, 26173
IAST [candidate] (24.696 ms) : 0, 24696
Logs Intake [baseline] (301.623 µs) : 0, 302
Logs Intake [candidate] (301.218 µs) : 0, 301
Remote Config [baseline] (656.11 µs) : 0, 656
Remote Config [candidate] (575.451 µs) : 0, 575
Telemetry [baseline] (7.732 ms) : 0, 7732
Telemetry [candidate] (10.062 ms) : 0, 10062
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (782.836 ms) : 0, 782836
BytebuddyAgent [candidate] (777.982 ms) : 0, 777982
GlobalTracer [baseline] (294.958 ms) : 0, 294958
GlobalTracer [candidate] (293.537 ms) : 0, 293537
AppSec [baseline] (47.718 ms) : 0, 47718
AppSec [candidate] (46.695 ms) : 0, 46695
IAST [baseline] (28.051 ms) : 0, 28051
IAST [candidate] (26.264 ms) : 0, 26264
Logs Intake [baseline] (300.247 µs) : 0, 300
Logs Intake [candidate] (303.697 µs) : 0, 304
Remote Config [baseline] (571.014 µs) : 0, 571
Remote Config [candidate] (571.233 µs) : 0, 571
Telemetry [baseline] (6.858 ms) : 0, 6858
Telemetry [candidate] (6.833 ms) : 0, 6833

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-06-14T12:11:59	2024-06-14T12:18:46
git_branch	master	mcculls/map-otel-config-for-dropin-v1.35.1
git_commit_date	1718365351	1718365940
git_commit_sha	`24d82a5`	`ca480b0`
release_version	1.36.0-SNAPSHOT~24d82a55c1	1.36.0-SNAPSHOT~ca480b0038
start_time	2024-06-14T12:11:46	2024-06-14T12:18:33

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1718367870	1718367870
ci_job_id	543580396	543580396
ci_pipeline_id	36767092	36767092
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 2 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 16 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:iast	better [-59.158µs; -12.518µs] or [-12.151%; -2.571%]	unstable [-2712.367op/s; +2712.367op/s] or [-31.644%; +31.644%]	451.030µs	8571.429op/s	486.868µs	8571.429op/s
scenario:load:insecure-bank:tracing	better [-62.167µs; -18.077µs] or [-13.819%; -4.019%]	unstable [-3088.321op/s; +3088.321op/s] or [-33.457%; +33.457%]	409.727µs	9230.769op/s	449.848µs	9230.769op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~ca480b0038, baseline=1.36.0-SNAPSHOT~24d82a55c1
    dateFormat X
    axisFormat %s
section baseline
no_agent (373.173 µs) : 354, 393
.   : milestone, 373,
iast (486.868 µs) : 465, 509
.   : milestone, 487,
iast_FULL (547.382 µs) : 526, 569
.   : milestone, 547,
iast_GLOBAL (510.688 µs) : 489, 532
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (480.228 µs) : 459, 501
.   : milestone, 480,
iast_INACTIVE (452.405 µs) : 431, 474
.   : milestone, 452,
iast_TELEMETRY_OFF (473.635 µs) : 452, 495
.   : milestone, 474,
tracing (449.848 µs) : 429, 471
.   : milestone, 450,
section candidate
no_agent (360.894 µs) : 341, 380
.   : milestone, 361,
iast (451.03 µs) : 430, 472
.   : milestone, 451,
iast_FULL (551.865 µs) : 530, 573
.   : milestone, 552,
iast_GLOBAL (486.138 µs) : 465, 507
.   : milestone, 486,
iast_HARDCODED_SECRET_DISABLED (481.803 µs) : 461, 503
.   : milestone, 482,
iast_INACTIVE (455.496 µs) : 434, 477
.   : milestone, 455,
iast_TELEMETRY_OFF (470.227 µs) : 449, 492
.   : milestone, 470,
tracing (409.727 µs) : 389, 430
.   : milestone, 410,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	373.173 µs [353.686 µs, 392.66 µs]	-
iast	486.868 µs [464.696 µs, 509.04 µs]	113.694 µs (30.5%)
iast_FULL	547.382 µs [526.097 µs, 568.667 µs]	174.208 µs (46.7%)
iast_GLOBAL	510.688 µs [488.991 µs, 532.385 µs]	137.515 µs (36.9%)
iast_HARDCODED_SECRET_DISABLED	480.228 µs [459.37 µs, 501.085 µs]	107.055 µs (28.7%)
iast_INACTIVE	452.405 µs [430.704 µs, 474.107 µs]	79.232 µs (21.2%)
iast_TELEMETRY_OFF	473.635 µs [452.046 µs, 495.224 µs]	100.462 µs (26.9%)
tracing	449.848 µs [429.171 µs, 470.526 µs]	76.675 µs (20.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	360.894 µs [341.358 µs, 380.43 µs]	-
iast	451.03 µs [429.871 µs, 472.188 µs]	90.136 µs (25.0%)
iast_FULL	551.865 µs [530.455 µs, 573.276 µs]	190.971 µs (52.9%)
iast_GLOBAL	486.138 µs [465.262 µs, 507.015 µs]	125.244 µs (34.7%)
iast_HARDCODED_SECRET_DISABLED	481.803 µs [460.853 µs, 502.753 µs]	120.909 µs (33.5%)
iast_INACTIVE	455.496 µs [433.702 µs, 477.29 µs]	94.602 µs (26.2%)
iast_TELEMETRY_OFF	470.227 µs [448.848 µs, 491.606 µs]	109.333 µs (30.3%)
tracing	409.727 µs [389.434 µs, 430.019 µs]	48.832 µs (13.5%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~ca480b0038, baseline=1.36.0-SNAPSHOT~24d82a55c1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.35 ms) : 1331, 1369
.   : milestone, 1350,
appsec (1.722 ms) : 1698, 1746
.   : milestone, 1722,
appsec_no_iast (1.706 ms) : 1681, 1731
.   : milestone, 1706,
iast (1.49 ms) : 1469, 1512
.   : milestone, 1490,
profiling (1.482 ms) : 1457, 1507
.   : milestone, 1482,
tracing (1.456 ms) : 1431, 1481
.   : milestone, 1456,
section candidate
no_agent (1.351 ms) : 1332, 1370
.   : milestone, 1351,
appsec (1.709 ms) : 1685, 1734
.   : milestone, 1709,
appsec_no_iast (1.735 ms) : 1711, 1760
.   : milestone, 1735,
iast (1.495 ms) : 1471, 1519
.   : milestone, 1495,
profiling (1.484 ms) : 1459, 1508
.   : milestone, 1484,
tracing (1.469 ms) : 1445, 1493
.   : milestone, 1469,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.35 ms [1.331 ms, 1.369 ms]	-
appsec	1.722 ms [1.698 ms, 1.746 ms]	371.832 µs (27.5%)
appsec_no_iast	1.706 ms [1.681 ms, 1.731 ms]	355.525 µs (26.3%)
iast	1.49 ms [1.469 ms, 1.512 ms]	140.124 µs (10.4%)
profiling	1.482 ms [1.457 ms, 1.507 ms]	132.095 µs (9.8%)
tracing	1.456 ms [1.431 ms, 1.481 ms]	106.05 µs (7.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.351 ms [1.332 ms, 1.37 ms]	-
appsec	1.709 ms [1.685 ms, 1.734 ms]	358.25 µs (26.5%)
appsec_no_iast	1.735 ms [1.711 ms, 1.76 ms]	384.036 µs (28.4%)
iast	1.495 ms [1.471 ms, 1.519 ms]	143.888 µs (10.6%)
profiling	1.484 ms [1.459 ms, 1.508 ms]	132.459 µs (9.8%)
tracing	1.469 ms [1.445 ms, 1.493 ms]	117.674 µs (8.7%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/map-otel-config-for-dropin-v1.35.1
git_commit_date	1718365351	1718365940
git_commit_sha	`24d82a5`	`ca480b0`
release_version	1.36.0-SNAPSHOT~24d82a55c1	1.36.0-SNAPSHOT~ca480b0038

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1718368380	1718368380
ci_job_id	543580397	543580397
ci_pipeline_id	36767092	36767092
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~ca480b0038, baseline=1.36.0-SNAPSHOT~24d82a55c1
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.529 s) : 15529000, 15529000
.   : milestone, 15529000,
appsec (15.138 s) : 15138000, 15138000
.   : milestone, 15138000,
iast (18.679 s) : 18679000, 18679000
.   : milestone, 18679000,
iast_GLOBAL (17.85 s) : 17850000, 17850000
.   : milestone, 17850000,
profiling (15.359 s) : 15359000, 15359000
.   : milestone, 15359000,
tracing (15.148 s) : 15148000, 15148000
.   : milestone, 15148000,
section candidate
no_agent (15.101 s) : 15101000, 15101000
.   : milestone, 15101000,
appsec (15.303 s) : 15303000, 15303000
.   : milestone, 15303000,
iast (18.811 s) : 18811000, 18811000
.   : milestone, 18811000,
iast_GLOBAL (17.796 s) : 17796000, 17796000
.   : milestone, 17796000,
profiling (15.339 s) : 15339000, 15339000
.   : milestone, 15339000,
tracing (15.382 s) : 15382000, 15382000
.   : milestone, 15382000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.529 s [15.529 s, 15.529 s]	-
appsec	15.138 s [15.138 s, 15.138 s]	-391.0 ms (-2.5%)
iast	18.679 s [18.679 s, 18.679 s]	3.15 s (20.3%)
iast_GLOBAL	17.85 s [17.85 s, 17.85 s]	2.321 s (14.9%)
profiling	15.359 s [15.359 s, 15.359 s]	-170.0 ms (-1.1%)
tracing	15.148 s [15.148 s, 15.148 s]	-381.0 ms (-2.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.101 s [15.101 s, 15.101 s]	-
appsec	15.303 s [15.303 s, 15.303 s]	202.0 ms (1.3%)
iast	18.811 s [18.811 s, 18.811 s]	3.71 s (24.6%)
iast_GLOBAL	17.796 s [17.796 s, 17.796 s]	2.695 s (17.8%)
profiling	15.339 s [15.339 s, 15.339 s]	238.0 ms (1.6%)
tracing	15.382 s [15.382 s, 15.382 s]	281.0 ms (1.9%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~ca480b0038, baseline=1.36.0-SNAPSHOT~24d82a55c1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.458 ms) : 1446, 1469
.   : milestone, 1458,
appsec (2.203 ms) : 2169, 2238
.   : milestone, 2203,
iast (1.952 ms) : 1911, 1993
.   : milestone, 1952,
iast_GLOBAL (2.001 ms) : 1960, 2042
.   : milestone, 2001,
profiling (1.804 ms) : 1771, 1836
.   : milestone, 1804,
tracing (1.82 ms) : 1788, 1851
.   : milestone, 1820,
section candidate
no_agent (1.46 ms) : 1448, 1471
.   : milestone, 1460,
appsec (2.186 ms) : 2153, 2220
.   : milestone, 2186,
iast (1.958 ms) : 1916, 1999
.   : milestone, 1958,
iast_GLOBAL (1.992 ms) : 1951, 2032
.   : milestone, 1992,
profiling (1.837 ms) : 1804, 1870
.   : milestone, 1837,
tracing (1.82 ms) : 1788, 1852
.   : milestone, 1820,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.458 ms [1.446 ms, 1.469 ms]	-
appsec	2.203 ms [2.169 ms, 2.238 ms]	745.756 µs (51.2%)
iast	1.952 ms [1.911 ms, 1.993 ms]	494.299 µs (33.9%)
iast_GLOBAL	2.001 ms [1.96 ms, 2.042 ms]	543.4 µs (37.3%)
profiling	1.804 ms [1.771 ms, 1.836 ms]	345.96 µs (23.7%)
tracing	1.82 ms [1.788 ms, 1.851 ms]	361.939 µs (24.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.46 ms [1.448 ms, 1.471 ms]	-
appsec	2.186 ms [2.153 ms, 2.22 ms]	726.535 µs (49.8%)
iast	1.958 ms [1.916 ms, 1.999 ms]	497.661 µs (34.1%)
iast_GLOBAL	1.992 ms [1.951 ms, 2.032 ms]	532.037 µs (36.4%)
profiling	1.837 ms [1.804 ms, 1.87 ms]	376.856 µs (25.8%)
tracing	1.82 ms [1.788 ms, 1.852 ms]	360.336 µs (24.7%)

PerfectSlayer

Same review as #7193

mcculls added 9 commits June 14, 2024 12:11

Support arbitrary lookup of 'otel.' config from extensions

0218543

Use property for OTel API version

cfcd363

Don't embed unnecessary classes

b46f28a

Use includes to control which areas of the OTel API we embed

c1799f2

Rework OTel package remapper to remap both shaded and unshaded refere…

5e27370

…nces

Embed OTel instrumentation API, removing classes already covered by e…

f98175e

…xisting mappings as well as experimental packages

Embed OTel javaagent-extension API, removing classes already covered …

b733381

…by existing mappings as well as experimental packages As part of this we redirect CallDepth requests to our own CallDepthThreadLocalMap

Embed opentelemetry-javaagent-servlet-common-bootstrap

12eae44

Redirect InstrumentationConfig requests to our own ConfigProvider

4b5be0e

mcculls added the inst: opentelemetry OpenTelemetry instrumentation label Jun 14, 2024

mcculls requested a review from a team as a code owner June 14, 2024 11:14

mcculls requested review from PerfectSlayer and ygree June 14, 2024 11:14

Ignore partial build class-path when checking for forbidden APIs in o…

ca480b0

…tel-bootstrap

mcculls added this to the 1.35.1 milestone Jun 14, 2024

PerfectSlayer approved these changes Jun 17, 2024

View reviewed changes

mcculls merged commit 8d4028b into release/v1.35.x Jun 17, 2024

mcculls deleted the mcculls/map-otel-config-for-dropin-v1.35.1 branch June 17, 2024 09:13

mcculls modified the milestones: 1.35.1, 1.35.2 Jun 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve config mapping for OpenTelemetry extensions #7194

Improve config mapping for OpenTelemetry extensions #7194

Uh oh!

mcculls commented Jun 14, 2024

Uh oh!

pr-commenter bot commented Jun 14, 2024 •

edited

Loading

Uh oh!

PerfectSlayer left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Improve config mapping for OpenTelemetry extensions #7194

Improve config mapping for OpenTelemetry extensions #7194

Uh oh!

Conversation

mcculls commented Jun 14, 2024

Uh oh!

pr-commenter bot commented Jun 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pr-commenter bot commented Jun 14, 2024 •

edited

Loading