-
Notifications
You must be signed in to change notification settings - Fork 317
Map OpenTelemetry muzzle references to Datadog equivalent #7172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 17 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~89ede03f6d, baseline=1.36.0-SNAPSHOT~222ce2c65e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1068381
Total [baseline] (8.577 s) : 0, 8577184
Agent [candidate] (1.067 s) : 0, 1067103
Total [candidate] (8.546 s) : 0, 8545540
section iast
Agent [baseline] (1.166 s) : 0, 1166179
Total [baseline] (8.998 s) : 0, 8997907
Agent [candidate] (1.174 s) : 0, 1174325
Total [candidate] (8.995 s) : 0, 8994985
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.168 s) : 0, 1168160
Total [baseline] (8.983 s) : 0, 8983322
Agent [candidate] (1.177 s) : 0, 1177433
Total [candidate] (8.975 s) : 0, 8974990
section iast_TELEMETRY_OFF
Agent [baseline] (1.163 s) : 0, 1163059
Total [baseline] (8.991 s) : 0, 8990670
Agent [candidate] (1.163 s) : 0, 1163131
Total [candidate] (8.988 s) : 0, 8988113
gantt
title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~89ede03f6d, baseline=1.36.0-SNAPSHOT~222ce2c65e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.221 ms) : 0, 669221
BytebuddyAgent [candidate] (668.99 ms) : 0, 668990
GlobalTracer [baseline] (305.503 ms) : 0, 305503
GlobalTracer [candidate] (304.59 ms) : 0, 304590
AppSec [baseline] (50.38 ms) : 0, 50380
AppSec [candidate] (50.195 ms) : 0, 50195
Logs Intake [baseline] (386.874 µs) : 0, 387
Logs Intake [candidate] (399.21 µs) : 0, 399
Remote Config [baseline] (693.134 µs) : 0, 693
Remote Config [candidate] (671.504 µs) : 0, 672
Telemetry [baseline] (7.584 ms) : 0, 7584
Telemetry [candidate] (7.578 ms) : 0, 7578
section iast
BytebuddyAgent [baseline] (777.254 ms) : 0, 777254
BytebuddyAgent [candidate] (783.201 ms) : 0, 783201
GlobalTracer [baseline] (292.311 ms) : 0, 292311
GlobalTracer [candidate] (294.83 ms) : 0, 294830
AppSec [baseline] (46.728 ms) : 0, 46728
AppSec [candidate] (47.226 ms) : 0, 47226
Logs Intake [baseline] (314.153 µs) : 0, 314
Logs Intake [candidate] (298.351 µs) : 0, 298
Remote Config [baseline] (563.326 µs) : 0, 563
Remote Config [candidate] (578.516 µs) : 0, 579
Telemetry [baseline] (7.611 ms) : 0, 7611
Telemetry [candidate] (9.174 ms) : 0, 9174
IAST [baseline] (28.149 ms) : 0, 28149
IAST [candidate] (25.676 ms) : 0, 25676
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (778.714 ms) : 0, 778714
BytebuddyAgent [candidate] (785.5 ms) : 0, 785500
GlobalTracer [baseline] (293.854 ms) : 0, 293854
GlobalTracer [candidate] (295.462 ms) : 0, 295462
AppSec [baseline] (46.573 ms) : 0, 46573
AppSec [candidate] (47.048 ms) : 0, 47048
Logs Intake [baseline] (300.413 µs) : 0, 300
Logs Intake [candidate] (307.391 µs) : 0, 307
Remote Config [baseline] (574.784 µs) : 0, 575
Remote Config [candidate] (585.807 µs) : 0, 586
Telemetry [baseline] (8.389 ms) : 0, 8389
Telemetry [candidate] (8.458 ms) : 0, 8458
IAST [baseline] (26.406 ms) : 0, 26406
IAST [candidate] (26.613 ms) : 0, 26613
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (775.782 ms) : 0, 775782
BytebuddyAgent [candidate] (775.673 ms) : 0, 775673
GlobalTracer [baseline] (293.349 ms) : 0, 293349
GlobalTracer [candidate] (292.915 ms) : 0, 292915
AppSec [baseline] (48.651 ms) : 0, 48651
AppSec [candidate] (47.204 ms) : 0, 47204
Logs Intake [baseline] (305.176 µs) : 0, 305
Logs Intake [candidate] (305.194 µs) : 0, 305
Remote Config [baseline] (559.414 µs) : 0, 559
Remote Config [candidate] (574.509 µs) : 0, 575
Telemetry [baseline] (6.788 ms) : 0, 6788
Telemetry [candidate] (6.842 ms) : 0, 6842
IAST [baseline] (24.338 ms) : 0, 24338
IAST [candidate] (26.291 ms) : 0, 26291
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~89ede03f6d, baseline=1.36.0-SNAPSHOT~222ce2c65e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1076507
Total [baseline] (10.471 s) : 0, 10470830
Agent [candidate] (1.062 s) : 0, 1062003
Total [candidate] (10.341 s) : 0, 10341239
section appsec
Agent [baseline] (1.182 s) : 0, 1181542
Total [baseline] (10.515 s) : 0, 10514947
Agent [candidate] (1.186 s) : 0, 1185873
Total [candidate] (10.503 s) : 0, 10502585
section iast
Agent [baseline] (1.173 s) : 0, 1173386
Total [baseline] (10.751 s) : 0, 10750611
Agent [candidate] (1.184 s) : 0, 1184089
Total [candidate] (10.781 s) : 0, 10781343
section profiling
Agent [baseline] (1.263 s) : 0, 1262848
Total [baseline] (10.628 s) : 0, 10628058
Agent [candidate] (1.259 s) : 0, 1259362
Total [candidate] (10.637 s) : 0, 10637059
gantt
title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~89ede03f6d, baseline=1.36.0-SNAPSHOT~222ce2c65e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.203 ms) : 0, 675203
BytebuddyAgent [candidate] (664.849 ms) : 0, 664849
GlobalTracer [baseline] (307.11 ms) : 0, 307110
GlobalTracer [candidate] (304.015 ms) : 0, 304015
AppSec [baseline] (50.519 ms) : 0, 50519
AppSec [candidate] (50.128 ms) : 0, 50128
Logs Intake [baseline] (409.528 µs) : 0, 410
Logs Intake [candidate] (391.535 µs) : 0, 392
Remote Config [baseline] (669.911 µs) : 0, 670
Remote Config [candidate] (677.263 µs) : 0, 677
Telemetry [baseline] (7.662 ms) : 0, 7662
Telemetry [candidate] (7.526 ms) : 0, 7526
section appsec
BytebuddyAgent [baseline] (676.705 ms) : 0, 676705
BytebuddyAgent [candidate] (679.347 ms) : 0, 679347
GlobalTracer [baseline] (297.985 ms) : 0, 297985
GlobalTracer [candidate] (298.931 ms) : 0, 298931
AppSec [baseline] (152.954 ms) : 0, 152954
AppSec [candidate] (153.662 ms) : 0, 153662
Logs Intake [baseline] (325.193 µs) : 0, 325
Logs Intake [candidate] (335.305 µs) : 0, 335
Remote Config [baseline] (637.013 µs) : 0, 637
Remote Config [candidate] (637.88 µs) : 0, 638
Telemetry [baseline] (8.16 ms) : 0, 8160
Telemetry [candidate] (7.869 ms) : 0, 7869
IAST [baseline] (20.628 ms) : 0, 20628
IAST [candidate] (21.158 ms) : 0, 21158
section iast
BytebuddyAgent [baseline] (784.154 ms) : 0, 784154
BytebuddyAgent [candidate] (790.925 ms) : 0, 790925
GlobalTracer [baseline] (293.687 ms) : 0, 293687
GlobalTracer [candidate] (297.698 ms) : 0, 297698
AppSec [baseline] (46.504 ms) : 0, 46504
AppSec [candidate] (47.671 ms) : 0, 47671
Logs Intake [baseline] (312.979 µs) : 0, 313
Logs Intake [candidate] (304.579 µs) : 0, 305
Remote Config [baseline] (583.711 µs) : 0, 584
Remote Config [candidate] (579.546 µs) : 0, 580
Telemetry [baseline] (7.656 ms) : 0, 7656
Telemetry [candidate] (6.974 ms) : 0, 6974
IAST [baseline] (27.182 ms) : 0, 27182
IAST [candidate] (26.509 ms) : 0, 26509
section profiling
BytebuddyAgent [baseline] (663.906 ms) : 0, 663906
BytebuddyAgent [candidate] (661.679 ms) : 0, 661679
GlobalTracer [baseline] (386.76 ms) : 0, 386760
GlobalTracer [candidate] (386.167 ms) : 0, 386167
AppSec [baseline] (50.772 ms) : 0, 50772
AppSec [candidate] (50.791 ms) : 0, 50791
Logs Intake [baseline] (341.179 µs) : 0, 341
Logs Intake [candidate] (332.058 µs) : 0, 332
Remote Config [baseline] (734.971 µs) : 0, 735
Remote Config [candidate] (745.864 µs) : 0, 746
Telemetry [baseline] (7.383 ms) : 0, 7383
Telemetry [candidate] (7.361 ms) : 0, 7361
ProfilingAgent [baseline] (96.249 ms) : 0, 96249
ProfilingAgent [candidate] (95.93 ms) : 0, 95930
Profiling [baseline] (96.274 ms) : 0, 96274
Profiling [candidate] (95.954 ms) : 0, 95954
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~89ede03f6d, baseline=1.36.0-SNAPSHOT~222ce2c65e
dateFormat X
axisFormat %s
section baseline
no_agent (1.349 ms) : 1330, 1367
. : milestone, 1349,
appsec (1.699 ms) : 1674, 1724
. : milestone, 1699,
appsec_no_iast (1.719 ms) : 1695, 1742
. : milestone, 1719,
iast (1.482 ms) : 1460, 1504
. : milestone, 1482,
profiling (1.513 ms) : 1487, 1539
. : milestone, 1513,
tracing (1.487 ms) : 1461, 1512
. : milestone, 1487,
section candidate
no_agent (1.333 ms) : 1314, 1353
. : milestone, 1333,
appsec (1.73 ms) : 1706, 1753
. : milestone, 1730,
appsec_no_iast (1.724 ms) : 1699, 1750
. : milestone, 1724,
iast (1.469 ms) : 1446, 1493
. : milestone, 1469,
profiling (1.501 ms) : 1476, 1525
. : milestone, 1501,
tracing (1.466 ms) : 1442, 1489
. : milestone, 1466,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~89ede03f6d, baseline=1.36.0-SNAPSHOT~222ce2c65e
dateFormat X
axisFormat %s
section baseline
no_agent (377.046 µs) : 357, 397
. : milestone, 377,
iast (481.932 µs) : 461, 503
. : milestone, 482,
iast_FULL (553.775 µs) : 533, 575
. : milestone, 554,
iast_GLOBAL (505.764 µs) : 485, 527
. : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (488.517 µs) : 467, 510
. : milestone, 489,
iast_INACTIVE (454.972 µs) : 434, 476
. : milestone, 455,
iast_TELEMETRY_OFF (475.932 µs) : 454, 497
. : milestone, 476,
tracing (454.15 µs) : 433, 476
. : milestone, 454,
section candidate
no_agent (371.177 µs) : 352, 391
. : milestone, 371,
iast (488.31 µs) : 467, 510
. : milestone, 488,
iast_FULL (556.81 µs) : 536, 578
. : milestone, 557,
iast_GLOBAL (512.442 µs) : 491, 533
. : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (487.343 µs) : 466, 508
. : milestone, 487,
iast_INACTIVE (457.234 µs) : 436, 478
. : milestone, 457,
iast_TELEMETRY_OFF (473.076 µs) : 452, 494
. : milestone, 473,
tracing (446.266 µs) : 425, 467
. : milestone, 446,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~89ede03f6d, baseline=1.36.0-SNAPSHOT~222ce2c65e
dateFormat X
axisFormat %s
section baseline
no_agent (15.526 s) : 15526000, 15526000
. : milestone, 15526000,
appsec (14.831 s) : 14831000, 14831000
. : milestone, 14831000,
iast (19.04 s) : 19040000, 19040000
. : milestone, 19040000,
iast_GLOBAL (17.9 s) : 17900000, 17900000
. : milestone, 17900000,
profiling (15.137 s) : 15137000, 15137000
. : milestone, 15137000,
tracing (15.058 s) : 15058000, 15058000
. : milestone, 15058000,
section candidate
no_agent (14.98 s) : 14980000, 14980000
. : milestone, 14980000,
appsec (15.042 s) : 15042000, 15042000
. : milestone, 15042000,
iast (18.601 s) : 18601000, 18601000
. : milestone, 18601000,
iast_GLOBAL (17.78 s) : 17780000, 17780000
. : milestone, 17780000,
profiling (15.582 s) : 15582000, 15582000
. : milestone, 15582000,
tracing (15.229 s) : 15229000, 15229000
. : milestone, 15229000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~89ede03f6d, baseline=1.36.0-SNAPSHOT~222ce2c65e
dateFormat X
axisFormat %s
section baseline
no_agent (1.46 ms) : 1449, 1471
. : milestone, 1460,
appsec (2.197 ms) : 2164, 2231
. : milestone, 2197,
iast (1.951 ms) : 1910, 1991
. : milestone, 1951,
iast_GLOBAL (2.004 ms) : 1963, 2046
. : milestone, 2004,
profiling (1.847 ms) : 1813, 1880
. : milestone, 1847,
tracing (1.841 ms) : 1808, 1874
. : milestone, 1841,
section candidate
no_agent (1.459 ms) : 1447, 1470
. : milestone, 1459,
appsec (2.203 ms) : 2169, 2238
. : milestone, 2203,
iast (1.96 ms) : 1919, 2001
. : milestone, 1960,
iast_GLOBAL (2.01 ms) : 1968, 2052
. : milestone, 2010,
profiling (1.859 ms) : 1825, 1893
. : milestone, 1859,
tracing (1.815 ms) : 1784, 1846
. : milestone, 1815,
|
PerfectSlayer
approved these changes
Jun 12, 2024
421653f to
e0f1442
Compare
Base automatically changed from
mcculls/map-otel-virtual-fields-v1.35.1
to
release/v1.35.x
June 12, 2024 12:34
* Use extended class-loader to lookup static Muzzle classes * Generate empty static Muzzle classes for OpenTelemetry extensions (they will contribute Muzzle references via the dynamic provider) * Retain original getMuzzleReferences method * Map unshaded ASM package to the shaded copy in byte-buddy * Provide Datadog equivalent of OpenTelemetry ClassRefBuilder * Map OpenTelemetry ClassRefBuilder to OtelMuzzleRefBuilder and related types * Lazily build OpenTelemetry muzzle references * Remove injected helper classes from OpenTelemetry's generated muzzle map
0253150 to
89ede03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7142 for v1.35.1