-
Notifications
You must be signed in to change notification settings - Fork 317
Support DD_LOG_LEVEL #7169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Support DD_LOG_LEVEL #7169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarziali
approved these changes
Jun 12, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 15 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~3d77d05f7a, baseline=1.36.0-SNAPSHOT~222ce2c65e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064482
Total [baseline] (10.433 s) : 0, 10433056
Agent [candidate] (1.069 s) : 0, 1068542
Total [candidate] (10.412 s) : 0, 10412286
section appsec
Agent [baseline] (1.181 s) : 0, 1180608
Total [baseline] (10.437 s) : 0, 10437322
Agent [candidate] (1.18 s) : 0, 1179672
Total [candidate] (10.453 s) : 0, 10453194
section iast
Agent [baseline] (1.169 s) : 0, 1169019
Total [baseline] (10.695 s) : 0, 10695137
Agent [candidate] (1.168 s) : 0, 1168429
Total [candidate] (10.788 s) : 0, 10787524
section profiling
Agent [baseline] (1.269 s) : 0, 1269301
Total [baseline] (10.648 s) : 0, 10647729
Agent [candidate] (1.26 s) : 0, 1259882
Total [candidate] (10.62 s) : 0, 10620296
gantt
title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~3d77d05f7a, baseline=1.36.0-SNAPSHOT~222ce2c65e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.566 ms) : 0, 665566
BytebuddyAgent [candidate] (669.069 ms) : 0, 669069
GlobalTracer [baseline] (305.698 ms) : 0, 305698
GlobalTracer [candidate] (305.546 ms) : 0, 305546
AppSec [baseline] (50.232 ms) : 0, 50232
AppSec [candidate] (50.671 ms) : 0, 50671
Logs Intake [baseline] (411.063 µs) : 0, 411
Logs Intake [candidate] (400.306 µs) : 0, 400
Remote Config [baseline] (673.223 µs) : 0, 673
Remote Config [candidate] (673.168 µs) : 0, 673
Telemetry [baseline] (7.599 ms) : 0, 7599
Telemetry [candidate] (7.56 ms) : 0, 7560
section appsec
BytebuddyAgent [baseline] (675.513 ms) : 0, 675513
BytebuddyAgent [candidate] (675.623 ms) : 0, 675623
GlobalTracer [baseline] (297.257 ms) : 0, 297257
GlobalTracer [candidate] (296.804 ms) : 0, 296804
AppSec [baseline] (153.105 ms) : 0, 153105
AppSec [candidate] (152.903 ms) : 0, 152903
Logs Intake [baseline] (324.093 µs) : 0, 324
Logs Intake [candidate] (330.205 µs) : 0, 330
Remote Config [baseline] (656.673 µs) : 0, 657
Remote Config [candidate] (645.247 µs) : 0, 645
Telemetry [baseline] (8.061 ms) : 0, 8061
Telemetry [candidate] (7.875 ms) : 0, 7875
IAST [baseline] (22.467 ms) : 0, 22467
IAST [candidate] (22.292 ms) : 0, 22292
section iast
BytebuddyAgent [baseline] (778.915 ms) : 0, 778915
BytebuddyAgent [candidate] (778.896 ms) : 0, 778896
GlobalTracer [baseline] (293.368 ms) : 0, 293368
GlobalTracer [candidate] (293.411 ms) : 0, 293411
AppSec [baseline] (46.914 ms) : 0, 46914
AppSec [candidate] (46.77 ms) : 0, 46770
Logs Intake [baseline] (302.059 µs) : 0, 302
Logs Intake [candidate] (297.787 µs) : 0, 298
Remote Config [baseline] (576.94 µs) : 0, 577
Remote Config [candidate] (570.99 µs) : 0, 571
Telemetry [baseline] (8.418 ms) : 0, 8418
Telemetry [candidate] (7.518 ms) : 0, 7518
IAST [baseline] (27.271 ms) : 0, 27271
IAST [candidate] (27.686 ms) : 0, 27686
section profiling
ProfilingAgent [baseline] (96.884 ms) : 0, 96884
ProfilingAgent [candidate] (96.306 ms) : 0, 96306
BytebuddyAgent [baseline] (667.243 ms) : 0, 667243
BytebuddyAgent [candidate] (661.929 ms) : 0, 661929
GlobalTracer [baseline] (388.579 ms) : 0, 388579
GlobalTracer [candidate] (385.637 ms) : 0, 385637
AppSec [baseline] (51.071 ms) : 0, 51071
AppSec [candidate] (50.968 ms) : 0, 50968
Logs Intake [baseline] (340.349 µs) : 0, 340
Logs Intake [candidate] (327.957 µs) : 0, 328
Remote Config [baseline] (738.833 µs) : 0, 739
Remote Config [candidate] (744.906 µs) : 0, 745
Telemetry [baseline] (7.43 ms) : 0, 7430
Telemetry [candidate] (7.348 ms) : 0, 7348
Profiling [baseline] (96.908 ms) : 0, 96908
Profiling [candidate] (96.331 ms) : 0, 96331
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~3d77d05f7a, baseline=1.36.0-SNAPSHOT~222ce2c65e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068983
Total [baseline] (8.565 s) : 0, 8565181
Agent [candidate] (1.068 s) : 0, 1068299
Total [candidate] (8.584 s) : 0, 8583798
section iast
Agent [baseline] (1.163 s) : 0, 1162840
Total [baseline] (8.984 s) : 0, 8984025
Agent [candidate] (1.164 s) : 0, 1163621
Total [candidate] (9.003 s) : 0, 9003183
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.168 s) : 0, 1168369
Total [baseline] (8.971 s) : 0, 8970829
Agent [candidate] (1.168 s) : 0, 1167611
Total [candidate] (9.002 s) : 0, 9002313
section iast_TELEMETRY_OFF
Agent [baseline] (1.16 s) : 0, 1159775
Total [baseline] (9.011 s) : 0, 9011100
Agent [candidate] (1.161 s) : 0, 1161403
Total [candidate] (8.976 s) : 0, 8976443
gantt
title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~3d77d05f7a, baseline=1.36.0-SNAPSHOT~222ce2c65e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.016 ms) : 0, 670016
BytebuddyAgent [candidate] (669.021 ms) : 0, 669021
GlobalTracer [baseline] (305.431 ms) : 0, 305431
GlobalTracer [candidate] (305.633 ms) : 0, 305633
AppSec [baseline] (50.186 ms) : 0, 50186
AppSec [candidate] (50.439 ms) : 0, 50439
Logs Intake [baseline] (406.384 µs) : 0, 406
Logs Intake [candidate] (387.31 µs) : 0, 387
Remote Config [baseline] (666.419 µs) : 0, 666
Remote Config [candidate] (671.717 µs) : 0, 672
Telemetry [baseline] (7.553 ms) : 0, 7553
Telemetry [candidate] (7.572 ms) : 0, 7572
section iast
BytebuddyAgent [baseline] (776.715 ms) : 0, 776715
BytebuddyAgent [candidate] (776.624 ms) : 0, 776624
GlobalTracer [baseline] (292.556 ms) : 0, 292556
GlobalTracer [candidate] (292.451 ms) : 0, 292451
AppSec [baseline] (46.488 ms) : 0, 46488
AppSec [candidate] (46.592 ms) : 0, 46592
Logs Intake [baseline] (298.052 µs) : 0, 298
Logs Intake [candidate] (300.945 µs) : 0, 301
Remote Config [baseline] (564.691 µs) : 0, 565
Remote Config [candidate] (600.401 µs) : 0, 600
Telemetry [baseline] (7.686 ms) : 0, 7686
Telemetry [candidate] (8.437 ms) : 0, 8437
IAST [baseline] (25.269 ms) : 0, 25269
IAST [candidate] (25.34 ms) : 0, 25340
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (778.946 ms) : 0, 778946
BytebuddyAgent [candidate] (778.348 ms) : 0, 778348
GlobalTracer [baseline] (293.701 ms) : 0, 293701
GlobalTracer [candidate] (293.362 ms) : 0, 293362
AppSec [baseline] (46.681 ms) : 0, 46681
AppSec [candidate] (46.823 ms) : 0, 46823
Logs Intake [baseline] (300.371 µs) : 0, 300
Logs Intake [candidate] (311.555 µs) : 0, 312
Remote Config [baseline] (574.518 µs) : 0, 575
Remote Config [candidate] (567.531 µs) : 0, 568
Telemetry [baseline] (8.384 ms) : 0, 8384
Telemetry [candidate] (8.453 ms) : 0, 8453
IAST [baseline] (26.422 ms) : 0, 26422
IAST [candidate] (26.381 ms) : 0, 26381
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (773.231 ms) : 0, 773231
BytebuddyAgent [candidate] (774.587 ms) : 0, 774587
GlobalTracer [baseline] (292.507 ms) : 0, 292507
GlobalTracer [candidate] (293.102 ms) : 0, 293102
AppSec [baseline] (47.06 ms) : 0, 47060
AppSec [candidate] (47.435 ms) : 0, 47435
Logs Intake [baseline] (299.204 µs) : 0, 299
Logs Intake [candidate] (299.988 µs) : 0, 300
Remote Config [baseline] (582.368 µs) : 0, 582
Remote Config [candidate] (567.831 µs) : 0, 568
Telemetry [baseline] (9.944 ms) : 0, 9944
Telemetry [candidate] (7.609 ms) : 0, 7609
IAST [baseline] (22.894 ms) : 0, 22894
IAST [candidate] (24.455 ms) : 0, 24455
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~3d77d05f7a, baseline=1.36.0-SNAPSHOT~222ce2c65e
dateFormat X
axisFormat %s
section baseline
no_agent (1.364 ms) : 1344, 1383
. : milestone, 1364,
appsec (1.727 ms) : 1703, 1752
. : milestone, 1727,
appsec_no_iast (1.714 ms) : 1688, 1739
. : milestone, 1714,
iast (1.485 ms) : 1462, 1508
. : milestone, 1485,
profiling (1.537 ms) : 1512, 1563
. : milestone, 1537,
tracing (1.477 ms) : 1453, 1501
. : milestone, 1477,
section candidate
no_agent (1.348 ms) : 1328, 1367
. : milestone, 1348,
appsec (1.729 ms) : 1706, 1753
. : milestone, 1729,
appsec_no_iast (1.731 ms) : 1706, 1755
. : milestone, 1731,
iast (1.472 ms) : 1449, 1494
. : milestone, 1472,
profiling (1.532 ms) : 1506, 1558
. : milestone, 1532,
tracing (1.492 ms) : 1467, 1516
. : milestone, 1492,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~3d77d05f7a, baseline=1.36.0-SNAPSHOT~222ce2c65e
dateFormat X
axisFormat %s
section baseline
no_agent (375.979 µs) : 355, 397
. : milestone, 376,
iast (495.003 µs) : 473, 517
. : milestone, 495,
iast_FULL (558.081 µs) : 537, 579
. : milestone, 558,
iast_GLOBAL (521.055 µs) : 499, 543
. : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (495.834 µs) : 475, 517
. : milestone, 496,
iast_INACTIVE (462.643 µs) : 441, 484
. : milestone, 463,
iast_TELEMETRY_OFF (477.073 µs) : 456, 498
. : milestone, 477,
tracing (445.741 µs) : 425, 467
. : milestone, 446,
section candidate
no_agent (372.38 µs) : 352, 393
. : milestone, 372,
iast (488.341 µs) : 467, 509
. : milestone, 488,
iast_FULL (560.052 µs) : 539, 581
. : milestone, 560,
iast_GLOBAL (514.203 µs) : 493, 535
. : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (491.186 µs) : 470, 513
. : milestone, 491,
iast_INACTIVE (463.658 µs) : 442, 485
. : milestone, 464,
iast_TELEMETRY_OFF (480.311 µs) : 459, 502
. : milestone, 480,
tracing (454.484 µs) : 433, 476
. : milestone, 454,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~3d77d05f7a, baseline=1.36.0-SNAPSHOT~222ce2c65e
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1457, 1479
. : milestone, 1468,
appsec (2.222 ms) : 2188, 2257
. : milestone, 2222,
iast (1.968 ms) : 1927, 2008
. : milestone, 1968,
iast_GLOBAL (2.015 ms) : 1974, 2056
. : milestone, 2015,
profiling (1.87 ms) : 1836, 1905
. : milestone, 1870,
tracing (1.841 ms) : 1809, 1873
. : milestone, 1841,
section candidate
no_agent (1.468 ms) : 1457, 1479
. : milestone, 1468,
appsec (2.217 ms) : 2183, 2252
. : milestone, 2217,
iast (1.976 ms) : 1935, 2017
. : milestone, 1976,
iast_GLOBAL (1.982 ms) : 1942, 2022
. : milestone, 1982,
profiling (1.858 ms) : 1824, 1893
. : milestone, 1858,
tracing (1.835 ms) : 1802, 1867
. : milestone, 1835,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~3d77d05f7a, baseline=1.36.0-SNAPSHOT~222ce2c65e
dateFormat X
axisFormat %s
section baseline
no_agent (15.39 s) : 15390000, 15390000
. : milestone, 15390000,
appsec (15.212 s) : 15212000, 15212000
. : milestone, 15212000,
iast (18.59 s) : 18590000, 18590000
. : milestone, 18590000,
iast_GLOBAL (17.754 s) : 17754000, 17754000
. : milestone, 17754000,
profiling (15.304 s) : 15304000, 15304000
. : milestone, 15304000,
tracing (15.036 s) : 15036000, 15036000
. : milestone, 15036000,
section candidate
no_agent (15.044 s) : 15044000, 15044000
. : milestone, 15044000,
appsec (15.044 s) : 15044000, 15044000
. : milestone, 15044000,
iast (18.867 s) : 18867000, 18867000
. : milestone, 18867000,
iast_GLOBAL (17.865 s) : 17865000, 17865000
. : milestone, 17865000,
profiling (15.053 s) : 15053000, 15053000
. : milestone, 15053000,
tracing (15.032 s) : 15032000, 15032000
. : milestone, 15032000,
|
b65769c to
5951d1b
Compare
Note that DD_TRACE_DEBUG=true implies a log level of DEBUG, but DD_LOG_LEVEL=DEBUG does not imply DD_TRACE_DEBUG is enabled.
5951d1b to
3d77d05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7159 for v1.35.1