-
Notifications
You must be signed in to change notification settings - Fork 317
Support custom OpenTelemetry context #7118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~7454efca70, baseline=1.35.0-SNAPSHOT~6860183154
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058935
Total [baseline] (8.558 s) : 0, 8557689
Agent [candidate] (1.064 s) : 0, 1064266
Total [candidate] (8.581 s) : 0, 8581228
section iast
Agent [baseline] (1.175 s) : 0, 1174633
Total [baseline] (9.007 s) : 0, 9006667
Agent [candidate] (1.175 s) : 0, 1175310
Total [candidate] (9.006 s) : 0, 9006378
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.166 s) : 0, 1165988
Total [baseline] (8.978 s) : 0, 8977697
Agent [candidate] (1.174 s) : 0, 1173694
Total [candidate] (9.018 s) : 0, 9018049
section iast_TELEMETRY_OFF
Agent [baseline] (1.162 s) : 0, 1161693
Total [baseline] (8.964 s) : 0, 8964262
Agent [candidate] (1.173 s) : 0, 1173381
Total [candidate] (8.979 s) : 0, 8978710
gantt
title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~7454efca70, baseline=1.35.0-SNAPSHOT~6860183154
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (653.808 ms) : 0, 653808
BytebuddyAgent [candidate] (656.426 ms) : 0, 656426
GlobalTracer [baseline] (312.727 ms) : 0, 312727
GlobalTracer [candidate] (314.441 ms) : 0, 314441
AppSec [baseline] (49.873 ms) : 0, 49873
AppSec [candidate] (50.405 ms) : 0, 50405
Remote Config [baseline] (752.233 µs) : 0, 752
Remote Config [candidate] (763.267 µs) : 0, 763
Telemetry [baseline] (7.441 ms) : 0, 7441
Telemetry [candidate] (7.656 ms) : 0, 7656
section iast
BytebuddyAgent [baseline] (784.663 ms) : 0, 784663
BytebuddyAgent [candidate] (784.493 ms) : 0, 784493
GlobalTracer [baseline] (294.892 ms) : 0, 294892
GlobalTracer [candidate] (294.914 ms) : 0, 294914
AppSec [baseline] (46.973 ms) : 0, 46973
AppSec [candidate] (46.674 ms) : 0, 46674
IAST [baseline] (26.412 ms) : 0, 26412
IAST [candidate] (26.922 ms) : 0, 26922
Remote Config [baseline] (591.894 µs) : 0, 592
Remote Config [candidate] (589.883 µs) : 0, 590
Telemetry [baseline] (7.777 ms) : 0, 7777
Telemetry [candidate] (8.387 ms) : 0, 8387
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (778.643 ms) : 0, 778643
BytebuddyAgent [candidate] (782.831 ms) : 0, 782831
GlobalTracer [baseline] (292.829 ms) : 0, 292829
GlobalTracer [candidate] (294.445 ms) : 0, 294445
AppSec [baseline] (46.53 ms) : 0, 46530
AppSec [candidate] (46.876 ms) : 0, 46876
IAST [baseline] (26.443 ms) : 0, 26443
IAST [candidate] (27.16 ms) : 0, 27160
Remote Config [baseline] (591.341 µs) : 0, 591
Remote Config [candidate] (583.216 µs) : 0, 583
Telemetry [baseline] (7.655 ms) : 0, 7655
Telemetry [candidate] (8.418 ms) : 0, 8418
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (775.01 ms) : 0, 775010
BytebuddyAgent [candidate] (783.225 ms) : 0, 783225
GlobalTracer [baseline] (293.145 ms) : 0, 293145
GlobalTracer [candidate] (295.203 ms) : 0, 295203
AppSec [baseline] (49.437 ms) : 0, 49437
AppSec [candidate] (48.2 ms) : 0, 48200
IAST [baseline] (22.72 ms) : 0, 22720
IAST [candidate] (23.628 ms) : 0, 23628
Remote Config [baseline] (570.641 µs) : 0, 571
Remote Config [candidate] (573.422 µs) : 0, 573
Telemetry [baseline] (7.572 ms) : 0, 7572
Telemetry [candidate] (9.107 ms) : 0, 9107
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~7454efca70, baseline=1.35.0-SNAPSHOT~6860183154
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060034
Total [baseline] (10.289 s) : 0, 10288732
Agent [candidate] (1.061 s) : 0, 1060819
Total [candidate] (10.369 s) : 0, 10368986
section appsec
Agent [baseline] (1.177 s) : 0, 1176806
Total [baseline] (10.42 s) : 0, 10419645
Agent [candidate] (1.173 s) : 0, 1173200
Total [candidate] (10.46 s) : 0, 10459950
section iast
Agent [baseline] (1.175 s) : 0, 1174616
Total [baseline] (10.805 s) : 0, 10805179
Agent [candidate] (1.175 s) : 0, 1175032
Total [candidate] (10.731 s) : 0, 10731249
section profiling
Agent [baseline] (1.261 s) : 0, 1261289
Total [baseline] (10.662 s) : 0, 10661561
Agent [candidate] (1.261 s) : 0, 1260633
Total [candidate] (10.632 s) : 0, 10631548
gantt
title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~7454efca70, baseline=1.35.0-SNAPSHOT~6860183154
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (653.775 ms) : 0, 653775
BytebuddyAgent [candidate] (654.483 ms) : 0, 654483
GlobalTracer [baseline] (313.421 ms) : 0, 313421
GlobalTracer [candidate] (313.576 ms) : 0, 313576
AppSec [baseline] (50.155 ms) : 0, 50155
AppSec [candidate] (50.07 ms) : 0, 50070
Remote Config [baseline] (707.732 µs) : 0, 708
Remote Config [candidate] (695.577 µs) : 0, 696
Telemetry [baseline] (7.539 ms) : 0, 7539
Telemetry [candidate] (7.605 ms) : 0, 7605
section appsec
BytebuddyAgent [baseline] (675.568 ms) : 0, 675568
BytebuddyAgent [candidate] (673.435 ms) : 0, 673435
GlobalTracer [baseline] (296.518 ms) : 0, 296518
GlobalTracer [candidate] (295.369 ms) : 0, 295369
AppSec [baseline] (152.949 ms) : 0, 152949
AppSec [candidate] (152.372 ms) : 0, 152372
Remote Config [baseline] (926.678 µs) : 0, 927
Remote Config [candidate] (645.199 µs) : 0, 645
Telemetry [baseline] (6.87 ms) : 0, 6870
Telemetry [candidate] (6.853 ms) : 0, 6853
IAST [baseline] (19.23 ms) : 0, 19230
IAST [candidate] (20.493 ms) : 0, 20493
section iast
BytebuddyAgent [baseline] (784.227 ms) : 0, 784227
BytebuddyAgent [candidate] (784.041 ms) : 0, 784041
GlobalTracer [baseline] (294.441 ms) : 0, 294441
GlobalTracer [candidate] (295.236 ms) : 0, 295236
AppSec [baseline] (46.961 ms) : 0, 46961
AppSec [candidate] (47.028 ms) : 0, 47028
Remote Config [baseline] (603.663 µs) : 0, 604
Remote Config [candidate] (589.562 µs) : 0, 590
Telemetry [baseline] (8.537 ms) : 0, 8537
Telemetry [candidate] (8.442 ms) : 0, 8442
IAST [baseline] (26.505 ms) : 0, 26505
IAST [candidate] (26.354 ms) : 0, 26354
section profiling
BytebuddyAgent [baseline] (662.963 ms) : 0, 662963
BytebuddyAgent [candidate] (662.134 ms) : 0, 662134
GlobalTracer [baseline] (385.887 ms) : 0, 385887
GlobalTracer [candidate] (385.468 ms) : 0, 385468
AppSec [baseline] (51.189 ms) : 0, 51189
AppSec [candidate] (50.82 ms) : 0, 50820
Remote Config [baseline] (776.636 µs) : 0, 777
Remote Config [candidate] (765.512 µs) : 0, 766
Telemetry [baseline] (7.38 ms) : 0, 7380
Telemetry [candidate] (7.374 ms) : 0, 7374
ProfilingAgent [baseline] (96.473 ms) : 0, 96473
ProfilingAgent [candidate] (97.48 ms) : 0, 97480
Profiling [baseline] (96.497 ms) : 0, 96497
Profiling [candidate] (97.504 ms) : 0, 97504
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 22 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~7454efca70, baseline=1.35.0-SNAPSHOT~6860183154
dateFormat X
axisFormat %s
section baseline
no_agent (1.693 ms) : 1668, 1718
. : milestone, 1693,
appsec (2.174 ms) : 2142, 2205
. : milestone, 2174,
appsec_no_iast (2.214 ms) : 2183, 2245
. : milestone, 2214,
iast (1.857 ms) : 1827, 1887
. : milestone, 1857,
profiling (1.981 ms) : 1945, 2017
. : milestone, 1981,
tracing (1.849 ms) : 1817, 1881
. : milestone, 1849,
section candidate
no_agent (1.729 ms) : 1703, 1754
. : milestone, 1729,
appsec (2.175 ms) : 2144, 2206
. : milestone, 2175,
appsec_no_iast (2.174 ms) : 2141, 2206
. : milestone, 2174,
iast (1.89 ms) : 1859, 1920
. : milestone, 1890,
profiling (1.937 ms) : 1901, 1972
. : milestone, 1937,
tracing (1.898 ms) : 1866, 1930
. : milestone, 1898,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~7454efca70, baseline=1.35.0-SNAPSHOT~6860183154
dateFormat X
axisFormat %s
section baseline
no_agent (446.826 µs) : 418, 476
. : milestone, 447,
iast (586.519 µs) : 555, 618
. : milestone, 587,
iast_FULL (684.816 µs) : 652, 717
. : milestone, 685,
iast_GLOBAL (618.408 µs) : 586, 650
. : milestone, 618,
iast_HARDCODED_SECRET_DISABLED (581.475 µs) : 550, 613
. : milestone, 581,
iast_INACTIVE (555.292 µs) : 524, 587
. : milestone, 555,
iast_TELEMETRY_OFF (573.609 µs) : 543, 605
. : milestone, 574,
tracing (544.572 µs) : 514, 575
. : milestone, 545,
section candidate
no_agent (454.627 µs) : 425, 484
. : milestone, 455,
iast (583.567 µs) : 551, 616
. : milestone, 584,
iast_FULL (685.353 µs) : 653, 718
. : milestone, 685,
iast_GLOBAL (620.159 µs) : 588, 653
. : milestone, 620,
iast_HARDCODED_SECRET_DISABLED (586.963 µs) : 556, 618
. : milestone, 587,
iast_INACTIVE (551.375 µs) : 521, 582
. : milestone, 551,
iast_TELEMETRY_OFF (576.444 µs) : 545, 608
. : milestone, 576,
tracing (533.225 µs) : 503, 563
. : milestone, 533,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~7454efca70, baseline=1.35.0-SNAPSHOT~6860183154
dateFormat X
axisFormat %s
section baseline
no_agent (15.434 s) : 15434000, 15434000
. : milestone, 15434000,
appsec (15.119 s) : 15119000, 15119000
. : milestone, 15119000,
iast (18.986 s) : 18986000, 18986000
. : milestone, 18986000,
iast_GLOBAL (17.905 s) : 17905000, 17905000
. : milestone, 17905000,
profiling (15.177 s) : 15177000, 15177000
. : milestone, 15177000,
tracing (15.072 s) : 15072000, 15072000
. : milestone, 15072000,
section candidate
no_agent (14.816 s) : 14816000, 14816000
. : milestone, 14816000,
appsec (15.104 s) : 15104000, 15104000
. : milestone, 15104000,
iast (19.029 s) : 19029000, 19029000
. : milestone, 19029000,
iast_GLOBAL (17.99 s) : 17990000, 17990000
. : milestone, 17990000,
profiling (15.433 s) : 15433000, 15433000
. : milestone, 15433000,
tracing (14.921 s) : 14921000, 14921000
. : milestone, 14921000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~7454efca70, baseline=1.35.0-SNAPSHOT~6860183154
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1453, 1476
. : milestone, 1464,
appsec (2.2 ms) : 2166, 2234
. : milestone, 2200,
iast (1.97 ms) : 1929, 2011
. : milestone, 1970,
iast_GLOBAL (1.99 ms) : 1950, 2031
. : milestone, 1990,
profiling (1.864 ms) : 1830, 1897
. : milestone, 1864,
tracing (1.838 ms) : 1805, 1871
. : milestone, 1838,
section candidate
no_agent (1.466 ms) : 1455, 1478
. : milestone, 1466,
appsec (2.203 ms) : 2169, 2237
. : milestone, 2203,
iast (1.964 ms) : 1924, 2005
. : milestone, 1964,
iast_GLOBAL (2.006 ms) : 1965, 2047
. : milestone, 2006,
profiling (1.853 ms) : 1819, 1886
. : milestone, 1853,
tracing (1.83 ms) : 1798, 1862
. : milestone, 1830,
|
amarziali
approved these changes
Jun 4, 2024
Base automatically changed from
mcculls/inherit-otel-propagated-context
to
master
June 5, 2024 16:55
fd3c3f9 to
7454efc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Records custom OpenTelemetry context (keys and values) as adjacent entries in a simple array.
When a context associated with an agent span is activated (made current) we cache any custom entries in the wrapped agent scope. This lets us retrieve previous context entries later on in the lifetime of the scope without having to maintain a separate stack of OpenTelemetry contexts.
Additional Notes
This is a short-term solution while we rework how we track context in the Java tracer.
Jira ticket: APMAPI-105