Relocate JCTools #7004
Merged
Relocate JCTools #7004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CI failed because of |
dougqh
approved these changes
May 8, 2024
mcculls
approved these changes
May 9, 2024
Contributor
mcculls
left a comment
mcculls
left a comment
There was a problem hiding this comment.
+1 thanks for the contribution!
mcculls
added
tag: community
Contributor
|
Yes some of our tests don't run properly for external contributors, so I ran these changes through CI here 🟢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Relocates JCTools
Motivation
DD JCTools usage is clashing with Quarkus 3.10, since they both use JCTools and it requires GraalVM substitutions. Quarkus has the GraalVM config to do substitutions, and DD does as well, so this yields the following error
Error: Substition: org.jctools.util.UnsafeRefArrayAccess.REF_ELEMENT_SHIFT conflicts with previously registered: org.jctools.util.UnsafeRefArrayAccess.REF_ELEMENT_SHIFT... which means that there are two substitutions being registered for the same target.Relocating JCTools fixes not only that but prevents it from happening with other Java frameworks, as GraalVM (https://github.com/oracle/graal/blob/481625b5da2b293cc672fd4b9348612483b6e76c/substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/substitute/AnnotationSubstitutionProcessor.java#L904) throws an error if there is more than one substitution for the same key.
fixes #7002