Skip to content

Only capture stacktrace for snapshot probes #6955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2024
Merged

Only capture stacktrace for snapshot probes #6955

merged 1 commit into from
May 6, 2024

Conversation

@jpbempel
Copy link
Member

@jpbempel jpbempel commented Apr 26, 2024 •
edited by atlassian bot
Loading

What Does This Do

Motivation

For any log probes we recorded stacktrace while this is useless and wasteful for template log only

Additional Notes

Jira ticket: DEBUG-2140

@jpbempel
Only capture stacktrace for snapshot probes
7e67a2e 
For any log probes we recorded stacktrace while this is useless and
wasteful for template log only
@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label Apr 26, 2024
@jpbempel jpbempel requested a review from a team as a code owner April 26, 2024 15:16
@jpbempel jpbempel requested review from shatzi and removed request for a team April 26, 2024 15:16
@pr-commenter
Copy link

pr-commenter bot commented Apr 26, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/no-stacktrace-for-log-only
git_commit_date 1714138507 1714144531
git_commit_sha a481d0b 7e67a2e
release_version 1.34.0-SNAPSHOT~a481d0b8c2 1.34.0-SNAPSHOT~7e67a2e062
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714147125 1714147125
ci_job_id 498477319 498477319
ci_pipeline_id 33028548 33028548
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~7e67a2e062, baseline=1.34.0-SNAPSHOT~a481d0b8c2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1074754
Total [baseline] (8.546 s) : 0, 8545630
Agent [candidate] (1.074 s) : 0, 1074224
Total [candidate] (8.526 s) : 0, 8526310
section iast
Agent [baseline] (1.197 s) : 0, 1196926
Total [baseline] (8.974 s) : 0, 8973934
Agent [candidate] (1.196 s) : 0, 1196241
Total [candidate] (8.982 s) : 0, 8982198
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.204 s) : 0, 1204427
Total [baseline] (8.977 s) : 0, 8977481
Agent [candidate] (1.206 s) : 0, 1205579
Total [candidate] (8.979 s) : 0, 8978833
section iast_TELEMETRY_OFF
Agent [baseline] (1.196 s) : 0, 1195915
Total [baseline] (8.98 s) : 0, 8979910
Agent [candidate] (1.196 s) : 0, 1195650
Total [candidate] (8.987 s) : 0, 8987391
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent iast 1.197 s 122.173 ms (11.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.204 s 129.674 ms (12.1%)
Agent iast_TELEMETRY_OFF 1.196 s 121.162 ms (11.3%)
Total tracing 8.546 s -
Total iast 8.974 s 428.304 ms (5.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.977 s 431.85 ms (5.1%)
Total iast_TELEMETRY_OFF 8.98 s 434.279 ms (5.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.074 s -
Agent iast 1.196 s 122.017 ms (11.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.206 s 131.354 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.196 s 121.426 ms (11.3%)
Total tracing 8.526 s -
Total iast 8.982 s 455.888 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.979 s 452.524 ms (5.3%)
Total iast_TELEMETRY_OFF 8.987 s 461.082 ms (5.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~7e67a2e062, baseline=1.34.0-SNAPSHOT~a481d0b8c2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.915 ms) : 0, 672915
BytebuddyAgent [candidate] (672.553 ms) : 0, 672553
GlobalTracer [baseline] (309.603 ms) : 0, 309603
GlobalTracer [candidate] (309.367 ms) : 0, 309367
AppSec [baseline] (49.697 ms) : 0, 49697
AppSec [candidate] (49.629 ms) : 0, 49629
Remote Config [baseline] (651.403 µs) : 0, 651
Remote Config [candidate] (662.479 µs) : 0, 662
Telemetry [baseline] (7.56 ms) : 0, 7560
Telemetry [candidate] (7.652 ms) : 0, 7652
section iast
BytebuddyAgent [baseline] (792.509 ms) : 0, 792509
BytebuddyAgent [candidate] (792.004 ms) : 0, 792004
GlobalTracer [baseline] (287.347 ms) : 0, 287347
GlobalTracer [candidate] (287.385 ms) : 0, 287385
AppSec [baseline] (49.417 ms) : 0, 49417
AppSec [candidate] (48.638 ms) : 0, 48638
IAST [baseline] (26.144 ms) : 0, 26144
IAST [candidate] (25.87 ms) : 0, 25870
Remote Config [baseline] (582.971 µs) : 0, 583
Remote Config [candidate] (707.646 µs) : 0, 708
Telemetry [baseline] (6.597 ms) : 0, 6597
Telemetry [candidate] (7.39 ms) : 0, 7390
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (798.885 ms) : 0, 798885
BytebuddyAgent [candidate] (798.977 ms) : 0, 798977
GlobalTracer [baseline] (289.438 ms) : 0, 289438
GlobalTracer [candidate] (289.369 ms) : 0, 289369
AppSec [baseline] (49.801 ms) : 0, 49801
AppSec [candidate] (49.716 ms) : 0, 49716
IAST [baseline] (24.412 ms) : 0, 24412
IAST [candidate] (25.687 ms) : 0, 25687
Remote Config [baseline] (583.336 µs) : 0, 583
Remote Config [candidate] (568.424 µs) : 0, 568
Telemetry [baseline] (6.721 ms) : 0, 6721
Telemetry [candidate] (6.636 ms) : 0, 6636
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (791.838 ms) : 0, 791838
BytebuddyAgent [candidate] (791.442 ms) : 0, 791442
GlobalTracer [baseline] (288.157 ms) : 0, 288157
GlobalTracer [candidate] (287.867 ms) : 0, 287867
AppSec [baseline] (48.417 ms) : 0, 48417
AppSec [candidate] (48.115 ms) : 0, 48115
IAST [baseline] (24.457 ms) : 0, 24457
IAST [candidate] (26.754 ms) : 0, 26754
Remote Config [baseline] (592.044 µs) : 0, 592
Remote Config [candidate] (572.434 µs) : 0, 572
Telemetry [baseline] (8.051 ms) : 0, 8051
Telemetry [candidate] (6.53 ms) : 0, 6530
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~7e67a2e062, baseline=1.34.0-SNAPSHOT~a481d0b8c2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1073903
Total [baseline] (10.405 s) : 0, 10405473
Agent [candidate] (1.076 s) : 0, 1075501
Total [candidate] (10.368 s) : 0, 10367968
section appsec
Agent [baseline] (1.189 s) : 0, 1189275
Total [baseline] (10.475 s) : 0, 10475365
Agent [candidate] (1.189 s) : 0, 1188867
Total [candidate] (10.525 s) : 0, 10525264
section iast
Agent [baseline] (1.199 s) : 0, 1198720
Total [baseline] (10.703 s) : 0, 10703415
Agent [candidate] (1.198 s) : 0, 1197596
Total [candidate] (10.738 s) : 0, 10738399
section profiling
Agent [baseline] (1.274 s) : 0, 1274051
Total [baseline] (10.633 s) : 0, 10633332
Agent [candidate] (1.266 s) : 0, 1266254
Total [candidate] (10.589 s) : 0, 10588835
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.074 s -
Agent appsec 1.189 s 115.372 ms (10.7%)
Agent iast 1.199 s 124.818 ms (11.6%)
Agent profiling 1.274 s 200.149 ms (18.6%)
Total tracing 10.405 s -
Total appsec 10.475 s 69.892 ms (0.7%)
Total iast 10.703 s 297.942 ms (2.9%)
Total profiling 10.633 s 227.858 ms (2.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent appsec 1.189 s 113.365 ms (10.5%)
Agent iast 1.198 s 122.095 ms (11.4%)
Agent profiling 1.266 s 190.753 ms (17.7%)
Total tracing 10.368 s -
Total appsec 10.525 s 157.296 ms (1.5%)
Total iast 10.738 s 370.431 ms (3.6%)
Total profiling 10.589 s 220.867 ms (2.1%) 
gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~7e67a2e062, baseline=1.34.0-SNAPSHOT~a481d0b8c2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.507 ms) : 0, 672507
BytebuddyAgent [candidate] (673.204 ms) : 0, 673204
GlobalTracer [baseline] (309.538 ms) : 0, 309538
GlobalTracer [candidate] (310.176 ms) : 0, 310176
AppSec [baseline] (49.292 ms) : 0, 49292
AppSec [candidate] (49.531 ms) : 0, 49531
Remote Config [baseline] (660.771 µs) : 0, 661
Remote Config [candidate] (655.279 µs) : 0, 655
Telemetry [baseline] (7.582 ms) : 0, 7582
Telemetry [candidate] (7.617 ms) : 0, 7617
section appsec
BytebuddyAgent [baseline] (694.895 ms) : 0, 694895
BytebuddyAgent [candidate] (694.523 ms) : 0, 694523
GlobalTracer [baseline] (291.916 ms) : 0, 291916
GlobalTracer [candidate] (291.018 ms) : 0, 291018
AppSec [baseline] (149.402 ms) : 0, 149402
AppSec [candidate] (149.459 ms) : 0, 149459
IAST [baseline] (19.317 ms) : 0, 19317
IAST [candidate] (19.354 ms) : 0, 19354
Remote Config [baseline] (618.474 µs) : 0, 618
Remote Config [candidate] (617.522 µs) : 0, 618
Telemetry [baseline] (8.432 ms) : 0, 8432
Telemetry [candidate] (9.184 ms) : 0, 9184
section iast
BytebuddyAgent [baseline] (794.372 ms) : 0, 794372
BytebuddyAgent [candidate] (793.472 ms) : 0, 793472
GlobalTracer [baseline] (287.871 ms) : 0, 287871
GlobalTracer [candidate] (287.67 ms) : 0, 287670
AppSec [baseline] (51.639 ms) : 0, 51639
AppSec [candidate] (49.875 ms) : 0, 49875
IAST [baseline] (22.587 ms) : 0, 22587
IAST [candidate] (22.851 ms) : 0, 22851
Remote Config [baseline] (562.475 µs) : 0, 562
Remote Config [candidate] (571.943 µs) : 0, 572
Telemetry [baseline] (7.419 ms) : 0, 7419
Telemetry [candidate] (8.843 ms) : 0, 8843
section profiling
BytebuddyAgent [baseline] (681.056 ms) : 0, 681056
BytebuddyAgent [candidate] (676.196 ms) : 0, 676196
GlobalTracer [baseline] (381.498 ms) : 0, 381498
GlobalTracer [candidate] (379.93 ms) : 0, 379930
AppSec [baseline] (50.315 ms) : 0, 50315
AppSec [candidate] (49.918 ms) : 0, 49918
Remote Config [baseline] (710.785 µs) : 0, 711
Remote Config [candidate] (702.598 µs) : 0, 703
Telemetry [baseline] (7.502 ms) : 0, 7502
Telemetry [candidate] (7.473 ms) : 0, 7473
ProfilingAgent [baseline] (96.201 ms) : 0, 96201
ProfilingAgent [candidate] (95.679 ms) : 0, 95679
Profiling [baseline] (96.225 ms) : 0, 96225
Profiling [candidate] (95.703 ms) : 0, 95703
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-04-26T15:29:35 2024-04-26T15:36:23
git_branch master jpbempel/no-stacktrace-for-log-only
git_commit_date 1714138507 1714144531
git_commit_sha a481d0b 7e67a2e
release_version 1.34.0-SNAPSHOT~a481d0b8c2 1.34.0-SNAPSHOT~7e67a2e062
start_time 2024-04-26T15:29:22 2024-04-26T15:36:10
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714146128 1714146128
ci_job_id 498477321 498477321
ci_pipeline_id 33028548 33028548
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~7e67a2e062, baseline=1.34.0-SNAPSHOT~a481d0b8c2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.345 ms) : 1325, 1365
.   : milestone, 1345,
appsec (1.708 ms) : 1684, 1731
.   : milestone, 1708,
appsec_no_iast (1.736 ms) : 1712, 1760
.   : milestone, 1736,
iast (1.487 ms) : 1465, 1509
.   : milestone, 1487,
profiling (1.491 ms) : 1466, 1515
.   : milestone, 1491,
tracing (1.477 ms) : 1453, 1502
.   : milestone, 1477,
section candidate
no_agent (1.356 ms) : 1337, 1375
.   : milestone, 1356,
appsec (1.72 ms) : 1696, 1745
.   : milestone, 1720,
appsec_no_iast (1.71 ms) : 1686, 1734
.   : milestone, 1710,
iast (1.491 ms) : 1468, 1514
.   : milestone, 1491,
profiling (1.505 ms) : 1481, 1529
.   : milestone, 1505,
tracing (1.502 ms) : 1478, 1526
.   : milestone, 1502,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.325 ms, 1.365 ms] -
appsec 1.708 ms [1.684 ms, 1.731 ms] 362.367 µs (26.9%)
appsec_no_iast 1.736 ms [1.712 ms, 1.76 ms] 390.523 µs (29.0%)
iast 1.487 ms [1.465 ms, 1.509 ms] 141.944 µs (10.6%)
profiling 1.491 ms [1.466 ms, 1.515 ms] 145.593 µs (10.8%)
tracing 1.477 ms [1.453 ms, 1.502 ms] 131.931 µs (9.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.356 ms [1.337 ms, 1.375 ms] -
appsec 1.72 ms [1.696 ms, 1.745 ms] 364.194 µs (26.9%)
appsec_no_iast 1.71 ms [1.686 ms, 1.734 ms] 354.234 µs (26.1%)
iast 1.491 ms [1.468 ms, 1.514 ms] 135.085 µs (10.0%)
profiling 1.505 ms [1.481 ms, 1.529 ms] 148.927 µs (11.0%)
tracing 1.502 ms [1.478 ms, 1.526 ms] 145.611 µs (10.7%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~7e67a2e062, baseline=1.34.0-SNAPSHOT~a481d0b8c2
    dateFormat X
    axisFormat %s
section baseline
no_agent (362.613 µs) : 342, 383
.   : milestone, 363,
iast (471.61 µs) : 451, 492
.   : milestone, 472,
iast_FULL (534.416 µs) : 513, 556
.   : milestone, 534,
iast_GLOBAL (495.353 µs) : 475, 516
.   : milestone, 495,
iast_HARDCODED_SECRET_DISABLED (468.596 µs) : 447, 490
.   : milestone, 469,
iast_INACTIVE (445.257 µs) : 425, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (464.427 µs) : 443, 485
.   : milestone, 464,
tracing (444.814 µs) : 422, 468
.   : milestone, 445,
section candidate
no_agent (378.743 µs) : 359, 399
.   : milestone, 379,
iast (475.718 µs) : 455, 496
.   : milestone, 476,
iast_FULL (537.056 µs) : 516, 558
.   : milestone, 537,
iast_GLOBAL (489.629 µs) : 469, 510
.   : milestone, 490,
iast_HARDCODED_SECRET_DISABLED (470.751 µs) : 450, 492
.   : milestone, 471,
iast_INACTIVE (440.728 µs) : 420, 461
.   : milestone, 441,
iast_TELEMETRY_OFF (465.244 µs) : 444, 486
.   : milestone, 465,
tracing (443.493 µs) : 423, 464
.   : milestone, 443,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 362.613 µs [342.27 µs, 382.955 µs] -
iast 471.61 µs [451.199 µs, 492.022 µs] 108.998 µs (30.1%)
iast_FULL 534.416 µs [512.767 µs, 556.066 µs] 171.804 µs (47.4%)
iast_GLOBAL 495.353 µs [474.586 µs, 516.12 µs] 132.741 µs (36.6%)
iast_HARDCODED_SECRET_DISABLED 468.596 µs [446.956 µs, 490.237 µs] 105.984 µs (29.2%)
iast_INACTIVE 445.257 µs [424.62 µs, 465.895 µs] 82.645 µs (22.8%)
iast_TELEMETRY_OFF 464.427 µs [443.49 µs, 485.364 µs] 101.814 µs (28.1%)
tracing 444.814 µs [421.849 µs, 467.779 µs] 82.201 µs (22.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 378.743 µs [358.546 µs, 398.941 µs] -
iast 475.718 µs [454.986 µs, 496.451 µs] 96.975 µs (25.6%)
iast_FULL 537.056 µs [516.036 µs, 558.076 µs] 158.312 µs (41.8%)
iast_GLOBAL 489.629 µs [469.061 µs, 510.197 µs] 110.885 µs (29.3%)
iast_HARDCODED_SECRET_DISABLED 470.751 µs [449.627 µs, 491.875 µs] 92.008 µs (24.3%)
iast_INACTIVE 440.728 µs [420.437 µs, 461.018 µs] 61.984 µs (16.4%)
iast_TELEMETRY_OFF 465.244 µs [444.156 µs, 486.332 µs] 86.501 µs (22.8%)
tracing 443.493 µs [422.733 µs, 464.253 µs] 64.749 µs (17.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/no-stacktrace-for-log-only
git_commit_date 1714138507 1714144531
git_commit_sha a481d0b 7e67a2e
release_version 1.34.0-SNAPSHOT~a481d0b8c2 1.34.0-SNAPSHOT~7e67a2e062
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1714146621 1714146621
ci_job_id 498477322 498477322
ci_pipeline_id 33028548 33028548
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~7e67a2e062, baseline=1.34.0-SNAPSHOT~a481d0b8c2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.458 ms) : 1446, 1469
.   : milestone, 1458,
appsec (2.193 ms) : 2159, 2227
.   : milestone, 2193,
iast (1.879 ms) : 1844, 1915
.   : milestone, 1879,
iast_GLOBAL (1.913 ms) : 1878, 1948
.   : milestone, 1913,
profiling (1.837 ms) : 1805, 1870
.   : milestone, 1837,
tracing (1.82 ms) : 1789, 1852
.   : milestone, 1820,
section candidate
no_agent (1.458 ms) : 1447, 1469
.   : milestone, 1458,
appsec (2.189 ms) : 2155, 2222
.   : milestone, 2189,
iast (1.864 ms) : 1829, 1899
.   : milestone, 1864,
iast_GLOBAL (1.902 ms) : 1868, 1937
.   : milestone, 1902,
profiling (1.834 ms) : 1802, 1866
.   : milestone, 1834,
tracing (1.82 ms) : 1788, 1852
.   : milestone, 1820,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.446 ms, 1.469 ms] -
appsec 2.193 ms [2.159 ms, 2.227 ms] 735.638 µs (50.5%)
iast 1.879 ms [1.844 ms, 1.915 ms] 421.908 µs (28.9%)
iast_GLOBAL 1.913 ms [1.878 ms, 1.948 ms] 455.386 µs (31.2%)
profiling 1.837 ms [1.805 ms, 1.87 ms] 379.779 µs (26.1%)
tracing 1.82 ms [1.789 ms, 1.852 ms] 362.748 µs (24.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.447 ms, 1.469 ms] -
appsec 2.189 ms [2.155 ms, 2.222 ms] 730.704 µs (50.1%)
iast 1.864 ms [1.829 ms, 1.899 ms] 405.825 µs (27.8%)
iast_GLOBAL 1.902 ms [1.868 ms, 1.937 ms] 444.36 µs (30.5%)
profiling 1.834 ms [1.802 ms, 1.866 ms] 376.006 µs (25.8%)
tracing 1.82 ms [1.788 ms, 1.852 ms] 362.191 µs (24.8%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~7e67a2e062, baseline=1.34.0-SNAPSHOT~a481d0b8c2
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.964 s) : 14964000, 14964000
.   : milestone, 14964000,
appsec (15.277 s) : 15277000, 15277000
.   : milestone, 15277000,
iast (18.854 s) : 18854000, 18854000
.   : milestone, 18854000,
iast_GLOBAL (17.756 s) : 17756000, 17756000
.   : milestone, 17756000,
profiling (15.434 s) : 15434000, 15434000
.   : milestone, 15434000,
tracing (15.13 s) : 15130000, 15130000
.   : milestone, 15130000,
section candidate
no_agent (15.381 s) : 15381000, 15381000
.   : milestone, 15381000,
appsec (14.874 s) : 14874000, 14874000
.   : milestone, 14874000,
iast (18.756 s) : 18756000, 18756000
.   : milestone, 18756000,
iast_GLOBAL (17.929 s) : 17929000, 17929000
.   : milestone, 17929000,
profiling (15.287 s) : 15287000, 15287000
.   : milestone, 15287000,
tracing (14.754 s) : 14754000, 14754000
.   : milestone, 14754000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.964 s [14.964 s, 14.964 s] -
appsec 15.277 s [15.277 s, 15.277 s] 313.0 ms (2.1%)
iast 18.854 s [18.854 s, 18.854 s] 3.89 s (26.0%)
iast_GLOBAL 17.756 s [17.756 s, 17.756 s] 2.792 s (18.7%)
profiling 15.434 s [15.434 s, 15.434 s] 470.0 ms (3.1%)
tracing 15.13 s [15.13 s, 15.13 s] 166.0 ms (1.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.381 s [15.381 s, 15.381 s] -
appsec 14.874 s [14.874 s, 14.874 s] -507.0 ms (-3.3%)
iast 18.756 s [18.756 s, 18.756 s] 3.375 s (21.9%)
iast_GLOBAL 17.929 s [17.929 s, 17.929 s] 2.548 s (16.6%)
profiling 15.287 s [15.287 s, 15.287 s] -94.0 ms (-0.6%)
tracing 14.754 s [14.754 s, 14.754 s] -627.0 ms (-4.1%)

evanchooly
evanchooly approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@evanchooly evanchooly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hard to get much simpler. i might add a test for the inverse, though.

@jpbempel
Copy link
Member Author

jpbempel commented May 6, 2024

hard to get much simpler. i might add a test for the inverse, though.

Largely covered by tests in CapturedSnapshotTest

@jpbempel jpbempel merged commit 485ef50 into master May 6, 2024
@jpbempel jpbempel deleted the jpbempel/no-stacktrace-for-log-only branch May 6, 2024 17:07
@github-actions github-actions bot added this to the 1.34.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evanchooly evanchooly evanchooly approved these changes

@shatzi shatzi Awaiting requested review from shatzi shatzi is a code owner automatically assigned from DataDog/debugger-java

Assignees

No one assigned

Labels

comp: debugger Dynamic Instrumentation

Projects

None yet

Milestone

1.34.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jpbempel @evanchooly