Skip to content

Fix agent JAR index build script cache #6951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2024
Merged

Fix agent JAR index build script cache #6951

merged 1 commit into from
Apr 26, 2024

Conversation

@PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Apr 26, 2024 •
edited
Loading

What Does This Do

This PR fixes the agent JAR index generation Gradle task to avoid breaking build cache.
The task generates an index into its input folder, making the tasks always outdated and mandatory to execute for each build.

Motivation

This was the last task breaking the agent build cache:

$ ./gradlew :dd-java-agent:shadowJar
…
…
…
BUILD SUCCESSFUL in 9s
1037 actionable tasks: 1037 up-to-date

Additional Notes

An alternative way to fix the issue is to create a dedicated generated-resources folder into the module build dir and make sure to is part of resource folder when assembling the artifact.

Jira ticket: [PROJ-IDENT]

cc @mcculls (original author) & @randomanderson (currently working on build cache)

@PerfectSlayer
fix(agent): Fix build script cache
2184188 
Fix agent JAR index generation gradle task to avoid breaking build cache.
The task generates an index into its input folder, making the tasks always outdated and mandatory to execute for each build.
@PerfectSlayer PerfectSlayer added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Apr 26, 2024
@PerfectSlayer PerfectSlayer requested a review from a team as a code owner April 26, 2024 11:20
@PerfectSlayer PerfectSlayer changed the title Fix agent JAR inde build script cache Fix agent JAR index build script cache Apr 26, 2024
mcculls
mcculls approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@mcculls mcculls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pr-commenter
Copy link

pr-commenter bot commented Apr 26, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/fix-agent-jar-index
git_commit_date 1714049499 1714130112
git_commit_sha ae1c4c9 2184188
release_version 1.34.0-SNAPSHOT~ae1c4c9475 1.34.0-SNAPSHOT~2184188901
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714132615 1714132615
ci_job_id 498147046 498147046
ci_pipeline_id 33005312 33005312
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~2184188901, baseline=1.34.0-SNAPSHOT~ae1c4c9475

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1082542
Total [baseline] (10.443 s) : 0, 10442912
Agent [candidate] (1.075 s) : 0, 1074547
Total [candidate] (10.43 s) : 0, 10430087
section appsec
Agent [baseline] (1.193 s) : 0, 1192563
Total [baseline] (10.519 s) : 0, 10519167
Agent [candidate] (1.191 s) : 0, 1190945
Total [candidate] (10.448 s) : 0, 10447803
section iast
Agent [baseline] (1.208 s) : 0, 1207565
Total [baseline] (10.734 s) : 0, 10734373
Agent [candidate] (1.217 s) : 0, 1217067
Total [candidate] (10.792 s) : 0, 10791690
section profiling
Agent [baseline] (1.269 s) : 0, 1269119
Total [baseline] (10.644 s) : 0, 10644248
Agent [candidate] (1.268 s) : 0, 1267971
Total [candidate] (10.627 s) : 0, 10626702
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.083 s -
Agent appsec 1.193 s 110.021 ms (10.2%)
Agent iast 1.208 s 125.023 ms (11.5%)
Agent profiling 1.269 s 186.577 ms (17.2%)
Total tracing 10.443 s -
Total appsec 10.519 s 76.255 ms (0.7%)
Total iast 10.734 s 291.461 ms (2.8%)
Total profiling 10.644 s 201.336 ms (1.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent appsec 1.191 s 116.398 ms (10.8%)
Agent iast 1.217 s 142.52 ms (13.3%)
Agent profiling 1.268 s 193.424 ms (18.0%)
Total tracing 10.43 s -
Total appsec 10.448 s 17.716 ms (0.2%)
Total iast 10.792 s 361.603 ms (3.5%)
Total profiling 10.627 s 196.616 ms (1.9%) 
gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~2184188901, baseline=1.34.0-SNAPSHOT~ae1c4c9475

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (678.471 ms) : 0, 678471
BytebuddyAgent [candidate] (673.278 ms) : 0, 673278
GlobalTracer [baseline] (311.415 ms) : 0, 311415
GlobalTracer [candidate] (309.327 ms) : 0, 309327
AppSec [baseline] (49.866 ms) : 0, 49866
AppSec [candidate] (49.395 ms) : 0, 49395
Remote Config [baseline] (670.668 µs) : 0, 671
Remote Config [candidate] (665.312 µs) : 0, 665
Telemetry [baseline] (7.588 ms) : 0, 7588
Telemetry [candidate] (7.63 ms) : 0, 7630
section appsec
BytebuddyAgent [baseline] (698.09 ms) : 0, 698090
BytebuddyAgent [candidate] (697.067 ms) : 0, 697067
GlobalTracer [baseline] (292.594 ms) : 0, 292594
GlobalTracer [candidate] (291.794 ms) : 0, 291794
AppSec [baseline] (149.852 ms) : 0, 149852
AppSec [candidate] (149.915 ms) : 0, 149915
IAST [baseline] (19.279 ms) : 0, 19279
IAST [candidate] (19.203 ms) : 0, 19203
Remote Config [baseline] (628.5 µs) : 0, 629
Remote Config [candidate] (623.421 µs) : 0, 623
Telemetry [baseline] (7.24 ms) : 0, 7240
Telemetry [candidate] (7.501 ms) : 0, 7501
section iast
BytebuddyAgent [baseline] (800.681 ms) : 0, 800681
BytebuddyAgent [candidate] (806.561 ms) : 0, 806561
GlobalTracer [baseline] (289.849 ms) : 0, 289849
GlobalTracer [candidate] (291.576 ms) : 0, 291576
AppSec [baseline] (51.866 ms) : 0, 51866
AppSec [candidate] (49.055 ms) : 0, 49055
IAST [baseline] (22.637 ms) : 0, 22637
IAST [candidate] (27.025 ms) : 0, 27025
Remote Config [baseline] (579.4 µs) : 0, 579
Remote Config [candidate] (579.222 µs) : 0, 579
Telemetry [baseline] (7.4 ms) : 0, 7400
Telemetry [candidate] (7.455 ms) : 0, 7455
section profiling
BytebuddyAgent [baseline] (677.849 ms) : 0, 677849
BytebuddyAgent [candidate] (676.743 ms) : 0, 676743
GlobalTracer [baseline] (380.237 ms) : 0, 380237
GlobalTracer [candidate] (380.191 ms) : 0, 380191
AppSec [baseline] (50.279 ms) : 0, 50279
AppSec [candidate] (50.361 ms) : 0, 50361
Remote Config [baseline] (729.091 µs) : 0, 729
Remote Config [candidate] (703.36 µs) : 0, 703
Telemetry [baseline] (7.515 ms) : 0, 7515
Telemetry [candidate] (7.443 ms) : 0, 7443
ProfilingAgent [baseline] (96.0 ms) : 0, 96000
ProfilingAgent [candidate] (96.111 ms) : 0, 96111
Profiling [baseline] (96.025 ms) : 0, 96025
Profiling [candidate] (96.134 ms) : 0, 96134
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~2184188901, baseline=1.34.0-SNAPSHOT~ae1c4c9475

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1075026
Total [baseline] (8.549 s) : 0, 8549050
Agent [candidate] (1.082 s) : 0, 1082348
Total [candidate] (8.592 s) : 0, 8592382
section iast
Agent [baseline] (1.215 s) : 0, 1215302
Total [baseline] (9.081 s) : 0, 9080947
Agent [candidate] (1.208 s) : 0, 1207930
Total [candidate] (9.043 s) : 0, 9042856
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.201 s) : 0, 1201469
Total [baseline] (9.01 s) : 0, 9009682
Agent [candidate] (1.195 s) : 0, 1194735
Total [candidate] (8.977 s) : 0, 8976795
section iast_TELEMETRY_OFF
Agent [baseline] (1.206 s) : 0, 1206480
Total [baseline] (9.016 s) : 0, 9015685
Agent [candidate] (1.193 s) : 0, 1193446
Total [candidate] (9.031 s) : 0, 9031231
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent iast 1.215 s 140.275 ms (13.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.201 s 126.443 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.206 s 131.454 ms (12.2%)
Total tracing 8.549 s -
Total iast 9.081 s 531.897 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.01 s 460.632 ms (5.4%)
Total iast_TELEMETRY_OFF 9.016 s 466.635 ms (5.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.082 s -
Agent iast 1.208 s 125.582 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.195 s 112.387 ms (10.4%)
Agent iast_TELEMETRY_OFF 1.193 s 111.098 ms (10.3%)
Total tracing 8.592 s -
Total iast 9.043 s 450.474 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 8.977 s 384.413 ms (4.5%)
Total iast_TELEMETRY_OFF 9.031 s 438.849 ms (5.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~2184188901, baseline=1.34.0-SNAPSHOT~ae1c4c9475

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.045 ms) : 0, 674045
BytebuddyAgent [candidate] (678.061 ms) : 0, 678061
GlobalTracer [baseline] (309.068 ms) : 0, 309068
GlobalTracer [candidate] (311.693 ms) : 0, 311693
AppSec [baseline] (49.41 ms) : 0, 49410
AppSec [candidate] (49.775 ms) : 0, 49775
Remote Config [baseline] (653.14 µs) : 0, 653
Remote Config [candidate] (670.674 µs) : 0, 671
Telemetry [baseline] (7.523 ms) : 0, 7523
Telemetry [candidate] (7.571 ms) : 0, 7571
section iast
BytebuddyAgent [baseline] (805.476 ms) : 0, 805476
BytebuddyAgent [candidate] (800.001 ms) : 0, 800001
GlobalTracer [baseline] (291.045 ms) : 0, 291045
GlobalTracer [candidate] (291.354 ms) : 0, 291354
AppSec [baseline] (51.17 ms) : 0, 51170
AppSec [candidate] (52.251 ms) : 0, 52251
IAST [baseline] (25.369 ms) : 0, 25369
IAST [candidate] (22.193 ms) : 0, 22193
Remote Config [baseline] (593.887 µs) : 0, 594
Remote Config [candidate] (669.457 µs) : 0, 669
Telemetry [baseline] (6.779 ms) : 0, 6779
Telemetry [candidate] (6.869 ms) : 0, 6869
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (795.731 ms) : 0, 795731
BytebuddyAgent [candidate] (791.395 ms) : 0, 791395
GlobalTracer [baseline] (288.689 ms) : 0, 288689
GlobalTracer [candidate] (287.501 ms) : 0, 287501
AppSec [baseline] (50.177 ms) : 0, 50177
AppSec [candidate] (51.275 ms) : 0, 51275
IAST [baseline] (25.155 ms) : 0, 25155
IAST [candidate] (22.372 ms) : 0, 22372
Remote Config [baseline] (586.87 µs) : 0, 587
Remote Config [candidate] (575.404 µs) : 0, 575
Telemetry [baseline] (6.673 ms) : 0, 6673
Telemetry [candidate] (7.351 ms) : 0, 7351
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (799.348 ms) : 0, 799348
BytebuddyAgent [candidate] (790.145 ms) : 0, 790145
GlobalTracer [baseline] (290.677 ms) : 0, 290677
GlobalTracer [candidate] (287.229 ms) : 0, 287229
AppSec [baseline] (49.876 ms) : 0, 49876
AppSec [candidate] (48.622 ms) : 0, 48622
IAST [baseline] (23.829 ms) : 0, 23829
IAST [candidate] (24.502 ms) : 0, 24502
Remote Config [baseline] (586.213 µs) : 0, 586
Remote Config [candidate] (575.383 µs) : 0, 575
Telemetry [baseline] (7.421 ms) : 0, 7421
Telemetry [candidate] (8.07 ms) : 0, 8070
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-04-26T11:27:47 2024-04-26T11:34:34
git_branch master bbujon/fix-agent-jar-index
git_commit_date 1714049499 1714130112
git_commit_sha ae1c4c9 2184188
release_version 1.34.0-SNAPSHOT~ae1c4c9475 1.34.0-SNAPSHOT~2184188901
start_time 2024-04-26T11:27:34 2024-04-26T11:34:21
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714131618 1714131618
ci_job_id 498147047 498147047
ci_pipeline_id 33005312 33005312
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~2184188901, baseline=1.34.0-SNAPSHOT~ae1c4c9475
    dateFormat X
    axisFormat %s
section baseline
no_agent (364.879 µs) : 346, 384
.   : milestone, 365,
iast (472.68 µs) : 451, 495
.   : milestone, 473,
iast_FULL (529.183 µs) : 508, 550
.   : milestone, 529,
iast_GLOBAL (500.229 µs) : 478, 522
.   : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (476.456 µs) : 455, 498
.   : milestone, 476,
iast_INACTIVE (441.835 µs) : 421, 462
.   : milestone, 442,
iast_TELEMETRY_OFF (468.199 µs) : 447, 490
.   : milestone, 468,
tracing (436.622 µs) : 416, 457
.   : milestone, 437,
section candidate
no_agent (363.851 µs) : 344, 383
.   : milestone, 364,
iast (469.214 µs) : 448, 490
.   : milestone, 469,
iast_FULL (537.604 µs) : 516, 559
.   : milestone, 538,
iast_GLOBAL (491.641 µs) : 470, 513
.   : milestone, 492,
iast_HARDCODED_SECRET_DISABLED (470.342 µs) : 449, 492
.   : milestone, 470,
iast_INACTIVE (441.049 µs) : 421, 462
.   : milestone, 441,
iast_TELEMETRY_OFF (466.037 µs) : 445, 487
.   : milestone, 466,
tracing (438.548 µs) : 418, 459
.   : milestone, 439,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.879 µs [345.568 µs, 384.191 µs] -
iast 472.68 µs [450.844 µs, 494.517 µs] 107.801 µs (29.5%)
iast_FULL 529.183 µs [508.294 µs, 550.073 µs] 164.304 µs (45.0%)
iast_GLOBAL 500.229 µs [478.118 µs, 522.34 µs] 135.349 µs (37.1%)
iast_HARDCODED_SECRET_DISABLED 476.456 µs [454.734 µs, 498.178 µs] 111.577 µs (30.6%)
iast_INACTIVE 441.835 µs [421.358 µs, 462.311 µs] 76.955 µs (21.1%)
iast_TELEMETRY_OFF 468.199 µs [446.523 µs, 489.876 µs] 103.32 µs (28.3%)
tracing 436.622 µs [416.252 µs, 456.993 µs] 71.743 µs (19.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.851 µs [344.453 µs, 383.248 µs] -
iast 469.214 µs [448.352 µs, 490.076 µs] 105.363 µs (29.0%)
iast_FULL 537.604 µs [516.264 µs, 558.944 µs] 173.753 µs (47.8%)
iast_GLOBAL 491.641 µs [470.412 µs, 512.87 µs] 127.79 µs (35.1%)
iast_HARDCODED_SECRET_DISABLED 470.342 µs [448.531 µs, 492.152 µs] 106.491 µs (29.3%)
iast_INACTIVE 441.049 µs [420.582 µs, 461.517 µs] 77.198 µs (21.2%)
iast_TELEMETRY_OFF 466.037 µs [444.775 µs, 487.299 µs] 102.186 µs (28.1%)
tracing 438.548 µs [418.381 µs, 458.716 µs] 74.697 µs (20.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~2184188901, baseline=1.34.0-SNAPSHOT~ae1c4c9475
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.354 ms) : 1335, 1373
.   : milestone, 1354,
appsec (1.707 ms) : 1683, 1731
.   : milestone, 1707,
appsec_no_iast (1.708 ms) : 1683, 1732
.   : milestone, 1708,
iast (1.48 ms) : 1457, 1503
.   : milestone, 1480,
profiling (1.489 ms) : 1464, 1514
.   : milestone, 1489,
tracing (1.475 ms) : 1451, 1500
.   : milestone, 1475,
section candidate
no_agent (1.332 ms) : 1313, 1351
.   : milestone, 1332,
appsec (1.741 ms) : 1717, 1766
.   : milestone, 1741,
appsec_no_iast (1.724 ms) : 1701, 1748
.   : milestone, 1724,
iast (1.496 ms) : 1473, 1518
.   : milestone, 1496,
profiling (1.523 ms) : 1498, 1549
.   : milestone, 1523,
tracing (1.482 ms) : 1458, 1507
.   : milestone, 1482,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.335 ms, 1.373 ms] -
appsec 1.707 ms [1.683 ms, 1.731 ms] 353.133 µs (26.1%)
appsec_no_iast 1.708 ms [1.683 ms, 1.732 ms] 354.012 µs (26.1%)
iast 1.48 ms [1.457 ms, 1.503 ms] 126.075 µs (9.3%)
profiling 1.489 ms [1.464 ms, 1.514 ms] 135.066 µs (10.0%)
tracing 1.475 ms [1.451 ms, 1.5 ms] 121.405 µs (9.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.332 ms [1.313 ms, 1.351 ms] -
appsec 1.741 ms [1.717 ms, 1.766 ms] 409.374 µs (30.7%)
appsec_no_iast 1.724 ms [1.701 ms, 1.748 ms] 392.362 µs (29.5%)
iast 1.496 ms [1.473 ms, 1.518 ms] 163.601 µs (12.3%)
profiling 1.523 ms [1.498 ms, 1.549 ms] 191.412 µs (14.4%)
tracing 1.482 ms [1.458 ms, 1.507 ms] 150.112 µs (11.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/fix-agent-jar-index
git_commit_date 1714049499 1714130112
git_commit_sha ae1c4c9 2184188
release_version 1.34.0-SNAPSHOT~ae1c4c9475 1.34.0-SNAPSHOT~2184188901
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1714132123 1714132123
ci_job_id 498147048 498147048
ci_pipeline_id 33005312 33005312
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~2184188901, baseline=1.34.0-SNAPSHOT~ae1c4c9475
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.451 s) : 15451000, 15451000
.   : milestone, 15451000,
appsec (14.761 s) : 14761000, 14761000
.   : milestone, 14761000,
iast (18.66 s) : 18660000, 18660000
.   : milestone, 18660000,
iast_GLOBAL (17.926 s) : 17926000, 17926000
.   : milestone, 17926000,
profiling (15.469 s) : 15469000, 15469000
.   : milestone, 15469000,
tracing (15.117 s) : 15117000, 15117000
.   : milestone, 15117000,
section candidate
no_agent (14.947 s) : 14947000, 14947000
.   : milestone, 14947000,
appsec (14.929 s) : 14929000, 14929000
.   : milestone, 14929000,
iast (18.724 s) : 18724000, 18724000
.   : milestone, 18724000,
iast_GLOBAL (17.668 s) : 17668000, 17668000
.   : milestone, 17668000,
profiling (15.199 s) : 15199000, 15199000
.   : milestone, 15199000,
tracing (14.948 s) : 14948000, 14948000
.   : milestone, 14948000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.451 s [15.451 s, 15.451 s] -
appsec 14.761 s [14.761 s, 14.761 s] -690.0 ms (-4.5%)
iast 18.66 s [18.66 s, 18.66 s] 3.209 s (20.8%)
iast_GLOBAL 17.926 s [17.926 s, 17.926 s] 2.475 s (16.0%)
profiling 15.469 s [15.469 s, 15.469 s] 18.0 ms (0.1%)
tracing 15.117 s [15.117 s, 15.117 s] -334.0 ms (-2.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.947 s [14.947 s, 14.947 s] -
appsec 14.929 s [14.929 s, 14.929 s] -18.0 ms (-0.1%)
iast 18.724 s [18.724 s, 18.724 s] 3.777 s (25.3%)
iast_GLOBAL 17.668 s [17.668 s, 17.668 s] 2.721 s (18.2%)
profiling 15.199 s [15.199 s, 15.199 s] 252.0 ms (1.7%)
tracing 14.948 s [14.948 s, 14.948 s] 1.0 ms (0.0%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~2184188901, baseline=1.34.0-SNAPSHOT~ae1c4c9475
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.46 ms) : 1448, 1471
.   : milestone, 1460,
appsec (2.18 ms) : 2147, 2212
.   : milestone, 2180,
iast (1.878 ms) : 1844, 1913
.   : milestone, 1878,
iast_GLOBAL (1.91 ms) : 1875, 1944
.   : milestone, 1910,
profiling (1.851 ms) : 1818, 1884
.   : milestone, 1851,
tracing (1.819 ms) : 1788, 1850
.   : milestone, 1819,
section candidate
no_agent (1.459 ms) : 1448, 1471
.   : milestone, 1459,
appsec (2.203 ms) : 2169, 2237
.   : milestone, 2203,
iast (1.879 ms) : 1844, 1914
.   : milestone, 1879,
iast_GLOBAL (1.913 ms) : 1878, 1948
.   : milestone, 1913,
profiling (1.841 ms) : 1809, 1874
.   : milestone, 1841,
tracing (1.823 ms) : 1791, 1855
.   : milestone, 1823,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.448 ms, 1.471 ms] -
appsec 2.18 ms [2.147 ms, 2.212 ms] 719.937 µs (49.3%)
iast 1.878 ms [1.844 ms, 1.913 ms] 418.84 µs (28.7%)
iast_GLOBAL 1.91 ms [1.875 ms, 1.944 ms] 449.999 µs (30.8%)
profiling 1.851 ms [1.818 ms, 1.884 ms] 391.403 µs (26.8%)
tracing 1.819 ms [1.788 ms, 1.85 ms] 359.52 µs (24.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.448 ms, 1.471 ms] -
appsec 2.203 ms [2.169 ms, 2.237 ms] 743.981 µs (51.0%)
iast 1.879 ms [1.844 ms, 1.914 ms] 419.937 µs (28.8%)
iast_GLOBAL 1.913 ms [1.878 ms, 1.948 ms] 453.644 µs (31.1%)
profiling 1.841 ms [1.809 ms, 1.874 ms] 381.883 µs (26.2%)
tracing 1.823 ms [1.791 ms, 1.855 ms] 363.68 µs (24.9%)

@PerfectSlayer PerfectSlayer merged commit e763318 into master Apr 26, 2024
@PerfectSlayer PerfectSlayer deleted the bbujon/fix-agent-jar-index branch April 26, 2024 16:00
@github-actions github-actions bot added this to the 1.34.0 milestone Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smola smola smola approved these changes

@mcculls mcculls mcculls approved these changes

@randomanderson randomanderson randomanderson approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.34.0

Development

Successfully merging this pull request may close these issues.

5 participants

@PerfectSlayer @smola @mcculls @randomanderson