Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent gitlab pipelines from always being "blocked" #6869

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

randomanderson
Copy link
Contributor

What Does This Do

Adds allow_failure: true to DSM benchmark jobs. Without it being set, all Gitlab jobs are in the blocked state. This is a quirk of Gitlab for pipelines using rules config with manual jobs.

Motivation

I noticed all gitlab pipelines were blocked for months.

@randomanderson randomanderson added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Apr 2, 2024
@randomanderson randomanderson requested a review from a team as a code owner April 2, 2024 16:05
@randomanderson randomanderson requested review from mcculls and am312 April 2, 2024 16:05
@randomanderson randomanderson enabled auto-merge (squash) April 2, 2024 16:05
@randomanderson randomanderson merged commit 97b9cf1 into master Apr 2, 2024
79 checks passed
@randomanderson randomanderson deleted the landerson/blocked-gitlab branch April 2, 2024 18:30
@github-actions github-actions bot added this to the 1.32.0 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants