Use JDK11 to build javadoc of the internal-api-9 module #6817

manuel-alvarez-alvarez · 2024-03-15T08:46:26Z

What Does This Do

Removes the error during the assemble of the internal-api-9 module due to using the wrong JDK to build the JavaDoc documentation.

smola · 2024-03-15T09:14:16Z

internal-api/internal-api-9/build.gradle


+java {
+  toolchain {
+    languageVersion = JavaLanguageVersion.of(11)


I'm not sure what the effect of this is in the build. Will this still produce bytecode compatible with JDK 9?

Actually it produces JDK8 byte code as per:

[JavaCompile, GroovyCompile].each { tasks.withType(it).configureEach { setJavaVersion(it, 11) sourceCompatibility = JavaVersion.VERSION_1_8 targetCompatibility = JavaVersion.VERSION_1_8 } }

Just tested it locally (to be sure):

public class datadog/trace/util/stacktrace/JDK9StackWalker extends datadog/trace/util/stacktrace/AbstractStackWalker { <ClassVersion=52> <SourceFile=JDK9StackWalker.java>

pr-commenter · 2024-03-15T09:38:59Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/fix-javadoc-internal-api-9
git_commit_date	1710435433	1710492116
git_commit_sha	`6d2f2ad`	`a329036`
release_version	1.32.0-SNAPSHOT~6d2f2adf41	1.32.0-SNAPSHOT~a329036264

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1710496743	1710496743
ci_job_id	460568909	460568909
ci_pipeline_id	30164251	30164251
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.32.0-SNAPSHOT~a329036264, baseline=1.32.0-SNAPSHOT~6d2f2adf41

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1088764
Total [baseline] (9.213 s) : 0, 9212890
Agent [candidate] (1.082 s) : 0, 1082090
Total [candidate] (9.158 s) : 0, 9158435
section appsec
Agent [baseline] (1.212 s) : 0, 1211663
Total [baseline] (9.343 s) : 0, 9343088
Agent [candidate] (1.202 s) : 0, 1201695
Total [candidate] (9.291 s) : 0, 9290703
section iast
Agent [baseline] (1.208 s) : 0, 1208047
Total [baseline] (9.349 s) : 0, 9349027
Agent [candidate] (1.216 s) : 0, 1215582
Total [candidate] (9.369 s) : 0, 9369442
section profiling
Agent [baseline] (1.282 s) : 0, 1281520
Total [baseline] (9.434 s) : 0, 9433996
Agent [candidate] (1.278 s) : 0, 1277902
Total [candidate] (9.455 s) : 0, 9454732

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.089 s	-
Agent	appsec	1.212 s	122.899 ms (11.3%)
Agent	iast	1.208 s	119.283 ms (11.0%)
Agent	profiling	1.282 s	192.756 ms (17.7%)
Total	tracing	9.213 s	-
Total	appsec	9.343 s	130.198 ms (1.4%)
Total	iast	9.349 s	136.137 ms (1.5%)
Total	profiling	9.434 s	221.106 ms (2.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.082 s	-
Agent	appsec	1.202 s	119.605 ms (11.1%)
Agent	iast	1.216 s	133.492 ms (12.3%)
Agent	profiling	1.278 s	195.812 ms (18.1%)
Total	tracing	9.158 s	-
Total	appsec	9.291 s	132.268 ms (1.4%)
Total	iast	9.369 s	211.006 ms (2.3%)
Total	profiling	9.455 s	296.297 ms (3.2%)

gantt
    title petclinic - break down per module: candidate=1.32.0-SNAPSHOT~a329036264, baseline=1.32.0-SNAPSHOT~6d2f2adf41

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (702.484 ms) : 0, 702484
BytebuddyAgent [candidate] (697.035 ms) : 0, 697035
GlobalTracer [baseline] (293.919 ms) : 0, 293919
GlobalTracer [candidate] (293.034 ms) : 0, 293034
AppSec [baseline] (49.253 ms) : 0, 49253
AppSec [candidate] (49.185 ms) : 0, 49185
Remote Config [baseline] (744.89 µs) : 0, 745
Remote Config [candidate] (739.91 µs) : 0, 740
Telemetry [baseline] (7.755 ms) : 0, 7755
Telemetry [candidate] (7.844 ms) : 0, 7844
section appsec
BytebuddyAgent [baseline] (702.828 ms) : 0, 702828
BytebuddyAgent [candidate] (696.639 ms) : 0, 696639
GlobalTracer [baseline] (294.239 ms) : 0, 294239
GlobalTracer [candidate] (292.245 ms) : 0, 292245
AppSec [baseline] (154.308 ms) : 0, 154308
AppSec [candidate] (153.227 ms) : 0, 153227
IAST [baseline] (18.04 ms) : 0, 18040
IAST [candidate] (17.773 ms) : 0, 17773
Remote Config [baseline] (613.385 µs) : 0, 613
Remote Config [candidate] (602.236 µs) : 0, 602
Telemetry [baseline] (6.954 ms) : 0, 6954
Telemetry [candidate] (6.855 ms) : 0, 6855
section iast
BytebuddyAgent [baseline] (802.619 ms) : 0, 802619
BytebuddyAgent [candidate] (808.05 ms) : 0, 808050
GlobalTracer [baseline] (289.168 ms) : 0, 289168
GlobalTracer [candidate] (291.538 ms) : 0, 291538
AppSec [baseline] (46.76 ms) : 0, 46760
AppSec [candidate] (48.857 ms) : 0, 48857
IAST [baseline] (27.928 ms) : 0, 27928
IAST [candidate] (23.096 ms) : 0, 23096
Remote Config [baseline] (609.846 µs) : 0, 610
Remote Config [candidate] (607.304 µs) : 0, 607
Telemetry [baseline] (6.527 ms) : 0, 6527
Telemetry [candidate] (8.873 ms) : 0, 8873
section profiling
BytebuddyAgent [baseline] (693.178 ms) : 0, 693178
BytebuddyAgent [candidate] (691.253 ms) : 0, 691253
GlobalTracer [baseline] (378.577 ms) : 0, 378577
GlobalTracer [candidate] (377.629 ms) : 0, 377629
AppSec [baseline] (49.896 ms) : 0, 49896
AppSec [candidate] (49.912 ms) : 0, 49912
Remote Config [baseline] (828.092 µs) : 0, 828
Remote Config [candidate] (777.631 µs) : 0, 778
Telemetry [baseline] (7.412 ms) : 0, 7412
Telemetry [candidate] (7.527 ms) : 0, 7527
ProfilingAgent [baseline] (95.366 ms) : 0, 95366
ProfilingAgent [candidate] (94.471 ms) : 0, 94471
Profiling [baseline] (95.389 ms) : 0, 95389
Profiling [candidate] (94.495 ms) : 0, 94495

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.32.0-SNAPSHOT~a329036264, baseline=1.32.0-SNAPSHOT~6d2f2adf41

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1080453
Total [baseline] (8.566 s) : 0, 8565697
Agent [candidate] (1.081 s) : 0, 1081022
Total [candidate] (8.562 s) : 0, 8562389
section iast
Agent [baseline] (1.211 s) : 0, 1210838
Total [baseline] (9.057 s) : 0, 9057173
Agent [candidate] (1.206 s) : 0, 1205751
Total [candidate] (9.055 s) : 0, 9054595
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.206 s) : 0, 1206423
Total [baseline] (9.035 s) : 0, 9035203
Agent [candidate] (1.215 s) : 0, 1215338
Total [candidate] (9.042 s) : 0, 9041916
section iast_TELEMETRY_OFF
Agent [baseline] (1.199 s) : 0, 1199343
Total [baseline] (9.062 s) : 0, 9062248
Agent [candidate] (1.2 s) : 0, 1200134
Total [candidate] (9.055 s) : 0, 9055029

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.08 s	-
Agent	iast	1.211 s	130.384 ms (12.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.206 s	125.969 ms (11.7%)
Agent	iast_TELEMETRY_OFF	1.199 s	118.89 ms (11.0%)
Total	tracing	8.566 s	-
Total	iast	9.057 s	491.476 ms (5.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.035 s	469.507 ms (5.5%)
Total	iast_TELEMETRY_OFF	9.062 s	496.551 ms (5.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.081 s	-
Agent	iast	1.206 s	124.729 ms (11.5%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.215 s	134.316 ms (12.4%)
Agent	iast_TELEMETRY_OFF	1.2 s	119.112 ms (11.0%)
Total	tracing	8.562 s	-
Total	iast	9.055 s	492.206 ms (5.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.042 s	479.526 ms (5.6%)
Total	iast_TELEMETRY_OFF	9.055 s	492.64 ms (5.8%)

gantt
    title insecure-bank - break down per module: candidate=1.32.0-SNAPSHOT~a329036264, baseline=1.32.0-SNAPSHOT~6d2f2adf41

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.894 ms) : 0, 696894
BytebuddyAgent [candidate] (696.729 ms) : 0, 696729
GlobalTracer [baseline] (291.99 ms) : 0, 291990
GlobalTracer [candidate] (292.449 ms) : 0, 292449
AppSec [baseline] (48.784 ms) : 0, 48784
AppSec [candidate] (48.917 ms) : 0, 48917
Remote Config [baseline] (741.049 µs) : 0, 741
Remote Config [candidate] (731.14 µs) : 0, 731
Telemetry [baseline] (7.768 ms) : 0, 7768
Telemetry [candidate] (7.852 ms) : 0, 7852
section iast
BytebuddyAgent [baseline] (805.029 ms) : 0, 805029
BytebuddyAgent [candidate] (801.231 ms) : 0, 801231
GlobalTracer [baseline] (289.998 ms) : 0, 289998
GlobalTracer [candidate] (289.016 ms) : 0, 289016
AppSec [baseline] (50.216 ms) : 0, 50216
AppSec [candidate] (50.117 ms) : 0, 50117
IAST [baseline] (23.09 ms) : 0, 23090
IAST [candidate] (23.787 ms) : 0, 23787
Remote Config [baseline] (599.983 µs) : 0, 600
Remote Config [candidate] (600.566 µs) : 0, 601
Telemetry [baseline] (7.37 ms) : 0, 7370
Telemetry [candidate] (6.609 ms) : 0, 6609
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (801.465 ms) : 0, 801465
BytebuddyAgent [candidate] (807.439 ms) : 0, 807439
GlobalTracer [baseline] (289.118 ms) : 0, 289118
GlobalTracer [candidate] (291.445 ms) : 0, 291445
AppSec [baseline] (47.92 ms) : 0, 47920
AppSec [candidate] (49.619 ms) : 0, 49619
IAST [baseline] (26.349 ms) : 0, 26349
IAST [candidate] (24.963 ms) : 0, 24963
Remote Config [baseline] (603.315 µs) : 0, 603
Remote Config [candidate] (613.391 µs) : 0, 613
Telemetry [baseline] (6.609 ms) : 0, 6609
Telemetry [candidate] (6.606 ms) : 0, 6606
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (794.091 ms) : 0, 794091
BytebuddyAgent [candidate] (793.993 ms) : 0, 793993
GlobalTracer [baseline] (289.695 ms) : 0, 289695
GlobalTracer [candidate] (290.257 ms) : 0, 290257
AppSec [baseline] (52.332 ms) : 0, 52332
AppSec [candidate] (49.671 ms) : 0, 49671
IAST [baseline] (21.609 ms) : 0, 21609
IAST [candidate] (23.2 ms) : 0, 23200
Remote Config [baseline] (572.865 µs) : 0, 573
Remote Config [candidate] (576.36 µs) : 0, 576
Telemetry [baseline] (6.58 ms) : 0, 6580
Telemetry [candidate] (8.033 ms) : 0, 8033

Load

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~a329036264, baseline=1.32.0-SNAPSHOT~6d2f2adf41
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.358 ms) : 1339, 1377
.   : milestone, 1358,
appsec (1.783 ms) : 1759, 1807
.   : milestone, 1783,
iast (1.567 ms) : 1543, 1591
.   : milestone, 1567,
profiling (1.593 ms) : 1568, 1618
.   : milestone, 1593,
tracing (1.522 ms) : 1499, 1545
.   : milestone, 1522,
section candidate
no_agent (1.352 ms) : 1333, 1371
.   : milestone, 1352,
appsec (1.797 ms) : 1773, 1821
.   : milestone, 1797,
iast (1.546 ms) : 1523, 1569
.   : milestone, 1546,
profiling (1.51 ms) : 1486, 1534
.   : milestone, 1510,
tracing (1.517 ms) : 1495, 1540
.   : milestone, 1517,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.358 ms [1.339 ms, 1.377 ms]	-
appsec	1.783 ms [1.759 ms, 1.807 ms]	424.78 µs (31.3%)
iast	1.567 ms [1.543 ms, 1.591 ms]	209.398 µs (15.4%)
profiling	1.593 ms [1.568 ms, 1.618 ms]	234.966 µs (17.3%)
tracing	1.522 ms [1.499 ms, 1.545 ms]	164.104 µs (12.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.352 ms [1.333 ms, 1.371 ms]	-
appsec	1.797 ms [1.773 ms, 1.821 ms]	445.224 µs (32.9%)
iast	1.546 ms [1.523 ms, 1.569 ms]	194.239 µs (14.4%)
profiling	1.51 ms [1.486 ms, 1.534 ms]	158.156 µs (11.7%)
tracing	1.517 ms [1.495 ms, 1.54 ms]	165.833 µs (12.3%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~a329036264, baseline=1.32.0-SNAPSHOT~6d2f2adf41
    dateFormat X
    axisFormat %s
section baseline
no_agent (367.462 µs) : 348, 387
.   : milestone, 367,
iast (479.48 µs) : 459, 500
.   : milestone, 479,
iast_FULL (541.705 µs) : 521, 562
.   : milestone, 542,
iast_GLOBAL (498.6 µs) : 477, 520
.   : milestone, 499,
iast_HARDCODED_SECRET_DISABLED (481.292 µs) : 461, 502
.   : milestone, 481,
iast_INACTIVE (451.451 µs) : 431, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (478.513 µs) : 458, 499
.   : milestone, 479,
tracing (450.281 µs) : 429, 471
.   : milestone, 450,
section candidate
no_agent (373.178 µs) : 352, 394
.   : milestone, 373,
iast (477.557 µs) : 457, 498
.   : milestone, 478,
iast_FULL (544.21 µs) : 524, 565
.   : milestone, 544,
iast_GLOBAL (497.994 µs) : 477, 519
.   : milestone, 498,
iast_HARDCODED_SECRET_DISABLED (484.252 µs) : 463, 505
.   : milestone, 484,
iast_INACTIVE (451.301 µs) : 431, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (472.973 µs) : 452, 494
.   : milestone, 473,
tracing (450.087 µs) : 429, 471
.   : milestone, 450,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	367.462 µs [347.909 µs, 387.015 µs]	-
iast	479.48 µs [458.801 µs, 500.158 µs]	112.017 µs (30.5%)
iast_FULL	541.705 µs [521.193 µs, 562.218 µs]	174.243 µs (47.4%)
iast_GLOBAL	498.6 µs [477.289 µs, 519.91 µs]	131.137 µs (35.7%)
iast_HARDCODED_SECRET_DISABLED	481.292 µs [460.654 µs, 501.93 µs]	113.83 µs (31.0%)
iast_INACTIVE	451.451 µs [430.741 µs, 472.16 µs]	83.988 µs (22.9%)
iast_TELEMETRY_OFF	478.513 µs [457.627 µs, 499.398 µs]	111.05 µs (30.2%)
tracing	450.281 µs [429.409 µs, 471.152 µs]	82.818 µs (22.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	373.178 µs [352.307 µs, 394.049 µs]	-
iast	477.557 µs [456.806 µs, 498.307 µs]	104.379 µs (28.0%)
iast_FULL	544.21 µs [523.743 µs, 564.678 µs]	171.032 µs (45.8%)
iast_GLOBAL	497.994 µs [476.735 µs, 519.252 µs]	124.816 µs (33.4%)
iast_HARDCODED_SECRET_DISABLED	484.252 µs [463.374 µs, 505.129 µs]	111.074 µs (29.8%)
iast_INACTIVE	451.301 µs [431.088 µs, 471.514 µs]	78.123 µs (20.9%)
iast_TELEMETRY_OFF	472.973 µs [452.301 µs, 493.646 µs]	99.795 µs (26.7%)
tracing	450.087 µs [429.264 µs, 470.91 µs]	76.909 µs (20.6%)

Use JDK11 to build javadoc of the internal-api-9 module

a329036

manuel-alvarez-alvarez added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Mar 15, 2024

manuel-alvarez-alvarez requested a review from a team as a code owner March 15, 2024 08:46

manuel-alvarez-alvarez requested review from mcculls and nayeem-kamal March 15, 2024 08:46

manuel-alvarez-alvarez force-pushed the malvarez/fix-javadoc-internal-api-9 branch from 8515eb5 to a329036 Compare March 15, 2024 09:06

smola reviewed Mar 15, 2024

View reviewed changes

smola approved these changes Mar 15, 2024

View reviewed changes

manuel-alvarez-alvarez merged commit 76fe1a4 into master Mar 15, 2024

manuel-alvarez-alvarez deleted the malvarez/fix-javadoc-internal-api-9 branch March 15, 2024 15:23

github-actions bot added this to the 1.32.0 milestone Mar 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use JDK11 to build javadoc of the internal-api-9 module #6817

Use JDK11 to build javadoc of the internal-api-9 module #6817

Uh oh!

manuel-alvarez-alvarez commented Mar 15, 2024 •

edited

Loading

Uh oh!

smola Mar 15, 2024

Uh oh!

manuel-alvarez-alvarez Mar 15, 2024

Uh oh!

pr-commenter bot commented Mar 15, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Use JDK11 to build javadoc of the internal-api-9 module #6817

Use JDK11 to build javadoc of the internal-api-9 module #6817

Uh oh!

Conversation

manuel-alvarez-alvarez commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Uh oh!

smola Mar 15, 2024

Choose a reason for hiding this comment

Uh oh!

manuel-alvarez-alvarez Mar 15, 2024

Choose a reason for hiding this comment

Uh oh!

pr-commenter bot commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

manuel-alvarez-alvarez commented Mar 15, 2024 •

edited

Loading

pr-commenter bot commented Mar 15, 2024 •

edited

Loading