Skip to content

Delete some legacy classes that are no longer used #6811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2024
Merged

Delete some legacy classes that are no longer used #6811

merged 1 commit into from
Mar 19, 2024

Conversation

@mcculls
Copy link
Contributor

@mcculls mcculls commented Mar 14, 2024

These are leftovers from #6797

@mcculls mcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Mar 14, 2024
@mcculls mcculls requested a review from a team as a code owner March 14, 2024 11:24
@mcculls mcculls requested review from nayeem-kamal and ygree March 14, 2024 11:24
@pr-commenter
Copy link

pr-commenter bot commented Mar 14, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/delete-unused-legacy-classes
git_commit_date 1710526664 1710530859
git_commit_sha 36e924e 8a6bc5c
release_version 1.32.0-SNAPSHOT~36e924eaab 1.32.0-SNAPSHOT~8a6bc5ced5
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1710534089 1710534089
ci_job_id 461412518 461412518
ci_pipeline_id 30226173 30226173
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.32.0-SNAPSHOT~8a6bc5ced5, baseline=1.32.0-SNAPSHOT~36e924eaab

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1086223
Total [baseline] (8.587 s) : 0, 8586572
Agent [candidate] (1.087 s) : 0, 1087285
Total [candidate] (8.575 s) : 0, 8575455
section iast
Agent [baseline] (1.204 s) : 0, 1203691
Total [baseline] (9.086 s) : 0, 9085828
Agent [candidate] (1.201 s) : 0, 1201435
Total [candidate] (9.018 s) : 0, 9018483
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.217 s) : 0, 1217262
Total [baseline] (9.032 s) : 0, 9032358
Agent [candidate] (1.204 s) : 0, 1203759
Total [candidate] (9.013 s) : 0, 9013496
section iast_TELEMETRY_OFF
Agent [baseline] (1.209 s) : 0, 1208711
Total [baseline] (9.101 s) : 0, 9100530
Agent [candidate] (1.205 s) : 0, 1205030
Total [candidate] (9.075 s) : 0, 9075138
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent iast 1.204 s 117.468 ms (10.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.217 s 131.039 ms (12.1%)
Agent iast_TELEMETRY_OFF 1.209 s 122.488 ms (11.3%)
Total tracing 8.587 s -
Total iast 9.086 s 499.256 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.032 s 445.786 ms (5.2%)
Total iast_TELEMETRY_OFF 9.101 s 513.957 ms (6.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.087 s -
Agent iast 1.201 s 114.15 ms (10.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.204 s 116.474 ms (10.7%)
Agent iast_TELEMETRY_OFF 1.205 s 117.745 ms (10.8%)
Total tracing 8.575 s -
Total iast 9.018 s 443.028 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.013 s 438.041 ms (5.1%)
Total iast_TELEMETRY_OFF 9.075 s 499.683 ms (5.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.32.0-SNAPSHOT~8a6bc5ced5, baseline=1.32.0-SNAPSHOT~36e924eaab

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (700.816 ms) : 0, 700816
BytebuddyAgent [candidate] (701.084 ms) : 0, 701084
GlobalTracer [baseline] (292.914 ms) : 0, 292914
GlobalTracer [candidate] (293.701 ms) : 0, 293701
AppSec [baseline] (49.306 ms) : 0, 49306
AppSec [candidate] (49.515 ms) : 0, 49515
Remote Config [baseline] (1.079 ms) : 0, 1079
Remote Config [candidate] (1.083 ms) : 0, 1083
Telemetry [baseline] (7.513 ms) : 0, 7513
Telemetry [candidate] (7.488 ms) : 0, 7488
section iast
BytebuddyAgent [baseline] (800.127 ms) : 0, 800127
BytebuddyAgent [candidate] (797.606 ms) : 0, 797606
GlobalTracer [baseline] (288.102 ms) : 0, 288102
GlobalTracer [candidate] (288.338 ms) : 0, 288338
AppSec [baseline] (49.809 ms) : 0, 49809
AppSec [candidate] (50.313 ms) : 0, 50313
IAST [baseline] (23.22 ms) : 0, 23220
IAST [candidate] (23.782 ms) : 0, 23782
Remote Config [baseline] (572.036 µs) : 0, 572
Remote Config [candidate] (563.941 µs) : 0, 564
Telemetry [baseline] (7.461 ms) : 0, 7461
Telemetry [candidate] (6.577 ms) : 0, 6577
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (810.822 ms) : 0, 810822
BytebuddyAgent [candidate] (799.403 ms) : 0, 799403
GlobalTracer [baseline] (290.385 ms) : 0, 290385
GlobalTracer [candidate] (289.066 ms) : 0, 289066
AppSec [baseline] (49.094 ms) : 0, 49094
AppSec [candidate] (51.062 ms) : 0, 51062
IAST [baseline] (24.333 ms) : 0, 24333
IAST [candidate] (22.785 ms) : 0, 22785
Remote Config [baseline] (557.031 µs) : 0, 557
Remote Config [candidate] (561.445 µs) : 0, 561
Telemetry [baseline] (7.272 ms) : 0, 7272
Telemetry [candidate] (6.612 ms) : 0, 6612
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (799.332 ms) : 0, 799332
BytebuddyAgent [candidate] (797.494 ms) : 0, 797494
GlobalTracer [baseline] (292.154 ms) : 0, 292154
GlobalTracer [candidate] (291.533 ms) : 0, 291533
AppSec [baseline] (52.596 ms) : 0, 52596
AppSec [candidate] (48.319 ms) : 0, 48319
IAST [baseline] (22.094 ms) : 0, 22094
IAST [candidate] (24.758 ms) : 0, 24758
Remote Config [baseline] (584.189 µs) : 0, 584
Remote Config [candidate] (570.835 µs) : 0, 571
Telemetry [baseline] (7.439 ms) : 0, 7439
Telemetry [candidate] (8.044 ms) : 0, 8044
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.32.0-SNAPSHOT~8a6bc5ced5, baseline=1.32.0-SNAPSHOT~36e924eaab

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1079355
Total [baseline] (9.19 s) : 0, 9189782
Agent [candidate] (1.094 s) : 0, 1093856
Total [candidate] (9.193 s) : 0, 9192776
section appsec
Agent [baseline] (1.198 s) : 0, 1197947
Total [baseline] (9.296 s) : 0, 9295579
Agent [candidate] (1.204 s) : 0, 1203844
Total [candidate] (9.325 s) : 0, 9325342
section iast
Agent [baseline] (1.21 s) : 0, 1210472
Total [baseline] (9.415 s) : 0, 9415280
Agent [candidate] (1.212 s) : 0, 1212212
Total [candidate] (9.364 s) : 0, 9364285
section profiling
Agent [baseline] (1.28 s) : 0, 1279748
Total [baseline] (9.419 s) : 0, 9419429
Agent [candidate] (1.272 s) : 0, 1271955
Total [candidate] (9.354 s) : 0, 9354432
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent appsec 1.198 s 118.592 ms (11.0%)
Agent iast 1.21 s 131.117 ms (12.1%)
Agent profiling 1.28 s 200.393 ms (18.6%)
Total tracing 9.19 s -
Total appsec 9.296 s 105.797 ms (1.2%)
Total iast 9.415 s 225.498 ms (2.5%)
Total profiling 9.419 s 229.647 ms (2.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.094 s -
Agent appsec 1.204 s 109.988 ms (10.1%)
Agent iast 1.212 s 118.356 ms (10.8%)
Agent profiling 1.272 s 178.099 ms (16.3%)
Total tracing 9.193 s -
Total appsec 9.325 s 132.566 ms (1.4%)
Total iast 9.364 s 171.509 ms (1.9%)
Total profiling 9.354 s 161.656 ms (1.8%) 
gantt
    title petclinic - break down per module: candidate=1.32.0-SNAPSHOT~8a6bc5ced5, baseline=1.32.0-SNAPSHOT~36e924eaab

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.485 ms) : 0, 695485
BytebuddyAgent [candidate] (705.172 ms) : 0, 705172
GlobalTracer [baseline] (291.665 ms) : 0, 291665
GlobalTracer [candidate] (295.312 ms) : 0, 295312
AppSec [baseline] (49.413 ms) : 0, 49413
AppSec [candidate] (49.83 ms) : 0, 49830
Remote Config [baseline] (1.066 ms) : 0, 1066
Remote Config [candidate] (1.136 ms) : 0, 1136
Telemetry [baseline] (7.445 ms) : 0, 7445
Telemetry [candidate] (7.631 ms) : 0, 7631
section appsec
BytebuddyAgent [baseline] (694.368 ms) : 0, 694368
BytebuddyAgent [candidate] (698.083 ms) : 0, 698083
GlobalTracer [baseline] (290.685 ms) : 0, 290685
GlobalTracer [candidate] (292.222 ms) : 0, 292222
AppSec [baseline] (153.438 ms) : 0, 153438
AppSec [candidate] (153.847 ms) : 0, 153847
IAST [baseline] (17.854 ms) : 0, 17854
IAST [candidate] (17.851 ms) : 0, 17851
Remote Config [baseline] (604.165 µs) : 0, 604
Remote Config [candidate] (605.106 µs) : 0, 605
Telemetry [baseline] (6.851 ms) : 0, 6851
Telemetry [candidate] (6.879 ms) : 0, 6879
section iast
BytebuddyAgent [baseline] (804.538 ms) : 0, 804538
BytebuddyAgent [candidate] (804.069 ms) : 0, 804069
GlobalTracer [baseline] (289.753 ms) : 0, 289753
GlobalTracer [candidate] (291.262 ms) : 0, 291262
AppSec [baseline] (50.596 ms) : 0, 50596
AppSec [candidate] (50.4 ms) : 0, 50400
IAST [baseline] (23.056 ms) : 0, 23056
IAST [candidate] (24.029 ms) : 0, 24029
Remote Config [baseline] (580.789 µs) : 0, 581
Remote Config [candidate] (585.932 µs) : 0, 586
Telemetry [baseline] (7.48 ms) : 0, 7480
Telemetry [candidate] (7.372 ms) : 0, 7372
section profiling
BytebuddyAgent [baseline] (692.67 ms) : 0, 692670
BytebuddyAgent [candidate] (688.297 ms) : 0, 688297
GlobalTracer [baseline] (377.488 ms) : 0, 377488
GlobalTracer [candidate] (375.552 ms) : 0, 375552
AppSec [baseline] (50.312 ms) : 0, 50312
AppSec [candidate] (49.883 ms) : 0, 49883
Remote Config [baseline] (857.583 µs) : 0, 858
Remote Config [candidate] (855.16 µs) : 0, 855
Telemetry [baseline] (7.401 ms) : 0, 7401
Telemetry [candidate] (7.306 ms) : 0, 7306
ProfilingAgent [baseline] (94.595 ms) : 0, 94595
ProfilingAgent [candidate] (94.145 ms) : 0, 94145
Profiling [baseline] (94.619 ms) : 0, 94619
Profiling [candidate] (94.169 ms) : 0, 94169
Loading

Load

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~8a6bc5ced5, baseline=1.32.0-SNAPSHOT~36e924eaab
    dateFormat X
    axisFormat %s
section baseline
no_agent (364.063 µs) : 344, 385
.   : milestone, 364,
iast (475.599 µs) : 455, 496
.   : milestone, 476,
iast_FULL (538.105 µs) : 518, 559
.   : milestone, 538,
iast_GLOBAL (486.355 µs) : 466, 507
.   : milestone, 486,
iast_HARDCODED_SECRET_DISABLED (476.183 µs) : 456, 497
.   : milestone, 476,
iast_INACTIVE (456.534 µs) : 435, 478
.   : milestone, 457,
iast_TELEMETRY_OFF (464.033 µs) : 443, 485
.   : milestone, 464,
tracing (445.454 µs) : 425, 466
.   : milestone, 445,
section candidate
no_agent (361.686 µs) : 342, 382
.   : milestone, 362,
iast (474.415 µs) : 454, 495
.   : milestone, 474,
iast_FULL (533.703 µs) : 513, 554
.   : milestone, 534,
iast_GLOBAL (491.667 µs) : 472, 512
.   : milestone, 492,
iast_HARDCODED_SECRET_DISABLED (472.916 µs) : 453, 493
.   : milestone, 473,
iast_INACTIVE (445.691 µs) : 425, 466
.   : milestone, 446,
iast_TELEMETRY_OFF (474.112 µs) : 453, 495
.   : milestone, 474,
tracing (441.525 µs) : 421, 462
.   : milestone, 442,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.063 µs [343.544 µs, 384.582 µs] -
iast 475.599 µs [454.868 µs, 496.33 µs] 111.536 µs (30.6%)
iast_FULL 538.105 µs [517.636 µs, 558.575 µs] 174.042 µs (47.8%)
iast_GLOBAL 486.355 µs [466.129 µs, 506.58 µs] 122.292 µs (33.6%)
iast_HARDCODED_SECRET_DISABLED 476.183 µs [455.537 µs, 496.829 µs] 112.12 µs (30.8%)
iast_INACTIVE 456.534 µs [435.411 µs, 477.658 µs] 92.471 µs (25.4%)
iast_TELEMETRY_OFF 464.033 µs [443.225 µs, 484.84 µs] 99.97 µs (27.5%)
tracing 445.454 µs [424.921 µs, 465.986 µs] 81.391 µs (22.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 361.686 µs [341.777 µs, 381.595 µs] -
iast 474.415 µs [453.523 µs, 495.307 µs] 112.729 µs (31.2%)
iast_FULL 533.703 µs [513.311 µs, 554.095 µs] 172.016 µs (47.6%)
iast_GLOBAL 491.667 µs [471.573 µs, 511.761 µs] 129.981 µs (35.9%)
iast_HARDCODED_SECRET_DISABLED 472.916 µs [452.559 µs, 493.274 µs] 111.23 µs (30.8%)
iast_INACTIVE 445.691 µs [425.172 µs, 466.21 µs] 84.004 µs (23.2%)
iast_TELEMETRY_OFF 474.112 µs [452.745 µs, 495.48 µs] 112.426 µs (31.1%)
tracing 441.525 µs [421.021 µs, 462.029 µs] 79.839 µs (22.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~8a6bc5ced5, baseline=1.32.0-SNAPSHOT~36e924eaab
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.349 ms) : 1330, 1369
.   : milestone, 1349,
appsec (1.79 ms) : 1766, 1813
.   : milestone, 1790,
iast (1.499 ms) : 1476, 1522
.   : milestone, 1499,
profiling (1.518 ms) : 1495, 1541
.   : milestone, 1518,
tracing (1.493 ms) : 1470, 1516
.   : milestone, 1493,
section candidate
no_agent (1.355 ms) : 1336, 1374
.   : milestone, 1355,
appsec (1.758 ms) : 1734, 1781
.   : milestone, 1758,
iast (1.529 ms) : 1507, 1552
.   : milestone, 1529,
profiling (1.524 ms) : 1500, 1548
.   : milestone, 1524,
tracing (1.491 ms) : 1468, 1514
.   : milestone, 1491,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.349 ms [1.33 ms, 1.369 ms] -
appsec 1.79 ms [1.766 ms, 1.813 ms] 440.231 µs (32.6%)
iast 1.499 ms [1.476 ms, 1.522 ms] 149.561 µs (11.1%)
profiling 1.518 ms [1.495 ms, 1.541 ms] 168.605 µs (12.5%)
tracing 1.493 ms [1.47 ms, 1.516 ms] 143.376 µs (10.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.336 ms, 1.374 ms] -
appsec 1.758 ms [1.734 ms, 1.781 ms] 402.783 µs (29.7%)
iast 1.529 ms [1.507 ms, 1.552 ms] 174.433 µs (12.9%)
profiling 1.524 ms [1.5 ms, 1.548 ms] 169.027 µs (12.5%)
tracing 1.491 ms [1.468 ms, 1.514 ms] 136.249 µs (10.1%)

@mcculls mcculls force-pushed the mcculls/delete-unused-legacy-classes branch from 196ab59 to 8a6bc5c Compare March 15, 2024 19:27
@mcculls mcculls requested a review from am312 March 18, 2024 19:30
@mcculls mcculls merged commit f97f632 into master Mar 19, 2024
@mcculls mcculls deleted the mcculls/delete-unused-legacy-classes branch March 19, 2024 07:36
@github-actions github-actions bot added this to the 1.32.0 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

@am312 am312 Awaiting requested review from am312

1 more reviewer

@nayeem-kamal nayeem-kamal nayeem-kamal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.32.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mcculls @nayeem-kamal