Skip to content

Remove buildSingleAdvice test-only method from AbstractTransformerBuilder #6796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2024
Merged

Remove buildSingleAdvice test-only method from AbstractTransformerBuilder #6796

merged 1 commit into from
Mar 11, 2024

Conversation

@mcculls
Copy link
Contributor

@mcculls mcculls commented Mar 11, 2024 •
edited
Loading

This special code-path was used by some old tests, but is no longer required - removing it simplifies future refactoring

@mcculls mcculls added tag: no release notes Changes to exclude from release notes type: refactoring labels Mar 11, 2024
@mcculls mcculls changed the title This special code-path was used by some old tests, but is no longer required Remove buildSingleAdvice test-only method from AbstractTransformerBuilder Mar 11, 2024
@mcculls mcculls force-pushed the mcculls/remove-unused-agent-builder-path branch from 08a24cd to 05b7ce5 Compare March 11, 2024 09:57
@mcculls mcculls marked this pull request as ready for review March 11, 2024 10:47
@mcculls mcculls requested a review from a team as a code owner March 11, 2024 10:47
@mcculls mcculls requested review from nayeem-kamal and ygree March 11, 2024 10:47
@mcculls mcculls force-pushed the mcculls/remove-unused-agent-builder-path branch from 05b7ce5 to e394aab Compare March 11, 2024 10:48
@mcculls mcculls force-pushed the mcculls/remove-unused-agent-builder-path branch from e394aab to 81130bb Compare March 11, 2024 11:52
@pr-commenter
Copy link

pr-commenter bot commented Mar 11, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/remove-unused-agent-builder-path
git_commit_date 1710156386 1710157946
git_commit_sha e8da14e 81130bb
release_version 1.32.0-SNAPSHOT~e8da14ea49 1.32.0-SNAPSHOT~81130bb38f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1710161143 1710161143
ci_job_id 456230891 456230891
ci_pipeline_id 29882697 29882697
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.32.0-SNAPSHOT~81130bb38f, baseline=1.32.0-SNAPSHOT~e8da14ea49

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1080796
Total [baseline] (9.163 s) : 0, 9162634
Agent [candidate] (1.086 s) : 0, 1085775
Total [candidate] (9.246 s) : 0, 9245517
section appsec
Agent [baseline] (1.202 s) : 0, 1202276
Total [baseline] (9.384 s) : 0, 9384156
Agent [candidate] (1.204 s) : 0, 1203984
Total [candidate] (9.295 s) : 0, 9294689
section iast
Agent [baseline] (1.204 s) : 0, 1204117
Total [baseline] (9.325 s) : 0, 9324808
Agent [candidate] (1.209 s) : 0, 1209160
Total [candidate] (9.408 s) : 0, 9408134
section profiling
Agent [baseline] (1.273 s) : 0, 1272658
Total [baseline] (9.345 s) : 0, 9344880
Agent [candidate] (1.276 s) : 0, 1275832
Total [candidate] (9.458 s) : 0, 9457560
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent appsec 1.202 s 121.48 ms (11.2%)
Agent iast 1.204 s 123.321 ms (11.4%)
Agent profiling 1.273 s 191.862 ms (17.8%)
Total tracing 9.163 s -
Total appsec 9.384 s 221.522 ms (2.4%)
Total iast 9.325 s 162.174 ms (1.8%)
Total profiling 9.345 s 182.246 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent appsec 1.204 s 118.209 ms (10.9%)
Agent iast 1.209 s 123.385 ms (11.4%)
Agent profiling 1.276 s 190.057 ms (17.5%)
Total tracing 9.246 s -
Total appsec 9.295 s 49.172 ms (0.5%)
Total iast 9.408 s 162.617 ms (1.8%)
Total profiling 9.458 s 212.044 ms (2.3%) 
gantt
    title petclinic - break down per module: candidate=1.32.0-SNAPSHOT~81130bb38f, baseline=1.32.0-SNAPSHOT~e8da14ea49

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (697.018 ms) : 0, 697018
BytebuddyAgent [candidate] (698.971 ms) : 0, 698971
GlobalTracer [baseline] (292.001 ms) : 0, 292001
GlobalTracer [candidate] (294.527 ms) : 0, 294527
AppSec [baseline] (48.956 ms) : 0, 48956
AppSec [candidate] (49.416 ms) : 0, 49416
Remote Config [baseline] (725.209 µs) : 0, 725
Remote Config [candidate] (745.356 µs) : 0, 745
Telemetry [baseline] (7.682 ms) : 0, 7682
Telemetry [candidate] (7.666 ms) : 0, 7666
section appsec
BytebuddyAgent [baseline] (697.37 ms) : 0, 697370
BytebuddyAgent [candidate] (698.495 ms) : 0, 698495
GlobalTracer [baseline] (291.814 ms) : 0, 291814
GlobalTracer [candidate] (292.427 ms) : 0, 292427
AppSec [baseline] (153.41 ms) : 0, 153410
AppSec [candidate] (153.426 ms) : 0, 153426
Remote Config [baseline] (610.38 µs) : 0, 610
Remote Config [candidate] (610.723 µs) : 0, 611
Telemetry [baseline] (6.868 ms) : 0, 6868
Telemetry [candidate] (6.828 ms) : 0, 6828
IAST [baseline] (17.865 ms) : 0, 17865
IAST [candidate] (17.791 ms) : 0, 17791
section iast
BytebuddyAgent [baseline] (801.153 ms) : 0, 801153
BytebuddyAgent [candidate] (804.136 ms) : 0, 804136
GlobalTracer [baseline] (287.948 ms) : 0, 287948
GlobalTracer [candidate] (290.146 ms) : 0, 290146
AppSec [baseline] (49.139 ms) : 0, 49139
AppSec [candidate] (47.884 ms) : 0, 47884
Remote Config [baseline] (598.44 µs) : 0, 598
Remote Config [candidate] (625.079 µs) : 0, 625
Telemetry [baseline] (7.476 ms) : 0, 7476
Telemetry [candidate] (7.433 ms) : 0, 7433
IAST [baseline] (23.547 ms) : 0, 23547
IAST [candidate] (24.52 ms) : 0, 24520
section profiling
BytebuddyAgent [baseline] (688.628 ms) : 0, 688628
BytebuddyAgent [candidate] (690.003 ms) : 0, 690003
GlobalTracer [baseline] (374.937 ms) : 0, 374937
GlobalTracer [candidate] (376.521 ms) : 0, 376521
AppSec [baseline] (49.807 ms) : 0, 49807
AppSec [candidate] (49.65 ms) : 0, 49650
Remote Config [baseline] (671.983 µs) : 0, 672
Remote Config [candidate] (720.482 µs) : 0, 720
Telemetry [baseline] (7.41 ms) : 0, 7410
Telemetry [candidate] (7.469 ms) : 0, 7469
ProfilingAgent [baseline] (94.842 ms) : 0, 94842
ProfilingAgent [candidate] (95.149 ms) : 0, 95149
Profiling [baseline] (94.865 ms) : 0, 94865
Profiling [candidate] (95.172 ms) : 0, 95172
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.32.0-SNAPSHOT~81130bb38f, baseline=1.32.0-SNAPSHOT~e8da14ea49

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1088404
Total [baseline] (8.648 s) : 0, 8648494
Agent [candidate] (1.085 s) : 0, 1084850
Total [candidate] (8.576 s) : 0, 8576240
section iast
Agent [baseline] (1.205 s) : 0, 1204629
Total [baseline] (9.058 s) : 0, 9057622
Agent [candidate] (1.208 s) : 0, 1207631
Total [candidate] (9.098 s) : 0, 9097782
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.214 s) : 0, 1214075
Total [baseline] (9.021 s) : 0, 9020832
Agent [candidate] (1.208 s) : 0, 1207607
Total [candidate] (9.028 s) : 0, 9028066
section iast_TELEMETRY_OFF
Agent [baseline] (1.2 s) : 0, 1199995
Total [baseline] (9.067 s) : 0, 9067437
Agent [candidate] (1.21 s) : 0, 1209946
Total [candidate] (9.087 s) : 0, 9086555
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.088 s -
Agent iast 1.205 s 116.226 ms (10.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.214 s 125.671 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.2 s 111.591 ms (10.3%)
Total tracing 8.648 s -
Total iast 9.058 s 409.128 ms (4.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.021 s 372.337 ms (4.3%)
Total iast_TELEMETRY_OFF 9.067 s 418.942 ms (4.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.085 s -
Agent iast 1.208 s 122.781 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.208 s 122.757 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.21 s 125.095 ms (11.5%)
Total tracing 8.576 s -
Total iast 9.098 s 521.543 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.028 s 451.826 ms (5.3%)
Total iast_TELEMETRY_OFF 9.087 s 510.316 ms (6.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.32.0-SNAPSHOT~81130bb38f, baseline=1.32.0-SNAPSHOT~e8da14ea49

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (702.509 ms) : 0, 702509
BytebuddyAgent [candidate] (699.483 ms) : 0, 699483
GlobalTracer [baseline] (293.289 ms) : 0, 293289
GlobalTracer [candidate] (293.415 ms) : 0, 293415
AppSec [baseline] (49.402 ms) : 0, 49402
AppSec [candidate] (49.096 ms) : 0, 49096
Remote Config [baseline] (726.7 µs) : 0, 727
Remote Config [candidate] (737.246 µs) : 0, 737
Telemetry [baseline] (7.862 ms) : 0, 7862
Telemetry [candidate] (7.774 ms) : 0, 7774
section iast
BytebuddyAgent [baseline] (801.252 ms) : 0, 801252
BytebuddyAgent [candidate] (802.655 ms) : 0, 802655
GlobalTracer [baseline] (288.207 ms) : 0, 288207
GlobalTracer [candidate] (290.043 ms) : 0, 290043
AppSec [baseline] (49.907 ms) : 0, 49907
AppSec [candidate] (50.722 ms) : 0, 50722
IAST [baseline] (23.646 ms) : 0, 23646
IAST [candidate] (21.874 ms) : 0, 21874
Remote Config [baseline] (620.25 µs) : 0, 620
Remote Config [candidate] (599.186 µs) : 0, 599
Telemetry [baseline] (6.618 ms) : 0, 6618
Telemetry [candidate] (7.415 ms) : 0, 7415
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (807.255 ms) : 0, 807255
BytebuddyAgent [candidate] (801.994 ms) : 0, 801994
GlobalTracer [baseline] (290.662 ms) : 0, 290662
GlobalTracer [candidate] (289.45 ms) : 0, 289450
AppSec [baseline] (50.433 ms) : 0, 50433
AppSec [candidate] (48.238 ms) : 0, 48238
IAST [baseline] (21.598 ms) : 0, 21598
IAST [candidate] (25.545 ms) : 0, 25545
Remote Config [baseline] (602.059 µs) : 0, 602
Remote Config [candidate] (618.043 µs) : 0, 618
Telemetry [baseline] (8.994 ms) : 0, 8994
Telemetry [candidate] (7.409 ms) : 0, 7409
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (794.09 ms) : 0, 794090
BytebuddyAgent [candidate] (801.0 ms) : 0, 801000
GlobalTracer [baseline] (289.655 ms) : 0, 289655
GlobalTracer [candidate] (292.617 ms) : 0, 292617
AppSec [baseline] (49.718 ms) : 0, 49718
AppSec [candidate] (52.177 ms) : 0, 52177
IAST [baseline] (23.534 ms) : 0, 23534
IAST [candidate] (22.476 ms) : 0, 22476
Remote Config [baseline] (601.637 µs) : 0, 602
Remote Config [candidate] (570.582 µs) : 0, 571
Telemetry [baseline] (8.008 ms) : 0, 8008
Telemetry [candidate] (6.481 ms) : 0, 6481
Loading

Load

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~81130bb38f, baseline=1.32.0-SNAPSHOT~e8da14ea49
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.343 ms) : 1324, 1362
.   : milestone, 1343,
appsec (1.792 ms) : 1768, 1816
.   : milestone, 1792,
iast (1.532 ms) : 1508, 1556
.   : milestone, 1532,
profiling (1.578 ms) : 1553, 1602
.   : milestone, 1578,
tracing (1.527 ms) : 1503, 1550
.   : milestone, 1527,
section candidate
no_agent (1.362 ms) : 1343, 1382
.   : milestone, 1362,
appsec (1.774 ms) : 1750, 1797
.   : milestone, 1774,
iast (1.527 ms) : 1504, 1551
.   : milestone, 1527,
profiling (1.533 ms) : 1509, 1557
.   : milestone, 1533,
tracing (1.539 ms) : 1516, 1563
.   : milestone, 1539,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.362 ms] -
appsec 1.792 ms [1.768 ms, 1.816 ms] 448.24 µs (33.4%)
iast 1.532 ms [1.508 ms, 1.556 ms] 188.883 µs (14.1%)
profiling 1.578 ms [1.553 ms, 1.602 ms] 234.193 µs (17.4%)
tracing 1.527 ms [1.503 ms, 1.55 ms] 183.224 µs (13.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.362 ms [1.343 ms, 1.382 ms] -
appsec 1.774 ms [1.75 ms, 1.797 ms] 411.243 µs (30.2%)
iast 1.527 ms [1.504 ms, 1.551 ms] 164.849 µs (12.1%)
profiling 1.533 ms [1.509 ms, 1.557 ms] 170.446 µs (12.5%)
tracing 1.539 ms [1.516 ms, 1.563 ms] 177.021 µs (13.0%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~81130bb38f, baseline=1.32.0-SNAPSHOT~e8da14ea49
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.072 µs) : 353, 395
.   : milestone, 374,
iast (476.564 µs) : 456, 497
.   : milestone, 477,
iast_FULL (541.672 µs) : 521, 562
.   : milestone, 542,
iast_GLOBAL (500.086 µs) : 479, 521
.   : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (478.243 µs) : 458, 499
.   : milestone, 478,
iast_INACTIVE (452.363 µs) : 432, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (474.668 µs) : 454, 495
.   : milestone, 475,
tracing (449.968 µs) : 429, 471
.   : milestone, 450,
section candidate
no_agent (370.838 µs) : 351, 391
.   : milestone, 371,
iast (477.366 µs) : 457, 498
.   : milestone, 477,
iast_FULL (538.195 µs) : 518, 559
.   : milestone, 538,
iast_GLOBAL (500.586 µs) : 479, 522
.   : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (480.39 µs) : 460, 501
.   : milestone, 480,
iast_INACTIVE (448.912 µs) : 428, 469
.   : milestone, 449,
iast_TELEMETRY_OFF (481.62 µs) : 461, 503
.   : milestone, 482,
tracing (444.508 µs) : 425, 464
.   : milestone, 445,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.072 µs [353.37 µs, 394.774 µs] -
iast 476.564 µs [456.155 µs, 496.973 µs] 102.492 µs (27.4%)
iast_FULL 541.672 µs [520.968 µs, 562.377 µs] 167.6 µs (44.8%)
iast_GLOBAL 500.086 µs [479.036 µs, 521.135 µs] 126.014 µs (33.7%)
iast_HARDCODED_SECRET_DISABLED 478.243 µs [457.525 µs, 498.96 µs] 104.171 µs (27.8%)
iast_INACTIVE 452.363 µs [431.731 µs, 472.995 µs] 78.291 µs (20.9%)
iast_TELEMETRY_OFF 474.668 µs [453.924 µs, 495.413 µs] 100.596 µs (26.9%)
tracing 449.968 µs [429.339 µs, 470.597 µs] 75.896 µs (20.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.838 µs [350.647 µs, 391.029 µs] -
iast 477.366 µs [456.543 µs, 498.189 µs] 106.528 µs (28.7%)
iast_FULL 538.195 µs [517.541 µs, 558.85 µs] 167.357 µs (45.1%)
iast_GLOBAL 500.586 µs [479.285 µs, 521.888 µs] 129.748 µs (35.0%)
iast_HARDCODED_SECRET_DISABLED 480.39 µs [459.825 µs, 500.954 µs] 109.552 µs (29.5%)
iast_INACTIVE 448.912 µs [428.347 µs, 469.477 µs] 78.074 µs (21.1%)
iast_TELEMETRY_OFF 481.62 µs [460.591 µs, 502.649 µs] 110.782 µs (29.9%)
tracing 444.508 µs [424.547 µs, 464.469 µs] 73.67 µs (19.9%)

@mcculls mcculls merged commit 4fa5f84 into master Mar 11, 2024
@mcculls mcculls deleted the mcculls/remove-unused-agent-builder-path branch March 11, 2024 19:32
@github-actions github-actions bot added this to the 1.32.0 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.32.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mcculls