Fix Oracle JDK8 support #2551
Merged
Fix Oracle JDK8 support #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbachorik
force-pushed
the
jb/fix_oracle8
branch
2 times, most recently
from
a11db49 to
547422f
Compare
- Initialize the profiling controller only after JMX has been initialized. - Never propagate `close()` call to Okio output stream
jbachorik
force-pushed
the
jb/fix_oracle8
branch
from
547422f to
5eaeb94
Compare
jbachorik
requested review from
charliegracie,
bantonsson,
mar-kolya and
jpbempel
bantonsson
approved these changes
Apr 1, 2021
|
BTW @jbachorik |
jpbempel
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two main problems in the first version of Oracle JDK 8 support:
close()is not overridden not to propagate to the underlying Okio output stream and this in turn will cause closing the Okio sink. Fixing the other branch to have the same handling ofclose()method will resolve this problem.As a side effect I rewrote the profiling integration tests into JUnit5 when I realized that a whole portion of assertions in the spock test was not being evaluated because of a strange interplay between a condition guarding the assertions and the assertions themselves.