Add resource naming instrumentation for jax-rs #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbenson
added
type: enhancement
tylerbenson
force-pushed
the
tyler/jax-rs
branch
3 times, most recently
from
85b36c3 to
03abd0f
Compare
tylerbenson
force-pushed
the
tyler/jax-rs
branch
from
03abd0f to
c9da16f
Compare
realark
reviewed
Feb 14, 2018
|
|
||
| @After | ||
| public void afterTest() { | ||
| assert INSTRUMENTATION_ERROR_COUNT.get() == 0; |
|
Is there anything that would need to be done to ensure that this covers JBoss/RestEASY? |
Contributor
Author
|
@avram if there is an embedable version you can submit a PR with a test for it, otherwise manual testing. If you do see any problems with it please let me know. |
|
I identified some issues with Resteasy, and opened #234 to resolve them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve naming for dropwizard and anything else using jax-rs:
NOTE: This integration is currently off by default. Enable it by setting the following system property:
-Ddd.integration.jax-rs.enabled=trueOr the following Environment Variable:
DD_INTEGRATION_JAX_RS_ENABLED=true