Move Constants#BOOTSTRAP_PACKAGE_PREFIXES to bootstrap… #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d bootstrap helper-injection in ClassloadingInstrumentation
mcculls
force-pushed
the
mcculls/avoidBootstrapPrefixInjection
branch
from
af738e5 to
8cfc2a3
Compare
dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/Constants.java
Outdated
Show resolved
Hide resolved
richardstartin
approved these changes
Jan 4, 2021
tylerbenson
approved these changes
Jan 4, 2021
Co-authored-by: Richard Startin <richard.startin@datadoghq.com>
bantonsson
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…so we can avoid having to do bootstrap injection later on in
ClassloadingInstrumentationAlso removed
AGENT_PACKAGE_PREFIXESwhich had become very out of date - the only thing that used this was an integration test that has been disabled for a couple of months. I've left that test ignored for now as I would like to try and replace it with a more robust test, but I can also remove it completely if people prefer.