Prevent headers from being added for AWS client calls #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbenson
force-pushed
the
tyler/aws
branch
2 times, most recently
from
c6a666d to
91b597d
Compare
tylerbenson
added
type: bug
tylerbenson
force-pushed
the
tyler/aws
branch
from
91b597d to
bc3170b
Compare
tylerbenson
force-pushed
the
tyler/aws
branch
from
bc3170b to
c1f73c1
Compare
Contributor
|
It looks like the aws contrib mucks with the headers as well. Do you think that has anything to do with the auth failure? https://github.com/opentracing-contrib/java-aws-sdk/blob/master/src/main/java/io/opentracing/contrib/aws/TracingRequestHandler.java#L68-L69 |
Contributor
Author
|
@realark So while I think the remaining inject is unnecessary, I don't think it is going to break the signature as it looks like that gets called before the signature is generated, so those headers should be included in the signature. This was not the case by the apache httpclient instrumentation added headers. |
realark
previously approved these changes
Jan 30, 2018
realark
previously approved these changes
Jan 31, 2018
tylerbenson
force-pushed
the
tyler/aws
branch
from
cb602d5 to
2470349
Compare
realark
approved these changes
Jan 31, 2018
Handler was being added on builder return, which was too late. It appears it would have also failed if an existing handler resulted in a unmodifiable list to be returned.
tylerbenson
force-pushed
the
tyler/aws
branch
from
2470349 to
13c774e
Compare
palazzem
reviewed
Jan 31, 2018
|
|
||
| final boolean awsClientCall = request.getHeaders("amz-sdk-invocation-id").length > 0; | ||
| // AWS calls are often signed, so we can't add headers without breaking the signature. | ||
| if (!awsClientCall) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes the AWS integration. The request handler was being added too late, so it was having no effect. Additional testing is added too.