Skip to content

Conversation

@tylerbenson
Copy link
Contributor

@tylerbenson tylerbenson commented Jan 5, 2018

Modules:
dd-trace -> dd-trace-ot
dd-trace-annotations -> dd-trace-api

Packages:
Standardize on datadog.trace and datadog.opentracing as the package prefixes.

@tylerbenson tylerbenson added the comp: core Tracer core label Jan 5, 2018
@tylerbenson tylerbenson added this to the 0.3.0 milestone Jan 5, 2018
realark
realark previously approved these changes Jan 5, 2018
Copy link
Contributor

@realark realark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Earlier we discussed having two projects: dd-trace and dd-trace-ot. Is that still the eventual plan, or is it all going in dd-trace-ot?

@tylerbenson
Copy link
Contributor Author

tylerbenson commented Jan 8, 2018

@realark the eventual plan is to have a dd-trace project that won't necessarily be published independently, but will be used as a dependency for other projects. The work to extract dd-trace out of dd-trace-ot has been postponed for now, though I did try to get the package names aligned accordingly.

I'm going to rename the annotations artifact next and include that in this PR.

@tylerbenson
Copy link
Contributor Author

@realark @palazzem please review the latest changes.

palazzem
palazzem previously approved these changes Jan 8, 2018
Copy link
Contributor

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me!

@realark
Copy link
Contributor

realark commented Jan 8, 2018

Looks good! ✅

Module:
dd-trace -> dd-trace-ot

Packages:
Standardize on `datadog.trace` and `datadog.opentracing` as the package prefixes.
And move DDTags over to it.
Move some `datadog.trace.api` classes over to `datadog.trace.common`.
Other misc renaming.
@tylerbenson tylerbenson dismissed stale reviews from palazzem and realark via 6d3d889 January 9, 2018 00:07
@tylerbenson tylerbenson merged commit 5b4c965 into master Jan 9, 2018
@tylerbenson tylerbenson deleted the tyler/move-stuff branch January 9, 2018 00:14
froque added a commit to froque/oga-maven-plugin that referenced this pull request Oct 15, 2024
Artifact names have changed:
    dd-trace -> dd-trace-ot
    dd-trace-annotations -> dd-trace-api

https://github.com/DataDog/dd-trace-java/releases/tag/v0.3.0-RC1
DataDog/dd-trace-java#184
camerodev added a commit to camerodev/oga-maven-plugin that referenced this pull request Apr 6, 2025
Artifact names have changed:
    dd-trace -> dd-trace-ot
    dd-trace-annotations -> dd-trace-api

https://github.com/DataDog/dd-trace-java/releases/tag/v0.3.0-RC1
DataDog/dd-trace-java#184
rosen1218627 added a commit to rosen1218627/oga-maven-plugin that referenced this pull request Sep 10, 2025
Artifact names have changed:
    dd-trace -> dd-trace-ot
    dd-trace-annotations -> dd-trace-api

https://github.com/DataDog/dd-trace-java/releases/tag/v0.3.0-RC1
DataDog/dd-trace-java#184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: core Tracer core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants