Skip to content

Conversation

@realark
Copy link
Contributor

@realark realark commented Dec 29, 2017

  • Base perf project and jetty test project
  • Script for running performance tests against different agent versions

@realark realark added dev/tooling inst: others All other instrumentations labels Dec 29, 2017
@realark realark added this to the 0.2.12 milestone Dec 29, 2017
@realark realark requested a review from tylerbenson December 29, 2017 23:05
@realark realark force-pushed the ark/macro-benchmarks branch from 1e5692c to fc0291d Compare December 30, 2017 00:37
Copy link
Contributor

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I suggest moving this project to be a sibling of the benchmark tests under dd-java-agent?

How long does a test iteration take? I'd suggest updating the example to include agent versions in dd-java-agent/benchmark/releases

@realark realark force-pushed the ark/macro-benchmarks branch 2 times, most recently from 34de1b0 to 986e73f Compare January 2, 2018 19:17
@realark realark force-pushed the ark/macro-benchmarks branch from 986e73f to 905bdb1 Compare January 2, 2018 20:17
@realark
Copy link
Contributor Author

realark commented Jan 2, 2018

Sure I'm fine with moving the project below dd-java-agent. I've updated the readme to point people to the releases dir.

Each test endpoint takes about 2 minutes (30s warmup, 90s test); total test time of 10 minutes per agent.

I also added the ability to customize the resources per machine. Defaults settings are in perf-test-default-settings.rc.

Copy link
Contributor

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. What do the results look like? What kind of impact are we seeing?

@realark
Copy link
Contributor Author

realark commented Jan 2, 2018

The results look very good. At 1ms and above the agent has no impact on the throughput.

For the <1MS worst-case scenario (average 60 microseconds latency per request) the agent is noticeable at 20% reduction in throughput. I'm not surprised to see that; we're essentially measuring nothing so our presence is more obvious.

That leaves the question open about the performance between 60us and 1ms response times, but I wasn't sure if that data was interesting enough to collect.

@realark realark merged commit f1fa137 into master Jan 2, 2018
@realark realark deleted the ark/macro-benchmarks branch January 2, 2018 22:04
@PerfectSlayer PerfectSlayer added comp: tooling Build & Tooling and removed dev/tooling labels Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling inst: others All other instrumentations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants