-
Notifications
You must be signed in to change notification settings - Fork 318
macro benchmarks #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macro benchmarks #180
Conversation
realark
commented
Dec 29, 2017
- Base perf project and jetty test project
- Script for running performance tests against different agent versions
1e5692c to
fc0291d
Compare
tylerbenson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I suggest moving this project to be a sibling of the benchmark tests under dd-java-agent?
How long does a test iteration take? I'd suggest updating the example to include agent versions in dd-java-agent/benchmark/releases
34de1b0 to
986e73f
Compare
986e73f to
905bdb1
Compare
|
Sure I'm fine with moving the project below dd-java-agent. I've updated the readme to point people to the releases dir. Each test endpoint takes about 2 minutes (30s warmup, 90s test); total test time of 10 minutes per agent. I also added the ability to customize the resources per machine. Defaults settings are in |
tylerbenson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. What do the results look like? What kind of impact are we seeing?
|
The results look very good. At 1ms and above the agent has no impact on the throughput. For the That leaves the question open about the performance between 60us and 1ms response times, but I wasn't sure if that data was interesting enough to collect. |