Instrumentation Test Framework #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realark
force-pushed
the
ark/agent_test_framework
branch
11 times, most recently
from
d11a8de to
d41897e
Compare
realark
added
dev/tooling
type: enhancement
added 10 commits
December 28, 2017 09:46
BytebuddyAgent install already handles class retransformation, make the custom classloader redundant.
realark
force-pushed
the
ark/agent_test_framework
branch
from
28d8e05 to
1a80e44
Compare
tylerbenson
reviewed
Jan 2, 2018
| * in an initialized state. | ||
| * </ul> | ||
| */ | ||
| @SpecMetadata(filename = "AgentTestRunner.java", line = 0) |
Contributor
There was a problem hiding this comment.
Just out of curiosity... what does this line do?
Contributor
Author
There was a problem hiding this comment.
Spock expects subclasses of spock.lang.Specification to have this annotation; adding it allows us to extend Specification from a java class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toolingto allow the core agent and the test framework to share the same codepath for configuring the bytebuddy agent.This allows us to test instrumentation entirely in the ide/spock (no -javaagent flag required).
There are still some tests in the
dd-java-agent-ittestsproject which should be moved into their integration subproject and converted to the new test framework. These will eventually be moved over, but they're not a super high priority at the moment.