Name agent writer threadpools and set to daemon #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a clean shutdown, instead of keeping the vm running.
tylerbenson
force-pushed
the
tyler/fix-threadpool-names
branch
from
cad48b3 to
dc89cd1
Compare
tylerbenson
commented
Dec 6, 2017
| static final long FLUSH_TIME_SECONDS = 1; | ||
|
|
||
| private final ThreadFactory agentWriterThreadFactory = | ||
| new ThreadFactoryBuilder().setNameFormat("dd-agent-writer-%d").setDaemon(true).build(); |
Contributor
Author
There was a problem hiding this comment.
Any opinion on thread name format?
realark
approved these changes
Dec 6, 2017
| static final long FLUSH_TIME_SECONDS = 1; | ||
|
|
||
| private final ThreadFactory agentWriterThreadFactory = | ||
| new ThreadFactoryBuilder().setNameFormat("dd-agent-writer-%d").setDaemon(true).build(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a clean shutdown, instead of keeping the vm running.