-
Notifications
You must be signed in to change notification settings - Fork 318
Add JMH Benchmarks #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JMH Benchmarks #163
Conversation
|
Is this related to #162? |
|
Looks good! Can you add instructions for running the benchmarks in No Agent: With Agent: |
b6f167d to
78210d6
Compare
|
This PR is actually not dependent on the gradle upgrade PR. I initially did that as a troubleshooting step, but was able to work around it. I still think it's valuable to upgrade though. I've modified the test to be able to test across many different agent versions. There is a significant regression in 0.2.7 which is probably caused by running two different byte transformers concurrently that I hope will be reduced when we remove byteman: The stack profiling seems to indicate that byteman is still a significant point of overhead: |
realark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very interesting! We'll have to keep an eye on these as we do releases.
Unfortunately there are some incompatibilities with how gradle is forking the jmh task. It includes multiple different versions of groovy, which causes an error. I worked around this by creating a separate task.
Sample run with and without the
javaagentline commented out: