Migrate JMS to Byte Buddy and add JMS 1 support #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbenson
commented
Nov 17, 2017
Contributor
Author
There was a problem hiding this comment.
Check out this cool way to test instrumentation in pieces. Using this, I'm able to write "integration" tests for each integration separately without needing to run the agent at startup.
Contributor
There was a problem hiding this comment.
👍 Nice! I think we'll want to formalize this into an instrumentation test framework in the near future.
tylerbenson
force-pushed
the
tyler/jms
branch
from
6640c3d to
a563c93
Compare
This does not yet include instrumentation for MessageListener. I think there is actually no difference between the instrumentation so we should combine them. I also added TEXT_MAP as a format that maps to the HTTP Codec. There is some remapping inside the instrumentation to remove dashes before setting as a property. This should also be changed when an official format is defined. This also currently has a problem with Spring Boot applications as the JMS Util references classes not on the system classpath (it needs to be injected into the child classpath)
tylerbenson
force-pushed
the
tyler/jms
branch
from
a563c93 to
871ce37
Compare
realark
reviewed
Nov 22, 2017
| } | ||
| } | ||
|
|
||
| public void waitForTraces(final int number) throws InterruptedException { |
Contributor
|
Looks good! CI failure seems unrelated (Cassandra integration test timeout). I'm going to go for green anyways then I think we can |
.
realark
reviewed
Nov 22, 2017
Contributor
realark
left a comment
realark
left a comment
There was a problem hiding this comment.
I'm okay with merging as long as we're confident the CI failures are unrelated. I can't get a clean run and I don't find the build output easy to parse.
jpbempel
pushed a commit
that referenced
this pull request
May 18, 2022
Merging changes from the upstream repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not yet include instrumentation for MessageListener.
I think there is actually no difference between the instrumentation so we should combine them.
I also added TEXT_MAP as a format that maps to the HTTP Codec. There is some remapping inside the instrumentation to remove dashes before setting as a property. This should also be changed when an official format is defined.
In order to resolve an issue with classes needing to be injected, I moved the "helper classes" over to the helper jar.