Refactoring integrations #14
Conversation
| @@ -1,117 +0,0 @@ | |||
| package io.opentracing.contrib.agent; | |||
There was a problem hiding this comment.
@gpolaert Please keep the class even if you don't use it. We might need th ability to scan the Jars.
There was a problem hiding this comment.
Not sure, I reverted the file. But I'm keeping the check disabled? = doing nothing
| debug(args.getClass().getName() + " patched"); | ||
| } catch (ClassNotFoundException | NoSuchMethodException | InstantiationException | IllegalAccessException | InvocationTargetException e) { | ||
| error("Your " + args.getClass().getName() + "seems to be not compatible with the current integration, integration disabled, reason: " + e.getMessage()); | ||
| errTraceException(e); |
| error("Your " + args.getClass().getName() + "seems to be not compatible with the current integration, integration disabled, reason: " + e.getMessage()); | ||
| errTraceException(e); | ||
| patched = args; | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Not sure this is a good idea to have to kind of exception catching. Also I would catch "Throwable" instead of "Exception" which is the lowest kind of error (otherwise RuntimeException for instance won't be caught)
| @@ -1,38 +0,0 @@ | |||
| okhttp: | |||
There was a problem hiding this comment.
Ok to remove this one
| @@ -1,71 +1,59 @@ | |||
| # -------------------------------------------------------- | |||
There was a problem hiding this comment.
Ok so, OkHTTP and WebServlet filters are missing here. Remove rules jars in Maven, write dedicated helpers and rules in this file.
There was a problem hiding this comment.
To be released soon ...
Changelog: