Skip to content

🍒 12769 - Update default query string obfuscation pattern - #12784

Merged
jandro996 merged 1 commit into
release/v1.67.xfrom
alejandro.gonzalez/backport-pr-12769
Oct 8, 2026
Merged

jandro996 merged 1 commit into
release/v1.67.xfrom
alejandro.gonzalez/backport-pr-12769

Conversation

@jandro996

Copy link
Copy Markdown
Member

Backport #12769 to release/v1.67.x

@jandro996
jandro996 requested a review from a team as a code owner October 8, 2026 09:35
@jandro996 jandro996 added type: feature Enhancements and improvements comp: core Tracer core labels Oct 8, 2026
@jandro996
jandro996 requested review from dougqh and removed request for a team October 8, 2026 09:35
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T09:39:05.854638Z e5e01b1 PR opened
🔒 Security Review ✅ Completed 2026-10-08T09:40:58.174178Z e5e01b1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jandro996 jandro996 added this to the 1.67.1 milestone Oct 8, 2026

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The updated JWT matching preserves delimiters, while custom regex capture groups are not copied back into query tags. Invalid patterns and obfuscation exceptions drop the query tag, preventing fail-open reporting.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit e5e01b1 · @DataDog review to ask questions

@datadog-official

This comment has been minimized.

@jandro996
jandro996 requested a review from bric3 October 8, 2026 09:55
@dd-octo-sts

dd-octo-sts Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.95 s 14.10 s [-1.7%; -0.4%] (maybe better)
startup:insecure-bank:tracing:Agent 12.94 s 13.06 s [-1.7%; -0.2%] (maybe better)
startup:petclinic:appsec:Agent 17.23 s 17.12 s [-0.4%; +1.6%] (no difference)
startup:petclinic:iast:Agent 16.92 s 17.01 s [-1.4%; +0.3%] (no difference)
startup:petclinic:profiling:Agent 16.62 s 16.92 s [-3.0%; -0.6%] (maybe better)
startup:petclinic:sca:Agent 17.08 s 16.86 s [+0.5%; +2.0%] (maybe worse)
startup:petclinic:tracing:Agent 16.14 s 16.18 s [-1.3%; +0.8%] (no difference)

Commit: e5e01b18 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@jandro996
jandro996 enabled auto-merge (squash) October 8, 2026 10:27
@jandro996
jandro996 merged commit ee08275 into release/v1.67.x Oct 8, 2026
608 of 611 checks passed
@jandro996
jandro996 deleted the alejandro.gonzalez/backport-pr-12769 branch October 8, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: core Tracer core type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants