Repository navigation
Conversation
A UFC split can carry a list of key-value features for exposure hooks. Split gains a nullable features field, and the parser reads it leniently: a malformed list or entry is dropped instead of rejecting the flag, so features never change which variation a subject gets.
This comment has been minimized.
This comment has been minimized.
…coverage Test the factory's type and annotation checks and the read-only adapter, as the other UFC adapters do, and list the Feature model class with the other UFC POJOs that are excluded from coverage verification.
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Each feature now lists where SDKs deliver it, such as HOOK, EXPOSURE or EVALUATION. Destinations are open strings: the parser keeps every non-empty string, including ones this SDK does not know, and drops a feature that has no destinations.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
NOT READY FOR REVIEW YET
What Does This Do
Featureclass (key,value) to the UFC model in the bootstrap module.featureslist toSplit. Each feature has a key, a value, and a list of destinations. The existing constructor still works.FeatureListAdapterinUniversalFlagConfigParser:null.Motivation
The UFC will carry features on some splits, starting with holdout splits (
holdout.key,holdout.assignment_group). Customers who write exposures to their own warehouse need these values in their exposure hook. This change only parses them. A later change surfaces them in flag metadata.A malformed feature must not reject the flag, because features never change which variation a subject gets.
Additional Notes
Splitships in the bootstrap module withdd-java-agent, so an older agent has nofeaturesfield. The change that first reads the field will guard it the wayDDEvaluator.splitSerialIdSupportedguardsserialId.featuresparse as before.Jira ticket: EX-3799