Skip to content

Remove OTel resource attribute tag limit - #12617

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
milan.garnier/remove-otel-resource-attributes-tag-limit
Oct 5, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
milan.garnier/remove-otel-resource-attributes-tag-limit

Conversation

@MilanGarnier

@MilanGarnier MilanGarnier commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Remove the arbitrary 10-tag cap when mapping OTEL_RESOURCE_ATTRIBUTES. This was an undocumented gap.
  • Preserve all custom resource attributes as Datadog tags.

Testing

  • ./gradlew :internal-api:test --tests datadog.trace.bootstrap.config.provider.OtelEnvironmentConfigSourceTest

Related: APMAPI-2420

@MilanGarnier MilanGarnier added type: bug fix Bug fix tag: ai generated Largely based on code generated by an AI or LLM comp: config Configuration labels Sep 23, 2026
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 0.00%
• Overall Coverage: 59.28% (-0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e25a7c1 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.99 s 13.92 s [-0.2%; +1.1%] (no difference)
startup:insecure-bank:tracing:Agent 12.92 s 13.03 s [-1.4%; -0.2%] (maybe better)
startup:petclinic:appsec:Agent 17.05 s 16.87 s [+0.4%; +1.8%] (maybe worse)
startup:petclinic:iast:Agent 17.00 s 16.99 s [-0.8%; +0.9%] (no difference)
startup:petclinic:profiling:Agent 16.69 s 16.87 s [-2.3%; +0.1%] (no difference)
startup:petclinic:sca:Agent 16.94 s 16.82 s [-0.1%; +1.5%] (no difference)
startup:petclinic:tracing:Agent 16.11 s 16.13 s [-1.0%; +0.8%] (no difference)

Commit: e25a7c18 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@MilanGarnier
MilanGarnier marked this pull request as ready for review October 5, 2026 08:39
@MilanGarnier
MilanGarnier requested a review from a team as a code owner October 5, 2026 08:39
@MilanGarnier
MilanGarnier requested review from mcculls and removed request for a team October 5, 2026 08:39
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T08:44:35.422312Z e25a7c1 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-05T08:45:21.879307Z e25a7c1 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: FAIL

Resource attributes beyond the former ten-entry limit now participate in Datadog tag parsing, where a later value containing spaces clears the entire tag map and drops valid preceding tags.

Open Bits AI session

🤖 Bits Code Review · Commit e25a7c1 · @DataDog review to ask questions

@MilanGarnier
MilanGarnier added this pull request to the merge queue Oct 5, 2026
@dd-octo-sts

dd-octo-sts Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-10-05 11:30:37 UTC ℹ️ Start processing command /merge


2026-10-05 11:30:41 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-10-05 12:43:42 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 5, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit dd49ccf into master Oct 5, 2026
617 of 624 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the milan.garnier/remove-otel-resource-attributes-tag-limit branch October 5, 2026 12:43
@github-actions github-actions Bot added this to the 1.67.0 milestone Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: config Configuration tag: ai generated Largely based on code generated by an AI or LLM type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants