Repository navigation
Release Akka message continuations when discarded to dead letters - #12616
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Please try again by commenting @autotest review.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/code blockers |
|
View all feedbacks in Devflow UI.
Checking merge blockers for #12616...
Detected 1 merge blocker(s) to address: 🟠 Pending
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Build pipeline has failing jobs for 40ad441: What to do next?
DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Release the captured continuation when Akka’s dead-letter queue discards a message envelope.
An actor can terminate while traced messages remain in its mailbox. Akka drains those messages into the dead-letter queue, bypassing
ActorCell.invoke()and its normal continuation cleanup.Changes
MessageQueueimplementations nested insideMailboxes, avoiding reliance on Scala’s anonymous-class numbering.flowchart LR A[Capture context in message envelope] --> B{Message disposition} B -->|Delivered| C[Actor invokes and closes context] B -->|Actor terminates| D[Dead-letter queue] D -->|Previously| E[Continuation remains unresolved] D -->|Fixed| F[Release captured continuation] linkStyle 1,4 stroke:green linkStyle 3 stroke:redMotivation
This surfaced in the Play 2.5 smoke tests: stream subscription notifications were discarded after their actor stopped, leaving request continuations unresolved.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]