Repository navigation
Avoid queue-timing metadata reads before JFR is ready - #12550
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
Conversation
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The readiness guard runs before queue type and size reads. The defensive helper guard stays in place for other callers.
🤖 Datadog Autotest · Commit 4bae9f2 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Build pipeline has failing jobs for 9e18cc4: What to do next?
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
d5c61ec
into
master
What Does This Do
ThreadPoolExecutorinstrumentation collected queue metadata before the timer helper checked whether JFR was ready. Move that readiness check ahead of metadata collection, preserving trace propagation and delayed profiling startup.Avoiding
queue.size()also avoids unnecessary lock acquisition—and potential blocking under contention—for queues such asArrayBlockingQueueandPriorityBlockingQueue.Share the readiness predicate through
QueueTimerHelper, retaining its native-image exclusion and defensive check for other callers.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]