Repository navigation
Migrate OpenTelemetry smoke test to JUnit - #12127
Conversation
There was a problem hiding this comment.
More details
The JUnit migration preserves the OpenTelemetry smoke application launch and validates its one annotated trace plus ten sequential manual traces with the new backend assertions. No diff-only behavioral regression was confirmed; no additional tests recommended because the existing application shape is deterministic and the attempted module execution was blocked by unavailable Gradle/JDK tooling.
📊 Validated against 3 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 9eece4a · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9eece4ad18
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
e3bc1dc to
f9175c8
Compare
This comment has been minimized.
This comment has been minimized.
f9175c8 to
36e7755
Compare
|
Bits Code status: ✅ Done Comment @DataDog to request changes |
13ba721 to
97b671f
Compare
97b671f to
54741a2
Compare
54741a2 to
5eaac9a
Compare
5eaac9a to
7f045df
Compare
bric3
left a comment
There was a problem hiding this comment.
Looks good to me, however I think the comment on assertTrace and the list of spans deserves some attention.
7f045df to
8808628
Compare
There was a problem hiding this comment.
More details
The JUnit test keeps the prior check for 11 traces and exit value 0. It also checks each trace and span with the new smoke test framework.
🤖 Datadog Autotest · Commit 8808628 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
8808628 to
b88ff9e
Compare
b88ff9e to
921c1cc
Compare
24d9a52 to
bb1762b
Compare
There was a problem hiding this comment.
More details
The JUnit migration preserves the 11 expected OpenTelemetry traces and the zero exit code check. The shared smoke-test framework has no reportable static correctness issue.
🤖 Datadog Autotest · Commit bb1762b · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Build pipeline has failing jobs for cb8d3b1: What to do next?
DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. |
bb1762b to
5b007a3
Compare
There was a problem hiding this comment.
The new span-link check accepts any three hexadecimal span IDs. Broken links can pass without pointing to the shard spans.
🤖 Datadog Autotest · Commit 5b007a3 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
LGTM, left couple of generic questions.
|
I really don’t like aggressively closing discussion to proceed with merge… That feels so rude. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
This PR migrates the OpenTelemetry smoke tests to the new JUnit smoke test framework.
Motivation
The new tests checks the whole trace structures and span values, in addition to trace payload validity and invariants.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APMLP-1247