Skip to content

Migrate OpenTelemetry smoke test to JUnit - #12127

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bbujon/smoke-tests-opentelemetry
Aug 25, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bbujon/smoke-tests-opentelemetry

Conversation

@PerfectSlayer

@PerfectSlayer PerfectSlayer commented Aug 3, 2026 •

Copy link
Copy Markdown
Collaborator

What Does This Do

This PR migrates the OpenTelemetry smoke tests to the new JUnit smoke test framework.

Motivation

The new tests checks the whole trace structures and span values, in addition to trace payload validity and invariants.

Additional Notes

Contributor Checklist

Jira ticket: APMLP-1247

@PerfectSlayer PerfectSlayer added the type: feature Enhancements and improvements label Aug 3, 2026
@PerfectSlayer
PerfectSlayer requested a review from a team as a code owner August 3, 2026 13:26
@PerfectSlayer PerfectSlayer added the tag: no release notes Changes to exclude from release notes label Aug 3, 2026
@PerfectSlayer
PerfectSlayer requested review from mtoffl01 and removed request for a team August 3, 2026 13:26
@PerfectSlayer PerfectSlayer added the inst: opentelemetry OpenTelemetry instrumentation label Aug 3, 2026

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The JUnit migration preserves the OpenTelemetry smoke application launch and validates its one annotated trace plus ten sequential manual traces with the new backend assertions. No diff-only behavioral regression was confirmed; no additional tests recommended because the existing application shape is deterministic and the attempted module execution was blocked by unavailable Gradle/JDK tooling.

Was this helpful? React 👍 or 👎

📊 Validated against 3 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 9eece4a · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9eece4ad18

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dd-octo-sts

dd-octo-sts Bot commented Aug 3, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.98 s 13.98 s [-0.9%; +0.9%] (no difference)
startup:insecure-bank:tracing:Agent 12.82 s 12.95 s [-1.6%; -0.3%] (maybe better)
startup:petclinic:appsec:Agent 17.50 s 17.28 s [+0.5%; +2.1%] (maybe worse)
startup:petclinic:iast:Agent 17.40 s 17.53 s [-1.5%; -0.1%] (maybe better)
startup:petclinic:profiling:Agent 17.38 s 17.34 s [-0.9%; +1.3%] (no difference)
startup:petclinic:sca:Agent 17.41 s 17.25 s [+0.0%; +1.7%] (maybe worse)
startup:petclinic:tracing:Agent 16.51 s 16.60 s [-1.4%; +0.4%] (no difference)

Commit: 5b007a3e · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@PerfectSlayer
PerfectSlayer requested a review from a team as a code owner August 4, 2026 11:30
@PerfectSlayer
PerfectSlayer requested a review from mcculls August 4, 2026 11:30
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-opentelemetry branch 2 times, most recently from e3bc1dc to f9175c8 Compare August 4, 2026 11:32
@datadog-datadog-prod-us1-2

This comment has been minimized.

@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-opentelemetry branch from f9175c8 to 36e7755 Compare August 5, 2026 15:48
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

View session in Datadog

Bits Code status: ✅ Done

Comment @DataDog to request changes

@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-opentelemetry branch 2 times, most recently from 13ba721 to 97b671f Compare August 6, 2026 11:47
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-opentelemetry branch from 97b671f to 54741a2 Compare August 7, 2026 08:13
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-opentelemetry branch from 54741a2 to 5eaac9a Compare August 11, 2026 09:55
@PerfectSlayer PerfectSlayer added tag: no release notes Changes to exclude from release notes and removed tag: no release notes Changes to exclude from release notes labels Aug 12, 2026
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-opentelemetry branch from 5eaac9a to 7f045df Compare August 13, 2026 12:33

@bric3 bric3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, however I think the comment on assertTrace and the list of spans deserves some attention.

@PerfectSlayer
PerfectSlayer requested a review from a team as a code owner August 20, 2026 16:15
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-opentelemetry branch from 7f045df to 8808628 Compare August 20, 2026 16:15

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The JUnit test keeps the prior check for 11 traces and exit value 0. It also checks each trace and span with the new smoke test framework.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 8808628 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@bm1549
bm1549 removed the request for review from mtoffl01 August 20, 2026 20:35
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-opentelemetry branch from 8808628 to b88ff9e Compare August 21, 2026 06:24
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-opentelemetry branch from b88ff9e to 921c1cc Compare August 21, 2026 08:10
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-opentelemetry branch 2 times, most recently from 24d9a52 to bb1762b Compare August 21, 2026 11:27
Base automatically changed from bbujon/smoke-tests-junit-framework to master August 21, 2026 12:22

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The JUnit migration preserves the 11 expected OpenTelemetry traces and the zero exit code check. The shared smoke-test framework has no reportable static correctness issue.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit bb1762b · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@PerfectSlayer

Copy link
Copy Markdown
Collaborator Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-24 08:52:27 UTC ℹ️ Start processing command /merge


2026-08-24 08:52:31 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-08-24 09:19:51 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for cb8d3b1:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-opentelemetry branch from bb1762b to 5b007a3 Compare August 24, 2026 16:40
@PerfectSlayer
PerfectSlayer requested a review from a team as a code owner August 24, 2026 16:40
@PerfectSlayer
PerfectSlayer requested review from AlexeyKuznetsov-DD and removed request for a team August 24, 2026 16:40

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: FAIL

The new span-link check accepts any three hexadecimal span IDs. Broken links can pass without pointing to the shard spans.

Open Bits AI session

🤖 Datadog Autotest · Commit 5b007a3 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left couple of generic questions.

@PerfectSlayer

Copy link
Copy Markdown
Collaborator Author

I really don’t like aggressively closing discussion to proceed with merge… That feels so rude.
This is a stacked PR, I expect follow up changes and polish to be added to the stack.

@PerfectSlayer

Copy link
Copy Markdown
Collaborator Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 25, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-25 07:23:51 UTC ℹ️ Start processing command /merge


2026-08-25 07:23:55 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-08-25 08:20:05 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 703558c into master Aug 25, 2026
591 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the bbujon/smoke-tests-opentelemetry branch August 25, 2026 08:19
@github-actions github-actions Bot added this to the 1.66.0 milestone Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: opentelemetry OpenTelemetry instrumentation tag: no release notes Changes to exclude from release notes type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants